cozy-sharing 38.1.2 → 38.1.3

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [38.1.3](https://github.com/cozy/cozy-libs/compare/cozy-sharing@38.1.2...cozy-sharing@38.1.3) (2026-09-23)
+
+### Bug Fixes
+
+- **sharing:** Downgrade member on shared parents when confirming ([3602a68](https://github.com/cozy/cozy-libs/commit/3602a6879e6a7c585f9233d2336812ee9972e612))
+
 ## [38.1.2](https://github.com/cozy/cozy-libs/compare/cozy-sharing@38.1.1...cozy-sharing@38.1.2) (2026-09-23)
 
 ### Bug Fixes

package/dist/components/Recipient/PermissionTypeMenu.js

@@ -1,6 +1,13 @@
 import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import _regeneratorRuntime from "@babel/runtime/regenerator";
+
+function _createForOfIteratorHelper(o, allowArrayLike) { var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"]; if (!it) { if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") { if (it) o = it; var i = 0; var F = function F() {}; return { s: F, n: function n() { if (i >= o.length) return { done: true }; return { done: false, value: o[i++] }; }, e: function e(_e) { throw _e; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var normalCompletion = true, didErr = false, err; return { s: function s() { it = it.call(o); }, n: function n() { var step = it.next(); normalCompletion = step.done; return step; }, e: function e(_e2) { didErr = true; err = _e2; }, f: function f() { try { if (!normalCompletion && it.return != null) it.return(); } finally { if (didErr) throw err; } } }; }
+
+function _unsupportedIterableToArray(o, minLen) { if (!o) return; if (typeof o === "string") return _arrayLikeToArray(o, minLen); var n = Object.prototype.toString.call(o).slice(8, -1); if (n === "Object" && o.constructor) n = o.constructor.name; if (n === "Map" || n === "Set") return Array.from(o); if (n === "Arguments" || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(n)) return _arrayLikeToArray(o, minLen); }
+
+function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len = arr.length; for (var i = 0, arr2 = new Array(len); i < len; i++) arr2[i] = arr[i]; return arr2; }
+
 import React, { useCallback, useRef, useState } from 'react';
 import { useClient } from 'cozy-client';
 import minilog from 'cozy-minilog';
@@ -53,38 +60,96 @@ var PermissionTypeMenuComponent = function PermissionTypeMenuComponent(_ref) {
   }, []);
   var applyType = useCallback( /*#__PURE__*/function () {
     var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(newType) {
+      var _ref3,
+          _ref3$withAncestors,
+          withAncestors,
+          ancestors,
+          _iterator,
+          _step,
+          ancestor,
+          _args = arguments;
+
       return _regeneratorRuntime.wrap(function _callee$(_context) {
         while (1) switch (_context.prev = _context.next) {
           case 0:
-            _context.prev = 0;
-            _context.next = 3;
+            _ref3 = _args.length > 1 && _args[1] !== undefined ? _args[1] : {}, _ref3$withAncestors = _ref3.withAncestors, withAncestors = _ref3$withAncestors === void 0 ? false : _ref3$withAncestors;
+            _context.prev = 1;
+
+            if (!withAncestors) {
+              _context.next = 21;
+              break;
+            }
+
+            // Ancestors first: only the target's own update refetches its
+            // effective recipients, which must already see them downgraded.
+            ancestors = ((recipient === null || recipient === void 0 ? void 0 : recipient.sources) || []).filter(function (s) {
+              return s.kind === 'ancestor' && !s.read_only;
+            });
+            _iterator = _createForOfIteratorHelper(ancestors);
+            _context.prev = 5;
+
+            _iterator.s();
+
+          case 7:
+            if ((_step = _iterator.n()).done) {
+              _context.next = 13;
+              break;
+            }
+
+            ancestor = _step.value;
+            _context.next = 11;
+            return updateSharingMemberType(ancestor.sharing_id, ancestor.member_index, newType);
+
+          case 11:
+            _context.next = 7;
+            break;
+
+          case 13:
+            _context.next = 18;
+            break;
+
+          case 15:
+            _context.prev = 15;
+            _context.t0 = _context["catch"](5);
+
+            _iterator.e(_context.t0);
+
+          case 18:
+            _context.prev = 18;
+
+            _iterator.f();
+
+            return _context.finish(18);
+
+          case 21:
+            _context.next = 23;
             return updateSharingMemberType(sharingId, memberIndex, newType);
 
-          case 3:
-            _context.next = 9;
+          case 23:
+            _context.next = 29;
             break;
 
-          case 5:
-            _context.prev = 5;
-            _context.t0 = _context["catch"](0);
-            log.error('Failed to change member permission type', _context.t0);
+          case 25:
+            _context.prev = 25;
+            _context.t1 = _context["catch"](1);
+            log.error('Failed to change member permission type', _context.t1);
             showAlert({
               message: t('Share.members.error.changePermission'),
               severity: 'error',
               variant: 'filled'
             });
 
-          case 9:
+          case 29:
           case "end":
             return _context.stop();
         }
-      }, _callee, null, [[0, 5]]);
+      }, _callee, null, [[1, 25], [5, 15, 18, 21]]);
     }));
 
     return function (_x) {
       return _ref2.apply(this, arguments);
     };
-  }(), [memberIndex, sharingId, showAlert, t, updateSharingMemberType]); // Downgrading to viewer on a folder inside a shared parent also reduces
+  }(), [memberIndex, recipient, sharingId, showAlert, t, updateSharingMemberType]); // Downgrading to viewer on a folder inside a shared parent also reduces
   // the member's rights on the parent: require explicit confirmation first.
 
   var shouldConfirmDowngrade = type === 'two-way' && Boolean(documentPath) && (hasSharedParent === null || hasSharedParent === void 0 ? void 0 : hasSharedParent(documentPath));
@@ -102,7 +167,9 @@ var PermissionTypeMenuComponent = function PermissionTypeMenuComponent(_ref) {
   var handleConfirmDowngrade = useCallback(function () {
     var newType = pendingType;
     setPendingType(null);
-    if (newType) applyType(newType);
+    if (newType) applyType(newType, {
+      withAncestors: true
+    });
   }, [applyType, pendingType]);
   var handleCancelDowngrade = useCallback(function () {
     setPendingType(null);

package/dist/components/Recipient/PermissionTypeMenu.spec.js

@@ -242,13 +242,62 @@ describe('PermissionTypeMenu component', function () {
         }
       }, _callee5);
     })));
+    it('should also downgrade the member on read-write ancestor shares when confirming', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6() {
+      var _setup7, getByRole;
+
+      return _regeneratorRuntime.wrap(function _callee6$(_context6) {
+        while (1) switch (_context6.prev = _context6.next) {
+          case 0:
+            mockUpdateSharingMemberType.mockResolvedValue(undefined);
+            _setup7 = setup({
+              type: 'two-way',
+              document: folderDocument,
+              recipient: {
+                name: 'Bob',
+                sources: [{
+                  kind: 'self',
+                  sharing_id: 'sharing-123',
+                  member_index: 1
+                }, {
+                  kind: 'ancestor',
+                  sharing_id: 'sharing-parent',
+                  member_index: 2,
+                  read_only: false
+                }, {
+                  kind: 'ancestor',
+                  sharing_id: 'sharing-grandparent',
+                  member_index: 3,
+                  read_only: true
+                }]
+              }
+            }), getByRole = _setup7.getByRole;
+            fireEvent.click(getByRole('button', {
+              name: 'Editor'
+            }));
+            fireEvent.click(getByRole('menuitem', {
+              name: 'Viewer'
+            }));
+            fireEvent.click(getByRole('button', {
+              name: 'Update parent'
+            }));
+            _context6.next = 7;
+            return waitFor(function () {
+              expect(mockUpdateSharingMemberType.mock.calls).toEqual([['sharing-parent', 2, 'one-way'], ['sharing-123', 1, 'one-way']]);
+            });
+
+          case 7:
+          case "end":
+            return _context6.stop();
+        }
+      }, _callee6);
+    })));
     it('should not call updateSharingMemberType when cancelling', function () {
-      var _setup7 = setup({
+      var _setup8 = setup({
         type: 'two-way',
         document: folderDocument
       }),
-          getByRole = _setup7.getByRole,
-          queryByRole = _setup7.queryByRole;
+          getByRole = _setup8.getByRole,
+          queryByRole = _setup8.queryByRole;
 
       fireEvent.click(getByRole('button', {
         name: 'Editor'
@@ -267,12 +316,12 @@ describe('PermissionTypeMenu component', function () {
     it('should update directly when the folder has no shared parent', function () {
       mockHasSharedParent.mockReturnValue(false);
 
-      var _setup8 = setup({
+      var _setup9 = setup({
         type: 'two-way',
         document: folderDocument
       }),
-          getByRole = _setup8.getByRole,
-          queryByRole = _setup8.queryByRole;
+          getByRole = _setup9.getByRole,
+          queryByRole = _setup9.queryByRole;
 
       fireEvent.click(getByRole('button', {
         name: 'Editor'

package/dist/helpers/effectiveRecipients.js

@@ -28,7 +28,8 @@ var mapToRecipient = function mapToRecipient(effectiveRecipient, source) {
     sharingId: source.sharing_id,
     memberIndex: source.member_index,
     avatarPath: "/sharings/".concat(source.sharing_id, "/recipients/").concat(source.member_index, "/avatar"),
-    type: effectiveRecipient.read_only ? 'one-way' : 'two-way'
+    type: effectiveRecipient.read_only ? 'one-way' : 'two-way',
+    sources: effectiveRecipient.sources
   };
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-sharing",
-  "version": "38.1.2",
+  "version": "38.1.3",
   "description": "Provides sharing login for React applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -59,7 +59,7 @@
     "cozy-intent": "^2.31.1",
     "cozy-minilog": "^3.10.1",
     "cozy-ui": "^140.5.0",
-    "cozy-ui-plus": "^13.0.6",
+    "cozy-ui-plus": "^13.0.7",
     "jest": "30.3.0",
     "jest-environment-jsdom": "30.3.0",
     "react": "16.12.0",
@@ -85,5 +85,5 @@
   "sideEffects": [
     "*.css"
   ],
-  "gitHead": "f3a4ca49d7e1fea6099fe103720926959ed02e1a"
+  "gitHead": "8c012d67c3b598402f84b65bdc9f0f6f7e9d4e95"
 }

package/src/components/Recipient/PermissionTypeMenu.jsx

@@ -40,8 +40,22 @@ const PermissionTypeMenuComponent = ({
   }, [])
 
   const applyType = useCallback(
-    async newType => {
+    async (newType, { withAncestors = false } = {}) => {
       try {
+        if (withAncestors) {
+          // Ancestors first: only the target's own update refetches its
+          // effective recipients, which must already see them downgraded.
+          const ancestors = (recipient?.sources || []).filter(
+            s => s.kind === 'ancestor' && !s.read_only
+          )
+          for (const ancestor of ancestors) {
+            await updateSharingMemberType(
+              ancestor.sharing_id,
+              ancestor.member_index,
+              newType
+            )
+          }
+        }
         await updateSharingMemberType(sharingId, memberIndex, newType)
       } catch (error) {
         log.error('Failed to change member permission type', error)
@@ -52,7 +66,7 @@ const PermissionTypeMenuComponent = ({
         })
       }
     },
-    [memberIndex, sharingId, showAlert, t, updateSharingMemberType]
+    [memberIndex, recipient, sharingId, showAlert, t, updateSharingMemberType]
   )
 
   // Downgrading to viewer on a folder inside a shared parent also reduces
@@ -78,7 +92,7 @@ const PermissionTypeMenuComponent = ({
   const handleConfirmDowngrade = useCallback(() => {
     const newType = pendingType
     setPendingType(null)
-    if (newType) applyType(newType)
+    if (newType) applyType(newType, { withAncestors: true })
   }, [applyType, pendingType])
 
   const handleCancelDowngrade = useCallback(() => {

package/src/components/Recipient/PermissionTypeMenu.spec.jsx

@@ -179,6 +179,44 @@ describe('PermissionTypeMenu component', () => {
       })
     })
 
+    it('should also downgrade the member on read-write ancestor shares when confirming', async () => {
+      mockUpdateSharingMemberType.mockResolvedValue(undefined)
+
+      const { getByRole } = setup({
+        type: 'two-way',
+        document: folderDocument,
+        recipient: {
+          name: 'Bob',
+          sources: [
+            { kind: 'self', sharing_id: 'sharing-123', member_index: 1 },
+            {
+              kind: 'ancestor',
+              sharing_id: 'sharing-parent',
+              member_index: 2,
+              read_only: false
+            },
+            {
+              kind: 'ancestor',
+              sharing_id: 'sharing-grandparent',
+              member_index: 3,
+              read_only: true
+            }
+          ]
+        }
+      })
+
+      fireEvent.click(getByRole('button', { name: 'Editor' }))
+      fireEvent.click(getByRole('menuitem', { name: 'Viewer' }))
+      fireEvent.click(getByRole('button', { name: 'Update parent' }))
+
+      await waitFor(() => {
+        expect(mockUpdateSharingMemberType.mock.calls).toEqual([
+          ['sharing-parent', 2, 'one-way'],
+          ['sharing-123', 1, 'one-way']
+        ])
+      })
+    })
+
     it('should not call updateSharingMemberType when cancelling', () => {
       const { getByRole, queryByRole } = setup({
         type: 'two-way',

package/src/helpers/effectiveRecipients.js

@@ -24,7 +24,8 @@ const mapToRecipient = (effectiveRecipient, source) => ({
   sharingId: source.sharing_id,
   memberIndex: source.member_index,
   avatarPath: `/sharings/${source.sharing_id}/recipients/${source.member_index}/avatar`,
-  type: effectiveRecipient.read_only ? 'one-way' : 'two-way'
+  type: effectiveRecipient.read_only ? 'one-way' : 'two-way',
+  sources: effectiveRecipient.sources
 })
 
 export const mapEffectiveRecipients = effectiveRecipients =>