cozy-sharing 37.5.4 → 37.6.0

package/src/helpers/effectiveRecipients.js

@@ -0,0 +1,34 @@
+/**
+ * Pick the most relevant source for a recipient: prefer the target's own
+ * share ("self"), fall back to the first ancestor source.
+ * Needed because revoke/RO-RW actions target a specific sharing+member index.
+ */
+const getBestSource = effectiveRecipient => {
+  const sources = effectiveRecipient.sources || []
+  return sources.find(s => s.kind === 'self') || sources[0]
+}
+
+/**
+ * Build a view object for MemberRecipient/MemberRecipientPermissions.
+ * Extracts sharingId/memberIndex/avatarPath/type from the source so
+ * existing components work without reading sources[] directly.
+ * Does not spread the backend data — only the fields needed for rendering.
+ */
+const mapToRecipient = (effectiveRecipient, source) => ({
+  name: effectiveRecipient.name,
+  email: effectiveRecipient.email,
+  instance: effectiveRecipient.instance,
+  status: effectiveRecipient.status,
+  read_only: effectiveRecipient.read_only,
+  index: `effective-${source.sharing_id}-${source.member_index}`,
+  sharingId: source.sharing_id,
+  memberIndex: source.member_index,
+  avatarPath: `/sharings/${source.sharing_id}/recipients/${source.member_index}/avatar`,
+  type: effectiveRecipient.read_only ? 'one-way' : 'two-way'
+})
+
+export const mapEffectiveRecipients = effectiveRecipients =>
+  (effectiveRecipients || []).map(recipient => {
+    const source = getBestSource(recipient)
+    return source ? mapToRecipient(recipient, source) : recipient
+  })

package/src/helpers/effectiveRecipients.spec.js

@@ -0,0 +1,125 @@
+import { mapEffectiveRecipients } from './effectiveRecipients'
+
+const makeAncestorSource = (rootName = 'Parent Folder') => ({
+  sharing_id: 'sharing-1',
+  root_id: 'root-1',
+  root_name: rootName,
+  kind: 'ancestor',
+  member_index: 1,
+  read_only: false,
+  manageable: false
+})
+
+const makeSelfSource = (opts = {}) => ({
+  sharing_id: opts.sharing_id || 'sharing-2',
+  root_id: 'root-2',
+  root_name: 'Child Folder',
+  kind: 'self',
+  member_index: opts.memberIndex ?? 1,
+  read_only: opts.readOnly ?? false,
+  manageable: opts.manageable ?? true
+})
+
+const makeRecipient = (overrides = {}) => ({
+  id: 'recip-1',
+  name: 'Alice',
+  email: 'alice@example.com',
+  instance: 'https://alice.mycozy.cloud',
+  status: 'ready',
+  read_only: false,
+  can_edit_here: false,
+  sources: overrides.sources || [],
+  ...overrides
+})
+
+describe('mapEffectiveRecipients', () => {
+  it('returns empty array for empty input', () => {
+    expect(mapEffectiveRecipients([])).toEqual([])
+  })
+
+  it('returns empty array for null or undefined', () => {
+    expect(mapEffectiveRecipients(null)).toEqual([])
+    expect(mapEffectiveRecipients(undefined)).toEqual([])
+  })
+
+  it('maps a recipient with a self source using the self source', () => {
+    const recipient = makeRecipient({
+      sources: [makeSelfSource()]
+    })
+    const result = mapEffectiveRecipients([recipient])
+
+    expect(result).toHaveLength(1)
+    expect(result[0].sharingId).toBe('sharing-2')
+    expect(result[0].memberIndex).toBe(1)
+    expect(result[0].avatarPath).toBe('/sharings/sharing-2/recipients/1/avatar')
+    expect(result[0].type).toBe('two-way')
+  })
+
+  it('maps a recipient with only ancestor sources using the ancestor source', () => {
+    const recipient = makeRecipient({
+      sources: [makeAncestorSource('Shared Parent')]
+    })
+    const result = mapEffectiveRecipients([recipient])
+
+    expect(result).toHaveLength(1)
+    expect(result[0].sharingId).toBe('sharing-1')
+    expect(result[0].memberIndex).toBe(1)
+    expect(result[0].name).toBe('Alice')
+    expect(result[0].email).toBe('alice@example.com')
+  })
+
+  it('maps an owner (self source, index 0) correctly', () => {
+    const recipient = makeRecipient({
+      status: 'owner',
+      read_only: true,
+      sources: [makeSelfSource({ memberIndex: 0, manageable: false })]
+    })
+    const result = mapEffectiveRecipients([recipient])
+
+    expect(result).toHaveLength(1)
+    expect(result[0].status).toBe('owner')
+    expect(result[0].type).toBe('one-way')
+  })
+
+  it('maps an owner with only ancestor sources correctly', () => {
+    const recipient = makeRecipient({
+      status: 'owner',
+      sources: [makeAncestorSource('Parent Folder')]
+    })
+    const result = mapEffectiveRecipients([recipient])
+
+    expect(result).toHaveLength(1)
+    expect(result[0].status).toBe('owner')
+    expect(result[0].sharingId).toBe('sharing-1')
+    expect(result[0].memberIndex).toBe(1)
+  })
+
+  it('sets type to one-way for read_only recipients', () => {
+    const recipient = makeRecipient({
+      read_only: true,
+      sources: [makeSelfSource({ readOnly: true })]
+    })
+    const result = mapEffectiveRecipients([recipient])
+    expect(result[0].type).toBe('one-way')
+  })
+
+  it('handles all recipients in the same array regardless of source kind', () => {
+    const selfRecipient = makeRecipient({
+      id: 'self-1',
+      name: 'Bob',
+      email: 'bob@example.com',
+      sources: [makeSelfSource()]
+    })
+    const ancestorRecipient = makeRecipient({
+      id: 'ancestor-1',
+      name: 'Carol',
+      email: 'carol@example.com',
+      sources: [makeAncestorSource('Root Folder')]
+    })
+    const result = mapEffectiveRecipients([selfRecipient, ancestorRecipient])
+
+    expect(result).toHaveLength(2)
+    expect(result[0].sharingId).toBe('sharing-2')
+    expect(result[1].sharingId).toBe('sharing-1')
+  })
+})

package/src/state.js

@@ -13,6 +13,9 @@ const ADD_SHARING_LINK = 'ADD_SHARING_LINK'
 const UPDATE_SHARING_LINK = 'UPDATE_SHARING_LINK'
 const REVOKE_SHARING_LINK = 'REVOKE_SHARING_LINK'
 const RECEIVE_PATHS = 'RECEIVE_PATHS'
+const RECEIVE_EFFECTIVE_RECIPIENTS = 'RECEIVE_EFFECTIVE_RECIPIENTS'
+const UPDATE_EFFECTIVE_RECIPIENT = 'UPDATE_EFFECTIVE_RECIPIENT'
+const INVALIDATE_EFFECTIVE_RECIPIENTS = 'INVALIDATE_EFFECTIVE_RECIPIENTS'
 export const SHARING_TYPE = {
   TWO_WAY: 'two-way',
   ONE_WAY: 'one-way'
@@ -101,6 +104,21 @@ export const revokeSharingLink = permissions => ({
   permissions
 })
 export const receivePaths = paths => ({ type: RECEIVE_PATHS, paths })
+export const receiveEffectiveRecipients = (docId, recipients) => ({
+  type: RECEIVE_EFFECTIVE_RECIPIENTS,
+  docId,
+  recipients
+})
+export const updateEffectiveRecipient = (sharingId, memberIndex, readOnly) => ({
+  type: UPDATE_EFFECTIVE_RECIPIENT,
+  sharingId,
+  memberIndex,
+  readOnly
+})
+export const invalidateEffectiveRecipients = docId => ({
+  type: INVALIDATE_EFFECTIVE_RECIPIENTS,
+  docId
+})
 export const matchingInstanceName =
   (instanceUri = '') =>
   shareMember =>
@@ -281,11 +299,41 @@ const sharedPaths = (state = [], action) => {
   }
 }
 
+const effectiveRecipients = (state = {}, action) => {
+  switch (action.type) {
+    case RECEIVE_EFFECTIVE_RECIPIENTS:
+      return { ...state, [action.docId]: action.recipients }
+    case UPDATE_EFFECTIVE_RECIPIENT:
+      return Object.fromEntries(
+        Object.entries(state).map(([docId, recipients]) => [
+          docId,
+          recipients.map(r =>
+            r.sharingId === action.sharingId &&
+            r.memberIndex === action.memberIndex
+              ? {
+                  ...r,
+                  read_only: action.readOnly,
+                  type: action.readOnly ? 'one-way' : 'two-way'
+                }
+              : r
+          )
+        ])
+      )
+    case INVALIDATE_EFFECTIVE_RECIPIENTS: {
+      const { [action.docId]: _, ...rest } = state
+      return rest
+    }
+    default:
+      return state
+  }
+}
+
 const reducer = (state = {}, action = {}) => ({
   byDocId: byDocId(state.byDocId, action),
   sharings: sharings(state.sharings, action),
   permissions: permissions(state.permissions, action),
-  sharedPaths: sharedPaths(state.sharedPaths, action)
+  sharedPaths: sharedPaths(state.sharedPaths, action),
+  effectiveRecipients: effectiveRecipients(state.effectiveRecipients, action)
 })
 export default reducer
 
@@ -527,6 +575,9 @@ export const getSharedParentPath = (state, documentPath) => {
   return null
 }
 
+export const getEffectiveRecipients = (state, docId) =>
+  state.effectiveRecipients?.[docId] || []
+
 // helpers
 export const getSharedDocIds = doc =>
   doc.type === 'io.cozy.sharings'

package/src/state.spec.js

@@ -42,7 +42,8 @@ describe('Sharing state', () => {
       byDocId: {},
       sharings: [],
       permissions: [],
-      sharedPaths: []
+      sharedPaths: [],
+      effectiveRecipients: {}
     })
   })