cozy-sharing 33.3.1 → 33.3.2

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [33.3.2](https://github.com/cozy/cozy-libs/compare/cozy-sharing@33.3.1...cozy-sharing@33.3.2) (2026-06-11)
+
+### Bug Fixes
+
+- **cozy-sharing:** Use readonly endpoint in updateSharingMemberType ([f4914b6](https://github.com/cozy/cozy-libs/commit/f4914b61daaf5c20b17c4b9f1ddda511860a56ac))
+
 ## [33.3.1](https://github.com/cozy/cozy-libs/compare/cozy-sharing@33.3.0...cozy-sharing@33.3.1) (2026-06-10)
 
 ### Bug Fixes

package/dist/SharingProvider.js

@@ -471,7 +471,7 @@ export var SharingProvider = /*#__PURE__*/function (_Component) {
      */
     _defineProperty(_this2, "updateSharingMemberType", /*#__PURE__*/function () {
       var _ref12 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee10(sharingId, memberIndex, newType) {
-        var sharing, member, matchedContacts, contact, readOnly;
+        var sharing, member, makeReadOnly;
         return _regeneratorRuntime.wrap(function _callee10$(_context10) {
           while (1) switch (_context10.prev = _context10.next) {
             case 0:
@@ -495,62 +495,49 @@ export var SharingProvider = /*#__PURE__*/function (_Component) {
               throw new Error('Member not found');
 
             case 6:
-              _context10.next = 8;
-              return _this2.props.client.collection('io.cozy.contacts').find({
-                email: {
-                  $elemMatch: {
-                    address: member.email
-                  }
-                },
-                _id: {
-                  $gt: null
-                }
-              }, {
-                indexedFields: ['_id']
-              });
+              makeReadOnly = newType === 'one-way';
 
-            case 8:
-              matchedContacts = _context10.sent;
-
-              if (matchedContacts.data.length) {
-                _context10.next = 11;
+              if (!(newType !== 'one-way' && newType !== 'two-way')) {
+                _context10.next = 9;
                 break;
               }
 
-              throw new Error("Contact not found for member ".concat(member.email));
+              throw new Error('Unsupported sharing type: ' + newType);
 
-            case 11:
-              contact = matchedContacts.data[0]; // Revoke (API call only, no state dispatch to avoid UI flickering)
+            case 9:
+              _context10.prev = 9;
 
-              _context10.next = 14;
-              return _this2.sharingCol.revokeRecipient(sharing, memberIndex);
+              if (!makeReadOnly) {
+                _context10.next = 15;
+                break;
+              }
 
-            case 14:
-              // Re-add with the new permission type
-              readOnly = newType === 'one-way';
-              _context10.prev = 15;
-              _context10.next = 18;
-              return _this2.addRecipients({
-                document: sharing,
-                recipients: readOnly ? [] : [contact],
-                readOnlyRecipients: readOnly ? [contact] : []
-              });
+              _context10.next = 13;
+              return _this2.sharingCol.setReadOnly(sharing, memberIndex);
 
-            case 18:
-              _context10.next = 24;
+            case 13:
+              _context10.next = 17;
               break;
 
-            case 20:
-              _context10.prev = 20;
-              _context10.t0 = _context10["catch"](15);
-              log.error("Failed to re-add member ".concat(member.email, " after revocation. The member has been revoked but could not be re-added with the new permission type."), _context10.t0);
+            case 15:
+              _context10.next = 17;
+              return _this2.sharingCol.setReadWrite(sharing, memberIndex);
+
+            case 17:
+              _context10.next = 23;
+              break;
+
+            case 19:
+              _context10.prev = 19;
+              _context10.t0 = _context10["catch"](9);
+              log.error("Failed to change member ".concat(member.email, " permission type to ").concat(newType), _context10.t0);
               throw _context10.t0;
 
-            case 24:
+            case 23:
             case "end":
               return _context10.stop();
           }
-        }, _callee10, null, [[15, 20]]);
+        }, _callee10, null, [[9, 19]]);
       }));
 
       return function (_x16, _x17, _x18) {

package/dist/SharingProvider.spec.js

@@ -412,12 +412,6 @@ describe('updateDocumentPermissions', function () {
   })));
 });
 describe('updateSharingMemberType', function () {
-  var mockContact = {
-    _id: 'contact-1',
-    email: [{
-      address: 'bob@bob.cozy'
-    }]
-  };
   var mockSharing = {
     id: 'sharing-123',
     type: 'io.cozy.sharings',
@@ -432,20 +426,14 @@ describe('updateSharingMemberType', function () {
     }
   };
   var instance;
-  var mockContactsCollection;
   beforeEach(function () {
-    mockContactsCollection = {
-      find: jest.fn().mockResolvedValue({
-        data: [mockContact]
-      })
-    };
     var mockClient = {
       getStackClient: function getStackClient() {
         return {
           uri: 'http://cozy.local'
         };
       },
-      collection: jest.fn().mockReturnValue(mockContactsCollection)
+      collection: jest.fn().mockReturnValue({})
     };
     instance = new SharingProvider({
       client: mockClient
@@ -454,9 +442,10 @@ describe('updateSharingMemberType', function () {
       sharings: [mockSharing]
     });
     instance.sharingCol = {
-      revokeRecipient: jest.fn().mockResolvedValue({})
+      setReadOnly: jest.fn().mockResolvedValue({}),
+      setReadWrite: jest.fn().mockResolvedValue({})
     };
-    jest.spyOn(instance, 'addRecipients').mockResolvedValue({});
+    jest.spyOn(instance, 'setState');
   });
   it('should throw when sharing is not found', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee8() {
     return _regeneratorRuntime.wrap(function _callee8$(_context8) {
@@ -484,36 +473,33 @@ describe('updateSharingMemberType', function () {
       }
     }, _callee9);
   })));
-  it('should throw when contact is not found', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee10() {
+  it('should call setReadOnly when switching to one-way', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee10() {
     return _regeneratorRuntime.wrap(function _callee10$(_context10) {
       while (1) switch (_context10.prev = _context10.next) {
         case 0:
-          mockContactsCollection.find.mockResolvedValue({
-            data: []
-          });
-          _context10.next = 3;
-          return expect(instance.updateSharingMemberType('sharing-123', 1, 'one-way')).rejects.toThrow('Contact not found');
+          _context10.next = 2;
+          return instance.updateSharingMemberType('sharing-123', 1, 'one-way');
 
-        case 3:
+        case 2:
+          expect(instance.sharingCol.setReadOnly).toHaveBeenCalledWith(mockSharing, 1);
+          expect(instance.sharingCol.setReadWrite).not.toHaveBeenCalled();
+
+        case 4:
         case "end":
           return _context10.stop();
       }
     }, _callee10);
   })));
-  it('should revoke and re-add with readOnly when switching to one-way', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee11() {
+  it('should call setReadWrite when switching to two-way', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee11() {
     return _regeneratorRuntime.wrap(function _callee11$(_context11) {
       while (1) switch (_context11.prev = _context11.next) {
         case 0:
           _context11.next = 2;
-          return instance.updateSharingMemberType('sharing-123', 1, 'one-way');
+          return instance.updateSharingMemberType('sharing-123', 1, 'two-way');
 
         case 2:
-          expect(instance.sharingCol.revokeRecipient).toHaveBeenCalledWith(mockSharing, 1);
-          expect(instance.addRecipients).toHaveBeenCalledWith({
-            document: mockSharing,
-            recipients: [],
-            readOnlyRecipients: [mockContact]
-          });
+          expect(instance.sharingCol.setReadWrite).toHaveBeenCalledWith(mockSharing, 1);
+          expect(instance.sharingCol.setReadOnly).not.toHaveBeenCalled();
 
         case 4:
         case "end":
@@ -521,34 +507,31 @@ describe('updateSharingMemberType', function () {
       }
     }, _callee11);
   })));
-  it('should revoke and re-add as read-write when switching to two-way', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee12() {
+  it('should not dispatch a state update — realtime refreshes the store', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee12() {
     return _regeneratorRuntime.wrap(function _callee12$(_context12) {
       while (1) switch (_context12.prev = _context12.next) {
         case 0:
           _context12.next = 2;
-          return instance.updateSharingMemberType('sharing-123', 1, 'two-way');
+          return instance.updateSharingMemberType('sharing-123', 1, 'one-way');
 
         case 2:
-          expect(instance.sharingCol.revokeRecipient).toHaveBeenCalledWith(mockSharing, 1);
-          expect(instance.addRecipients).toHaveBeenCalledWith({
-            document: mockSharing,
-            recipients: [mockContact],
-            readOnlyRecipients: []
-          });
+          expect(instance.setState).not.toHaveBeenCalled();
 
-        case 4:
+        case 3:
         case "end":
           return _context12.stop();
       }
     }, _callee12);
   })));
-  it('should rethrow error if addRecipients fails after revocation', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee13() {
+  it('should not dispatch a state update for two-way — realtime refreshes the store', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee13() {
     return _regeneratorRuntime.wrap(function _callee13$(_context13) {
       while (1) switch (_context13.prev = _context13.next) {
         case 0:
-          instance.addRecipients.mockRejectedValue(new Error('Network error'));
-          _context13.next = 3;
-          return expect(instance.updateSharingMemberType('sharing-123', 1, 'one-way')).rejects.toThrow('Network error');
+          _context13.next = 2;
+          return instance.updateSharingMemberType('sharing-123', 1, 'two-way');
+
+        case 2:
+          expect(instance.setState).not.toHaveBeenCalled();
 
         case 3:
         case "end":
@@ -556,6 +539,51 @@ describe('updateSharingMemberType', function () {
       }
     }, _callee13);
   })));
+  it('should rethrow error if setReadOnly fails', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee14() {
+    return _regeneratorRuntime.wrap(function _callee14$(_context14) {
+      while (1) switch (_context14.prev = _context14.next) {
+        case 0:
+          instance.sharingCol.setReadOnly.mockRejectedValue(new Error('Network error'));
+          _context14.next = 3;
+          return expect(instance.updateSharingMemberType('sharing-123', 1, 'one-way')).rejects.toThrow('Network error');
+
+        case 3:
+        case "end":
+          return _context14.stop();
+      }
+    }, _callee14);
+  })));
+  it('should rethrow error if setReadWrite fails', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee15() {
+    return _regeneratorRuntime.wrap(function _callee15$(_context15) {
+      while (1) switch (_context15.prev = _context15.next) {
+        case 0:
+          instance.sharingCol.setReadWrite.mockRejectedValue(new Error('Network error'));
+          _context15.next = 3;
+          return expect(instance.updateSharingMemberType('sharing-123', 1, 'two-way')).rejects.toThrow('Network error');
+
+        case 3:
+        case "end":
+          return _context15.stop();
+      }
+    }, _callee15);
+  })));
+  it('should not dispatch state update if API call fails', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee16() {
+    return _regeneratorRuntime.wrap(function _callee16$(_context16) {
+      while (1) switch (_context16.prev = _context16.next) {
+        case 0:
+          instance.sharingCol.setReadOnly.mockRejectedValue(new Error('Network error'));
+          _context16.next = 3;
+          return expect(instance.updateSharingMemberType('sharing-123', 1, 'one-way')).rejects.toThrow('Network error');
+
+        case 3:
+          expect(instance.setState).not.toHaveBeenCalled();
+
+        case 4:
+        case "end":
+          return _context16.stop();
+      }
+    }, _callee16);
+  })));
 }); // TODO Convert with react-testing-library
 // describe('hasWriteAccess', () => {
 //   it('tells if a doc is writtable', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-sharing",
-  "version": "33.3.1",
+  "version": "33.3.2",
   "description": "Provides sharing login for React applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -53,7 +53,7 @@
     "babel-jest": "30.3.0",
     "babel-plugin-css-modules-transform": "1.6.2",
     "babel-plugin-inline-react-svg": "1.1.2",
-    "cozy-client": "^60.24.0",
+    "cozy-client": "^60.27.0",
     "cozy-device-helper": "^4.0.0",
     "cozy-intent": "^2.31.1",
     "cozy-minilog": "^3.10.1",
@@ -68,7 +68,7 @@
     "twake-i18n": "^0.4.1"
   },
   "peerDependencies": {
-    "cozy-client": ">=60.24.0",
+    "cozy-client": ">=60.27.0",
     "cozy-device-helper": ">=4.0.0",
     "cozy-flags": ">=4.8.1",
     "cozy-intent": ">=2.29.1",
@@ -83,5 +83,5 @@
   "sideEffects": [
     "*.css"
   ],
-  "gitHead": "80c72e3af992596597b9319ee436ec8d238c9967"
+  "gitHead": "08272a4e1b47e169b6f4af662e30a40e4e9a4124"
 }

package/src/SharingProvider.jsx

@@ -143,7 +143,7 @@ export class SharingProvider extends Component {
     this.fetchAllSharings()
     if (!client.plugins.realtime) {
       // eslint-disable-next-line
-      console.warn(
+         console.warn(
         `You should register the realtime plugin to your CozyClient instance see https://docs.cozy.io/en/cozy-realtime/#example`
       )
     } else {
@@ -353,36 +353,19 @@ export class SharingProvider extends Component {
     const member = sharing.attributes.members[memberIndex]
     if (!member) throw new Error('Member not found')
 
-    // Find the contact by email (same pattern as helpers/contacts.js)
-    const matchedContacts = await this.props.client
-      .collection('io.cozy.contacts')
-      .find(
-        {
-          email: { $elemMatch: { address: member.email } },
-          _id: { $gt: null }
-        },
-        { indexedFields: ['_id'] }
-      )
-
-    if (!matchedContacts.data.length) {
-      throw new Error(`Contact not found for member ${member.email}`)
+    const makeReadOnly = newType === 'one-way'
+    if (newType !== 'one-way' && newType !== 'two-way') {
+      throw new Error('Unsupported sharing type: ' + newType)
     }
-    const contact = matchedContacts.data[0]
-
-    // Revoke (API call only, no state dispatch to avoid UI flickering)
-    await this.sharingCol.revokeRecipient(sharing, memberIndex)
-
-    // Re-add with the new permission type
-    const readOnly = newType === 'one-way'
     try {
-      await this.addRecipients({
-        document: sharing,
-        recipients: readOnly ? [] : [contact],
-        readOnlyRecipients: readOnly ? [contact] : []
-      })
+      if (makeReadOnly) {
+        await this.sharingCol.setReadOnly(sharing, memberIndex)
+      } else {
+        await this.sharingCol.setReadWrite(sharing, memberIndex)
+      }
     } catch (error) {
       log.error(
-        `Failed to re-add member ${member.email} after revocation. The member has been revoked but could not be re-added with the new permission type.`,
+        `Failed to change member ${member.email} permission type to ${newType}`,
         error
       )
       throw error

package/src/SharingProvider.spec.jsx

@@ -292,7 +292,6 @@ describe('updateDocumentPermissions', () => {
 })
 
 describe('updateSharingMemberType', () => {
-  const mockContact = { _id: 'contact-1', email: [{ address: 'bob@bob.cozy' }] }
   const mockSharing = {
     id: 'sharing-123',
     type: 'io.cozy.sharings',
@@ -305,16 +304,11 @@ describe('updateSharingMemberType', () => {
   }
 
   let instance
-  let mockContactsCollection
 
   beforeEach(() => {
-    mockContactsCollection = {
-      find: jest.fn().mockResolvedValue({ data: [mockContact] })
-    }
-
     const mockClient = {
       getStackClient: () => ({ uri: 'http://cozy.local' }),
-      collection: jest.fn().mockReturnValue(mockContactsCollection)
+      collection: jest.fn().mockReturnValue({})
     }
 
     instance = new SharingProvider({ client: mockClient })
@@ -323,9 +317,10 @@ describe('updateSharingMemberType', () => {
       sharings: [mockSharing]
     }
     instance.sharingCol = {
-      revokeRecipient: jest.fn().mockResolvedValue({})
+      setReadOnly: jest.fn().mockResolvedValue({}),
+      setReadWrite: jest.fn().mockResolvedValue({})
     }
-    jest.spyOn(instance, 'addRecipients').mockResolvedValue({})
+    jest.spyOn(instance, 'setState')
   })
 
   it('should throw when sharing is not found', async () => {
@@ -340,48 +335,65 @@ describe('updateSharingMemberType', () => {
     ).rejects.toThrow('Member not found')
   })
 
-  it('should throw when contact is not found', async () => {
-    mockContactsCollection.find.mockResolvedValue({ data: [] })
+  it('should call setReadOnly when switching to one-way', async () => {
+    await instance.updateSharingMemberType('sharing-123', 1, 'one-way')
 
-    await expect(
-      instance.updateSharingMemberType('sharing-123', 1, 'one-way')
-    ).rejects.toThrow('Contact not found')
+    expect(instance.sharingCol.setReadOnly).toHaveBeenCalledWith(mockSharing, 1)
+    expect(instance.sharingCol.setReadWrite).not.toHaveBeenCalled()
   })
 
-  it('should revoke and re-add with readOnly when switching to one-way', async () => {
-    await instance.updateSharingMemberType('sharing-123', 1, 'one-way')
+  it('should call setReadWrite when switching to two-way', async () => {
+    await instance.updateSharingMemberType('sharing-123', 1, 'two-way')
 
-    expect(instance.sharingCol.revokeRecipient).toHaveBeenCalledWith(
+    expect(instance.sharingCol.setReadWrite).toHaveBeenCalledWith(
       mockSharing,
       1
     )
-    expect(instance.addRecipients).toHaveBeenCalledWith({
-      document: mockSharing,
-      recipients: [],
-      readOnlyRecipients: [mockContact]
-    })
+    expect(instance.sharingCol.setReadOnly).not.toHaveBeenCalled()
   })
 
-  it('should revoke and re-add as read-write when switching to two-way', async () => {
+  it('should not dispatch a state update — realtime refreshes the store', async () => {
+    await instance.updateSharingMemberType('sharing-123', 1, 'one-way')
+
+    expect(instance.setState).not.toHaveBeenCalled()
+  })
+
+  it('should not dispatch a state update for two-way — realtime refreshes the store', async () => {
     await instance.updateSharingMemberType('sharing-123', 1, 'two-way')
 
-    expect(instance.sharingCol.revokeRecipient).toHaveBeenCalledWith(
-      mockSharing,
-      1
+    expect(instance.setState).not.toHaveBeenCalled()
+  })
+
+  it('should rethrow error if setReadOnly fails', async () => {
+    instance.sharingCol.setReadOnly.mockRejectedValue(
+      new Error('Network error')
     )
-    expect(instance.addRecipients).toHaveBeenCalledWith({
-      document: mockSharing,
-      recipients: [mockContact],
-      readOnlyRecipients: []
-    })
+
+    await expect(
+      instance.updateSharingMemberType('sharing-123', 1, 'one-way')
+    ).rejects.toThrow('Network error')
+  })
+
+  it('should rethrow error if setReadWrite fails', async () => {
+    instance.sharingCol.setReadWrite.mockRejectedValue(
+      new Error('Network error')
+    )
+
+    await expect(
+      instance.updateSharingMemberType('sharing-123', 1, 'two-way')
+    ).rejects.toThrow('Network error')
   })
 
-  it('should rethrow error if addRecipients fails after revocation', async () => {
-    instance.addRecipients.mockRejectedValue(new Error('Network error'))
+  it('should not dispatch state update if API call fails', async () => {
+    instance.sharingCol.setReadOnly.mockRejectedValue(
+      new Error('Network error')
+    )
 
     await expect(
       instance.updateSharingMemberType('sharing-123', 1, 'one-way')
     ).rejects.toThrow('Network error')
+
+    expect(instance.setState).not.toHaveBeenCalled()
   })
 })