cozy-sharing 33.3.0 → 33.3.1

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [33.3.1](https://github.com/cozy/cozy-libs/compare/cozy-sharing@33.3.0...cozy-sharing@33.3.1) (2026-06-10)
+
+### Bug Fixes
+
+- **cozy-sharing:** Expire share links at the end of the selected day ([db81ed9](https://github.com/cozy/cozy-libs/commit/db81ed936a15850f278404511c1b6faec0fc7a54))
+
 # [33.3.0](https://github.com/cozy/cozy-libs/compare/cozy-sharing@33.2.2...cozy-sharing@33.3.0) (2026-06-10)
 
 ### Features

package/dist/components/ShareRestrictionModal/helpers.js

@@ -1,5 +1,6 @@
 import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _regeneratorRuntime from "@babel/runtime/regenerator";
+import { endOfDay } from 'date-fns';
 import { generateWebLink } from 'cozy-client';
 import minilog from 'cozy-minilog';
 import { getAppSlugFromDocumentType } from '../../helpers/link';
@@ -7,6 +8,21 @@ import { getShortcode } from '../../helpers/shortcodes';
 var log = minilog('ShareRestrictionModal/helpers');
 export var WRITE_PERMS = ['GET', 'POST', 'PUT', 'PATCH'];
 export var READ_ONLY_PERMS = ['GET'];
+/**
+ * A share link expires at the END of the selected day, so picking today keeps
+ * the link reachable for the rest of today and expires it the next day.
+ * Without this, the picked day defaults to its midnight (start of day), which
+ * is already in the past and makes the link unreachable as soon as it is set.
+ * @param {Date|string|null|undefined} date - The picked expiration day
+ * @returns {Date|null|undefined} - The same value normalized to end of day
+ */
+
+export var toExpirationDate = function toExpirationDate(date) {
+  if (!date) return date;
+  var parsed = date instanceof Date ? date : new Date(date);
+  if (parsed.toString() === 'Invalid Date') return date;
+  return endOfDay(parsed);
+};
 /**
  * Create a sharing link for a file with specified options
  * @param {object} options
@@ -250,7 +266,8 @@ export var makeTTL = function makeTTL(selectedDate) {
 
     if (selectedDateConverted instanceof Date) {
       var now = new Date();
-      var ttl = selectedDateConverted > now ? "".concat(Math.round((selectedDateConverted - now) / 1000), "s") : undefined;
+      var expiration = toExpirationDate(selectedDateConverted);
+      var ttl = expiration > now ? "".concat(Math.round((expiration - now) / 1000), "s") : undefined;
       return ttl;
     }
 
@@ -326,13 +343,14 @@ export var createPermissions = /*#__PURE__*/function () {
 
 export var updatePermissions = /*#__PURE__*/function () {
   var _ref9 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4(_ref8) {
-    var file, t, dateToggle, selectedDate, passwordToggle, password, editingRights, documentType, updateDocumentPermissions, showAlert, expiresAt, ensurePassword, verbs;
+    var file, t, dateToggle, selectedDate, passwordToggle, password, editingRights, documentType, updateDocumentPermissions, showAlert, _toExpirationDate, expiresAt, ensurePassword, verbs;
+
     return _regeneratorRuntime.wrap(function _callee4$(_context4) {
       while (1) switch (_context4.prev = _context4.next) {
         case 0:
           file = _ref8.file, t = _ref8.t, dateToggle = _ref8.dateToggle, selectedDate = _ref8.selectedDate, passwordToggle = _ref8.passwordToggle, password = _ref8.password, editingRights = _ref8.editingRights, documentType = _ref8.documentType, updateDocumentPermissions = _ref8.updateDocumentPermissions, showAlert = _ref8.showAlert;
           _context4.prev = 1;
-          expiresAt = dateToggle ? (selectedDate === null || selectedDate === void 0 ? void 0 : selectedDate.toISOString()) || undefined : '';
+          expiresAt = dateToggle ? ((_toExpirationDate = toExpirationDate(selectedDate)) === null || _toExpirationDate === void 0 ? void 0 : _toExpirationDate.toISOString()) || undefined : '';
           ensurePassword = passwordToggle ? password || undefined : '';
           verbs = editingRights === 'readOnly' ? READ_ONLY_PERMS : WRITE_PERMS;
           return _context4.abrupt("return", updateDocumentPermissions(file, {

package/dist/components/ShareRestrictionModal/helpers.spec.js

@@ -1,7 +1,23 @@
 import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _regeneratorRuntime from "@babel/runtime/regenerator";
-import { makeTTL, revokePermissions, updatePermissions } from './helpers';
+import { endOfDay } from 'date-fns';
+import { makeTTL, revokePermissions, toExpirationDate, updatePermissions } from './helpers';
 describe('ShareRestrictionModal/helpers', function () {
+  describe('toExpirationDate', function () {
+    it('returns falsy values unchanged', function () {
+      expect(toExpirationDate(null)).toBeNull();
+      expect(toExpirationDate(undefined)).toBeUndefined();
+      expect(toExpirationDate('')).toBe('');
+    });
+    it('normalizes a Date to the end of its day', function () {
+      var date = new Date(2100, 0, 1, 9, 30);
+      expect(toExpirationDate(date)).toEqual(endOfDay(date));
+    });
+    it('accepts an ISO string', function () {
+      var iso = '2100-01-01T09:30:00.000Z';
+      expect(toExpirationDate(iso)).toEqual(endOfDay(new Date(iso)));
+    });
+  });
   describe('makeTTL', function () {
     it('sould return undefined', function () {
       expect(makeTTL()).toBeUndefined();
@@ -15,6 +31,18 @@ describe('ShareRestrictionModal/helpers', function () {
       expect(makeTTL(new Date('2100-01-01T00:00:00.000Z'))).toBeDefined();
       expect(makeTTL('2100-01-01T00:00:00.000Z')).toBeDefined();
     });
+    it('keeps a link picked for today valid until the end of the day', function () {
+      // Regression: picking "today" used to resolve to midnight (already past),
+      // which dropped the TTL and the link never expired or was unreachable.
+      jest.useFakeTimers();
+      jest.setSystemTime(new Date('2100-01-01T12:00:00.000Z'));
+
+      try {
+        expect(makeTTL(new Date())).toBeDefined();
+      } finally {
+        jest.useRealTimers();
+      }
+    });
   });
   describe('updatePermissions', function () {
     var documentType = 'Files';
@@ -163,7 +191,7 @@ describe('ShareRestrictionModal/helpers', function () {
       }, _callee4);
     })));
     it('should call updateDocumentPermissions with expected date & password if their switches are true', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee5() {
-      var updateDocumentPermissions, file;
+      var updateDocumentPermissions, file, selectedDate;
       return _regeneratorRuntime.wrap(function _callee5$(_context5) {
         while (1) switch (_context5.prev = _context5.next) {
           case 0:
@@ -171,12 +199,13 @@ describe('ShareRestrictionModal/helpers', function () {
             file = {
               _id: '123'
             };
-            _context5.next = 4;
+            selectedDate = new Date('2100-01-01T00:00:00.000Z');
+            _context5.next = 5;
             return updatePermissions({
               file: file,
               t: jest.fn(),
               dateToggle: true,
-              selectedDate: new Date('2100-01-01T00:00:00.000Z'),
+              selectedDate: selectedDate,
               passwordToggle: true,
               password: '1234',
               editingRights: 'readOnly',
@@ -185,32 +214,77 @@ describe('ShareRestrictionModal/helpers', function () {
               showAlert: jest.fn()
             });
 
-          case 4:
+          case 5:
             expect(updateDocumentPermissions).toHaveBeenCalledWith(file, {
-              expiresAt: '2100-01-01T00:00:00.000Z',
+              expiresAt: endOfDay(selectedDate).toISOString(),
               password: '1234',
               verbs: ['GET']
             });
 
-          case 5:
+          case 6:
           case "end":
             return _context5.stop();
         }
       }, _callee5);
     })));
+    it('sets expiration to the end of the selected day so picking today stays valid', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6() {
+      var updateDocumentPermissions, file, today, expiresAt;
+      return _regeneratorRuntime.wrap(function _callee6$(_context6) {
+        while (1) switch (_context6.prev = _context6.next) {
+          case 0:
+            // Freeze time so the "expires in the future" assertion can't flake near
+            // midnight or under slow CI.
+            jest.useFakeTimers();
+            jest.setSystemTime(new Date('2100-01-01T12:00:00.000Z'));
+            _context6.prev = 2;
+            updateDocumentPermissions = jest.fn();
+            file = {
+              _id: '123'
+            };
+            today = new Date();
+            _context6.next = 8;
+            return updatePermissions({
+              file: file,
+              t: jest.fn(),
+              dateToggle: true,
+              selectedDate: today,
+              passwordToggle: false,
+              password: '',
+              editingRights: 'readOnly',
+              documentType: documentType,
+              updateDocumentPermissions: updateDocumentPermissions,
+              showAlert: jest.fn()
+            });
+
+          case 8:
+            expiresAt = updateDocumentPermissions.mock.calls[0][1].expiresAt;
+            expect(expiresAt).toBe(endOfDay(today).toISOString());
+            expect(new Date(expiresAt).getTime()).toBeGreaterThan(Date.now());
+
+          case 11:
+            _context6.prev = 11;
+            jest.useRealTimers();
+            return _context6.finish(11);
+
+          case 14:
+          case "end":
+            return _context6.stop();
+        }
+      }, _callee6, null, [[2,, 11, 14]]);
+    })));
   });
   describe('revokePermissions', function () {
     var documentType = 'Files';
-    it('should call revokeSharingLink', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6() {
+    it('should call revokeSharingLink', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7() {
       var revokeSharingLink, file;
-      return _regeneratorRuntime.wrap(function _callee6$(_context6) {
-        while (1) switch (_context6.prev = _context6.next) {
+      return _regeneratorRuntime.wrap(function _callee7$(_context7) {
+        while (1) switch (_context7.prev = _context7.next) {
           case 0:
             revokeSharingLink = jest.fn();
             file = {
               _id: '123'
             };
-            _context6.next = 4;
+            _context7.next = 4;
             return revokePermissions({
               file: file,
               t: jest.fn(),
@@ -224,9 +298,9 @@ describe('ShareRestrictionModal/helpers', function () {
 
           case 5:
           case "end":
-            return _context6.stop();
+            return _context7.stop();
         }
-      }, _callee6);
+      }, _callee7);
     })));
   });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-sharing",
-  "version": "33.3.0",
+  "version": "33.3.1",
   "description": "Provides sharing login for React applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -83,5 +83,5 @@
   "sideEffects": [
     "*.css"
   ],
-  "gitHead": "4fe0199d7042ff150315bd4a097256b2364f200c"
+  "gitHead": "80c72e3af992596597b9319ee436ec8d238c9967"
 }

package/src/components/ShareRestrictionModal/helpers.js

@@ -1,3 +1,5 @@
+import { endOfDay } from 'date-fns'
+
 import { generateWebLink } from 'cozy-client'
 import minilog from 'cozy-minilog'
 
@@ -9,6 +11,21 @@ const log = minilog('ShareRestrictionModal/helpers')
 export const WRITE_PERMS = ['GET', 'POST', 'PUT', 'PATCH']
 export const READ_ONLY_PERMS = ['GET']
 
+/**
+ * A share link expires at the END of the selected day, so picking today keeps
+ * the link reachable for the rest of today and expires it the next day.
+ * Without this, the picked day defaults to its midnight (start of day), which
+ * is already in the past and makes the link unreachable as soon as it is set.
+ * @param {Date|string|null|undefined} date - The picked expiration day
+ * @returns {Date|null|undefined} - The same value normalized to end of day
+ */
+export const toExpirationDate = date => {
+  if (!date) return date
+  const parsed = date instanceof Date ? date : new Date(date)
+  if (parsed.toString() === 'Invalid Date') return date
+  return endOfDay(parsed)
+}
+
 /**
  * Create a sharing link for a file with specified options
  * @param {object} options
@@ -161,9 +178,10 @@ export const makeTTL = selectedDate => {
     }
     if (selectedDateConverted instanceof Date) {
       const now = new Date()
+      const expiration = toExpirationDate(selectedDateConverted)
       const ttl =
-        selectedDateConverted > now
-          ? `${Math.round((selectedDateConverted - now) / 1000)}s`
+        expiration > now
+          ? `${Math.round((expiration - now) / 1000)}s`
           : undefined
       return ttl
     }
@@ -239,7 +257,9 @@ export const updatePermissions = async ({
   showAlert
 }) => {
   try {
-    const expiresAt = dateToggle ? selectedDate?.toISOString() || undefined : ''
+    const expiresAt = dateToggle
+      ? toExpirationDate(selectedDate)?.toISOString() || undefined
+      : ''
     const ensurePassword = passwordToggle ? password || undefined : ''
     const verbs = editingRights === 'readOnly' ? READ_ONLY_PERMS : WRITE_PERMS
     return updateDocumentPermissions(file, {

package/src/components/ShareRestrictionModal/helpers.spec.js

@@ -1,6 +1,29 @@
-import { makeTTL, revokePermissions, updatePermissions } from './helpers'
+import { endOfDay } from 'date-fns'
+
+import {
+  makeTTL,
+  revokePermissions,
+  toExpirationDate,
+  updatePermissions
+} from './helpers'
 
 describe('ShareRestrictionModal/helpers', () => {
+  describe('toExpirationDate', () => {
+    it('returns falsy values unchanged', () => {
+      expect(toExpirationDate(null)).toBeNull()
+      expect(toExpirationDate(undefined)).toBeUndefined()
+      expect(toExpirationDate('')).toBe('')
+    })
+    it('normalizes a Date to the end of its day', () => {
+      const date = new Date(2100, 0, 1, 9, 30)
+      expect(toExpirationDate(date)).toEqual(endOfDay(date))
+    })
+    it('accepts an ISO string', () => {
+      const iso = '2100-01-01T09:30:00.000Z'
+      expect(toExpirationDate(iso)).toEqual(endOfDay(new Date(iso)))
+    })
+  })
+
   describe('makeTTL', () => {
     it('sould return undefined', () => {
       expect(makeTTL()).toBeUndefined()
@@ -14,6 +37,17 @@ describe('ShareRestrictionModal/helpers', () => {
       expect(makeTTL(new Date('2100-01-01T00:00:00.000Z'))).toBeDefined()
       expect(makeTTL('2100-01-01T00:00:00.000Z')).toBeDefined()
     })
+    it('keeps a link picked for today valid until the end of the day', () => {
+      // Regression: picking "today" used to resolve to midnight (already past),
+      // which dropped the TTL and the link never expired or was unreachable.
+      jest.useFakeTimers()
+      jest.setSystemTime(new Date('2100-01-01T12:00:00.000Z'))
+      try {
+        expect(makeTTL(new Date())).toBeDefined()
+      } finally {
+        jest.useRealTimers()
+      }
+    })
   })
 
   describe('updatePermissions', () => {
@@ -118,11 +152,12 @@ describe('ShareRestrictionModal/helpers', () => {
       const updateDocumentPermissions = jest.fn()
       const file = { _id: '123' }
 
+      const selectedDate = new Date('2100-01-01T00:00:00.000Z')
       await updatePermissions({
         file,
         t: jest.fn(),
         dateToggle: true,
-        selectedDate: new Date('2100-01-01T00:00:00.000Z'),
+        selectedDate,
         passwordToggle: true,
         password: '1234',
         editingRights: 'readOnly',
@@ -132,11 +167,42 @@ describe('ShareRestrictionModal/helpers', () => {
       })
 
       expect(updateDocumentPermissions).toHaveBeenCalledWith(file, {
-        expiresAt: '2100-01-01T00:00:00.000Z',
+        expiresAt: endOfDay(selectedDate).toISOString(),
         password: '1234',
         verbs: ['GET']
       })
     })
+
+    it('sets expiration to the end of the selected day so picking today stays valid', async () => {
+      // Freeze time so the "expires in the future" assertion can't flake near
+      // midnight or under slow CI.
+      jest.useFakeTimers()
+      jest.setSystemTime(new Date('2100-01-01T12:00:00.000Z'))
+      try {
+        const updateDocumentPermissions = jest.fn()
+        const file = { _id: '123' }
+        const today = new Date()
+
+        await updatePermissions({
+          file,
+          t: jest.fn(),
+          dateToggle: true,
+          selectedDate: today,
+          passwordToggle: false,
+          password: '',
+          editingRights: 'readOnly',
+          documentType,
+          updateDocumentPermissions,
+          showAlert: jest.fn()
+        })
+
+        const { expiresAt } = updateDocumentPermissions.mock.calls[0][1]
+        expect(expiresAt).toBe(endOfDay(today).toISOString())
+        expect(new Date(expiresAt).getTime()).toBeGreaterThan(Date.now())
+      } finally {
+        jest.useRealTimers()
+      }
+    })
   })
 
   describe('revokePermissions', () => {