cozy-sharing 3.12.7 → 4.0.0

package/CHANGELOG.md

@@ -3,6 +3,68 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [4.0.0](https://github.com/cozy/cozy-libs/compare/cozy-sharing@3.12.10...cozy-sharing@4.0.0) (2022-01-07)
+
+
+### Features
+
+* **eslint:** Propose Eslint plugin promise ([1fded18](https://github.com/cozy/cozy-libs/commit/1fded18))
+
+
+### BREAKING CHANGES
+
+* **eslint:** Most errors are not auto fixable,
+if needed, use // disable-next-line
+
+Or insert in .eslintrc:
+{
+  "rules": {
+    "promise/always-return": "warn",
+    "promise/no-return-wrap": "warn",
+    "promise/param-names": "warn",
+    "promise/catch-or-return": "warn",
+    "promise/no-native": "warn",
+    "promise/no-nesting": "warn",
+    "promise/no-promise-in-callback": "warn",
+    "promise/no-callback-in-promise": "warn",
+    "promise/avoid-new": "warn",
+    "promise/no-new-statics": "warn",
+    "promise/no-return-in-finally": "warn",
+    "promise/valid-params": "warn"
+  }
+}
+
+
+
+
+
+## [3.12.10](https://github.com/cozy/cozy-libs/compare/cozy-sharing@3.12.9...cozy-sharing@3.12.10) (2022-01-06)
+
+**Note:** Version bump only for package cozy-sharing
+
+
+
+
+
+## [3.12.9](https://github.com/cozy/cozy-libs/compare/cozy-sharing@3.12.8...cozy-sharing@3.12.9) (2021-12-31)
+
+
+### Bug Fixes
+
+* **sharing:** ShareButton should not pass I18n props to Cozy-UI Button ([587cd2e](https://github.com/cozy/cozy-libs/commit/587cd2e))
+
+
+
+
+
+## [3.12.8](https://github.com/cozy/cozy-libs/compare/cozy-sharing@3.12.7...cozy-sharing@3.12.8) (2021-12-28)
+
+**Note:** Version bump only for package cozy-sharing
+
+
+
+
+
 ## [3.12.7](https://github.com/cozy/cozy-libs/compare/cozy-sharing@3.12.6...cozy-sharing@3.12.7) (2021-12-24)
 
 

package/dist/ShareButton.js

@@ -1,6 +1,12 @@
 import _extends from "@babel/runtime/helpers/extends";
+import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
 var _excluded = ["docId", "useShortLabel"];
+
+function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); if (enumerableOnly) symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; }); keys.push.apply(keys, symbols); } return keys; }
+
+function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; if (i % 2) { ownKeys(Object(source), true).forEach(function (key) { _defineProperty(target, key, source[key]); }); } else if (Object.getOwnPropertyDescriptors) { Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)); } else { ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } } return target; }
+
 import React from 'react';
 import { useI18n } from 'cozy-ui/transpiled/react/I18n';
 import SharingContext from './context';
@@ -14,16 +20,22 @@ export var ShareButton = withLocales(function (_ref) {
   var _useI18n = useI18n(),
       t = _useI18n.t;
 
+  var restProps = _objectSpread(_objectSpread({}, rest), {}, {
+    t: null,
+    f: null,
+    lang: null
+  });
+
   return /*#__PURE__*/React.createElement(SharingContext.Consumer, null, function (_ref2) {
     var byDocId = _ref2.byDocId,
         documentType = _ref2.documentType,
         isOwner = _ref2.isOwner;
     return !byDocId[docId] ? /*#__PURE__*/React.createElement(DumbShareButton, _extends({
       label: t("".concat(documentType, ".share.cta"))
-    }, rest)) : isOwner(docId) ? /*#__PURE__*/React.createElement(SharedByMeButton, _extends({
+    }, restProps)) : isOwner(docId) ? /*#__PURE__*/React.createElement(SharedByMeButton, _extends({
       label: useShortLabel ? t("".concat(documentType, ".share.shared")) : t("".concat(documentType, ".share.sharedByMe"))
-    }, rest)) : /*#__PURE__*/React.createElement(SharedWithMeButton, _extends({
+    }, restProps)) : /*#__PURE__*/React.createElement(SharedWithMeButton, _extends({
       label: useShortLabel ? t("".concat(documentType, ".share.shared")) : t("".concat(documentType, ".share.sharedWithMe"))
-    }, rest));
+    }, restProps));
   });
 });

package/dist/ShareButton.spec.js

@@ -0,0 +1,60 @@
+import React from 'react';
+import { render } from '@testing-library/react';
+import { ShareButton } from './ShareButton';
+jest.mock('cozy-ui/transpiled/react', function () {
+  return {
+    Button: function Button(props) {
+      if (props.t || props.t || props.lang) {
+        throw 'do not pass html button invalid props';
+      }
+
+      return /*#__PURE__*/React.createElement(React.Fragment, null);
+    }
+  };
+});
+jest.mock('cozy-ui/transpiled/react/I18n', function () {
+  return {
+    useI18n: jest.fn().mockReturnValue({
+      t: jest.fn()
+    })
+  };
+});
+jest.mock('./withLocales', function () {
+  return (// eslint-disable-next-line react/display-name
+    function (Component) {
+      return function (props) {
+        return /*#__PURE__*/React.createElement(React.Fragment, null, Component(props));
+      };
+    }
+  );
+});
+jest.mock('./context', function () {
+  return {
+    // eslint-disable-next-line react/display-name
+    Consumer: function Consumer(props) {
+      var Component = function Component() {
+        return props.children({
+          byDocId: {
+            docId: false
+          }
+        });
+      };
+
+      return /*#__PURE__*/React.createElement(Component, null);
+    }
+  };
+});
+describe('ShareButton', function () {
+  it('should not send incorrect props to CozyUI button', function () {
+    // When
+    var _render = render( /*#__PURE__*/React.createElement(ShareButton, {
+      f: "incorrect prop",
+      t: "incorrect prop",
+      lang: "incorrect prop"
+    })),
+        container = _render.container; // Then
+
+
+    expect(container).toBeDefined();
+  });
+});

package/dist/SharingProvider.js

@@ -636,7 +636,8 @@ export var SharingProvider = /*#__PURE__*/function (_Component) {
                 }));
                 this.setState({
                   hasLoadedAtLeastOnePage: true
-                });
+                }); // eslint-disable-next-line promise/catch-or-return
+
                 fetchNextPermissions(permissions, this.dispatch, client).then(function () {
                   return _this2.setState({
                     allLoaded: true

package/dist/components/ShareDialogTwoStepsConfirmationContainer.js

@@ -207,13 +207,15 @@ var ShareDialogTwoStepsConfirmationContainer = function ShareDialogTwoStepsConfi
   };
 
   var onConfirmRecipient = function onConfirmRecipient() {
+    // eslint-disable-next-line promise/catch-or-return,promise/always-return
     confirmRecipient(recipientConfirmationData).then(function () {
       getRecipientsToBeConfirmed();
     });
   };
 
   var onRejectRecipient = function onRejectRecipient() {
-    setStatus('loading');
+    setStatus('loading'); // eslint-disable-next-line promise/catch-or-return,promise/always-return
+
     rejectRecipient(recipientConfirmationData).then(function () {
       getRecipientsToBeConfirmed();
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-sharing",
-  "version": "3.12.7",
+  "version": "4.0.0",
   "description": "Provides sharing login for React applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -28,7 +28,7 @@
     "@cozy/minilog": "^1.0.0",
     "classnames": "^2.2.6",
     "copy-text-to-clipboard": "^2.1.1",
-    "cozy-device-helper": "^1.13.2",
+    "cozy-device-helper": "^1.15.0",
     "cozy-doctypes": "^1.83.3",
     "lodash": "^4.17.19",
     "react-autosuggest": "^9.4.3",
@@ -61,5 +61,5 @@
   "sideEffects": [
     "*.css"
   ],
-  "gitHead": "ae29bac9f22e86e051f3db3f688499262a820c06"
+  "gitHead": "d0157461fc7919473be52fa994fed99c23b24ec2"
 }

package/src/ShareButton.jsx

@@ -12,12 +12,15 @@ import {
 
 export const ShareButton = withLocales(({ docId, useShortLabel, ...rest }) => {
   const { t } = useI18n()
-
+  const restProps = { ...rest, t: null, f: null, lang: null }
   return (
     <SharingContext.Consumer>
       {({ byDocId, documentType, isOwner }) => {
         return !byDocId[docId] ? (
-          <DumbShareButton label={t(`${documentType}.share.cta`)} {...rest} />
+          <DumbShareButton
+            label={t(`${documentType}.share.cta`)}
+            {...restProps}
+          />
         ) : isOwner(docId) ? (
           <SharedByMeButton
             label={
@@ -25,7 +28,7 @@ export const ShareButton = withLocales(({ docId, useShortLabel, ...rest }) => {
                 ? t(`${documentType}.share.shared`)
                 : t(`${documentType}.share.sharedByMe`)
             }
-            {...rest}
+            {...restProps}
           />
         ) : (
           <SharedWithMeButton
@@ -34,7 +37,7 @@ export const ShareButton = withLocales(({ docId, useShortLabel, ...rest }) => {
                 ? t(`${documentType}.share.shared`)
                 : t(`${documentType}.share.sharedWithMe`)
             }
-            {...rest}
+            {...restProps}
           />
         )
       }}

package/src/ShareButton.spec.jsx

@@ -0,0 +1,45 @@
+import React from 'react'
+import { render } from '@testing-library/react'
+import { ShareButton } from './ShareButton'
+
+jest.mock('cozy-ui/transpiled/react', () => ({
+  Button: props => {
+    if (props.t || props.t || props.lang) {
+      throw 'do not pass html button invalid props'
+    }
+    return <></>
+  }
+}))
+
+jest.mock('cozy-ui/transpiled/react/I18n', () => ({
+  useI18n: jest.fn().mockReturnValue({ t: jest.fn() })
+}))
+
+jest.mock('./withLocales', () =>
+  // eslint-disable-next-line react/display-name
+  Component => props => <>{Component(props)}</>
+)
+
+jest.mock('./context', () => ({
+  // eslint-disable-next-line react/display-name
+  Consumer: props => {
+    const Component = () => props.children({ byDocId: { docId: false } })
+    return <Component />
+  }
+}))
+
+describe('ShareButton', () => {
+  it('should not send incorrect props to CozyUI button', () => {
+    // When
+    const { container } = render(
+      <ShareButton
+        f="incorrect prop"
+        t="incorrect prop"
+        lang="incorrect prop"
+      />
+    )
+
+    // Then
+    expect(container).toBeDefined()
+  })
+})

package/src/SharingProvider.jsx

@@ -185,6 +185,7 @@ export class SharingProvider extends Component {
       })
     )
     this.setState({ hasLoadedAtLeastOnePage: true })
+    // eslint-disable-next-line promise/catch-or-return
     fetchNextPermissions(permissions, this.dispatch, client).then(() =>
       this.setState({ allLoaded: true })
     )

package/src/components/ShareDialogTwoStepsConfirmationContainer.jsx

@@ -173,6 +173,7 @@ const ShareDialogTwoStepsConfirmationContainer = ({
   }
 
   const onConfirmRecipient = () => {
+    // eslint-disable-next-line promise/catch-or-return,promise/always-return
     confirmRecipient(recipientConfirmationData).then(() => {
       getRecipientsToBeConfirmed()
     })
@@ -180,6 +181,7 @@ const ShareDialogTwoStepsConfirmationContainer = ({
 
   const onRejectRecipient = () => {
     setStatus('loading')
+    // eslint-disable-next-line promise/catch-or-return,promise/always-return
     rejectRecipient(recipientConfirmationData).then(() => {
       getRecipientsToBeConfirmed()
     })