cozy-sharing 27.0.6 → 27.1.0

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [27.1.0](https://github.com/cozy/cozy-libs/compare/cozy-sharing@27.0.6...cozy-sharing@27.1.0) (2025-11-25)
+
+### Features
+
+- Enhance sharing logic to retain shared drives without recipients ([ab91186](https://github.com/cozy/cozy-libs/commit/ab911869e5f49aafaf5ca16b3323bd9826072b35))
+
 ## [27.0.6](https://github.com/cozy/cozy-libs/compare/cozy-sharing@27.0.5...cozy-sharing@27.0.6) (2025-11-14)
 
 ### Bug Fixes

package/dist/state.js

@@ -39,7 +39,9 @@ export var receiveSharings = function receiveSharings(_ref) {
     type: RECEIVE_SHARINGS,
     data: {
       sharings: sharings.filter(function (s) {
-        return !areAllRecipientsRevoked(s) && !hasBeenSelfRevoked(s, instanceUri);
+        return (// Shared drives without recipients are valid and should be kept
+          (isSharingADrive(s) || !areAllRecipientsRevoked(s)) && !hasBeenSelfRevoked(s, instanceUri)
+        );
       }),
       permissions: permissions,
       apps: apps
@@ -235,7 +237,7 @@ var byDocId = function byDocId() {
     case REVOKE_GROUP:
     case REVOKE_RECIPIENT:
     case UPDATE_SHARING:
-      if (areAllRecipientsRevoked(action.sharing)) {
+      if (!isSharingADrive(action.sharing) && areAllRecipientsRevoked(action.sharing)) {
         return forgetSharing(state, action.sharing);
       }
 
@@ -367,7 +369,7 @@ var sharedPaths = function sharedPaths() {
 
     case REVOKE_GROUP:
     case REVOKE_RECIPIENT:
-      if (areAllRecipientsRevoked(action.sharing)) {
+      if (!isSharingADrive(action.sharing) && areAllRecipientsRevoked(action.sharing)) {
         return state.filter(function (p) {
           return p !== action.path;
         });
@@ -667,6 +669,10 @@ export var getPermissionDocIds = function getPermissionDocIds(perm) {
   }, []);
 };
 
+var isSharingADrive = function isSharingADrive(sharing) {
+  return sharing.attributes.drive === true;
+};
+
 var areAllRecipientsRevoked = function areAllRecipientsRevoked(sharing) {
   return sharing.attributes.owner && sharing.attributes.members.filter(function (m) {
     return m.status !== 'revoked';

package/dist/state.spec.js

@@ -4,7 +4,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
-import reducer, { receiveSharings, addSharing, addSharingLink, updateSharingLink, revokeSharingLink, getRecipients, revokeRecipient, revokeSelf, matchingInstanceName, getSharingLink, hasSharedParent, hasSharedChild, getSharedDocIdsBySharings, getSharingType, getPermissionDocIds, getDocumentSharingType, getSharedParentPath, getExternalSharingIds, getRecipientsWithGroups } from './state';
+import reducer, { receiveSharings, addSharing, addSharingLink, updateSharingLink, revokeSharingLink, getRecipients, revokeRecipient, revokeSelf, updateSharing, matchingInstanceName, getSharingLink, hasSharedParent, hasSharedChild, getSharedDocIdsBySharings, getSharingType, getPermissionDocIds, getDocumentSharingType, getSharedParentPath, getExternalSharingIds, getRecipientsWithGroups } from './state';
 import { SHARING_1, SHARING_2, SHARING_3, SHARING_READ_ONLY, PERM_1, PERM_2, PERM_WITHOUT_DOC, SHARING_NO_ACTIVE, SHARING_WITH_SHORTCUT, APPS } from '../__tests__/fixtures';
 describe('Sharing state', function () {
   it('should have a default state', function () {
@@ -69,6 +69,133 @@ describe('Sharing state', function () {
     });
     expect(state.sharings).toEqual([SHARING_1]);
   });
+  it('should not filter out shared drives without recipients', function () {
+    var SHARED_DRIVE_WITHOUT_RECIPIENTS = _objectSpread(_objectSpread({}, SHARING_1), {}, {
+      id: 'shared_drive_no_recipients',
+      attributes: _objectSpread(_objectSpread({}, SHARING_1.attributes), {}, {
+        drive: true,
+        members: [{
+          status: 'owner',
+          name: 'Jane Doe',
+          email: 'jane@doe.com',
+          instance: 'http://cozy.tools:8080'
+        }],
+        rules: [{
+          title: 'My Shared Drive',
+          doctype: 'io.cozy.files',
+          values: ['shared_drive_folder'],
+          add: 'sync',
+          update: 'sync',
+          remove: 'sync'
+        }]
+      })
+    });
+
+    var state = reducer(undefined, receiveSharings({
+      sharings: [SHARING_1, SHARED_DRIVE_WITHOUT_RECIPIENTS]
+    }));
+    expect(state.byDocId).toEqual({
+      folder_1: {
+        sharings: [SHARING_1.id],
+        permissions: []
+      },
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS.id],
+        permissions: []
+      }
+    });
+    expect(state.sharings).toEqual([SHARING_1, SHARED_DRIVE_WITHOUT_RECIPIENTS]);
+  });
+  it('should not forget shared drives without recipients when updating', function () {
+    var SHARED_DRIVE_WITHOUT_RECIPIENTS = _objectSpread(_objectSpread({}, SHARING_1), {}, {
+      id: 'shared_drive_no_recipients',
+      attributes: _objectSpread(_objectSpread({}, SHARING_1.attributes), {}, {
+        drive: true,
+        members: [{
+          status: 'owner',
+          name: 'Jane Doe',
+          email: 'jane@doe.com',
+          instance: 'http://cozy.tools:8080'
+        }],
+        rules: [{
+          title: 'My Shared Drive',
+          doctype: 'io.cozy.files',
+          values: ['shared_drive_folder'],
+          add: 'sync',
+          update: 'sync',
+          remove: 'sync'
+        }]
+      })
+    });
+
+    var initialState = reducer(undefined, receiveSharings({
+      sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS]
+    }));
+
+    var updatedSharing = _objectSpread(_objectSpread({}, SHARED_DRIVE_WITHOUT_RECIPIENTS), {}, {
+      attributes: _objectSpread(_objectSpread({}, SHARED_DRIVE_WITHOUT_RECIPIENTS.attributes), {}, {
+        description: 'Updated description'
+      })
+    });
+
+    var state = reducer(initialState, updateSharing(updatedSharing));
+    expect(state.byDocId).toEqual({
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS.id],
+        permissions: []
+      }
+    });
+    expect(state.sharings).toEqual([updatedSharing]);
+  });
+  it('should not remove shared drive path when revoking last recipient', function () {
+    var SHARED_DRIVE_WITH_ONE_RECIPIENT = _objectSpread(_objectSpread({}, SHARING_1), {}, {
+      id: 'shared_drive_one_recipient',
+      attributes: _objectSpread(_objectSpread({}, SHARING_1.attributes), {}, {
+        drive: true,
+        members: [{
+          status: 'owner',
+          name: 'Jane Doe',
+          email: 'jane@doe.com',
+          instance: 'http://cozy.tools:8080'
+        }, {
+          status: 'ready',
+          name: 'John Doe',
+          email: 'john@doe.com',
+          instance: 'http://cozy.local:8080'
+        }],
+        rules: [{
+          title: 'My Shared Drive',
+          doctype: 'io.cozy.files',
+          values: ['shared_drive_folder'],
+          add: 'sync',
+          update: 'sync',
+          remove: 'sync'
+        }]
+      })
+    });
+
+    var sharedDrivePath = '/shared_drive_folder';
+    var initialState = reducer(reducer(undefined, receiveSharings({
+      sharings: [SHARED_DRIVE_WITH_ONE_RECIPIENT]
+    })), addSharing(SHARED_DRIVE_WITH_ONE_RECIPIENT, sharedDrivePath));
+
+    var sharingAfterRevoke = _objectSpread(_objectSpread({}, SHARED_DRIVE_WITH_ONE_RECIPIENT), {}, {
+      attributes: _objectSpread(_objectSpread({}, SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes), {}, {
+        members: [SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes.members[0], _objectSpread(_objectSpread({}, SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes.members[1]), {}, {
+          status: 'revoked'
+        })]
+      })
+    });
+
+    var state = reducer(initialState, revokeRecipient(sharingAfterRevoke, 1, sharedDrivePath));
+    expect(state.sharedPaths).toContain(sharedDrivePath);
+    expect(state.byDocId).toEqual({
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITH_ONE_RECIPIENT.id],
+        permissions: []
+      }
+    });
+  });
   it('should index received permissions', function () {
     var state = reducer(undefined, receiveSharings({
       sharings: [SHARING_1, SHARING_2],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-sharing",
-  "version": "27.0.6",
+  "version": "27.1.0",
   "description": "Provides sharing login for React applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -81,5 +81,5 @@
   "sideEffects": [
     "*.css"
   ],
-  "gitHead": "3a0c0103636a6365a7d2a380960d7e7d773078eb"
+  "gitHead": "208d6d5eb0fdc5c3d22ca611e9e0ae48282b6708"
 }

package/src/state.js

@@ -27,7 +27,10 @@ export const receiveSharings = ({
   type: RECEIVE_SHARINGS,
   data: {
     sharings: sharings.filter(
-      s => !areAllRecipientsRevoked(s) && !hasBeenSelfRevoked(s, instanceUri)
+      s =>
+        // Shared drives without recipients are valid and should be kept
+        (isSharingADrive(s) || !areAllRecipientsRevoked(s)) &&
+        !hasBeenSelfRevoked(s, instanceUri)
     ),
     permissions,
     apps
@@ -181,7 +184,10 @@ const byDocId = (state = {}, action) => {
     case REVOKE_GROUP:
     case REVOKE_RECIPIENT:
     case UPDATE_SHARING:
-      if (areAllRecipientsRevoked(action.sharing)) {
+      if (
+        !isSharingADrive(action.sharing) &&
+        areAllRecipientsRevoked(action.sharing)
+      ) {
         return forgetSharing(state, action.sharing)
       }
       return state
@@ -275,7 +281,10 @@ const sharedPaths = (state = [], action) => {
       return newState
     case REVOKE_GROUP:
     case REVOKE_RECIPIENT:
-      if (areAllRecipientsRevoked(action.sharing)) {
+      if (
+        !isSharingADrive(action.sharing) &&
+        areAllRecipientsRevoked(action.sharing)
+      ) {
         return state.filter(p => p !== action.path)
       }
       return state
@@ -551,6 +560,8 @@ export const getPermissionDocIds = perm =>
     )
     .reduce((acc, val) => [...acc, ...val], [])
 
+const isSharingADrive = sharing => sharing.attributes.drive === true
+
 const areAllRecipientsRevoked = sharing =>
   sharing.attributes.owner &&
   sharing.attributes.members.filter(m => m.status !== 'revoked').length === 1

package/src/state.spec.js

@@ -7,6 +7,7 @@ import reducer, {
   getRecipients,
   revokeRecipient,
   revokeSelf,
+  updateSharing,
   matchingInstanceName,
   getSharingLink,
   hasSharedParent,
@@ -98,6 +99,168 @@ describe('Sharing state', () => {
     expect(state.sharings).toEqual([SHARING_1])
   })
 
+  it('should not filter out shared drives without recipients', () => {
+    const SHARED_DRIVE_WITHOUT_RECIPIENTS = {
+      ...SHARING_1,
+      id: 'shared_drive_no_recipients',
+      attributes: {
+        ...SHARING_1.attributes,
+        drive: true,
+        members: [
+          {
+            status: 'owner',
+            name: 'Jane Doe',
+            email: 'jane@doe.com',
+            instance: 'http://cozy.tools:8080'
+          }
+        ],
+        rules: [
+          {
+            title: 'My Shared Drive',
+            doctype: 'io.cozy.files',
+            values: ['shared_drive_folder'],
+            add: 'sync',
+            update: 'sync',
+            remove: 'sync'
+          }
+        ]
+      }
+    }
+    const state = reducer(
+      undefined,
+      receiveSharings({
+        sharings: [SHARING_1, SHARED_DRIVE_WITHOUT_RECIPIENTS]
+      })
+    )
+    expect(state.byDocId).toEqual({
+      folder_1: { sharings: [SHARING_1.id], permissions: [] },
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS.id],
+        permissions: []
+      }
+    })
+    expect(state.sharings).toEqual([SHARING_1, SHARED_DRIVE_WITHOUT_RECIPIENTS])
+  })
+
+  it('should not forget shared drives without recipients when updating', () => {
+    const SHARED_DRIVE_WITHOUT_RECIPIENTS = {
+      ...SHARING_1,
+      id: 'shared_drive_no_recipients',
+      attributes: {
+        ...SHARING_1.attributes,
+        drive: true,
+        members: [
+          {
+            status: 'owner',
+            name: 'Jane Doe',
+            email: 'jane@doe.com',
+            instance: 'http://cozy.tools:8080'
+          }
+        ],
+        rules: [
+          {
+            title: 'My Shared Drive',
+            doctype: 'io.cozy.files',
+            values: ['shared_drive_folder'],
+            add: 'sync',
+            update: 'sync',
+            remove: 'sync'
+          }
+        ]
+      }
+    }
+    const initialState = reducer(
+      undefined,
+      receiveSharings({
+        sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS]
+      })
+    )
+    const updatedSharing = {
+      ...SHARED_DRIVE_WITHOUT_RECIPIENTS,
+      attributes: {
+        ...SHARED_DRIVE_WITHOUT_RECIPIENTS.attributes,
+        description: 'Updated description'
+      }
+    }
+    const state = reducer(initialState, updateSharing(updatedSharing))
+    expect(state.byDocId).toEqual({
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITHOUT_RECIPIENTS.id],
+        permissions: []
+      }
+    })
+    expect(state.sharings).toEqual([updatedSharing])
+  })
+
+  it('should not remove shared drive path when revoking last recipient', () => {
+    const SHARED_DRIVE_WITH_ONE_RECIPIENT = {
+      ...SHARING_1,
+      id: 'shared_drive_one_recipient',
+      attributes: {
+        ...SHARING_1.attributes,
+        drive: true,
+        members: [
+          {
+            status: 'owner',
+            name: 'Jane Doe',
+            email: 'jane@doe.com',
+            instance: 'http://cozy.tools:8080'
+          },
+          {
+            status: 'ready',
+            name: 'John Doe',
+            email: 'john@doe.com',
+            instance: 'http://cozy.local:8080'
+          }
+        ],
+        rules: [
+          {
+            title: 'My Shared Drive',
+            doctype: 'io.cozy.files',
+            values: ['shared_drive_folder'],
+            add: 'sync',
+            update: 'sync',
+            remove: 'sync'
+          }
+        ]
+      }
+    }
+    const sharedDrivePath = '/shared_drive_folder'
+    const initialState = reducer(
+      reducer(
+        undefined,
+        receiveSharings({
+          sharings: [SHARED_DRIVE_WITH_ONE_RECIPIENT]
+        })
+      ),
+      addSharing(SHARED_DRIVE_WITH_ONE_RECIPIENT, sharedDrivePath)
+    )
+    const sharingAfterRevoke = {
+      ...SHARED_DRIVE_WITH_ONE_RECIPIENT,
+      attributes: {
+        ...SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes,
+        members: [
+          SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes.members[0],
+          {
+            ...SHARED_DRIVE_WITH_ONE_RECIPIENT.attributes.members[1],
+            status: 'revoked'
+          }
+        ]
+      }
+    }
+    const state = reducer(
+      initialState,
+      revokeRecipient(sharingAfterRevoke, 1, sharedDrivePath)
+    )
+    expect(state.sharedPaths).toContain(sharedDrivePath)
+    expect(state.byDocId).toEqual({
+      shared_drive_folder: {
+        sharings: [SHARED_DRIVE_WITH_ONE_RECIPIENT.id],
+        permissions: []
+      }
+    })
+  })
+
   it('should index received permissions', () => {
     const state = reducer(
       undefined,