cozy-sharing 13.1.2 → 13.3.0

package/CHANGELOG.md

@@ -3,6 +3,33 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [13.3.0](https://github.com/cozy/cozy-libs/compare/cozy-sharing@13.2.0...cozy-sharing@13.3.0) (2024-05-02)
+
+
+### Features
+
+* **share:** Manage the case of a contact that is already in ([7c979af](https://github.com/cozy/cozy-libs/commit/7c979af7efebd906e45f1e83b43414bf2cb5b984))
+
+
+
+
+
+# [13.2.0](https://github.com/cozy/cozy-libs/compare/cozy-sharing@13.1.2...cozy-sharing@13.2.0) (2024-04-18)
+
+
+### Bug Fixes
+
+* Only show add email suggestion when we can't send an email ([9212597](https://github.com/cozy/cozy-libs/commit/92125976900b939e985330682f9375ce22f2ab42))
+
+
+### Features
+
+* Allow to add empty group ([a16f535](https://github.com/cozy/cozy-libs/commit/a16f535008a4dbe9426ee026acdbd413280585dd))
+
+
+
+
+
 ## [13.1.2](https://github.com/cozy/cozy-libs/compare/cozy-sharing@13.1.1...cozy-sharing@13.1.2) (2024-04-17)
 
 

package/dist/components/Recipient/GroupRecipientDetail.js

@@ -1,5 +1,8 @@
 import React from 'react';
+import { useClient, generateWebLink } from 'cozy-client';
+import Buttons from 'cozy-ui/transpiled/react/Buttons';
 import { Dialog } from 'cozy-ui/transpiled/react/CozyDialogs';
+import Empty from 'cozy-ui/transpiled/react/Empty';
 import Typography from 'cozy-ui/transpiled/react/Typography';
 import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n';
 import { GroupRecipientDetailWithAccess } from './GroupRecipientDetailWithAccess';
@@ -11,6 +14,7 @@ var GroupRecipientDetail = function GroupRecipientDetail(_ref) {
       members = _ref.members,
       onClose = _ref.onClose,
       isOwner = _ref.isOwner;
+  var client = useClient();
 
   var _useI18n = useI18n(),
       t = _useI18n.t;
@@ -22,6 +26,12 @@ var GroupRecipientDetail = function GroupRecipientDetail(_ref) {
     return ['revoked', 'mail-not-sent'].includes(member.status);
   });
   var ownerName = owner.public_name;
+  var contactsLink = generateWebLink({
+    cozyUrl: client.getStackClient().uri,
+    slug: 'contacts',
+    pathname: '/',
+    subDomainType: client.getInstanceOptions().subdomain
+  });
   return /*#__PURE__*/React.createElement(Dialog, {
     open: true,
     size: "small",
@@ -33,7 +43,16 @@ var GroupRecipientDetail = function GroupRecipientDetail(_ref) {
     })) : null),
     content: /*#__PURE__*/React.createElement("div", {
       className: "u-flex u-stack-xs u-flex-column"
-    }, withAccess.length > 0 ? /*#__PURE__*/React.createElement(GroupRecipientDetailWithAccess, {
+    }, members.length === 0 ? /*#__PURE__*/React.createElement(Empty, {
+      text: t('GroupRecipientDetail.empty.content')
+    }, /*#__PURE__*/React.createElement(Buttons, {
+      component: "a",
+      className: "u-mt-1",
+      href: contactsLink,
+      target: "_blank",
+      rel: "noopener noreferrer",
+      label: t('GroupRecipientDetail.empty.action')
+    })) : null, withAccess.length > 0 ? /*#__PURE__*/React.createElement(GroupRecipientDetailWithAccess, {
       withAccess: withAccess
     }) : null, withoutAccess.length > 0 ? /*#__PURE__*/React.createElement(GroupRecipientDetailWithoutAccess, {
       withoutAccess: withoutAccess,

package/dist/components/Recipient/GroupRecipientDetailWithoutAccess.js

@@ -41,7 +41,7 @@ var GroupRecipientDetailWithoutAccess = function GroupRecipientDetailWithoutAcce
         style: {
           marginRight: '0.25rem'
         }
-      }) : null, t("GroupRecipientDetail.withoutAccess.status.".concat(recipient.status)), isOwner ? " - ".concat(t('GroupRecipientDetail.withoutAccess.addEmail')) : null)
+      }) : null, t("GroupRecipientDetail.withoutAccess.status.".concat(recipient.status)), isOwner && recipient.status === 'mail-not-sent' ? " - ".concat(t('GroupRecipientDetail.withoutAccess.addEmail')) : null)
     }));
   })));
 };

package/dist/components/ShareByEmail.js

@@ -14,7 +14,7 @@ import ShareSubmit from './Sharesubmit';
 import ShareTypeSelect from './Sharetypeselect';
 import { getOrCreateFromArray } from '../helpers/contacts';
 import { mergeRecipients, spreadGroupAndMergeRecipients, hasReachRecipientsLimit } from '../helpers/recipients';
-import { getSuccessMessage } from '../helpers/successMessage';
+import { getSuccessMessage, getErrorMessage } from '../helpers/share';
 import { isReadOnlySharing } from '../state';
 var styles = {
   "share-modal-content": "share__share-modal-content___1iqEq",
@@ -99,7 +99,7 @@ export var ShareByEmail = function ShareByEmail(_ref) {
 
   var share = /*#__PURE__*/function () {
     var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee() {
-      var recipientsBefore, contacts, readWriteRecipients, readOnlyRecipients, showGenericAlert, detail, sharingRights;
+      var recipientsBefore, contacts, readWriteRecipients, readOnlyRecipients;
       return _regeneratorRuntime.wrap(function _callee$(_context) {
         while (1) switch (_context.prev = _context.next) {
           case 0:
@@ -155,54 +155,34 @@ export var ShareByEmail = function ShareByEmail(_ref) {
               severity: 'success',
               variant: 'filled'
             });
-            _context.next = 25;
+            _context.next = 22;
             break;
 
           case 19:
             _context.prev = 19;
             _context.t0 = _context["catch"](7);
-            showGenericAlert = true;
-
-            if (_context.t0.name === 'FetchError' && _context.t0.status === 400) {
-              detail = JSON.parse(_context.t0.message).errors[0].detail;
-
-              if (detail.startsWith('A group member cannot be added as they are already in')) {
-                // To know the sharing rights of the other group
-                sharingRights = selectedOption === 'readOnly' ? 'readWrite' : 'readOnly';
-                showAlert({
-                  message: t('Share.errors.groupMemberAlreadyInSharing', {
-                    smart_count: recipients.length,
-                    groupName: recipients[0].name,
-                    sharingRights: t("Share.errors.sharingRights.".concat(sharingRights)),
-                    icon: false
-                  }),
-                  severity: 'error',
-                  variant: 'filled'
-                });
-                showGenericAlert = false;
-              }
-            }
-
-            if (showGenericAlert) {
-              showAlert({
-                message: t("".concat(documentType, ".share.error.generic")),
-                severity: 'error',
-                variant: 'filled'
-              });
-            }
-
-            throw _context.t0;
+            showAlert({
+              message: t.apply(void 0, _toConsumableArray(getErrorMessage({
+                t: t,
+                err: _context.t0,
+                documentType: documentType,
+                recipients: recipients,
+                selectedOption: selectedOption
+              }))),
+              severity: 'error',
+              variant: 'filled'
+            });
 
-          case 25:
-            _context.prev = 25;
+          case 22:
+            _context.prev = 22;
             reset();
-            return _context.finish(25);
+            return _context.finish(22);
 
-          case 28:
+          case 25:
           case "end":
             return _context.stop();
         }
-      }, _callee, null, [[7, 19, 25, 28]]);
+      }, _callee, null, [[7, 19, 22, 25]]);
     }));
 
     return function share() {

package/dist/components/ShareRecipientsInput.js

@@ -11,7 +11,7 @@ import { useQueryAll, isQueryLoading } from 'cozy-client';
 import flag from 'cozy-flags';
 import ShareAutosuggest from './ShareAutosuggest';
 import { getContactsFromGroupId } from '../helpers/contacts';
-import { buildReachableContactsQuery, buildContactGroupsByIdsQuery, buildUnreachableContactsWithGroupsQuery } from '../queries/queries';
+import { buildReachableContactsQuery, buildContactGroupsQuery, buildUnreachableContactsWithGroupsQuery } from '../queries/queries';
 /**
  * ShareRecipientsInput is responsible for fetching contacts and groups.
  * We retrieve all the contacts that are reachable and the groups they belong to.
@@ -30,20 +30,14 @@ var ShareRecipientsInput = function ShareRecipientsInput(_ref) {
   var unreachableContactsWithGroupsResult = useQueryAll(unreachableContactsWithGroupsQuery.definition, _objectSpread(_objectSpread({}, unreachableContactsWithGroupsQuery.options), {}, {
     enabled: !!flag('sharing.show-recipient-groups')
   }));
-  var contactGroupsByIdsQuery = buildContactGroupsByIdsQuery(_toConsumableArray(new Set((reachableContactsResult.data || []).flatMap(function (contact) {
-    var _contact$relationship;
-
-    return (((_contact$relationship = contact.relationships) === null || _contact$relationship === void 0 || (_contact$relationship = _contact$relationship.groups) === null || _contact$relationship === void 0 ? void 0 : _contact$relationship.data) || []).map(function (group) {
-      return group._id;
-    });
-  }))));
-  var contactGroupsByIdsResult = useQueryAll(contactGroupsByIdsQuery.definition, contactGroupsByIdsQuery.options);
-  var isLoading = isQueryLoading(reachableContactsResult) || reachableContactsResult.hasMore || isQueryLoading(contactGroupsByIdsResult) || contactGroupsByIdsResult.hasMore || flag('sharing.show-recipient-groups') && (isQueryLoading(unreachableContactsWithGroupsResult) || unreachableContactsWithGroupsResult.hasMore);
+  var contactGroupsQuery = buildContactGroupsQuery();
+  var contactGroupsResult = useQueryAll(contactGroupsQuery.definition, contactGroupsQuery.options);
+  var isLoading = isQueryLoading(reachableContactsResult) || reachableContactsResult.hasMore || isQueryLoading(contactGroupsResult) || contactGroupsResult.hasMore || flag('sharing.show-recipient-groups') && (isQueryLoading(unreachableContactsWithGroupsResult) || unreachableContactsWithGroupsResult.hasMore);
   var currentRecipientGroups = currentRecipients.map(function (_ref2) {
     var id = _ref2.id;
     return id;
   }).filter(Boolean);
-  var contactGroups = (contactGroupsByIdsResult.data || []).filter(function (_ref3) {
+  var contactGroups = (contactGroupsResult.data || []).filter(function (_ref3) {
     var _id = _ref3._id;
     return !flag('sharing.show-recipient-groups') || !currentRecipientGroups.includes(_id);
   }).map(function (contactGroup) {

package/dist/components/ShareRecipientsInput.spec.js

@@ -44,7 +44,7 @@ describe('ShareRecipientsInput component', function () {
           doctype: 'io.cozy.contacts',
           data: contacts
         },
-        'io.cozy.contacts.groups/by-ids/fe86af20-c6c5': {
+        'io.cozy.contacts.groups': {
           doctype: 'io.cozy.contacts.groups',
           data: contactGroups
         },

package/dist/helpers/{successMessage.js → share.js}

@@ -5,7 +5,7 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
 import { models } from 'cozy-client';
-import { Contact, Group } from '../models';
+import { Contact, Group, getDisplayName } from '../models';
 export var countNewRecipients = function countNewRecipients(currentRecipients, newRecipients) {
   var newRecipientsNotAlreadyIncluded = newRecipients.filter(function (recipient) {
     if (Contact.isContact(recipient)) {
@@ -75,4 +75,37 @@ export var getSuccessMessage = function getSuccessMessage(recipientsBefore, reci
       }];
     }
   }
+};
+export var getErrorMessage = function getErrorMessage(_ref) {
+  var t = _ref.t,
+      err = _ref.err,
+      documentType = _ref.documentType,
+      recipients = _ref.recipients,
+      selectedOption = _ref.selectedOption;
+
+  if (err.name === 'FetchError' && err.status === 400) {
+    var detail = JSON.parse(err.message).errors[0].detail;
+
+    if (detail.startsWith('A group member cannot be added as they are already in')) {
+      var sharingRights = t("Share.errors.sharingRights.".concat(selectedOption === 'readOnly' ? 'readWrite' : 'readOnly'));
+
+      if (recipients.length === 1 && recipients[0]._type === Contact.doctype) {
+        return ['Share.errors.contactAlreadyInSharing', {
+          smart_count: recipients.length,
+          contactName: getDisplayName(recipients[0]),
+          sharingRights: sharingRights,
+          icon: false
+        }];
+      }
+
+      return ['Share.errors.groupMemberAlreadyInSharing', {
+        smart_count: recipients.length,
+        groupName: recipients[0].name,
+        sharingRights: sharingRights,
+        icon: false
+      }];
+    }
+  }
+
+  return ["".concat(documentType, ".share.error.generic")];
 };

package/dist/helpers/share.spec.js

@@ -0,0 +1,385 @@
+import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
+import { getSuccessMessage, countNewRecipients, getErrorMessage } from './share';
+describe('share', function () {
+  describe('getSuccessMessage', function () {
+    var props = {
+      currentRecipients: [{
+        email: 'sansa.stark@winterfell.westeros'
+      }],
+      documentType: 'Files',
+      sharingDesc: 'fake-doc.odt',
+      onShare: jest.fn(),
+      createContact: jest.fn()
+    };
+    it('should return a success message and its params for multiple recipients', function () {
+      var recipientsAfter = [{
+        _type: 'io.cozy.contacts',
+        email: 'jon.snow@thewall.westeros'
+      }, {
+        _type: 'io.cozy.contacts',
+        email: 'arya.stark@winterfell.westeros'
+      }, {
+        _type: 'io.cozy.contacts',
+        email: 'sansa.stark@winterfell.westeros'
+      }];
+
+      var _getSuccessMessage = getSuccessMessage(props.currentRecipients, recipientsAfter, props.documentType),
+          _getSuccessMessage2 = _slicedToArray(_getSuccessMessage, 2),
+          message = _getSuccessMessage2[0],
+          params = _getSuccessMessage2[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.contactSuccess');
+      expect(params).toEqual({
+        smart_count: 2
+      });
+    });
+    it('should return a success message and its params for one recipient with email', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage3 = getSuccessMessage(recipientsBefore, [{
+        email: 'jon.snow@thewall.westeros'
+      }], props.documentType),
+          _getSuccessMessage4 = _slicedToArray(_getSuccessMessage3, 2),
+          message = _getSuccessMessage4[0],
+          params = _getSuccessMessage4[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.singleContactSuccess');
+      expect(params).toEqual({
+        email: 'jon.snow@thewall.westeros'
+      });
+    });
+    it('should return a success message and its params for one recipient (contact) with email', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage5 = getSuccessMessage(recipientsBefore, [{
+        _id: 'e8c0e15f-da7d',
+        _type: 'io.cozy.contacts',
+        fullname: 'Jon Snow',
+        email: [{
+          address: 'jon.snow@thewall.westeros',
+          primary: true
+        }, {
+          address: 'jon.snow@winterfell.westeros',
+          primary: false
+        }]
+      }], props.documentType),
+          _getSuccessMessage6 = _slicedToArray(_getSuccessMessage5, 2),
+          message = _getSuccessMessage6[0],
+          params = _getSuccessMessage6[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.singleContactSuccess');
+      expect(params).toEqual({
+        email: 'jon.snow@thewall.westeros'
+      });
+    });
+    it('should return a success message and its params for one recipient with cozy', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage7 = getSuccessMessage(recipientsBefore, [{
+        cozy: [{
+          url: 'https://doranmartell.mycozy.cloud'
+        }]
+      }], props.documentType),
+          _getSuccessMessage8 = _slicedToArray(_getSuccessMessage7, 2),
+          message = _getSuccessMessage8[0],
+          params = _getSuccessMessage8[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.singleContactSuccess');
+      expect(params).toEqual({
+        email: 'https://doranmartell.mycozy.cloud'
+      });
+    });
+    it('should use contact success message if recipient has no email and no cozy', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage9 = getSuccessMessage(recipientsBefore, [{
+        _id: 'fcb16b9e-7421'
+      }], props.documentType),
+          _getSuccessMessage10 = _slicedToArray(_getSuccessMessage9, 2),
+          message = _getSuccessMessage10[0],
+          params = _getSuccessMessage10[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.contactSuccess');
+      expect(params).toEqual({
+        smart_count: 1
+      });
+    });
+    it('should use single group success message if recipient is a group', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage11 = getSuccessMessage(recipientsBefore, [{
+        _type: 'io.cozy.contacts.groups',
+        name: 'Stark family'
+      }], props.documentType),
+          _getSuccessMessage12 = _slicedToArray(_getSuccessMessage11, 2),
+          message = _getSuccessMessage12[0],
+          params = _getSuccessMessage12[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.singleGroupSuccess');
+      expect(params).toEqual({
+        groupName: 'Stark family'
+      });
+    });
+    it('should use contact success message if recipient has only multiple contacts', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage13 = getSuccessMessage(recipientsBefore, [{
+        _type: 'io.cozy.contacts'
+      }, {
+        _type: 'io.cozy.contacts'
+      }, {
+        _type: 'io.cozy.contacts'
+      }], props.documentType),
+          _getSuccessMessage14 = _slicedToArray(_getSuccessMessage13, 2),
+          message = _getSuccessMessage14[0],
+          params = _getSuccessMessage14[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.contactSuccess');
+      expect(params).toEqual({
+        smart_count: 3
+      });
+    });
+    it('should use group success message if recipient has only multiple groups', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage15 = getSuccessMessage(recipientsBefore, [{
+        _type: 'io.cozy.contacts.groups'
+      }, {
+        _type: 'io.cozy.contacts.groups'
+      }], props.documentType),
+          _getSuccessMessage16 = _slicedToArray(_getSuccessMessage15, 2),
+          message = _getSuccessMessage16[0],
+          params = _getSuccessMessage16[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.groupSuccess');
+      expect(params).toEqual({
+        smart_count: 2
+      });
+    });
+    it('should use contact and group success message if recipient has multiple contacts and groups', function () {
+      var recipientsBefore = props.currentRecipients;
+
+      var _getSuccessMessage17 = getSuccessMessage(recipientsBefore, [{
+        _type: 'io.cozy.contacts'
+      }, {
+        _id: 'fcb16b9e-7421',
+        _type: 'io.cozy.contacts.groups'
+      }, {
+        _id: 'f45b16be-7523',
+        _type: 'io.cozy.contacts.groups'
+      }], props.documentType),
+          _getSuccessMessage18 = _slicedToArray(_getSuccessMessage17, 2),
+          message = _getSuccessMessage18[0],
+          params = _getSuccessMessage18[1];
+
+      expect(message).toEqual('Files.share.shareByEmail.contactAndGroupSuccess');
+      expect(params).toEqual({
+        nbContact: 1,
+        nbGroup: 2
+      });
+    });
+  });
+  describe('countNewRecipients', function () {
+    var currentRecipients = [{
+      email: 'arya.stark@winterfell.westeros'
+    }, {
+      email: 'sansa.stark@winterfell.westeros'
+    }, {
+      email: 'jon.snow@thewall.westeros'
+    }];
+    var addedRecipients = [{
+      _id: 'e8c0e15f-da7d',
+      _type: 'io.cozy.contacts',
+      fullname: 'Jon Snow',
+      email: [{
+        address: 'jon.snow@thewall.westeros',
+        primary: true
+      }, {
+        address: 'jon.snow@winterfell.westeros',
+        primary: false
+      }]
+    }, {
+      _id: 'fcb16b9e-7421',
+      _type: 'io.cozy.contacts'
+    }, {
+      _id: 'f45b16be-7523',
+      _type: 'io.cozy.contacts',
+      cozy: [{
+        url: 'https://doranmartell.mycozy.cloud'
+      }]
+    }];
+    it('should count the new recipients with email', function () {
+      var result = countNewRecipients(currentRecipients, addedRecipients);
+      expect(result.contact).toEqual(2);
+      expect(result.group).toEqual(0);
+    });
+    it('should count the new recipients with cozy url', function () {
+      var currentRecipients = [{
+        instance: 'https://bran.mycozy.cloud'
+      }, {
+        instance: 'https://jon.mycozy.cloud'
+      }];
+      var addedRecipients = [{
+        _type: 'io.cozy.contacts',
+        cozy: [{
+          url: 'https://jon.mycozy.cloud',
+          type: 'primary'
+        }]
+      }, {
+        _type: 'io.cozy.contacts',
+        cozy: [{
+          url: 'https://sansa.mycozy.cloud',
+          type: 'primary'
+        }]
+      }, {
+        _type: 'io.cozy.contacts',
+        cozy: [{
+          url: 'https://bran.mycozy.cloud',
+          type: 'primary'
+        }]
+      }, {
+        _type: 'io.cozy.contacts',
+        cozy: [{
+          url: 'https://arya.mycozy.cloud',
+          type: 'primary'
+        }]
+      }];
+      var result = countNewRecipients(currentRecipients, addedRecipients);
+      expect(result.contact).toEqual(2);
+      expect(result.group).toEqual(0);
+    });
+    it('should count the new recipients with groups', function () {
+      var result = countNewRecipients(currentRecipients, [].concat(addedRecipients, [{
+        _id: 'f45b16be-7523',
+        _type: 'io.cozy.contacts.groups'
+      }]));
+      expect(result.contact).toEqual(2);
+      expect(result.group).toEqual(1);
+    });
+    it('should return 0 if there are no new recipients', function () {
+      var result = countNewRecipients(currentRecipients, []);
+      expect(result.contact).toEqual(0);
+      expect(result.group).toEqual(0);
+    });
+  });
+  describe('getErrorMessage', function () {
+    var t = function t(key) {
+      return key;
+    }; // Mock translation function
+
+
+    var documentType = 'document';
+    var recipients = [{
+      name: 'John Doe'
+    }];
+    var selectedOption = 'readOnly';
+    it('should return generic error message for non-FetchError', function () {
+      var err = new Error('Some error');
+      var result = getErrorMessage({
+        t: t,
+        err: err,
+        documentType: documentType,
+        recipients: recipients,
+        selectedOption: selectedOption
+      });
+      expect(result).toEqual(["".concat(documentType, ".share.error.generic")]);
+    });
+    it('should return specific error message for FetchError with status 400 and specific detail', function () {
+      var err = {
+        name: 'FetchError',
+        status: 400,
+        message: JSON.stringify({
+          errors: [{
+            detail: 'A group member cannot be added as they are already in'
+          }]
+        })
+      };
+      var result = getErrorMessage({
+        t: t,
+        err: err,
+        documentType: documentType,
+        recipients: recipients,
+        selectedOption: selectedOption
+      });
+      expect(result).toEqual(['Share.errors.groupMemberAlreadyInSharing', {
+        smart_count: recipients.length,
+        groupName: recipients[0].name,
+        sharingRights: 'Share.errors.sharingRights.readWrite',
+        icon: false
+      }]);
+    });
+    it('should return opposite sharingRights for the other group when the group member already in sharing', function () {
+      var err = {
+        name: 'FetchError',
+        status: 400,
+        message: JSON.stringify({
+          errors: [{
+            detail: 'A group member cannot be added as they are already in'
+          }]
+        })
+      };
+      var result = getErrorMessage({
+        t: t,
+        err: err,
+        documentType: documentType,
+        recipients: recipients,
+        selectedOption: 'readWrite'
+      });
+      expect(result).toEqual(['Share.errors.groupMemberAlreadyInSharing', {
+        smart_count: recipients.length,
+        groupName: recipients[0].name,
+        sharingRights: 'Share.errors.sharingRights.readOnly',
+        icon: false
+      }]);
+    });
+    it('should return specific text if there is only one recipient and it is a contact', function () {
+      var err = {
+        name: 'FetchError',
+        status: 400,
+        message: JSON.stringify({
+          errors: [{
+            detail: 'A group member cannot be added as they are already in'
+          }]
+        })
+      };
+      var result = getErrorMessage({
+        t: t,
+        err: err,
+        documentType: documentType,
+        recipients: [{
+          _type: 'io.cozy.contacts',
+          name: {
+            givenName: 'John',
+            familyName: 'Doe'
+          }
+        }],
+        selectedOption: selectedOption
+      });
+      expect(result).toEqual(['Share.errors.contactAlreadyInSharing', {
+        smart_count: recipients.length,
+        contactName: 'John Doe',
+        sharingRights: 'Share.errors.sharingRights.readWrite',
+        icon: false
+      }]);
+    });
+    it('should return generic error message for FetchError with status 400 and different detail', function () {
+      var err = {
+        name: 'FetchError',
+        status: 400,
+        message: JSON.stringify({
+          errors: [{
+            detail: 'Some other detail'
+          }]
+        })
+      };
+      var result = getErrorMessage({
+        t: t,
+        err: err,
+        documentType: documentType,
+        recipients: recipients,
+        selectedOption: selectedOption
+      });
+      expect(result).toEqual(["".concat(documentType, ".share.error.generic")]);
+    });
+  });
+});

package/dist/queries/queries.js

@@ -53,13 +53,12 @@ export var buildReachableContactsQuery = function buildReachableContactsQuery()
     }
   };
 };
-export var buildContactGroupsByIdsQuery = function buildContactGroupsByIdsQuery(ids) {
+export var buildContactGroupsQuery = function buildContactGroupsQuery() {
   return {
-    definition: Q(Group.doctype).getByIds(ids),
+    definition: Q(Group.doctype),
     options: {
-      as: "io.cozy.contacts.groups/by-ids/".concat(ids.join('/')),
-      fetchPolicy: defaultFetchPolicy,
-      enabled: ids.length > 0
+      as: "io.cozy.contacts.groups",
+      fetchPolicy: defaultFetchPolicy
     }
   };
 };