cozy-search 2.11.2 → 2.11.3

package/dist/components/KnowledgeBase/KnowledgeBaseChip.d.ts

@@ -8,6 +8,8 @@ export default KnowledgeBaseChip;
  * open the folder in Drive (new tab) or change the knowledge base through
  * the Drive folder picker (persisted on the assistant immediately). The
  * menu starts with the folder name, which the icon button does not show.
+ * Changing the folder is part of editing assistants, so it follows the
+ * same flag as creating and editing them.
  */
 declare function KnowledgeBaseChip({ dirId, folder, isRoot, isUnavailable, onChangeFolder, variant }: {
     dirId: any;

package/dist/components/KnowledgeBase/KnowledgeBaseChip.js

@@ -15,6 +15,8 @@ var _twakeIcons = require("@linagora/twake-icons");
 
 var _cozyClient = require("cozy-client");
 
+var _cozyFlags = _interopRequireDefault(require("cozy-flags"));
+
 var _ActionsMenu = _interopRequireDefault(require("cozy-ui/transpiled/react/ActionsMenu"));
 
 var _ActionsMenuItem = _interopRequireDefault(require("cozy-ui/transpiled/react/ActionsMenu/ActionsMenuItem"));
@@ -57,6 +59,8 @@ var sourceStyles = {
  * open the folder in Drive (new tab) or change the knowledge base through
  * the Drive folder picker (persisted on the assistant immediately). The
  * menu starts with the folder name, which the icon button does not show.
+ * Changing the folder is part of editing assistants, so it follows the
+ * same flag as creating and editing them.
  */
 
 var KnowledgeBaseChip = function KnowledgeBaseChip(_ref) {
@@ -86,6 +90,9 @@ var KnowledgeBaseChip = function KnowledgeBaseChip(_ref) {
       isPickerOpen = _useState4[0],
       setIsPickerOpen = _useState4[1];
 
+  var canChangeFolder = (0, _cozyFlags.default)('cozy.assistant.create-assistant.enabled');
+  var hasActions = !isUnavailable || canChangeFolder;
+
   var closeMenu = function closeMenu() {
     return setIsMenuOpen(false);
   };
@@ -133,12 +140,12 @@ var KnowledgeBaseChip = function KnowledgeBaseChip(_ref) {
       preserveColor: true
     }),
     label: label,
-    clickable: true,
-    "aria-haspopup": "menu",
-    "aria-expanded": isMenuOpen,
-    onClick: function onClick() {
+    clickable: hasActions,
+    "aria-haspopup": hasActions ? 'menu' : undefined,
+    "aria-expanded": hasActions ? isMenuOpen : undefined,
+    onClick: hasActions ? function () {
       return setIsMenuOpen(true);
-    },
+    } : undefined,
     className: sourceStyles['source-chip'],
     classes: _SourceButton.CHIP_CLASSES
   }))), isMenuOpen && /*#__PURE__*/_react.default.createElement(_ActionsMenu.default, {
@@ -168,7 +175,7 @@ var KnowledgeBaseChip = function KnowledgeBaseChip(_ref) {
     className: "u-mr-half"
   }), /*#__PURE__*/_react.default.createElement(_Typography.default, {
     variant: "body1"
-  }, t('assistant.knowledge_base.open_folder')))), /*#__PURE__*/_react.default.createElement(_ActionsMenuItem.default, {
+  }, t('assistant.knowledge_base.open_folder')))), canChangeFolder && /*#__PURE__*/_react.default.createElement(_ActionsMenuItem.default, {
     onClick: handleChangeFolder
   }, /*#__PURE__*/_react.default.createElement("div", {
     className: "u-flex u-flex-items-center"
@@ -178,7 +185,7 @@ var KnowledgeBaseChip = function KnowledgeBaseChip(_ref) {
     className: "u-mr-half"
   }), /*#__PURE__*/_react.default.createElement(_Typography.default, {
     variant: "body1"
-  }, t('assistant.knowledge_base.change_folder'))))), isPickerOpen && /*#__PURE__*/_react.default.createElement(_FolderPickerDialog.default, {
+  }, t('assistant.knowledge_base.change_folder'))))), canChangeFolder && isPickerOpen && /*#__PURE__*/_react.default.createElement(_FolderPickerDialog.default, {
     open: isPickerOpen,
     onClose: function onClose() {
       return setIsPickerOpen(false);

package/dist/components/KnowledgeBase/KnowledgeBaseChip.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/components/KnowledgeBase/KnowledgeBaseChip.spec.js

@@ -0,0 +1,82 @@
+import { fireEvent, render, screen } from '@testing-library/react';
+import React from 'react';
+import flag from 'cozy-flags';
+import KnowledgeBaseChip from './KnowledgeBaseChip';
+jest.mock('cozy-flags', () => jest.fn());
+jest.mock('cozy-client', () => ({
+    useClient: () => ({
+        getStackClient: () => ({ uri: 'https://alice.cozy.example' }),
+        getInstanceOptions: () => ({ subdomain: 'flat' })
+    }),
+    generateWebLink: ({ hash }) => `https://alice-drive.cozy.example/#${hash}`
+}));
+jest.mock('cozy-intent', () => ({
+    useWebviewIntent: () => null
+}));
+jest.mock('cozy-ui/transpiled/react/providers/Breakpoints', () => {
+    const useBreakpoints = () => ({ isMobile: false });
+    return { __esModule: true, default: useBreakpoints, useBreakpoints };
+});
+jest.mock('twake-i18n', () => ({
+    useI18n: () => ({ t: key => key })
+}));
+jest.mock('./FolderPickerDialog', () => () => (React.createElement("div", { "data-testid": "folder-picker" })));
+const CHANGE_FOLDER = 'assistant.knowledge_base.change_folder';
+const OPEN_FOLDER = 'assistant.knowledge_base.open_folder';
+const setup = props => render(React.createElement(KnowledgeBaseChip, Object.assign({ dirId: "folder-id", folder: { _id: 'folder-id', name: 'Meetings' }, isRoot: false, isUnavailable: false, onChangeFolder: jest.fn() }, props)));
+const mockCreateAssistantFlag = isEnabled => flag.mockImplementation(name => name === 'cozy.assistant.create-assistant.enabled' ? isEnabled : null);
+describe('KnowledgeBaseChip', () => {
+    beforeEach(() => {
+        flag.mockReset();
+    });
+    describe('when creating assistants is enabled', () => {
+        beforeEach(() => {
+            mockCreateAssistantFlag(true);
+        });
+        it('offers to open the folder and to change it', () => {
+            setup();
+            fireEvent.click(screen.getByRole('button', { name: 'Meetings' }));
+            expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null);
+            expect(screen.queryByText(CHANGE_FOLDER)).not.toBe(null);
+        });
+        it('opens the folder picker from the menu', () => {
+            setup();
+            fireEvent.click(screen.getByRole('button', { name: 'Meetings' }));
+            fireEvent.click(screen.getByText(CHANGE_FOLDER));
+            expect(screen.queryByTestId('folder-picker')).not.toBe(null);
+        });
+        it('still offers to change an unavailable folder', () => {
+            setup({ isUnavailable: true });
+            fireEvent.click(screen.getByRole('button', {
+                name: 'assistant.knowledge_base.unavailable'
+            }));
+            expect(screen.queryByText(OPEN_FOLDER)).toBe(null);
+            expect(screen.queryByText(CHANGE_FOLDER)).not.toBe(null);
+        });
+    });
+    describe('when creating assistants is disabled', () => {
+        beforeEach(() => {
+            mockCreateAssistantFlag(false);
+        });
+        it('only offers to open the folder', () => {
+            setup();
+            fireEvent.click(screen.getByRole('button', { name: 'Meetings' }));
+            expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null);
+            expect(screen.queryByText(CHANGE_FOLDER)).toBe(null);
+            expect(screen.queryByTestId('folder-picker')).toBe(null);
+        });
+        it('only offers to open the folder from the icon button', () => {
+            setup({ variant: 'icon' });
+            fireEvent.click(screen.getByRole('button', { name: 'Meetings' }));
+            expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null);
+            expect(screen.queryByText(CHANGE_FOLDER)).toBe(null);
+        });
+        it('does not open an empty menu for an unavailable folder', () => {
+            setup({ isUnavailable: true });
+            expect(screen.queryByRole('button', {
+                name: 'assistant.knowledge_base.unavailable'
+            })).toBe(null);
+            expect(screen.queryByRole('menu')).toBe(null);
+        });
+    });
+});

package/dist/components/KnowledgeBase/KnowledgeBaseChip.spec.jsx

@@ -0,0 +1,122 @@
+import { fireEvent, render, screen } from '@testing-library/react'
+import React from 'react'
+
+import flag from 'cozy-flags'
+
+import KnowledgeBaseChip from './KnowledgeBaseChip'
+
+jest.mock('cozy-flags', () => jest.fn())
+jest.mock('cozy-client', () => ({
+  useClient: () => ({
+    getStackClient: () => ({ uri: 'https://alice.cozy.example' }),
+    getInstanceOptions: () => ({ subdomain: 'flat' })
+  }),
+  generateWebLink: ({ hash }) => `https://alice-drive.cozy.example/#${hash}`
+}))
+jest.mock('cozy-intent', () => ({
+  useWebviewIntent: () => null
+}))
+jest.mock('cozy-ui/transpiled/react/providers/Breakpoints', () => {
+  const useBreakpoints = () => ({ isMobile: false })
+  return { __esModule: true, default: useBreakpoints, useBreakpoints }
+})
+jest.mock('twake-i18n', () => ({
+  useI18n: () => ({ t: key => key })
+}))
+jest.mock('./FolderPickerDialog', () => () => (
+  <div data-testid="folder-picker" />
+))
+
+const CHANGE_FOLDER = 'assistant.knowledge_base.change_folder'
+const OPEN_FOLDER = 'assistant.knowledge_base.open_folder'
+
+const setup = props =>
+  render(
+    <KnowledgeBaseChip
+      dirId="folder-id"
+      folder={{ _id: 'folder-id', name: 'Meetings' }}
+      isRoot={false}
+      isUnavailable={false}
+      onChangeFolder={jest.fn()}
+      {...props}
+    />
+  )
+
+const mockCreateAssistantFlag = isEnabled =>
+  flag.mockImplementation(name =>
+    name === 'cozy.assistant.create-assistant.enabled' ? isEnabled : null
+  )
+
+describe('KnowledgeBaseChip', () => {
+  beforeEach(() => {
+    flag.mockReset()
+  })
+
+  describe('when creating assistants is enabled', () => {
+    beforeEach(() => {
+      mockCreateAssistantFlag(true)
+    })
+
+    it('offers to open the folder and to change it', () => {
+      setup()
+      fireEvent.click(screen.getByRole('button', { name: 'Meetings' }))
+
+      expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null)
+      expect(screen.queryByText(CHANGE_FOLDER)).not.toBe(null)
+    })
+
+    it('opens the folder picker from the menu', () => {
+      setup()
+      fireEvent.click(screen.getByRole('button', { name: 'Meetings' }))
+      fireEvent.click(screen.getByText(CHANGE_FOLDER))
+
+      expect(screen.queryByTestId('folder-picker')).not.toBe(null)
+    })
+
+    it('still offers to change an unavailable folder', () => {
+      setup({ isUnavailable: true })
+      fireEvent.click(
+        screen.getByRole('button', {
+          name: 'assistant.knowledge_base.unavailable'
+        })
+      )
+
+      expect(screen.queryByText(OPEN_FOLDER)).toBe(null)
+      expect(screen.queryByText(CHANGE_FOLDER)).not.toBe(null)
+    })
+  })
+
+  describe('when creating assistants is disabled', () => {
+    beforeEach(() => {
+      mockCreateAssistantFlag(false)
+    })
+
+    it('only offers to open the folder', () => {
+      setup()
+      fireEvent.click(screen.getByRole('button', { name: 'Meetings' }))
+
+      expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null)
+      expect(screen.queryByText(CHANGE_FOLDER)).toBe(null)
+      expect(screen.queryByTestId('folder-picker')).toBe(null)
+    })
+
+    it('only offers to open the folder from the icon button', () => {
+      setup({ variant: 'icon' })
+      fireEvent.click(screen.getByRole('button', { name: 'Meetings' }))
+
+      expect(screen.queryByText(OPEN_FOLDER)).not.toBe(null)
+      expect(screen.queryByText(CHANGE_FOLDER)).toBe(null)
+    })
+
+    it('does not open an empty menu for an unavailable folder', () => {
+      setup({ isUnavailable: true })
+
+      expect(
+        screen.queryByRole('button', {
+          name: 'assistant.knowledge_base.unavailable'
+        })
+      ).toBe(null)
+      expect(screen.queryByRole('menu')).toBe(null)
+    })
+  })
+})

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "cozy-search",
   "description": "UI components about search bar and IA assistant",
-  "version": "2.11.2",
+  "version": "2.11.3",
   "author": {
     "name": "Cozy Cloud",
     "url": "https://github.com/cozy"
@@ -96,5 +96,5 @@
     "lint": "cd .. && yarn eslint --ext js,jsx,ts packages/cozy-search"
   },
   "types": "dist/index.d.ts",
-  "gitHead": "a9f046c1c02c5ffc85bf5c46da1acb41407dc584"
+  "gitHead": "cf7659dd90d8e1e970e79dd421f1620bd1f6a84f"
 }