cozy-harvest-lib 9.26.13 → 9.26.14

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.26.14](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@9.26.13...cozy-harvest-lib@9.26.14) (2022-09-19)
+
+
+### Bug Fixes
+
+* Deal with empty and malformed encrypted values ([b4a6406](https://github.com/cozy/cozy-libs/commit/b4a6406be80cec7d3b7246dc42c19a419e442224))
+
+
+
+
+
 ## [9.26.13](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@9.26.12...cozy-harvest-lib@9.26.13) (2022-09-15)
 
 

package/dist/services/utils.js

@@ -1,6 +1,6 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
-import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
+import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
 
 function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
 
@@ -13,21 +13,59 @@ import Polyglot from 'node-polyglot';
 import { Q } from 'cozy-client';
 import SymmetricCryptoKey from 'cozy-keys-lib/transpiled/SymmetricCryptoKey';
 import EncryptionType from 'cozy-keys-lib/transpiled/EncryptionType';
-export var decryptString = function decryptString(encryptedString, vaultClient, orgKey) {
-  var _encryptedString$spli = encryptedString.split('|'),
-      _encryptedString$spli2 = _slicedToArray(_encryptedString$spli, 3),
-      encTypeAndIv = _encryptedString$spli2[0],
-      data = _encryptedString$spli2[1],
-      mac = _encryptedString$spli2[2];
-
-  var _encTypeAndIv$split = encTypeAndIv.split('.'),
-      _encTypeAndIv$split2 = _slicedToArray(_encTypeAndIv$split, 2),
-      encTypeString = _encTypeAndIv$split2[0],
-      iv = _encTypeAndIv$split2[1];
-
-  var encType = parseInt(encTypeString, 10);
-  return vaultClient.cryptoService.aesDecryptToUtf8(encType, data, iv, mac, orgKey);
-};
+import logger from './logger';
+/**
+ * Decrypt the given string with the organization key
+ *
+ * @param {string} encryptedString - The encrypted string
+ * @param {object} vaultClient - The vault client
+ * @param {ArrayBuffer} orgKey - The organization key
+ * @returns {Promise<string>} The decrypted string
+ */
+
+export var decryptString = /*#__PURE__*/function () {
+  var _ref = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(encryptedString, vaultClient, orgKey) {
+    var _encryptedString$spli, _encryptedString$spli2, encTypeAndIv, data, mac, _encTypeAndIv$split, _encTypeAndIv$split2, encTypeString, iv, encType;
+
+    return _regeneratorRuntime.wrap(function _callee$(_context) {
+      while (1) {
+        switch (_context.prev = _context.next) {
+          case 0:
+            if (encryptedString) {
+              _context.next = 2;
+              break;
+            }
+
+            return _context.abrupt("return", '');
+
+          case 2:
+            _encryptedString$spli = encryptedString.split('|'), _encryptedString$spli2 = _slicedToArray(_encryptedString$spli, 3), encTypeAndIv = _encryptedString$spli2[0], data = _encryptedString$spli2[1], mac = _encryptedString$spli2[2];
+
+            if (encTypeAndIv) {
+              _context.next = 6;
+              break;
+            }
+
+            logger.error('Encrypted string is malformed');
+            throw new Error('DECRYPT_FAILED');
+
+          case 6:
+            _encTypeAndIv$split = encTypeAndIv.split('.'), _encTypeAndIv$split2 = _slicedToArray(_encTypeAndIv$split, 2), encTypeString = _encTypeAndIv$split2[0], iv = _encTypeAndIv$split2[1];
+            encType = parseInt(encTypeString, 10);
+            return _context.abrupt("return", vaultClient.cryptoService.aesDecryptToUtf8(encType, data, iv, mac, orgKey));
+
+          case 9:
+          case "end":
+            return _context.stop();
+        }
+      }
+    }, _callee);
+  }));
+
+  return function decryptString(_x, _x2, _x3) {
+    return _ref.apply(this, arguments);
+  };
+}();
 export var getT = function getT() {
   var supportedLocales = ['en', 'fr', 'es'];
   var locale = supportedLocales.find(function (l) {
@@ -41,41 +79,41 @@ export var getT = function getT() {
   return polyglot.t.bind(polyglot);
 };
 export var getOrganizationKey = /*#__PURE__*/function () {
-  var _ref = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(cozyClient, vaultClient) {
+  var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee2(cozyClient, vaultClient) {
     var cozyKeys, orgKeyEncType, orgKey;
-    return _regeneratorRuntime.wrap(function _callee$(_context) {
+    return _regeneratorRuntime.wrap(function _callee2$(_context2) {
       while (1) {
-        switch (_context.prev = _context.next) {
+        switch (_context2.prev = _context2.next) {
           case 0:
-            _context.next = 2;
+            _context2.next = 2;
             return cozyClient.getStackClient().fetchJSON('GET', '/bitwarden/organizations/cozy');
 
           case 2:
-            cozyKeys = _context.sent;
+            cozyKeys = _context2.sent;
             orgKeyEncType = EncryptionType.AesCbc256_HmacSha256_B64;
             orgKey = new SymmetricCryptoKey(vaultClient.Utils.fromB64ToArray(cozyKeys.organizationKey), orgKeyEncType);
-            return _context.abrupt("return", orgKey);
+            return _context2.abrupt("return", orgKey);
 
           case 6:
           case "end":
-            return _context.stop();
+            return _context2.stop();
         }
       }
-    }, _callee);
+    }, _callee2);
   }));
 
-  return function getOrganizationKey(_x, _x2) {
-    return _ref.apply(this, arguments);
+  return function getOrganizationKey(_x4, _x5) {
+    return _ref2.apply(this, arguments);
   };
 }();
 export var fetchAccountsForCipherId = /*#__PURE__*/function () {
-  var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee2(cozyClient, cipherId) {
+  var _ref3 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3(cozyClient, cipherId) {
     var accounts;
-    return _regeneratorRuntime.wrap(function _callee2$(_context2) {
+    return _regeneratorRuntime.wrap(function _callee3$(_context3) {
       while (1) {
-        switch (_context2.prev = _context2.next) {
+        switch (_context3.prev = _context3.next) {
           case 0:
-            _context2.next = 2;
+            _context3.next = 2;
             return cozyClient.query(Q('io.cozy.accounts').where({
               'relationships.vaultCipher.data': {
                 _id: cipherId,
@@ -84,59 +122,59 @@ export var fetchAccountsForCipherId = /*#__PURE__*/function () {
             }).indexFields(['relationships.vaultCipher.data._id']));
 
           case 2:
-            accounts = _context2.sent;
-            return _context2.abrupt("return", accounts);
+            accounts = _context3.sent;
+            return _context3.abrupt("return", accounts);
 
           case 4:
           case "end":
-            return _context2.stop();
+            return _context3.stop();
         }
       }
-    }, _callee2);
+    }, _callee3);
   }));
 
-  return function fetchAccountsForCipherId(_x3, _x4) {
-    return _ref2.apply(this, arguments);
+  return function fetchAccountsForCipherId(_x6, _x7) {
+    return _ref3.apply(this, arguments);
   };
 }();
 export var fetchKonnectorFromAccount = /*#__PURE__*/function () {
-  var _ref3 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3(cozyClient, account) {
+  var _ref4 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4(cozyClient, account) {
     var slug, konnector;
-    return _regeneratorRuntime.wrap(function _callee3$(_context3) {
+    return _regeneratorRuntime.wrap(function _callee4$(_context4) {
       while (1) {
-        switch (_context3.prev = _context3.next) {
+        switch (_context4.prev = _context4.next) {
           case 0:
             slug = account.account_type;
-            _context3.next = 3;
+            _context4.next = 3;
             return cozyClient.query(Q('io.cozy.konnectors').getById("io.cozy.konnectors/".concat(slug)));
 
           case 3:
-            konnector = _context3.sent;
-            return _context3.abrupt("return", konnector.data ? _objectSpread({
+            konnector = _context4.sent;
+            return _context4.abrupt("return", konnector.data ? _objectSpread({
               _id: konnector.data._id,
               _type: konnector.data.type
             }, konnector.data.attributes) : null);
 
           case 5:
           case "end":
-            return _context3.stop();
+            return _context4.stop();
         }
       }
-    }, _callee3);
+    }, _callee4);
   }));
 
-  return function fetchKonnectorFromAccount(_x5, _x6) {
-    return _ref3.apply(this, arguments);
+  return function fetchKonnectorFromAccount(_x8, _x9) {
+    return _ref4.apply(this, arguments);
   };
 }();
 export var fetchTriggersFromAccount = /*#__PURE__*/function () {
-  var _ref4 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4(cozyClient, account) {
+  var _ref5 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee5(cozyClient, account) {
     var triggers;
-    return _regeneratorRuntime.wrap(function _callee4$(_context4) {
+    return _regeneratorRuntime.wrap(function _callee5$(_context5) {
       while (1) {
-        switch (_context4.prev = _context4.next) {
+        switch (_context5.prev = _context5.next) {
           case 0:
-            _context4.next = 2;
+            _context5.next = 2;
             return cozyClient.queryAll(Q('io.cozy.triggers').where({
               worker: {
                 $in: ['konnector', 'client']
@@ -145,28 +183,28 @@ export var fetchTriggersFromAccount = /*#__PURE__*/function () {
             }));
 
           case 2:
-            triggers = _context4.sent;
-            return _context4.abrupt("return", triggers);
+            triggers = _context5.sent;
+            return _context5.abrupt("return", triggers);
 
           case 4:
           case "end":
-            return _context4.stop();
+            return _context5.stop();
         }
       }
-    }, _callee4);
+    }, _callee5);
   }));
 
-  return function fetchTriggersFromAccount(_x7, _x8) {
-    return _ref4.apply(this, arguments);
+  return function fetchTriggersFromAccount(_x10, _x11) {
+    return _ref5.apply(this, arguments);
   };
 }();
 export var updateAccountsAuth = /*#__PURE__*/function () {
-  var _ref5 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee5(cozyClient, accounts, authData) {
-    return _regeneratorRuntime.wrap(function _callee5$(_context5) {
+  var _ref6 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6(cozyClient, accounts, authData) {
+    return _regeneratorRuntime.wrap(function _callee6$(_context6) {
       while (1) {
-        switch (_context5.prev = _context5.next) {
+        switch (_context6.prev = _context6.next) {
           case 0:
-            _context5.next = 2;
+            _context6.next = 2;
             return Promise.all(accounts.map(function (account) {
               merge(account.auth, authData);
               unset(account, 'auth.credentials_encrypted');
@@ -180,24 +218,24 @@ export var updateAccountsAuth = /*#__PURE__*/function () {
 
           case 2:
           case "end":
-            return _context5.stop();
+            return _context6.stop();
         }
       }
-    }, _callee5);
+    }, _callee6);
   }));
 
-  return function updateAccountsAuth(_x9, _x10, _x11) {
-    return _ref5.apply(this, arguments);
+  return function updateAccountsAuth(_x12, _x13, _x14) {
+    return _ref6.apply(this, arguments);
   };
 }();
 export var fetchLoginFailedTriggersForAccountsIds = /*#__PURE__*/function () {
-  var _ref6 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6(cozyClient, accountsIds) {
+  var _ref7 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7(cozyClient, accountsIds) {
     var triggers, triggersIds, triggersStates, triggersToRetry;
-    return _regeneratorRuntime.wrap(function _callee6$(_context6) {
+    return _regeneratorRuntime.wrap(function _callee7$(_context7) {
       while (1) {
-        switch (_context6.prev = _context6.next) {
+        switch (_context7.prev = _context7.next) {
           case 0:
-            _context6.next = 2;
+            _context7.next = 2;
             return cozyClient.queryAll(Q('io.cozy.triggers').where({
               worker: {
                 $in: ['konnector', 'client']
@@ -208,17 +246,17 @@ export var fetchLoginFailedTriggersForAccountsIds = /*#__PURE__*/function () {
             }));
 
           case 2:
-            triggers = _context6.sent;
+            triggers = _context7.sent;
             triggersIds = triggers.map(function (trigger) {
               return trigger._id;
             });
-            _context6.next = 6;
+            _context7.next = 6;
             return Promise.all(triggersIds.map(function (triggerId) {
               return cozyClient.getStackClient().fetchJSON('GET', "/jobs/triggers/".concat(triggerId, "/state"));
             }));
 
           case 6:
-            triggersStates = _context6.sent;
+            triggersStates = _context7.sent;
             triggersToRetry = triggersStates.filter(function (state) {
               var _state$data$attribute = state.data.attributes,
                   status = _state$data$attribute.status,
@@ -227,40 +265,40 @@ export var fetchLoginFailedTriggersForAccountsIds = /*#__PURE__*/function () {
             }).map(function (state) {
               return state.data.id;
             });
-            return _context6.abrupt("return", triggersToRetry);
+            return _context7.abrupt("return", triggersToRetry);
 
           case 9:
           case "end":
-            return _context6.stop();
+            return _context7.stop();
         }
       }
-    }, _callee6);
+    }, _callee7);
   }));
 
-  return function fetchLoginFailedTriggersForAccountsIds(_x12, _x13) {
-    return _ref6.apply(this, arguments);
+  return function fetchLoginFailedTriggersForAccountsIds(_x15, _x16) {
+    return _ref7.apply(this, arguments);
   };
 }();
 export var launchTriggers = /*#__PURE__*/function () {
-  var _ref7 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7(cozyClient, triggersIds) {
-    return _regeneratorRuntime.wrap(function _callee7$(_context7) {
+  var _ref8 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee8(cozyClient, triggersIds) {
+    return _regeneratorRuntime.wrap(function _callee8$(_context8) {
       while (1) {
-        switch (_context7.prev = _context7.next) {
+        switch (_context8.prev = _context8.next) {
           case 0:
-            _context7.next = 2;
+            _context8.next = 2;
             return Promise.all(triggersIds.map(function (triggerId) {
               return cozyClient.getStackClient().fetchJSON('POST', "/jobs/triggers/".concat(triggerId, "/launch"));
             }));
 
           case 2:
           case "end":
-            return _context7.stop();
+            return _context8.stop();
         }
       }
-    }, _callee7);
+    }, _callee8);
   }));
 
-  return function launchTriggers(_x14, _x15) {
-    return _ref7.apply(this, arguments);
+  return function launchTriggers(_x17, _x18) {
+    return _ref8.apply(this, arguments);
   };
 }();

package/dist/services/utils.spec.js

@@ -76,23 +76,58 @@ describe('decryptString', function () {
       }
     }, _callee);
   })));
+  it('should return empty if the encrypted string is empty', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee2() {
+    var res;
+    return _regeneratorRuntime.wrap(function _callee2$(_context2) {
+      while (1) {
+        switch (_context2.prev = _context2.next) {
+          case 0:
+            _context2.next = 2;
+            return decryptString('', mockVaultClient, new SymmetricCryptoKey('123', 2));
+
+          case 2:
+            res = _context2.sent;
+            expect(res).toEqual('');
+
+          case 4:
+          case "end":
+            return _context2.stop();
+        }
+      }
+    }, _callee2);
+  })));
+  it('should throw if the encrypted string is empty', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3() {
+    return _regeneratorRuntime.wrap(function _callee3$(_context3) {
+      while (1) {
+        switch (_context3.prev = _context3.next) {
+          case 0:
+            _context3.next = 2;
+            return expect(decryptString('|', mockVaultClient, new SymmetricCryptoKey('123', 2))).rejects.toThrowError();
+
+          case 2:
+          case "end":
+            return _context3.stop();
+        }
+      }
+    }, _callee3);
+  })));
 });
 describe('getOrganizationKey', function () {
-  it('should create a SymmetricCryptoKey with the params fetched from the stack', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee2() {
+  it('should create a SymmetricCryptoKey with the params fetched from the stack', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4() {
     var fetchedOrganizationKey, orgKey;
-    return _regeneratorRuntime.wrap(function _callee2$(_context2) {
+    return _regeneratorRuntime.wrap(function _callee4$(_context4) {
       while (1) {
-        switch (_context2.prev = _context2.next) {
+        switch (_context4.prev = _context4.next) {
           case 0:
             fetchedOrganizationKey = '123';
             mockCozyClient.fetchJSON.mockResolvedValue({
               organizationKey: fetchedOrganizationKey
             });
-            _context2.next = 4;
+            _context4.next = 4;
             return getOrganizationKey(mockCozyClient, mockVaultClient);
 
           case 4:
-            orgKey = _context2.sent;
+            orgKey = _context4.sent;
             expect(mockCozyClient.fetchJSON).toHaveBeenCalledWith('GET', '/bitwarden/organizations/cozy');
             expect(orgKey).toEqual({
               encType: EncryptionType.AesCbc256_HmacSha256_B64,
@@ -101,19 +136,19 @@ describe('getOrganizationKey', function () {
 
           case 7:
           case "end":
-            return _context2.stop();
+            return _context4.stop();
         }
       }
-    }, _callee2);
+    }, _callee4);
   })));
 });
 describe('fetchAccountsForCipherId', function () {
-  it('should fetch accounts with a relationship with the given cipher id', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3() {
-    return _regeneratorRuntime.wrap(function _callee3$(_context3) {
+  it('should fetch accounts with a relationship with the given cipher id', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee5() {
+    return _regeneratorRuntime.wrap(function _callee5$(_context5) {
       while (1) {
-        switch (_context3.prev = _context3.next) {
+        switch (_context5.prev = _context5.next) {
           case 0:
-            _context3.next = 2;
+            _context5.next = 2;
             return fetchAccountsForCipherId(mockCozyClient, '123-456');
 
           case 2:
@@ -130,18 +165,18 @@ describe('fetchAccountsForCipherId', function () {
 
           case 3:
           case "end":
-            return _context3.stop();
+            return _context5.stop();
         }
       }
-    }, _callee3);
+    }, _callee5);
   })));
 });
 describe('updateAccountsAuth', function () {
-  it('should update all accounts with the given credentials', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4() {
+  it('should update all accounts with the given credentials', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6() {
     var accounts;
-    return _regeneratorRuntime.wrap(function _callee4$(_context4) {
+    return _regeneratorRuntime.wrap(function _callee6$(_context6) {
       while (1) {
-        switch (_context4.prev = _context4.next) {
+        switch (_context6.prev = _context6.next) {
           case 0:
             accounts = [{
               auth: {
@@ -156,7 +191,7 @@ describe('updateAccountsAuth', function () {
                 credentials_encrypted: 'toberemoved'
               }
             }];
-            _context4.next = 3;
+            _context6.next = 3;
             return updateAccountsAuth(mockCozyClient, accounts, {
               login: 'newLogin',
               password: 'newPassword'
@@ -174,18 +209,18 @@ describe('updateAccountsAuth', function () {
 
           case 5:
           case "end":
-            return _context4.stop();
+            return _context6.stop();
         }
       }
-    }, _callee4);
+    }, _callee6);
   })));
 });
 describe('fetchLoginFailedTriggersForAccountsIds', function () {
-  it('should fetch triggers that are in a LOGIN_FAILED errored state for given accounts ids', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee5() {
+  it('should fetch triggers that are in a LOGIN_FAILED errored state for given accounts ids', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee7() {
     var i, accountsIds, triggers;
-    return _regeneratorRuntime.wrap(function _callee5$(_context5) {
+    return _regeneratorRuntime.wrap(function _callee7$(_context7) {
       while (1) {
-        switch (_context5.prev = _context5.next) {
+        switch (_context7.prev = _context7.next) {
           case 0:
             mockCozyClient.queryAll.mockResolvedValue([{
               _id: 'tri1'
@@ -209,11 +244,11 @@ describe('fetchLoginFailedTriggersForAccountsIds', function () {
               return triggerState;
             });
             accountsIds = ['acc1', 'acc2'];
-            _context5.next = 6;
+            _context7.next = 6;
             return fetchLoginFailedTriggersForAccountsIds(mockCozyClient, accountsIds);
 
           case 6:
-            triggers = _context5.sent;
+            triggers = _context7.sent;
             expect(mockCozyClient.queryAll).toHaveBeenCalledWith(expect.objectContaining({
               selector: {
                 'message.account': {
@@ -228,21 +263,21 @@ describe('fetchLoginFailedTriggersForAccountsIds', function () {
 
           case 9:
           case "end":
-            return _context5.stop();
+            return _context7.stop();
         }
       }
-    }, _callee5);
+    }, _callee7);
   })));
 });
 describe('launchTriggers', function () {
-  it('should launch all triggers which ids are passed in arguments', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee6() {
+  it('should launch all triggers which ids are passed in arguments', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee8() {
     var triggersIds;
-    return _regeneratorRuntime.wrap(function _callee6$(_context6) {
+    return _regeneratorRuntime.wrap(function _callee8$(_context8) {
       while (1) {
-        switch (_context6.prev = _context6.next) {
+        switch (_context8.prev = _context8.next) {
           case 0:
             triggersIds = ['tri1', 'tri2'];
-            _context6.next = 3;
+            _context8.next = 3;
             return launchTriggers(mockCozyClient, triggersIds);
 
           case 3:
@@ -252,9 +287,9 @@ describe('launchTriggers', function () {
 
           case 6:
           case "end":
-            return _context6.stop();
+            return _context8.stop();
         }
       }
-    }, _callee6);
+    }, _callee8);
   })));
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-harvest-lib",
-  "version": "9.26.13",
+  "version": "9.26.14",
   "description": "Provides logic, modules and components for Cozy's harvest applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -90,5 +90,5 @@
     "react-router-dom": "^5.0.1"
   },
   "sideEffects": false,
-  "gitHead": "f7d4761ad1b80385ba4977c193ef8b7177413ca8"
+  "gitHead": "16f7bf24064d091e969cebb24cf04c19c4738e93"
 }

package/src/services/utils.js

@@ -5,9 +5,25 @@ import Polyglot from 'node-polyglot'
 import { Q } from 'cozy-client'
 import SymmetricCryptoKey from 'cozy-keys-lib/transpiled/SymmetricCryptoKey'
 import EncryptionType from 'cozy-keys-lib/transpiled/EncryptionType'
-
-export const decryptString = (encryptedString, vaultClient, orgKey) => {
+import logger from './logger'
+
+/**
+ * Decrypt the given string with the organization key
+ *
+ * @param {string} encryptedString - The encrypted string
+ * @param {object} vaultClient - The vault client
+ * @param {ArrayBuffer} orgKey - The organization key
+ * @returns {Promise<string>} The decrypted string
+ */
+export const decryptString = async (encryptedString, vaultClient, orgKey) => {
+  if (!encryptedString) {
+    return ''
+  }
   const [encTypeAndIv, data, mac] = encryptedString.split('|')
+  if (!encTypeAndIv) {
+    logger.error('Encrypted string is malformed')
+    throw new Error('DECRYPT_FAILED')
+  }
   const [encTypeString, iv] = encTypeAndIv.split('.')
   const encType = parseInt(encTypeString, 10)
 

package/src/services/utils.spec.js

@@ -63,6 +63,21 @@ describe('decryptString', () => {
       orgKey
     )
   })
+
+  it('should return empty if the encrypted string is empty', async () => {
+    const res = await decryptString(
+      '',
+      mockVaultClient,
+      new SymmetricCryptoKey('123', 2)
+    )
+    expect(res).toEqual('')
+  })
+
+  it('should throw if the encrypted string is empty', async () => {
+    await expect(
+      decryptString('|', mockVaultClient, new SymmetricCryptoKey('123', 2))
+    ).rejects.toThrowError()
+  })
 })
 
 describe('getOrganizationKey', () => {