cozy-harvest-lib 29.0.0 → 29.1.0

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [29.1.0](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@29.0.0...cozy-harvest-lib@29.1.0) (2024-09-03)
+
+### Features
+
+- Remove `harvest.inappconnectors.enabled` flag ([d145900](https://github.com/cozy/cozy-libs/commit/d145900f2ce80ed4124a52917a3aa37c7ade4043))
+
 # [29.0.0](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@28.0.0...cozy-harvest-lib@29.0.0) (2024-08-29)
 
 ### Bug Fixes

package/dist/components/AccountForm/__snapshots__/index.spec.jsx.snap

@@ -28,6 +28,7 @@ exports[`AccountForm should not render error 1`] = `
       t={[Function]}
     />
     <ForwardRef
+      busy={false}
       className="u-mt-2 u-mb-1-half"
       data-testid="submit-btn"
       disabled={false}
@@ -67,6 +68,7 @@ exports[`AccountForm should render 1`] = `
       t={[Function]}
     />
     <ForwardRef
+      busy={false}
       className="u-mt-2 u-mb-1-half"
       data-testid="submit-btn"
       disabled={true}
@@ -123,6 +125,7 @@ exports[`AccountForm should render error 1`] = `
       t={[Function]}
     />
     <ForwardRef
+      busy={false}
       className="u-mt-2 u-mb-1-half"
       data-testid="submit-btn"
       disabled={false}
@@ -150,7 +153,7 @@ exports[`AccountForm should render normally when client side konnector with laun
     <ConnectCard
       buttonProps={
         Object {
-          "busy": undefined,
+          "busy": false,
           "data-testid": "submit-btn",
           "disabled": false,
           "label": "Connect",

package/dist/components/AccountForm/index.js

@@ -20,7 +20,6 @@ import PropTypes from 'prop-types';
 import React, { PureComponent } from 'react';
 import { Form } from 'react-final-form';
 import { isMobile } from 'cozy-device-helper';
-import flag from 'cozy-flags';
 import Button from 'cozy-ui/transpiled/react/Buttons';
 import { Dialog } from 'cozy-ui/transpiled/react/CozyDialogs';
 import Icon from 'cozy-ui/transpiled/react/Icon';
@@ -340,7 +339,7 @@ export var AccountForm = /*#__PURE__*/function (_PureComponent) {
               initialValues: values,
               inputRefByName: _this3.inputRefByName,
               t: t
-            }), flag('harvest.inappconnectors.enabled') && !konnector.clientSide && konnector.vendor_link && /*#__PURE__*/React.createElement(Link, {
+            }), !konnector.clientSide && konnector.vendor_link && /*#__PURE__*/React.createElement(Link, {
               className: "u-mt-1",
               variant: "body1",
               component: "button",
@@ -351,7 +350,7 @@ export var AccountForm = /*#__PURE__*/function (_PureComponent) {
                 name: konnector.name
               }),
               buttonProps: _defineProperty({
-                busy: submitting && !flag('harvest.inappconnectors.enabled'),
+                busy: false,
                 disabled: submitting || !_this3.isSubmittable({
                   error: error,
                   valid: valid
@@ -362,7 +361,7 @@ export var AccountForm = /*#__PURE__*/function (_PureComponent) {
                 }
               }, 'data-testid', 'submit-btn')
             }) : /*#__PURE__*/React.createElement(Button, {
-              busy: submitting && !flag('harvest.inappconnectors.enabled'),
+              busy: false,
               className: "u-mt-2 u-mb-1-half",
               disabled: submitting || !_this3.isSubmittable({
                 error: error,

package/dist/components/AccountModal.js

@@ -16,19 +16,15 @@ import flow from 'lodash/flow';
 import get from 'lodash/get';
 import PropTypes from 'prop-types';
 import React, { Component } from 'react';
-import { models, withClient } from 'cozy-client';
+import { withClient } from 'cozy-client';
 import { triggers as triggersModel } from 'cozy-client/dist/models/trigger';
-import flag from 'cozy-flags';
 import Button from 'cozy-ui/transpiled/react/Buttons';
 import DialogContent from 'cozy-ui/transpiled/react/DialogContent';
 import Spinner from 'cozy-ui/transpiled/react/Spinner';
-import Typography from 'cozy-ui/transpiled/react/Typography';
 import Infos from 'cozy-ui/transpiled/react/deprecated/Infos';
 import withBreakpoints from 'cozy-ui/transpiled/react/helpers/withBreakpoints';
 import AccountModalHeader from './AccountModalWithoutTabs/AccountModalHeader';
-import AccountSelectBox from './AccountSelectBox/AccountSelectBox';
 import KonnectorAccountWrapper from './KonnectorConfiguration/KonnectorAccountWrapper';
-import KonnectorModalHeader from './KonnectorModalHeader';
 import { withMountPointProps } from './MountPointContext';
 import withLocales from './hoc/withLocales';
 import { fetchAccount as _fetchAccount } from '../connections/accounts';
@@ -250,7 +246,6 @@ export var AccountModal = /*#__PURE__*/function (_Component) {
           onDismiss = _this$props2.onDismiss,
           accountsAndTriggers = _this$props2.accountsAndTriggers,
           t = _this$props2.t,
-          pushHistory = _this$props2.pushHistory,
           replaceHistory = _this$props2.replaceHistory,
           initialActiveTab = _this$props2.initialActiveTab,
           isMobile = _this$props2.breakpoints.isMobile,
@@ -264,24 +259,12 @@ export var AccountModal = /*#__PURE__*/function (_Component) {
           account = _this$state.account,
           fetching = _this$state.fetching,
           error = _this$state.error;
-      return /*#__PURE__*/React.createElement(React.Fragment, null, flag('harvest.inappconnectors.enabled') ? /*#__PURE__*/React.createElement(AccountModalHeader, {
+      return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(AccountModalHeader, {
         konnector: konnector,
         account: account,
         accountsAndTriggers: accountsAndTriggers,
         showAccountSelection: showAccountSelection
-      }) : /*#__PURE__*/React.createElement(KonnectorModalHeader, {
-        konnector: konnector
-      }, showAccountSelection ? /*#__PURE__*/React.createElement(AccountSelectBox, {
-        loading: !account,
-        selectedAccount: account,
-        accountsAndTriggers: accountsAndTriggers,
-        onChange: function onChange(option) {
-          pushHistory("/accounts/".concat(option.account._id));
-        },
-        onCreate: function onCreate() {
-          pushHistory('/new');
-        }
-      }) : /*#__PURE__*/React.createElement(Typography, null, models.account.getAccountName(account))), (error || fetching) && /*#__PURE__*/React.createElement(DialogContent, {
+      }), (error || fetching) && /*#__PURE__*/React.createElement(DialogContent, {
         className: "u-pb-2"
       }, error && /*#__PURE__*/React.createElement(Infos, {
         actionButton: /*#__PURE__*/React.createElement(Button, {

package/dist/components/AccountModal.spec.js

@@ -37,7 +37,6 @@ var accountsAndTriggersMock = [{
 var accountIdMock = '123';
 describe('AccountModal', function () {
   var setup = function setup() {
-    var mockHistoryPush = jest.fn();
     var mockHistoryReplace = jest.fn();
     var component = shallow( /*#__PURE__*/React.createElement(AccountModal, {
       konnector: {},
@@ -46,7 +45,6 @@ describe('AccountModal', function () {
       },
       accountId: accountIdMock,
       accountsAndTriggers: accountsAndTriggersMock,
-      pushHistory: mockHistoryPush,
       replaceHistory: mockHistoryReplace,
       breakpoints: {
         isMobile: true
@@ -55,7 +53,6 @@ describe('AccountModal', function () {
     }));
     return {
       component: component,
-      mockHistoryPush: mockHistoryPush,
       mockHistoryReplace: mockHistoryReplace
     };
   };
@@ -75,8 +72,7 @@ describe('AccountModal', function () {
     var _setup2 = setup({
       fetchAccount: fetchAccount
     }),
-        component = _setup2.component,
-        mockHistoryPush = _setup2.mockHistoryPush;
+        component = _setup2.component;
 
     it('should display the AccountSelect & Content if an account is there and we can change the selectedAccount', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee() {
       return _regeneratorRuntime.wrap(function _callee$(_context) {
@@ -110,34 +106,5 @@ describe('AccountModal', function () {
         }
       }, _callee);
     })));
-    it('should redirect to the correct locations', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee2() {
-      var accountTabs;
-      return _regeneratorRuntime.wrap(function _callee2$(_context2) {
-        while (1) {
-          switch (_context2.prev = _context2.next) {
-            case 0:
-              _context2.next = 2;
-              return component.instance().componentDidMount();
-
-            case 2:
-              component.find('AccountSelectBox').prop('onChange')({
-                account: {
-                  _id: '123'
-                }
-              });
-              expect(mockHistoryPush).toHaveBeenCalledWith('/accounts/123');
-              component.find('AccountSelectBox').prop('onCreate')();
-              expect(mockHistoryPush).toHaveBeenCalledWith('/new');
-              accountTabs = component.find('KonnectorAccountWrapper');
-              accountTabs.prop('addAccount')();
-              expect(mockHistoryPush).toHaveBeenCalledWith('/new');
-
-            case 9:
-            case "end":
-              return _context2.stop();
-          }
-        }
-      }, _callee2);
-    })));
   });
 });

package/dist/components/EditAccountModal.js

@@ -17,7 +17,6 @@ import PropTypes from 'prop-types';
 import React, { Component } from 'react';
 import { withClient } from 'cozy-client';
 import { triggers as triggersModel } from 'cozy-client/dist/models/trigger';
-import flag from 'cozy-flags';
 import { Dialog } from 'cozy-ui/transpiled/react/CozyDialogs';
 import Spinner from 'cozy-ui/transpiled/react/Spinner';
 import { withMountPointProps } from './MountPointContext';
@@ -195,7 +194,7 @@ export var EditAccountModal = /*#__PURE__*/function (_Component) {
       var account = this.state.account;
 
       if (account) {
-        flag('harvest.inappconnectors.enabled') ? this.props.replaceHistory("/accounts/".concat(account._id, "/config")) : this.props.replaceHistory("/accounts/".concat(account._id));
+        this.props.replaceHistory("/accounts/".concat(account._id, "/config"));
       } else {
         this.props.pushHistory("/accounts");
       }

package/dist/components/KonnectorConfiguration/DataTab/index.js

@@ -4,12 +4,10 @@ var _excluded = ["slug"];
 import PropTypes from 'prop-types';
 import React from 'react';
 import { withClient } from 'cozy-client';
-import flag from 'cozy-flags';
 import Divider from 'cozy-ui/transpiled/react/Divider';
 import Stack from 'cozy-ui/transpiled/react/Stack';
 import useBreakpoints from 'cozy-ui/transpiled/react/providers/Breakpoints';
 import appLinksProps from '../../../components/KonnectorConfiguration/DataTab/appLinksProps';
-import KonnectorMaintenance from '../../../components/Maintenance';
 import AppLinkCard from '../../../components/cards/AppLinkCard';
 import { InformationsCard } from '../../../components/cards/InformationsCard';
 import LaunchTriggerCard from '../../../components/cards/LaunchTriggerCard';
@@ -54,11 +52,9 @@ export var DataTab = function DataTab(_ref) {
   });
 
   var _useMaintenanceStatus = useMaintenanceStatus(konnector.slug),
-      _useMaintenanceStatus2 = _useMaintenanceStatus.data,
-      isInMaintenance = _useMaintenanceStatus2.isInMaintenance,
-      maintenanceMessages = _useMaintenanceStatus2.messages;
+      isInMaintenance = _useMaintenanceStatus.data.isInMaintenance;
 
-  return /*#__PURE__*/React.createElement("div", null, flag('harvest.inappconnectors.enabled') && /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(LaunchTriggerCard, {
+  return /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement(LaunchTriggerCard, {
     konnectorRoot: konnectorRoot,
     flow: flow,
     intentsApi: intentsApi,
@@ -66,18 +62,11 @@ export var DataTab = function DataTab(_ref) {
     withMaintenanceDescription: true
   }), isMobile && /*#__PURE__*/React.createElement(Divider, {
     style: styles.divider
-  })), /*#__PURE__*/React.createElement("div", {
+  }), /*#__PURE__*/React.createElement("div", {
     className: isMobile ? 'u-p-1' : 'u-pt-1 u-pb-1-half'
-  }, /*#__PURE__*/React.createElement(Stack, null, !flag('harvest.inappconnectors.enabled') && isInMaintenance && /*#__PURE__*/React.createElement("div", {
-    className: "u-bg-paleGrey u-p-1"
-  }, /*#__PURE__*/React.createElement(KonnectorMaintenance, {
-    maintenanceMessages: maintenanceMessages
-  })), !isInMaintenance && konnectorsModel.hasNewVersionAvailable(konnector) && /*#__PURE__*/React.createElement(KonnectorUpdateInfos, {
+  }, /*#__PURE__*/React.createElement(Stack, null, !isInMaintenance && konnectorsModel.hasNewVersionAvailable(konnector) && /*#__PURE__*/React.createElement(KonnectorUpdateInfos, {
     konnector: konnector,
     isBlocking: hasTermsVersionMismatchError
-  }), !flag('harvest.inappconnectors.enabled') && /*#__PURE__*/React.createElement(LaunchTriggerCard, {
-    flow: flow,
-    disabled: isInMaintenance
   }), appLinks.map(function (_ref2) {
     var slug = _ref2.slug,
         otherProps = _objectWithoutProperties(_ref2, _excluded);

package/dist/components/KonnectorConfiguration/DataTab.spec.js

@@ -5,7 +5,6 @@ function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (O
 function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { _defineProperty(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
 
 import { DataTab } from 'components/KonnectorConfiguration/DataTab';
-import KonnectorMaintenance from 'components/Maintenance';
 import AppLinkCard from 'components/cards/AppLinkCard';
 import LaunchTriggerCard from 'components/cards/LaunchTriggerCard';
 import useMaintenanceStatus from 'components/hooks/useMaintenanceStatus';
@@ -69,12 +68,6 @@ describe('DataTab', function () {
     var component = setup();
     expect(component.find(LaunchTriggerCard).length).toEqual(1);
   });
-  it('should show maintenance info', function () {
-    var component = setup({}, {
-      isInMaintenance: true
-    });
-    expect(component.find(KonnectorMaintenance).length).toEqual(1);
-  });
   describe('links to other apps', function () {
     it('should show the link to banks', function () {
       var withoutAccounts = setup({

package/dist/components/KonnectorConfiguration/KonnectorAccountWrapper.js

@@ -3,8 +3,6 @@ import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProper
 var _excluded = ["Component"];
 import PropTypes from 'prop-types';
 import React from 'react';
-import flag from 'cozy-flags';
-import KonnectorAccountTabs from './KonnectorAccountTabs';
 import { intentsApiProptype, innerAccountModalOverridesProptype } from '../../helpers/proptypes';
 import FlowProvider from '../FlowProvider';
 export var KonnectorAccountWrapper = function KonnectorAccountWrapper(props) {
@@ -16,15 +14,8 @@ export var KonnectorAccountWrapper = function KonnectorAccountWrapper(props) {
     konnector: props.konnector
   }, function (_ref) {
     var flow = _ref.flow;
-
-    if (flag('harvest.inappconnectors.enabled')) {
-      return /*#__PURE__*/React.createElement(Component, _extends({}, rest, {
-        trigger: rest.initialTrigger,
-        flow: flow
-      }));
-    }
-
-    return /*#__PURE__*/React.createElement(KonnectorAccountTabs, _extends({}, rest, {
+    return /*#__PURE__*/React.createElement(Component, _extends({}, rest, {
+      trigger: rest.initialTrigger,
       flow: flow
     }));
   });

package/dist/components/KonnectorConfiguration/KonnectorAccountWrapper.spec.js

@@ -39,12 +39,6 @@ jest.mock('react-router-dom', function () {
     }
   };
 });
-jest.mock('cozy-flags', function () {
-  return function (flag) {
-    if (flag === 'harvest.inappconnectors.enabled') return true;
-    return false;
-  };
-});
 describe('KonnectorAccountWrapper', function () {
   var setup = function setup() {
     var mockClient = {
@@ -102,7 +96,7 @@ describe('KonnectorAccountWrapper', function () {
     };
   };
 
-  it('should render a configuration modal when harvest.inappconnectors.enabled flag is enabled and allow account disconnect', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3() {
+  it('should render a configuration modal when allow account disconnect', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee3() {
     var _setup, root, onAccountDeleted;
 
     return _regeneratorRuntime.wrap(function _callee3$(_context3) {
@@ -158,7 +152,7 @@ describe('KonnectorAccountWrapper', function () {
       }
     }, _callee3);
   })));
-  it('should render a configuration modal when harvest.inappconnectors.enabled flag is enabled and allow account creation', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4() {
+  it('should render a configuration modal when allow account creation', /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee4() {
     var _setup2, root, addAccount, button;
 
     return _regeneratorRuntime.wrap(function _callee4$(_context4) {

package/dist/components/NewAccountModal.js

@@ -3,7 +3,6 @@ import cx from 'classnames';
 import PropTypes from 'prop-types';
 import React, { useContext } from 'react';
 import { triggers as triggersModel } from 'cozy-client/dist/models/trigger';
-import flag from 'cozy-flags';
 import { DialogTitle } from 'cozy-ui/transpiled/react/Dialog';
 import DialogContent from 'cozy-ui/transpiled/react/DialogContent';
 import Spinner from 'cozy-ui/transpiled/react/Spinner';
@@ -57,11 +56,6 @@ var NewAccountModal = function NewAccountModal(_ref) {
     }
 
     var accountId = triggersModel.getAccountId(trigger);
-
-    if (!flag('harvest.inappconnectors.enabled') && trigger.worker !== 'client') {
-      replaceHistory("/accounts/".concat(accountId, "/success"));
-    }
-
     replaceHistory("/accounts/".concat(accountId));
   };
 

package/dist/components/NewAccountModal.spec.js

@@ -31,12 +31,6 @@ describe('NewAccountModal', function () {
   var mountPointContextValue = {
     replaceHistory: replaceHistory
   };
-  var konnectorTrigger = {
-    worker: 'konnector',
-    message: {
-      account: 'accountNumber'
-    }
-  };
   var clientTrigger = {
     worker: 'client',
     message: {
@@ -46,20 +40,6 @@ describe('NewAccountModal', function () {
   afterEach(function () {
     jest.clearAllMocks();
   });
-  it('should redirect to success route on login success for non client triggers', function () {
-    render( /*#__PURE__*/React.createElement(AppLike, {
-      client: {}
-    }, /*#__PURE__*/React.createElement(MountPointContext.Provider, {
-      value: mountPointContextValue
-    }, /*#__PURE__*/React.createElement(NewAccountModal, {
-      konnector: {
-        slug: 'konnectorslug',
-        name: 'konnector slug'
-      }
-    }))));
-    onLoginSuccessFn(konnectorTrigger);
-    expect(replaceHistory).toHaveBeenCalledWith('/accounts/accountNumber/success');
-  });
   it('should redirect to route without success on login success for client triggers', function () {
     render( /*#__PURE__*/React.createElement(AppLike, {
       client: {}
@@ -74,20 +54,6 @@ describe('NewAccountModal', function () {
     onLoginSuccessFn(clientTrigger);
     expect(replaceHistory).toHaveBeenCalledWith('/accounts/accountNumberClient');
   });
-  it('should redirect to success route on success for non client triggers', function () {
-    render( /*#__PURE__*/React.createElement(AppLike, {
-      client: {}
-    }, /*#__PURE__*/React.createElement(MountPointContext.Provider, {
-      value: mountPointContextValue
-    }, /*#__PURE__*/React.createElement(NewAccountModal, {
-      konnector: {
-        slug: 'konnectorslug',
-        name: 'konnector slug'
-      }
-    }))));
-    onSuccessFn(konnectorTrigger);
-    expect(replaceHistory).toHaveBeenCalledWith('/accounts/accountNumber/success');
-  });
   it('should redirect to route without success on success for client triggers', function () {
     render( /*#__PURE__*/React.createElement(AppLike, {
       client: {}

package/dist/components/Routes/RoutesV4.js

@@ -1,12 +1,10 @@
 import React from 'react';
 import { Switch, Route, Redirect } from 'react-router-dom';
-import flag from 'cozy-flags';
 import AccountModal from '../AccountModal';
 import EditAccountModal from '../EditAccountModal';
 import HarvestModalRoot from '../HarvestModalRoot';
 import ConfigurationTab from '../KonnectorConfiguration/ConfigurationTab';
 import DataTab from '../KonnectorConfiguration/DataTab';
-import KonnectorSuccess from '../KonnectorSuccess';
 import NewAccountModal from '../NewAccountModal';
 import withAdaptiveRouter from '../hoc/withRouter';
 
@@ -46,7 +44,7 @@ var RoutesV4 = function RoutesV4(_ref) {
         onDismiss: onDismiss
       });
     }
-  }), flag('harvest.inappconnectors.enabled') ? /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(Route, {
+  }), /*#__PURE__*/React.createElement(Route, {
     path: "".concat(konnectorRoot, "/accounts/:accountId"),
     exact: true,
     render: function render(_ref3) {
@@ -76,32 +74,6 @@ var RoutesV4 = function RoutesV4(_ref) {
         Component: ConfigurationTab
       });
     }
-  })) : /*#__PURE__*/React.createElement(Route, {
-    path: "".concat(konnectorRoot, "/accounts/:accountId"),
-    exact: true,
-    render: function render(_ref5) {
-      var match = _ref5.match;
-      return /*#__PURE__*/React.createElement(AccountModal, {
-        konnector: konnectorWithTriggers,
-        accountId: match.params.accountId,
-        accountsAndTriggers: accountsAndTriggers,
-        onDismiss: onDismiss,
-        showNewAccountButton: !konnectorWithTriggers.clientSide,
-        showAccountSelection: !konnectorWithTriggers.clientSide
-      });
-    }
-  }), !flag('harvest.inappconnectors.enabled') && /*#__PURE__*/React.createElement(Route, {
-    path: "".concat(konnectorRoot, "/accounts/:accountId/success"),
-    exact: true,
-    render: function render(_ref6) {
-      var match = _ref6.match;
-      return /*#__PURE__*/React.createElement(KonnectorSuccess, {
-        konnector: konnectorWithTriggers,
-        accountId: match.params.accountId,
-        accounts: accountsAndTriggers,
-        onDismiss: onDismiss
-      });
-    }
   }), /*#__PURE__*/React.createElement(Redirect, {
     from: "".concat(konnectorRoot, "/*"),
     to: "".concat(konnectorRoot, "/")

package/dist/components/Routes/RoutesV6.js

@@ -1,6 +1,5 @@
 import React from 'react';
 import { Routes, Route, Navigate, useParams } from 'react-router-dom';
-import flag from 'cozy-flags';
 import { ViewerModal } from '../../datacards/ViewerModal';
 import AccountModal from '../AccountModal';
 import EditAccountModal from '../EditAccountModal';
@@ -33,7 +32,7 @@ var RoutesV6 = function RoutesV6(_ref) {
       onSuccess: onSuccess,
       onDismiss: onDismiss
     })
-  }), flag('harvest.inappconnectors.enabled') ? /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(Route, {
+  }), /*#__PURE__*/React.createElement(Route, {
     path: "accounts/:accountId",
     element: /*#__PURE__*/React.createElement(HarvestParamsWrapper, null, function (params) {
       return /*#__PURE__*/React.createElement(AccountModal, {
@@ -59,18 +58,6 @@ var RoutesV6 = function RoutesV6(_ref) {
         Component: ConfigurationTab
       });
     })
-  })) : /*#__PURE__*/React.createElement(Route, {
-    path: "accounts/:accountId",
-    element: /*#__PURE__*/React.createElement(HarvestParamsWrapper, null, function (params) {
-      return /*#__PURE__*/React.createElement(AccountModal, {
-        konnector: konnectorWithTriggers,
-        accountId: params.accountId,
-        accountsAndTriggers: accountsAndTriggers,
-        onDismiss: onDismiss,
-        showNewAccountButton: !konnectorWithTriggers.clientSide,
-        showAccountSelection: !konnectorWithTriggers.clientSide
-      });
-    })
   }), /*#__PURE__*/React.createElement(Route, {
     path: "accounts/:accountId/edit",
     element: /*#__PURE__*/React.createElement(HarvestParamsWrapper, null, function (params) {

package/dist/components/Routes.js

@@ -1,14 +1,12 @@
 import _extends from "@babel/runtime/helpers/extends";
 import PropTypes from 'prop-types';
 import React, { useEffect } from 'react';
-import flag from 'cozy-flags';
 import { useVaultUnlockContext, VaultUnlockPlaceholder } from 'cozy-keys-lib';
 import { DialogCloseButton, useCozyDialog } from 'cozy-ui/transpiled/react/CozyDialogs';
 import Dialog from 'cozy-ui/transpiled/react/Dialog';
 import Spinner from 'cozy-ui/transpiled/react/Spinner';
 import { useAlert } from 'cozy-ui/transpiled/react/providers/Alert';
 import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n';
-import { withStyles } from 'cozy-ui/transpiled/react/styles';
 import { DatacardOptions } from './Datacards/DatacardOptionsContext';
 import DialogContext from './DialogContext';
 import HarvestWrapper from './HarvestWrapper';
@@ -18,38 +16,7 @@ import RoutesV6 from './Routes/RoutesV6';
 import { isRouterV6 } from './hoc/withRouter';
 import { useKonnectorWithTriggers } from '../helpers/useKonnectorWithTriggers';
 
-var withHarvestDialogStyles = function withHarvestDialogStyles() {
-  /**
-   * When this flag is enabled, tabs are removed, and the layout shift between
-   * data and configuration screens is not as disturbing as with tabs. So we do
-   * not need to customize styles to align the dialog at the top anymore and we
-   * can just return the identity function. This whole HOC should be able to be
-   * removed at the same time as the flag. See the next comment for the former
-   * behavior.
-   */
-  if (flag('harvest.inappconnectors.enabled')) {
-    return function (component) {
-      return component;
-    };
-  }
-  /**
-   * Dialog will not be centered vertically since we need the modal to "stay in
-   * place" when changing tabs. Since tabs content's height is not the same
-   * between the data tab and the configuration, having the modal vertically
-   * centered makes it "jump" when changing tabs.
-   */
-
-
-  return withStyles({
-    scrollPaper: {
-      alignItems: 'start'
-    },
-    // Necessary to prevent warnings at runtime
-    paper: {}
-  });
-};
-
-var HarvestDialog = withHarvestDialogStyles()(function (props) {
+var HarvestDialog = function HarvestDialog(props) {
   var _useVaultUnlockContex = useVaultUnlockContext(),
       showingUnlockForm = _useVaultUnlockContex.showingUnlockForm;
 
@@ -60,7 +27,7 @@ var HarvestDialog = withHarvestDialogStyles()(function (props) {
   return /*#__PURE__*/React.createElement(Dialog, _extends({
     disableRestoreFocus: true
   }, props));
-});
+};
 
 var Routes = function Routes(_ref) {
   var konnectorRoot = _ref.konnectorRoot,
@@ -138,10 +105,10 @@ var Routes = function Routes(_ref) {
 
 Routes.propTypes = {
   /** The root URL of the konnector */
-  konnectorRoot: PropTypes.string.isRequired,
+  konnectorRoot: PropTypes.string,
 
   /** The konnector object */
-  konnector: PropTypes.object.isRequired,
+  konnector: PropTypes.object,
 
   /** The slug of the konnector */
   konnectorSlug: PropTypes.string.isRequired,