coveo.analytics 2.28.25 → 2.29.2

package/src/insight/insightClient.ts

@@ -93,9 +93,6 @@ export class CoveoInsightClient {
     }
 
     public disable() {
-        if (this.coveoAnalyticsClient instanceof CoveoAnalyticsClient) {
-            this.coveoAnalyticsClient.clear();
-        }
         this.coveoAnalyticsClient = new NoopAnalytics();
     }
 

package/src/searchPage/searchPageClient.spec.ts

@@ -12,6 +12,8 @@ import CoveoAnalyticsClient from '../client/analytics';
 import {NoopAnalytics} from '../client/noopAnalytics';
 import {mockFetch, lastCallBody} from '../../tests/fetchMock';
 import doNotTrack from '../donottrack';
+import {Cookie} from '../cookieutils';
+
 jest.mock('../donottrack', () => {
     return {
         default: jest.fn(),
@@ -1424,6 +1426,16 @@ describe('SearchPageClient', () => {
         expect(c.coveoAnalyticsClient instanceof NoopAnalytics).toBe(true);
     });
 
+    it('disabling analytics does not delete the visitorId', () => {
+        const visitorId = 'uuid';
+        Cookie.set('coveo_visitorId', visitorId);
+        const c = new CoveoSearchPageClient({enableAnalytics: true}, provider);
+
+        expect(Cookie.get('coveo_visitorId')).toBe(visitorId);
+        c.disable();
+        expect(Cookie.get('coveo_visitorId')).toBe(visitorId);
+    });
+
     it('should allow enabling analytics after initialization', () => {
         const c = new CoveoSearchPageClient({enableAnalytics: false}, provider);
         expect(c.coveoAnalyticsClient instanceof NoopAnalytics).toBe(true);

package/src/searchPage/searchPageClient.ts

@@ -84,10 +84,6 @@ export class CoveoSearchPageClient {
     }
 
     public disable() {
-        if (this.coveoAnalyticsClient instanceof CoveoAnalyticsClient) {
-            this.coveoAnalyticsClient.clear();
-        }
-
         this.coveoAnalyticsClient = new NoopAnalytics();
     }