coursecode 0.1.57 → 0.1.59

package/framework/js/assessment/AssessmentActions.js

@@ -70,7 +70,7 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
         await stateManager.setAttemptNumber(attemptNumber);
 
         _manageFooterVisibility('question');
-        uiManager.showView('question');
+        await uiManager.showView('question');
     }
 
     async function handlePrev() {
@@ -79,7 +79,7 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
         const currentIndex = stateManager.getCurrentQuestionIndex();
         if (currentIndex > 0) {
             await stateManager.setCurrentQuestionIndex(currentIndex - 1);
-            uiManager.showView('question');
+            await uiManager.showView('question');
         }
     }
 
@@ -94,7 +94,7 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
                 await stateManager.updateSession({ reviewReached: true });
                 await stateManager.setCurrentView('review');
                 _manageFooterVisibility('review');
-                uiManager.showView('review');
+                await uiManager.showView('review');
             } else {
                 // FIX: Route through handleSubmit to ensure unanswered checks are performed
                 // previously called submitAssessment() directly, bypassing validation
@@ -102,7 +102,7 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
             }
         } else {
             await stateManager.setCurrentQuestionIndex(currentIndex + 1);
-            uiManager.showView('question');
+            await uiManager.showView('question');
         }
     }
 
@@ -119,21 +119,21 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
         await stateManager.setCurrentView('question');
         await stateManager.setCurrentQuestionIndex(index);
         _manageFooterVisibility('question');
-        uiManager.showView('question');
+        await uiManager.showView('question');
     }
 
     async function handleBackToQuestions() {
         await _forceSaveCurrentResponse();
         await stateManager.setCurrentView('question');
         _manageFooterVisibility('question');
-        uiManager.showView('question');
+        await uiManager.showView('question');
     }
 
     async function handleJumpToReview() {
         await _forceSaveCurrentResponse();
         await stateManager.setCurrentView('review');
         _manageFooterVisibility('review');
-        uiManager.showView('review');
+        await uiManager.showView('review');
     }
 
     async function handleSubmit() {
@@ -242,14 +242,14 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
             // This will cause slide to create NEW assessment instance
             const currentSlideId = getCurrentSlideId();
             if (currentSlideId) {
-                goToSlide(currentSlideId, { refreshAssessment: true });
+                await goToSlide(currentSlideId, { refreshAssessment: true });
                 return; // Exit - new instance will be created
             }
         }
 
         // Simple reset - same questions
         _manageFooterVisibility('intro');
-        uiManager.showView('intro');
+        await uiManager.showView('intro');
     }
 
     function handleRestartCourse() {
@@ -353,7 +353,7 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
             throw new Error(errorMessage);
         }
 
-        goToSlide(firstRemedialSlide, {
+        await goToSlide(firstRemedialSlide, {
             fromAssessment: config.id,
             remedialReview: true
         });
@@ -413,11 +413,6 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
         const displayData = _prepareResultsDisplayData(finalResults);
 
         await stateManager.setCurrentView('results');
-        _manageFooterVisibility('results');
-        uiManager.showView('results', displayData);
-
-        // Keep full results in memory for this session only (not persisted)
-        // This allows detailed review immediately after submission
 
         // Automatically set linked objective if configured
         if (config.assessmentObjective) {
@@ -446,6 +441,12 @@ export function createAssessmentActions(stateManager, uiManager, questionInstanc
         // Assessment submission is a critical action - don't rely on debounce
         await globalStateManager.flush();
 
+        // Only transition the UI after the assessment outcome, objective, and
+        // course score are durably committed. A rendering failure must never
+        // prevent the LMS from receiving the learner's submitted result.
+        _manageFooterVisibility('results');
+        await uiManager.showView('results', displayData);
+
         if (typeof config.onComplete === 'function') {
             config.onComplete(finalResults);
         }

package/framework/js/assessment/AssessmentFactory.js

@@ -231,15 +231,37 @@ export function createAssessmentInstance(config) {
                     });
                     throw error;
                 } else {
-                    // Production mode: Log warning and filter out missing questions
-                    // Also emit event so course can potentially track this
-                    logger.warn(`[AssessmentFactory] ${errorMessage} Continuing with available questions.`);
+                    // Index-keyed responses cannot be safely paired with a
+                    // filtered question list. Restart only the in-progress
+                    // session and preserve the learner's submitted summaries.
+                    logger.warn(`[AssessmentFactory] ${errorMessage} Restarting the in-progress attempt safely.`);
                     eventBus.emit('state:recovered', {
                         domain: 'assessment',
                         message: errorMessage,
                         context: { assessmentId, missingIds },
-                        action: 'filtered_missing_questions'
+                        action: 'restarted_changed_assessment'
                     });
+
+                    const replacementQuestions = _selectNewQuestions();
+                    const existingSession = assessmentState.getSession() || {};
+                    assessmentState.updateSession({
+                        ...existingSession,
+                        currentView: 'intro',
+                        currentQuestionIndex: 0,
+                        startTime: null,
+                        submitted: false,
+                        responses: {},
+                        selectedQuestions: replacementQuestions.map(question => question.id),
+                        reviewReached: false
+                    }, 'assessment-state:course-update').catch(error => {
+                        logger.error(`Failed to persist safe assessment restart: ${error.message}`, {
+                            domain: 'assessment',
+                            operation: 'recover-changed-questions',
+                            assessmentId,
+                            stack: error.stack
+                        });
+                    });
+                    return replacementQuestions;
                 }
             }
 
@@ -248,22 +270,19 @@ export function createAssessmentInstance(config) {
                 .filter(q => q !== undefined); // Filter out any missing questions
         }
 
+        return _selectNewQuestions();
+    }
+
+    function _selectNewQuestions() {
         if (config.questionBanks && Array.isArray(config.questionBanks) && config.questionBanks.length > 0) {
-            // New session with banks: select and optionally randomize
             let selected = _selectQuestionsFromBanks(config.questionBanks);
-
-            if (config.settings?.randomizeQuestions) {
-                selected = shuffleArray(selected);
-            }
-
+            if (config.settings?.randomizeQuestions) selected = shuffleArray(selected);
             return selected;
         }
 
-        // Direct mode: use questions array as-is
         if (config.settings?.randomizeQuestions && Array.isArray(config.questions)) {
             return shuffleArray(config.questions);
         }
-
         return config.questions || [];
     }
 
@@ -320,10 +339,20 @@ export function createAssessmentInstance(config) {
         // Resolve active questions for this session
         activeQuestions = _resolveActiveQuestions();
 
-        // Persist selection if this is a new bank-based session (fire-and-forget)
-        if (config.questionBanks && !session?.selectedQuestions) {
+        // Persist every randomized order, including direct question arrays.
+        // Responses are keyed by index, so resume must reconstruct the exact
+        // same question order or answers can be scored against another item.
+        const requiresPersistedOrder = Boolean(
+            config.questionBanks || config.settings?.randomizeQuestions
+        );
+        if (requiresPersistedOrder && !session?.selectedQuestions) {
             assessmentState.setSelectedQuestions(activeQuestions).catch(error => {
-                logger.error(`Failed to persist selected questions: ${error.message}`, { domain: 'assessment', operation: 'persist-selected-questions', assessmentId });
+                logger.error(`Failed to persist selected questions: ${error.message}`, {
+                    domain: 'assessment',
+                    operation: 'persist-selected-questions',
+                    assessmentId,
+                    stack: error.stack
+                });
             });
         }
 

package/framework/js/automation/api-engagement.js

@@ -61,7 +61,7 @@ export function createEngagementMethods(logTrace) {
             if (!slideId) {
                 throw new Error('CourseCodeAutomation: No active slide');
             }
-            if (typeof percentage !== 'number' || percentage < 0 || percentage > 100) {
+            if (!Number.isFinite(percentage) || percentage < 0 || percentage > 100) {
                 throw new Error('CourseCodeAutomation: Scroll depth must be a number between 0 and 100');
             }
             engagementManager.trackScrollDepth(slideId, percentage);
@@ -143,7 +143,7 @@ export function createEngagementMethods(logTrace) {
             const currentSlideId = NavigationState.getCurrentSlideId();
 
             if (state.duration > 0) {
-                const targetPosition = state.duration * (state.completionThreshold || 0.95);
+                const targetPosition = state.duration * state.completionThreshold;
                 audioManager.seek(targetPosition);
             }
 
@@ -163,7 +163,10 @@ export function createEngagementMethods(logTrace) {
                 case 'tab':
                 case 'standalone':
                     if (currentSlideId) {
-                        engagementManager.trackStandaloneAudioComplete(currentSlideId, state.contextId);
+                        const audioId = state.contextType === 'standalone'
+                            ? state.contextId.replace(/^standalone-/, '')
+                            : state.contextId;
+                        engagementManager.trackStandaloneAudioComplete(currentSlideId, audioId);
                     }
                     break;
             }

package/framework/js/components/interactions/drag-drop.js

@@ -77,8 +77,7 @@ export const schema = {
             description: 'Draggable items',
             itemSchema: {
                 id: { type: 'string', required: true },
-                text: { type: 'string', required: true },
-                correctZone: { type: 'string', required: true }
+                content: { type: 'string', required: true }
             }
         },
         dropZones: {
@@ -88,7 +87,9 @@ export const schema = {
             description: 'Drop target zones',
             itemSchema: {
                 id: { type: 'string', required: true },
-                label: { type: 'string', required: true }
+                label: { type: 'string', required: true },
+                accepts: { type: 'array', required: true, minItems: 1 },
+                maxItems: { type: 'number' }
             }
         }
     }
@@ -881,4 +882,3 @@ function removeItemFromZone(container, itemId) {
     // Update state
     delete state.placements[itemId];
 }
-

package/framework/js/components/interactions/fill-in.js

@@ -137,10 +137,13 @@ export const schema = {
             type: 'object',
             required: true,
             description: 'Map of blank IDs to their correct answers',
-            valueSchema: {
-                correct: { type: ['string', 'array'], required: true },
-                typoTolerance: { type: 'number', default: 0 },
-                hint: { type: 'string' }
+            mapValueSchema: {
+                type: 'object',
+                valueSchema: {
+                    correct: { type: ['string', 'array'], required: true },
+                    typoTolerance: { type: 'number', default: 0 },
+                    hint: { type: 'string' }
+                }
             }
         },
         template: {

package/framework/js/components/interactions/hotspot.js

@@ -10,6 +10,7 @@ import {
   registerCoreInteraction
 } from './interaction-base.js';
 import { logger } from '../../utilities/logger.js';
+import { resolveCourseAssetUrl } from '../../utilities/portable-assets.js';
 
 // Default appearance themes for hotspots
 const HOTSPOT_DEFAULTS = {
@@ -282,7 +283,7 @@ export function createHotspotQuestion(config) {
           <div class="hotspot-container">
             <div class="image-container relative">
               <img
-                src="${image.src}"
+                src="${resolveCourseAssetUrl(image.src)}"
                 alt="${image.alt || ''}"
                 class="w-full h-auto"
                 id="${id}_image"
@@ -699,4 +700,3 @@ function toNumber(value, fallback = 0) {
   }
   return 0;
 }
-

package/framework/js/components/interactions/matching.js

@@ -94,10 +94,11 @@ export const schema = {
             type: 'array',
             required: true,
             minItems: 2,
-            description: 'Source-target pairs to match',
+            description: 'Items and their matching target text',
             itemSchema: {
-                source: { type: 'string', required: true },
-                target: { type: 'string', required: true }
+                id: { type: 'string', required: true },
+                text: { type: 'string', required: true },
+                match: { type: 'string', required: true }
             }
         },
         feedbackMode: {

package/framework/js/components/ui-components/audio-player.js

@@ -60,6 +60,7 @@ import engagementManager from '../../engagement/engagement-manager.js';
 import * as NavigationState from '../../navigation/NavigationState.js';
 import { logger } from '../../utilities/logger.js';
 import { iconManager } from '../../utilities/icons.js';
+import { normalizeCompletionThreshold } from '../../utilities/media-utils.js';
 
 
 /** @type {HTMLElement|null} */
@@ -351,6 +352,7 @@ function _handleProgressMousedown(event) {
 
     const progressBar = elements.progressBar;
     const rect = progressBar.getBoundingClientRect();
+    if (rect.width <= 0) return;
 
     const seek = (clientX) => {
         const percentage = Math.max(0, Math.min(100, ((clientX - rect.left) / rect.width) * 100));
@@ -823,7 +825,7 @@ class StandaloneAudioPlayer {
         this.audioSrc = container.dataset.audioSrc;
         this.required = container.dataset.audioRequired === 'true';
         this.compact = container.dataset.audioCompact === 'true';
-        this.threshold = parseFloat(container.dataset.audioThreshold) || 0.95;
+        this.threshold = normalizeCompletionThreshold(container.dataset.audioThreshold);
 
         if (!this.audioId) {
             throw new Error('[AudioPlayer] Standalone player requires data-audio-id');
@@ -836,6 +838,12 @@ class StandaloneAudioPlayer {
         this.isActive = false;
         this.eventHandlers = {};
         this.elements = {};
+        this.domEventHandlers = {
+            click: this._handleClick.bind(this),
+            progressKeydown: this._handleProgressKeydown.bind(this),
+            progressMousedown: this._handleProgressMousedown.bind(this)
+        };
+        this.dragCleanup = null;
 
         this._render();
         this._cacheElements();
@@ -867,11 +875,11 @@ class StandaloneAudioPlayer {
     }
 
     _setupEventListeners() {
-        this.container.addEventListener('click', this._handleClick.bind(this));
+        this.container.addEventListener('click', this.domEventHandlers.click);
 
         if (this.elements.progressBar) {
-            this.elements.progressBar.addEventListener('keydown', this._handleProgressKeydown.bind(this));
-            this.elements.progressBar.addEventListener('mousedown', this._handleProgressMousedown.bind(this));
+            this.elements.progressBar.addEventListener('keydown', this.domEventHandlers.progressKeydown);
+            this.elements.progressBar.addEventListener('mousedown', this.domEventHandlers.progressMousedown);
         }
     }
 
@@ -915,7 +923,9 @@ class StandaloneAudioPlayer {
                 completionThreshold: this.threshold
             }, this.contextId, 'standalone');
         } catch (error) {
-            logger.error(`[AudioPlayer] Failed to load ${this.audioId}:`, error.message);
+            if (error.name !== 'AbortError') {
+                logger.error(`[AudioPlayer] Failed to load ${this.audioId}:`, error.message);
+            }
         }
     }
 
@@ -939,8 +949,11 @@ class StandaloneAudioPlayer {
     _handleProgressMousedown(event) {
         if (!this.isActive || !audioManager.hasAudio()) return;
 
+        this.dragCleanup?.();
+
         const progressBar = this.elements.progressBar;
         const rect = progressBar.getBoundingClientRect();
+        if (rect.width <= 0) return;
 
         const seek = (clientX) => {
             const pct = Math.max(0, Math.min(100, ((clientX - rect.left) / rect.width) * 100));
@@ -950,15 +963,19 @@ class StandaloneAudioPlayer {
         seek(event.clientX);
 
         const onMouseMove = (e) => seek(e.clientX);
-        const onMouseUp = () => {
+        const cleanupDrag = () => {
             document.removeEventListener('mousemove', onMouseMove);
-            document.removeEventListener('mouseup', onMouseUp);
+            document.removeEventListener('mouseup', cleanupDrag);
             progressBar.classList.remove('dragging');
+            if (this.dragCleanup === cleanupDrag) {
+                this.dragCleanup = null;
+            }
         };
 
         progressBar.classList.add('dragging');
         document.addEventListener('mousemove', onMouseMove);
-        document.addEventListener('mouseup', onMouseUp);
+        document.addEventListener('mouseup', cleanupDrag);
+        this.dragCleanup = cleanupDrag;
     }
 
     _subscribeToAudioEvents() {
@@ -1111,6 +1128,11 @@ class StandaloneAudioPlayer {
     }
 
     destroy() {
+        this.dragCleanup?.();
+        this.container.removeEventListener('click', this.domEventHandlers.click);
+        this.elements.progressBar?.removeEventListener('keydown', this.domEventHandlers.progressKeydown);
+        this.elements.progressBar?.removeEventListener('mousedown', this.domEventHandlers.progressMousedown);
+
         eventBus.off('audio:loadStart', this.eventHandlers.loadStart);
         eventBus.off('audio:loaded', this.eventHandlers.loaded);
         eventBus.off('audio:unloaded', this.eventHandlers.unloaded);

package/framework/js/components/ui-components/collapse.js

@@ -90,11 +90,12 @@ export function init(container) {
     };
 
     // Handle transition end to set display: none for accessibility and performance
-    panel.addEventListener('transitionend', () => {
+    const handleTransitionEnd = () => {
         if (trigger.getAttribute('aria-expanded') === 'false') {
             panel.style.display = 'none';
         }
-    });
+    };
+    panel.addEventListener('transitionend', handleTransitionEnd);
     
     // Ensure panel is correctly displayed or hidden on init
     if (trigger.getAttribute('aria-expanded') === 'false') {
@@ -109,6 +110,7 @@ export function init(container) {
     return {
         destroy: () => {
             trigger.removeEventListener('click', toggle);
+            panel.removeEventListener('transitionend', handleTransitionEnd);
         }
     };
 }

package/framework/js/components/ui-components/dropdown.js

@@ -127,7 +127,7 @@ export function init(root, options = {}) {
     });
 
     // Delegated event listener for the entire dropdown
-    dropdown.addEventListener('click', (event) => {
+    const handleClick = (event) => {
         const actionTarget = event.target.closest('[data-action]');
         if (!actionTarget) return;
 
@@ -145,13 +145,17 @@ export function init(root, options = {}) {
                 selectDropdownItem(dropdownId, itemIndex);
             }
         }
-    });
+    };
 
     // Keyboard navigation for the menu
-    menu.addEventListener('keydown', (event) => handleDropdownKeyboard(dropdownId, event));
+    const handleKeydown = (event) => handleDropdownKeyboard(dropdownId, event);
+    dropdown.addEventListener('click', handleClick);
+    menu.addEventListener('keydown', handleKeydown);
 
     return {
         destroy: () => {
+            dropdown.removeEventListener('click', handleClick);
+            menu.removeEventListener('keydown', handleKeydown);
             dropdowns.delete(dropdownId);
         }
     };

package/framework/js/components/ui-components/embed-frame.js

@@ -51,6 +51,7 @@ export const metadata = {
 import { logger } from '../../utilities/logger.js';
 import { eventBus } from '../../core/event-bus.js';
 import flagManager from '../../managers/flag-manager.js';
+import { resolvePortableAssetUrl } from '../../utilities/portable-assets.js';
 
 /**
  * Initializes an embed-frame component.
@@ -254,6 +255,9 @@ function handleReadyMessage(embedId) {
  * @returns {string} Resolved path
  */
 function _resolvePath(src) {
+    const portableSrc = resolvePortableAssetUrl(src);
+    if (portableSrc !== src) return portableSrc;
+
     // Already absolute URL or protocol-relative
     if (src.startsWith('http://') || src.startsWith('https://') || src.startsWith('//')) {
         return src;
@@ -270,5 +274,5 @@ function _resolvePath(src) {
     }
 
     // Otherwise, assume relative to course/assets/
-    return `./course/${src}`;
+    return resolvePortableAssetUrl(`./course/${src}`);
 }

package/framework/js/components/ui-components/flip-card.js

@@ -218,13 +218,19 @@ export function init(element) {
         announceToScreenReader(action);
     };
 
-    // Click listener
-    element.addEventListener('click', toggleFlip);
-
-    // Keyboard listener (Enter or Space)
-    element.addEventListener('keydown', (e) => {
+    const handleKeydown = (e) => {
         if (e.key === 'Enter' || e.key === ' ') {
             toggleFlip(e);
         }
-    });
+    };
+
+    element.addEventListener('click', toggleFlip);
+    element.addEventListener('keydown', handleKeydown);
+
+    return {
+        destroy: () => {
+            element.removeEventListener('click', toggleFlip);
+            element.removeEventListener('keydown', handleKeydown);
+        }
+    };
 }