coursecode 0.1.14 → 0.1.15

package/framework/js/core/event-bus.js

@@ -1,10 +1,38 @@
 import { generateId } from '../utilities/utilities.js';
 import { logger } from '../utilities/logger.js';
 
+/**
+ * Safely serialize any value for logging. Handles circular references,
+ * Error instances, and oversized payloads without throwing.
+ */
+function safeStringify(data, maxLength = 4096) {
+  const seen = new WeakSet();
+  try {
+    const json = JSON.stringify(data, (key, value) => {
+      if (value instanceof Error) {
+        return { name: value.name, message: value.message, stack: value.stack };
+      }
+      if (typeof value === 'object' && value !== null) {
+        if (seen.has(value)) return '[Circular]';
+        seen.add(value);
+      }
+      return value;
+    }, 2);
+    if (json && json.length > maxLength) {
+      return json.slice(0, maxLength) + '...[truncated]';
+    }
+    return json;
+  } catch {
+    return `[Unserializable: ${typeof data}]`;
+  }
+}
+
 class EventBus {
   constructor() {
     // Event listeners registry
     this.events = {};
+    // Re-entrancy guard — prevents infinite :error → log → :error cascade
+    this._emittingError = false;
   }
 
   /**
@@ -86,31 +114,50 @@ class EventBus {
       return false;
     }
 
-    // Automatically log events that follow the ':error' naming convention
-    if (event.endsWith(':error')) {
-      logger.error(`[EventBus Error] ${event}:`, JSON.stringify(data, null, 2));
-    }
+    const isErrorEvent = event.endsWith(':error');
 
-    // Create a copy of listeners to avoid issues if listeners modify the array
-    const listeners = [...this.events[event]];
-    const onceListeners = [];
+    // Re-entrancy guard — if we're already inside an :error emit,
+    // suppress to prevent infinite cascade
+    if (isErrorEvent) {
+      if (this._emittingError) {
+        console.warn(`[EventBus] Suppressed recursive error event: ${event}`);
+        return false;
+      }
+      this._emittingError = true;
+    }
 
-    listeners.forEach(listener => {
-      try {
-        listener.callback(data);
+    try {
+      // Automatically log events that follow the ':error' naming convention
+      if (isErrorEvent) {
+        logger.error(`[EventBus Error] ${event}:`, safeStringify(data));
+      }
 
-        // Track once listeners for removal
-        if (listener.once) {
-          onceListeners.push(listener.id);
+      // Create a copy of listeners to avoid issues if listeners modify the array
+      const listeners = [...this.events[event]];
+      const onceListeners = [];
+
+      listeners.forEach(listener => {
+        try {
+          listener.callback(data);
+
+          // Track once listeners for removal
+          if (listener.once) {
+            onceListeners.push(listener.id);
+          }
+        } catch (error) {
+          // Log the error but don't break other listeners — use safeStringify
+          // to prevent a secondary cascade from unserializable error objects
+          logger.error(`[EventBus] Error in listener for '${event}':`, safeStringify(error));
         }
-      } catch (error) {
-        // Log the error but don't break other listeners
-        logger.error(`[EventBus] Error in listener for '${event}':`, error);
-      }
-    });
+      });
 
-    // Remove once listeners
-    onceListeners.forEach(id => this.off(event, id));
+      // Remove once listeners
+      onceListeners.forEach(id => this.off(event, id));
+    } finally {
+      if (isErrorEvent) {
+        this._emittingError = false;
+      }
+    }
 
     return true;
   }

package/framework/js/drivers/scorm-2004-driver.js

@@ -561,13 +561,27 @@ export class Scorm2004Driver extends ScormDriverBase {
      * Populates the CMI cache at init time. Single LMS read pass.
      */
     _populateCache() {
-        // Read-only scalars
-        this._cmiCache.entry = this._getValue('cmi.entry') || '';
-        this._cmiCache.bookmark = this._getValue('cmi.location') || '';
-        this._cmiCache.completionStatus = this._getValue('cmi.completion_status') || 'unknown';
-        this._cmiCache.successStatus = this._getValue('cmi.success_status') || 'unknown';
-        this._cmiCache.learnerId = this._getValue('cmi.learner_id') || '';
-        this._cmiCache.learnerName = this._getValue('cmi.learner_name') || '';
+        // Helper: read a CMI value via strict _getValue, but tolerate error 403
+        // ("Data Model Element Value Not Initialized") which strict LMSes like
+        // SCORM Cloud return for unset elements on a fresh session.
+        // Any other SCORM error still throws through _getValue's normal path.
+        const getOrDefault = (key, fallback) => {
+            try {
+                return this._getValue(key) || fallback;
+            } catch (e) {
+                const code = this._scorm.debug.getCode();
+                if (code === 403) return fallback;
+                throw e;
+            }
+        };
+
+        // Read-only scalars (may be uninitialized on first launch)
+        this._cmiCache.entry = getOrDefault('cmi.entry', '');
+        this._cmiCache.bookmark = getOrDefault('cmi.location', '');
+        this._cmiCache.completionStatus = getOrDefault('cmi.completion_status', 'unknown');
+        this._cmiCache.successStatus = getOrDefault('cmi.success_status', 'unknown');
+        this._cmiCache.learnerId = getOrDefault('cmi.learner_id', '');
+        this._cmiCache.learnerName = getOrDefault('cmi.learner_name', '');
 
         // Skip array hydration for fresh sessions
         if (this._cmiCache.entry === 'ab-initio') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "coursecode",
-  "version": "0.1.14",
+  "version": "0.1.15",
   "description": "Multi-format course authoring framework with CLI tools (SCORM 2004, SCORM 1.2, cmi5, LTI 1.3)",
   "type": "module",
   "bin": {