couchbase 4.2.6-dev.1 → 4.2.7

package/deps/couchbase-cxx-client/core/operations/document_lookup_in_all_replicas.hxx

@@ -0,0 +1,192 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-2021 Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#pragma once
+
+#include "core/error_context/key_value.hxx"
+#include "core/impl/lookup_in_replica.hxx"
+#include "core/impl/subdoc/command.hxx"
+#include "core/operations/document_lookup_in.hxx"
+#include "core/operations/operation_traits.hxx"
+#include "core/utils/movable_function.hxx"
+#include "couchbase/codec/encoded_value.hxx"
+#include "couchbase/error_codes.hxx"
+
+#include <functional>
+#include <memory>
+#include <mutex>
+
+namespace couchbase::core::operations
+{
+struct lookup_in_all_replicas_response {
+    struct entry {
+        struct lookup_in_entry {
+            std::string path;
+            codec::binary value;
+            std::size_t original_index;
+            bool exists;
+            protocol::subdoc_opcode opcode;
+            key_value_status_code status;
+            std::error_code ec{};
+        };
+        std::vector<lookup_in_entry> fields{};
+        couchbase::cas cas{};
+        bool deleted{ false };
+        bool is_replica{ true };
+    };
+    subdocument_error_context ctx{};
+    std::vector<entry> entries{};
+};
+
+struct lookup_in_all_replicas_request {
+    using response_type = lookup_in_all_replicas_response;
+    using encoded_request_type = core::protocol::client_request<core::protocol::lookup_in_replica_request_body>;
+    using encoded_response_type = core::protocol::client_response<core::protocol::lookup_in_replica_response_body>;
+
+    core::document_id id;
+    std::vector<couchbase::core::impl::subdoc::command> specs{};
+    std::optional<std::chrono::milliseconds> timeout{};
+    std::shared_ptr<couchbase::tracing::request_span> parent_span{ nullptr };
+
+    template<typename Core, typename Handler>
+    void execute(Core core, Handler handler)
+    {
+        core->with_bucket_configuration(
+          id.bucket(),
+          [core, id = id, timeout = timeout, specs = specs, parent_span = parent_span, h = std::forward<Handler>(handler)](
+            std::error_code ec, const topology::configuration& config) mutable {
+              if (!config.supports_subdoc_read_replica()) {
+                  ec = errc::common::feature_not_available;
+              }
+
+              if (ec) {
+                  std::optional<std::string> first_error_path{};
+                  std::optional<std::size_t> first_error_index{};
+                  return h(response_type{
+                    make_subdocument_error_context(make_key_value_error_context(ec, id), ec, first_error_path, first_error_index, false) });
+              }
+              using handler_type = utils::movable_function<void(response_type)>;
+
+              struct replica_context {
+                  replica_context(handler_type handler, std::uint32_t expected_responses)
+                    : handler_(std::move(handler))
+                    , expected_responses_(expected_responses)
+                  {
+                  }
+
+                  handler_type handler_;
+                  std::uint32_t expected_responses_;
+                  bool done_{ false };
+                  std::mutex mutex_{};
+                  std::vector<lookup_in_all_replicas_response::entry> result_{};
+              };
+              auto ctx = std::make_shared<replica_context>(std::move(h), config.num_replicas.value_or(0U) + 1U);
+
+              for (std::size_t idx = 1U; idx <= config.num_replicas.value_or(0U); ++idx) {
+                  document_id replica_id{ id };
+                  replica_id.node_index(idx);
+                  core->execute(impl::lookup_in_replica_request{ std::move(replica_id), specs, timeout, parent_span },
+                                [ctx](impl::lookup_in_replica_response&& resp) {
+                                    handler_type local_handler{};
+                                    {
+                                        std::scoped_lock lock(ctx->mutex_);
+                                        if (ctx->done_) {
+                                            return;
+                                        }
+                                        --ctx->expected_responses_;
+                                        if (resp.ctx.ec()) {
+                                            if (ctx->expected_responses_ > 0) {
+                                                // just ignore the response
+                                                return;
+                                            }
+                                        } else {
+                                            lookup_in_all_replicas_response::entry top_entry{};
+                                            top_entry.cas = resp.cas;
+                                            top_entry.deleted = resp.deleted;
+                                            top_entry.is_replica = true;
+                                            for (auto& field : resp.fields) {
+                                                lookup_in_all_replicas_response::entry::lookup_in_entry lookup_in_entry{};
+                                                lookup_in_entry.path = field.path;
+                                                lookup_in_entry.value = field.value;
+                                                lookup_in_entry.status = field.status;
+                                                lookup_in_entry.ec = field.ec;
+                                                lookup_in_entry.exists = field.exists;
+                                                lookup_in_entry.original_index = field.original_index;
+                                                lookup_in_entry.opcode = field.opcode;
+                                                top_entry.fields.emplace_back(lookup_in_entry);
+                                            }
+                                            ctx->result_.emplace_back(lookup_in_all_replicas_response::entry{ top_entry });
+                                        }
+                                        if (ctx->expected_responses_ == 0) {
+                                            ctx->done_ = true;
+                                            std::swap(local_handler, ctx->handler_);
+                                        }
+                                    }
+                                    if (local_handler) {
+                                        return local_handler({ std::move(resp.ctx), std::move(ctx->result_) });
+                                    }
+                                });
+              }
+
+              core->execute(lookup_in_request{ document_id{ id }, {}, {}, false, specs, timeout }, [ctx](lookup_in_response&& resp) {
+                  handler_type local_handler{};
+                  {
+                      std::scoped_lock lock(ctx->mutex_);
+                      if (ctx->done_) {
+                          return;
+                      }
+                      --ctx->expected_responses_;
+                      if (resp.ctx.ec()) {
+                          if (ctx->expected_responses_ > 0) {
+                              // just ignore the response
+                              return;
+                          }
+                      } else {
+                          lookup_in_all_replicas_response::entry top_entry{};
+                          top_entry.cas = resp.cas;
+                          top_entry.deleted = resp.deleted;
+                          top_entry.is_replica = false;
+                          for (auto& field : resp.fields) {
+                              lookup_in_all_replicas_response::entry::lookup_in_entry lookup_in_entry{};
+                              lookup_in_entry.path = field.path;
+                              lookup_in_entry.value = field.value;
+                              lookup_in_entry.status = field.status;
+                              lookup_in_entry.ec = field.ec;
+                              lookup_in_entry.exists = field.exists;
+                              lookup_in_entry.original_index = field.original_index;
+                              lookup_in_entry.opcode = field.opcode;
+                              top_entry.fields.emplace_back(lookup_in_entry);
+                          }
+                          ctx->result_.emplace_back(lookup_in_all_replicas_response::entry{ top_entry });
+                      }
+                      if (ctx->expected_responses_ == 0) {
+                          ctx->done_ = true;
+                          std::swap(local_handler, ctx->handler_);
+                      }
+                  }
+                  if (local_handler) {
+                      return local_handler({ std::move(resp.ctx), std::move(ctx->result_) });
+                  }
+              });
+          });
+    }
+};
+
+template<>
+struct is_compound_operation<lookup_in_all_replicas_request> : public std::true_type {
+};
+} // namespace couchbase::core::operations

package/deps/couchbase-cxx-client/core/operations/document_lookup_in_any_replica.hxx

@@ -0,0 +1,188 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-2021 Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#pragma once
+
+#include "core/error_context/key_value.hxx"
+#include "core/impl/lookup_in_replica.hxx"
+#include "core/impl/subdoc/command.hxx"
+#include "core/operations/document_lookup_in.hxx"
+#include "core/operations/operation_traits.hxx"
+#include "core/utils/movable_function.hxx"
+#include "couchbase/codec/encoded_value.hxx"
+#include "couchbase/error_codes.hxx"
+
+#include <functional>
+#include <memory>
+#include <mutex>
+
+namespace couchbase::core::operations
+{
+struct lookup_in_any_replica_response {
+    struct entry {
+        std::string path;
+        codec::binary value;
+        std::size_t original_index;
+        bool exists;
+        protocol::subdoc_opcode opcode;
+        key_value_status_code status;
+        std::error_code ec{};
+    };
+    subdocument_error_context ctx{};
+    couchbase::cas cas{};
+    std::vector<entry> fields{};
+    bool deleted{ false };
+    bool is_replica{ true };
+};
+
+struct lookup_in_any_replica_request {
+    using response_type = lookup_in_any_replica_response;
+    using encoded_request_type = core::protocol::client_request<core::protocol::lookup_in_replica_request_body>;
+    using encoded_response_type = core::protocol::client_response<core::protocol::lookup_in_replica_response_body>;
+
+    core::document_id id;
+    std::vector<couchbase::core::impl::subdoc::command> specs{};
+    std::optional<std::chrono::milliseconds> timeout{};
+    std::shared_ptr<couchbase::tracing::request_span> parent_span{ nullptr };
+
+    template<typename Core, typename Handler>
+    void execute(Core core, Handler handler)
+    {
+        core->with_bucket_configuration(
+          id.bucket(),
+          [core, id = id, timeout = timeout, specs = specs, parent_span = parent_span, h = std::forward<Handler>(handler)](
+            std::error_code ec, const topology::configuration& config) mutable {
+              if (!config.supports_subdoc_read_replica()) {
+                  ec = errc::common::feature_not_available;
+              }
+              if (specs.size() > 16) {
+                  ec = errc::common::invalid_argument;
+              }
+
+              if (ec) {
+                  std::optional<std::string> first_error_path{};
+                  std::optional<std::size_t> first_error_index{};
+                  return h(response_type{
+                    make_subdocument_error_context(make_key_value_error_context(ec, id), ec, first_error_path, first_error_index, false) });
+              }
+              using handler_type = utils::movable_function<void(response_type)>;
+
+              struct replica_context {
+                  replica_context(handler_type&& handler, std::uint32_t expected_responses)
+                    : handler_(std::move(handler))
+                    , expected_responses_(expected_responses)
+                  {
+                  }
+
+                  handler_type handler_;
+                  std::uint32_t expected_responses_;
+                  bool done_{ false };
+                  std::mutex mutex_{};
+              };
+              auto ctx = std::make_shared<replica_context>(std::move(h), config.num_replicas.value_or(0U) + 1U);
+
+              for (std::size_t idx = 1U; idx <= config.num_replicas.value_or(0U); ++idx) {
+                  document_id replica_id{ id };
+                  replica_id.node_index(idx);
+                  core->execute(impl::lookup_in_replica_request{ std::move(replica_id), specs, timeout, parent_span },
+                                [ctx](impl::lookup_in_replica_response&& resp) {
+                                    handler_type local_handler;
+                                    {
+                                        std::scoped_lock lock(ctx->mutex_);
+                                        if (ctx->done_) {
+                                            return;
+                                        }
+                                        --ctx->expected_responses_;
+                                        if (resp.ctx.ec()) {
+                                            if (ctx->expected_responses_ > 0) {
+                                                // just ignore the response
+                                                return;
+                                            }
+                                            // consider document irretrievable and give up
+                                            resp.ctx.override_ec(errc::key_value::document_irretrievable);
+                                        }
+                                        ctx->done_ = true;
+                                        std::swap(local_handler, ctx->handler_);
+                                    }
+                                    if (local_handler) {
+                                        response_type res{};
+                                        res.ctx = resp.ctx;
+                                        res.cas = resp.cas;
+                                        res.deleted = resp.deleted;
+                                        res.is_replica = true;
+                                        for (auto& field : resp.fields) {
+                                            auto lookup_in_entry = lookup_in_any_replica_response::entry{};
+                                            lookup_in_entry.path = field.path;
+                                            lookup_in_entry.value = field.value;
+                                            lookup_in_entry.status = field.status;
+                                            lookup_in_entry.ec = field.ec;
+                                            lookup_in_entry.exists = field.exists;
+                                            lookup_in_entry.original_index = field.original_index;
+                                            lookup_in_entry.opcode = field.opcode;
+                                            res.fields.emplace_back(lookup_in_entry);
+                                        }
+                                        return local_handler(res);
+                                    }
+                                });
+              }
+              core->execute(lookup_in_request{ id, {}, {}, false, specs, timeout }, [ctx](lookup_in_response&& resp) {
+                  handler_type local_handler{};
+                  {
+                      std::scoped_lock lock(ctx->mutex_);
+                      if (ctx->done_) {
+                          return;
+                      }
+                      --ctx->expected_responses_;
+                      if (resp.ctx.ec()) {
+                          if (ctx->expected_responses_ > 0) {
+                              // just ignore the response
+                              return;
+                          }
+                          // consider document irretrievable and give up
+                          resp.ctx.override_ec(errc::key_value::document_irretrievable);
+                      }
+                      ctx->done_ = true;
+                      std::swap(local_handler, ctx->handler_);
+                  }
+                  if (local_handler) {
+                      auto res = response_type{};
+                      res.ctx = resp.ctx;
+                      res.cas = resp.cas;
+                      res.deleted = resp.deleted;
+                      res.is_replica = false;
+                      for (auto& field : resp.fields) {
+                          auto lookup_in_entry = lookup_in_any_replica_response::entry{};
+                          lookup_in_entry.path = field.path;
+                          lookup_in_entry.value = field.value;
+                          lookup_in_entry.status = field.status;
+                          lookup_in_entry.ec = field.ec;
+                          lookup_in_entry.exists = field.exists;
+                          lookup_in_entry.original_index = field.original_index;
+                          lookup_in_entry.opcode = field.opcode;
+                          res.fields.emplace_back(lookup_in_entry);
+                      }
+                      return local_handler(res);
+                  }
+              });
+          });
+    }
+};
+
+template<>
+struct is_compound_operation<lookup_in_any_replica_request> : public std::true_type {
+};
+} // namespace couchbase::core::operations

package/deps/couchbase-cxx-client/core/operations.hxx

@@ -30,6 +30,8 @@
 #include "core/operations/document_increment.hxx"
 #include "core/operations/document_insert.hxx"
 #include "core/operations/document_lookup_in.hxx"
+#include "core/operations/document_lookup_in_all_replicas.hxx"
+#include "core/operations/document_lookup_in_any_replica.hxx"
 #include "core/operations/document_mutate_in.hxx"
 #include "core/operations/document_prepend.hxx"
 #include "core/operations/document_query.hxx"

package/deps/couchbase-cxx-client/core/protocol/cmd_hello.hxx

@@ -71,6 +71,7 @@ class hello_request_body
         hello_feature::collections,
         hello_feature::subdoc_create_as_deleted,
         hello_feature::preserve_ttl,
+        hello_feature::subdoc_replica_read,
     };
     std::vector<std::byte> value_;
 

package/deps/couchbase-cxx-client/core/protocol/cmd_lookup_in_replica.cxx

@@ -0,0 +1,107 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-2021 Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#include "cmd_lookup_in_replica.hxx"
+
+#include "core/utils/byteswap.hxx"
+#include "core/utils/unsigned_leb128.hxx"
+
+#include <cstring>
+#include <gsl/assert>
+
+namespace couchbase::core::protocol
+{
+bool
+lookup_in_replica_response_body::parse(key_value_status_code status,
+                                       const header_buffer& header,
+                                       std::uint8_t framing_extras_size,
+                                       std::uint16_t key_size,
+                                       std::uint8_t extras_size,
+                                       const std::vector<std::byte>& body,
+                                       const cmd_info& /* info */)
+{
+    Expects(header[1] == static_cast<std::byte>(opcode));
+    if (status == key_value_status_code::success || status == key_value_status_code::subdoc_multi_path_failure ||
+        status == key_value_status_code::subdoc_success_deleted || status == key_value_status_code::subdoc_multi_path_failure_deleted) {
+        using offset_type = std::vector<std::byte>::difference_type;
+        offset_type offset = framing_extras_size + key_size + extras_size;
+        fields_.reserve(16); /* we won't have more than 16 entries anyway */
+        while (static_cast<std::size_t>(offset) < body.size()) {
+            lookup_in_field field;
+
+            std::uint16_t entry_status = 0;
+            memcpy(&entry_status, body.data() + offset, sizeof(entry_status));
+            entry_status = utils::byte_swap(entry_status);
+            Expects(is_valid_status(entry_status));
+            field.status = static_cast<key_value_status_code>(entry_status);
+            offset += static_cast<offset_type>(sizeof(entry_status));
+
+            std::uint32_t entry_size = 0;
+            memcpy(&entry_size, body.data() + offset, sizeof(entry_size));
+            entry_size = utils::byte_swap(entry_size);
+            Expects(entry_size < 20 * 1024 * 1024);
+            offset += static_cast<offset_type>(sizeof(entry_size));
+
+            field.value.resize(entry_size);
+            memcpy(field.value.data(), body.data() + offset, entry_size);
+            offset += static_cast<offset_type>(entry_size);
+
+            fields_.emplace_back(field);
+        }
+        return true;
+    }
+    return false;
+}
+
+void
+lookup_in_replica_request_body::id(const document_id& id)
+{
+    key_ = make_protocol_key(id);
+}
+
+void
+lookup_in_replica_request_body::fill_extras()
+{
+    if (flags_ != 0) {
+        extras_.resize(sizeof(flags_));
+        extras_[0] = std::byte{ flags_ };
+    }
+}
+
+void
+lookup_in_replica_request_body::fill_value()
+{
+    size_t value_size = 0;
+    for (const auto& spec : specs_) {
+        value_size += sizeof(spec.opcode_) + sizeof(std::uint8_t) + sizeof(std::uint16_t) + spec.path_.size();
+    }
+    Expects(value_size > 0);
+    value_.resize(value_size);
+    std::vector<std::byte>::size_type offset = 0;
+    for (const auto& spec : specs_) {
+        value_[offset] = static_cast<std::byte>(spec.opcode_);
+        ++offset;
+        value_[offset] = spec.flags_;
+        ++offset;
+        std::uint16_t path_size = utils::byte_swap(gsl::narrow_cast<std::uint16_t>(spec.path_.size()));
+        std::memcpy(value_.data() + offset, &path_size, sizeof(path_size));
+        offset += sizeof(path_size);
+        std::memcpy(value_.data() + offset, spec.path_.data(), spec.path_.size());
+        offset += spec.path_.size();
+    }
+}
+} // namespace couchbase::core::protocol

package/deps/couchbase-cxx-client/core/protocol/cmd_lookup_in_replica.hxx

@@ -0,0 +1,137 @@
+/* -*- Mode: C++; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ *   Copyright 2020-2021 Couchbase, Inc.
+ *
+ *   Licensed under the Apache License, Version 2.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+#pragma once
+
+#include "client_opcode.hxx"
+#include "cmd_info.hxx"
+#include "core/document_id.hxx"
+#include "core/impl/subdoc/command.hxx"
+#include "core/io/mcbp_message.hxx"
+#include "status.hxx"
+
+#include <gsl/assert>
+
+namespace couchbase::core::protocol
+{
+
+class lookup_in_replica_response_body
+{
+  public:
+    static const inline client_opcode opcode = client_opcode::subdoc_multi_lookup;
+
+    struct lookup_in_field {
+        key_value_status_code status{};
+        std::string value;
+    };
+
+  private:
+    std::vector<lookup_in_field> fields_{};
+
+  public:
+    [[nodiscard]] const std::vector<lookup_in_field>& fields() const
+    {
+        return fields_;
+    }
+
+    [[nodiscard]] bool parse(key_value_status_code status,
+                             const header_buffer& header,
+                             std::uint8_t framing_extras_size,
+                             std::uint16_t key_size,
+                             std::uint8_t extras_size,
+                             const std::vector<std::byte>& body,
+                             const cmd_info& info);
+};
+
+class lookup_in_replica_request_body
+{
+  public:
+    using response_body_type = lookup_in_replica_response_body;
+    static const inline client_opcode opcode = client_opcode::subdoc_multi_lookup;
+
+    /**
+     * Tells the server to operate on replica vbucket instead of active
+     */
+    static const inline std::uint8_t doc_flag_replica_read = 0b0010'0000;
+
+  private:
+    std::vector<std::byte> key_;
+    std::vector<std::byte> extras_{};
+    std::vector<std::byte> value_{};
+
+    std::uint8_t flags_{ 0 };
+    std::vector<couchbase::core::impl::subdoc::command> specs_;
+
+  public:
+    void id(const document_id& id);
+
+    void read_replica(bool value)
+    {
+        if (value) {
+            flags_ = flags_ | doc_flag_replica_read;
+        }
+    }
+
+    void specs(const std::vector<couchbase::core::impl::subdoc::command>& specs)
+    {
+        specs_ = specs;
+    }
+
+    [[nodiscard]] const auto& key() const
+    {
+        return key_;
+    }
+
+    [[nodiscard]] const auto& framing_extras() const
+    {
+        return empty_buffer;
+    }
+
+    [[nodiscard]] const auto& extras()
+    {
+        if (extras_.empty()) {
+            fill_extras();
+        }
+        return extras_;
+    }
+
+    [[nodiscard]] const auto& value()
+    {
+        if (value_.empty()) {
+            fill_value();
+        }
+        return value_;
+    }
+
+    [[nodiscard]] std::size_t size()
+    {
+        if (extras_.empty()) {
+            fill_extras();
+        }
+        if (value_.empty()) {
+            fill_value();
+        }
+        return key_.size() + extras_.size() + value_.size();
+    }
+
+  private:
+    void fill_extras();
+
+    void fill_value();
+};
+
+} // namespace couchbase::core::protocol

package/deps/couchbase-cxx-client/core/protocol/hello_feature.hxx

@@ -155,6 +155,11 @@ enum class hello_feature : std::uint16_t {
     replace_body_with_xattr = 0x19,
 
     resource_units = 0x1a,
+
+    /**
+     * Indicates support for subdoc lookup operations on replicas
+     */
+    subdoc_replica_read = 0x1c,
 };
 
 constexpr bool
@@ -185,6 +190,7 @@ is_valid_hello_feature(std::uint16_t code)
         case hello_feature::subdoc_document_macro_support:
         case hello_feature::replace_body_with_xattr:
         case hello_feature::resource_units:
+        case hello_feature::subdoc_replica_read:
             return true;
     }
     return false;

package/deps/couchbase-cxx-client/core/protocol/hello_feature_fmt.hxx

@@ -106,6 +106,9 @@ struct fmt::formatter<couchbase::core::protocol::hello_feature> {
             case couchbase::core::protocol::hello_feature::resource_units:
                 name = "resource_units";
                 break;
+            case couchbase::core::protocol::hello_feature::subdoc_replica_read:
+                name = "subdoc_replica_read";
+                break;
         }
         return format_to(ctx.out(), "{}", name);
     }