couchbase 3.2.5 → 3.2.7

package/deps/lcb/CMakeLists.txt

@@ -30,7 +30,7 @@ CMAKE_MINIMUM_REQUIRED(VERSION 3.5.1)
 # Couchbase mock path to download
 SET(COUCHBASE_MOCK_VERSION 1.5.25)
 SET(COUCHBASE_MOCK_URL "https://github.com/couchbase/CouchbaseMock/releases/download/${COUCHBASE_MOCK_VERSION}/CouchbaseMock-${COUCHBASE_MOCK_VERSION}.jar")
-project(libcouchbase VERSION 3.2.5 LANGUAGES C CXX)
+project(libcouchbase VERSION 3.3.4 LANGUAGES C CXX)
 
 if (NOT CMAKE_VERSION VERSION_LESS "3.13")
     # CMP0077: option() honors normal variables
@@ -278,20 +278,30 @@ ELSE()
         # and set the appropriate OpenSSL variables
         IF(APPLE)
             IF(NOT OpenSSL_DIR)
-                EXECUTE_PROCESS(COMMAND brew --prefix openssl
+                EXECUTE_PROCESS(COMMAND brew --prefix openssl@1.1
                     OUTPUT_VARIABLE OPENSSL_ROOT_DIR
                     OUTPUT_STRIP_TRAILING_WHITESPACE)
                 MESSAGE(STATUS "Found OpenSSL Prefix: ${OPENSSL_ROOT_DIR}")
             ENDIF()
         ENDIF()
         FIND_PACKAGE(OpenSSL)
+        # If it still not found, try to locate it using pkg-config
+        IF(NOT OPENSSL_FOUND AND UNIX)
+            find_package(PkgConfig)
+            IF(PkgConfig_FOUND)
+                pkg_check_modules(OPENSSL openssl11)
+                IF(OPENSSL_FOUND)
+                    SET(OPENSSL_INCLUDE_DIR ${OPENSSL_INCLUDE_DIRS})
+                    SET(OPENSSL_LIBRARIES ${OPENSSL_LINK_LIBRARIES})
+                ENDIF()
+            ENDIF()
+        ENDIF()
     ENDIF(NOT OPENSSL_FOUND)
 
     IF(OPENSSL_FOUND)
         MESSAGE(STATUS "SSL Found: ${OPENSSL_VERSION} (${OPENSSL_LIBRARIES})")
     ELSE()
-        MESSAGE(STATUS "SSL Not Found. SSL support will be disabled")
-        ADD_DEFINITIONS(-DLCB_NO_SSL=1)
+        MESSAGE(FATAL_ERROR "SSL Not Found. Use LCB_NO_SSL to produce build without OpenSSL")
     ENDIF()
 ENDIF()
 
@@ -299,7 +309,14 @@ ADD_SUBDIRECTORY(src/vbucket)
 ADD_SUBDIRECTORY(contrib/cbsasl)
 ADD_SUBDIRECTORY(contrib/cliopts)
 ADD_SUBDIRECTORY(src/ssl)
-ADD_SUBDIRECTORY(contrib/lcb-jsoncpp)
+IF(NOT LCB_JSONCPP_LIB)
+    ADD_SUBDIRECTORY(contrib/lcb-jsoncpp)
+ENDIF()
+IF(NOT LCB_JSONCPP_INCLUDE_DIR)
+    INCLUDE_DIRECTORIES(contrib/lcb-jsoncpp)
+ELSE()
+    INCLUDE_DIRECTORIES(${LCB_JSONCPP_INCLUDE_DIR})
+ENDIF()
 IF(NOT LCB_SNAPPY_LIB)
     ADD_SUBDIRECTORY(contrib/snappy)
 ENDIF()
@@ -344,11 +361,13 @@ SET(LCB_CORE_OBJS
     $<TARGET_OBJECTS:lcbcore>
     $<TARGET_OBJECTS:lcbcore-cxx>
     $<TARGET_OBJECTS:lcb_jsparse>
-    $<TARGET_OBJECTS:lcb_jsoncpp>
     ${LCB_DTRACE_OBJECT}
     ${lcb_plat_objs}
     ${lcb_ssl_objs})
 
+IF(NOT LCB_JSONCPP_LIB)
+    LIST (APPEND LCB_CORE_OBJS $<TARGET_OBJECTS:lcb_jsoncpp>)
+ENDIF()
 IF(NOT LCB_SNAPPY_LIB)
     LIST (APPEND LCB_CORE_OBJS $<TARGET_OBJECTS:lcb_snappy>)
 ENDIF()
@@ -400,6 +419,9 @@ ENDIF()
 IF(LIBPROFILER)
     SET(LCB_LINK_DEPS ${LCB_LINK_DEPS} ${LIBPROFILER})
 ENDIF()
+IF(LCB_JSONCPP_LIB)
+    SET(LCB_LINK_DEPS ${LCB_LINK_DEPS} ${LCB_JSONCPP_LIB})
+ENDIF()
 IF(LCB_SNAPPY_LIB)
     SET(LCB_LINK_DEPS ${LCB_LINK_DEPS} ${LCB_SNAPPY_LIB})
 ENDIF()

package/deps/lcb/README.markdown

@@ -6,6 +6,11 @@ This is the C client library for [Couchbase](http://www.couchbase.com)
 It communicates with the cluster and speaks the relevant protocols
 necessary to connect to the cluster and execute data operations.
 
+## Support and Feedback
+
+If you find an issue, please file it in [our JIRA issue tracker](https://couchbase.com/issues/browse/CCBC). Also you are
+always welcome on [our forum](https://forums.couchbase.com/c/c-sdk) and [Discord](https://discord.com/invite/sQ5qbPZuTh).
+
 ## Features
 
 * Can function as either a synchronous or asynchronous library
@@ -110,15 +115,6 @@ servers the spec will look like `couchbase://localhost,default` or `couchbase://
 Also tests expecting `beer-sample` bucket loaded. It comes with the server. Look at "Sample buckets" section of Admin
 Console.
 
-## Bugs, Support, Issues
-You may report issues in the library in our issue tracker at
-<https://issues.couchbase.com>. Sign up for an account and file an issue
-against the _Couchbase C Client Library_ project.
-
-The developers of the library hang out in IRC on `#libcouchbase` on
-irc.freenode.net.
-
-
 ## Examples
 
 * The `examples` directory

package/deps/lcb/RELEASE_NOTES.markdown

@@ -1,31 +1,99 @@
 # Release Notes
 
+## 3.3.4 (2023-02-08)
+
+* CCBC-1583: disable collections support if KV does not ack it.
+
+## 3.3.3 (2022-09-09)
+
+* CCBC-1565: load system CAs when the trust certificate is not provided
+
+  When the user has not set any root ca provider but is using TLS then we
+  should trust both the system store and the Capella root CA.
+
+* CCBC-1564: update error message for authentication failure
+
+* CCBC-1568: skip logging for closed SSL IO contexts
+
+  OpenSSL might still invoke IO callbacks after the actual context has
+  been closed. This more likely could happen with libuv-style IO.
+
+  This patch ensures that once socket context has been closed, its pointer
+  in SSL object will be erased.
+
+* Added cbc-bucket-list command to list all buckets.
+
+## 3.3.2 (2022-08-29)
+
+* CCBC-1559: cbc-n1qlback: give time to IO loop in case of failure.
+
+  In schenario where all query nodes suddenly failed over and/or removed
+  from the cluster, all requests in cbc-n1qlback will start failing.
+  Because the libcouchbase knows that the latest config does not have any
+  query nodes, it rejects all queries immediately. The single-threaded
+  nature of libcouchbase does not allow the IO loop to run in background,
+  and the code in the tool does not run `lcb_wait` in case of failure.
+
+  As a fix, we run `lcb_tick_nowait` in case of failure, which is enough
+  for libcouchbase to give IO loop a chance to check for any pending
+  events and invoke corresponding callbacks.
+
+* CCBC-1552: Allow building with external jsoncpp
+
+* CCBC-1544: update feedback links: Jira, Forums and Discord
+
+* CCBC-1556: clarify log messages related to config cache
+
+* CCBC-1557: allow caching cluster-level configurations
+    
+  The library will cache cluster-level configurations only if the
+  `config_cache= connection` string option is set to directory (ends
+  with '/' symbol), otherwise it will cache only buckets configurations
+  (note that in this case the application should use unique cache name for
+  each bucket, otherwise the library will ignore cache if the bucket name
+  will not match).
+
+## 3.3.1 (2022-05-25)
+
+* CCBC-1550: Fixed RPM packages for CentOS 7, now they will require OpenSSL 1.1 during build. Also build script will not
+automatically define `LCB_NO_SSL` option if OpenSSL is not found. For builds without TLS support, this option must be
+explicitly defined.
+
+* CCBC-1546: cbc-pillowfight: add '--rand-space-per-thread' to allow threads to work from different rand numbers.
+
+## 3.3.0 (2022-05-09)
+
+* CCBC-1538: use 64-bit integer to store time in IOCP plugin
+* CCBC-1540: bundle capella ca certificate with SDK
+* CCBC-1526: do not validate length of collection specifier. Length will be checked on the server-side. 
+* CCBC-1527: pillowfight: deallocate all memory during shutdown
+
 ## 3.2.5 (2022-02-08)
 
-CCBC-1486: Add support for preserve expiry to query options
-CCBC-1534, CCBC-1411: improve query error handling
-CCBC-1519: pass extra privilege with KV "on-behalf-of".
-CCBC-1521: fix bootstrap process when client cert is used and error map is supported. If client cert auth is used, once
+* CCBC-1486: Add support for preserve expiry to query options
+* CCBC-1534, CCBC-1411: improve query error handling
+* CCBC-1519: pass extra privilege with KV "on-behalf-of".
+* CCBC-1521: fix bootstrap process when client cert is used and error map is supported. If client cert auth is used, once
 the error map response has been received, the negotiation is complete.
-CCBC-1529: load authentication certificate as chain file.
-CCBC-1525: remove stringstream in `collection_qualifier`. Constructing a stringstream object every time
+* CCBC-1529: load authentication certificate as chain file.
+* CCBC-1525: remove stringstream in `collection_qualifier`. Constructing a stringstream object every time
 `collection_qualifier` is constructed is very expensive.
-CCBC-1528: update parsing of "quota limit" error for FTS
+* CCBC-1528: update parsing of "quota limit" error for FTS
 
 ## 3.2.4 (2021-11-23)
 
-CCBC-1522: Filter `DnsQuery` results on Windows by type: only use records with `DNS_TYPE_SRV` type.
+* CCBC-1522: Filter `DnsQuery` results on Windows by type: only use records with `DNS_TYPE_SRV` type.
 
-CCBC-1521: Fixed bootstrap process when client certificate is used. We always pipeline error map request with `HELLO`
+* CCBC-1521: Fixed bootstrap process when client certificate is used. We always pipeline error map request with `HELLO`
 request, and usually await for `hello`+`error_map` responses, because after that goes SASL authentication (and then
 optional selection of the bucket) which cannot be completely pipelined. But in case of client certificate, we might
 terminate bootstrap process too early if the bootstrap process does not require immediate selection of the bucket.
     
-CCBC-1432: Support for rate limiting error codes: `LCB_ERR_RATE_LIMITED` and `LCB_ERR_QUOTA_LIMITED`.
+* CCBC-1432: Support for rate limiting error codes: `LCB_ERR_RATE_LIMITED` and `LCB_ERR_QUOTA_LIMITED`.
 
-CCBC-1514: Do not translate unknown error with "item-only" attribute into `LCB_ERR_CAS_MISMATCH`.
+* CCBC-1514: Do not translate unknown error with "item-only" attribute into `LCB_ERR_CAS_MISMATCH`.
 
-CCBC-1515: Performance optimization: replace `sstream` with string `append()`. Only if list of IO vectors supplied for
+* CCBC-1515: Performance optimization: replace `sstream` with string `append()`. Only if list of IO vectors supplied for
 value in mutation operations.
 
 ## 3.2.3 (2021-10-20)

package/deps/lcb/cmake/Modules/GetVersionInfo.cmake

@@ -65,7 +65,7 @@ IF(APPLE)
 ELSE()
     SET(LCB_SONAME_MAJOR "8")
 ENDIF()
-SET(LCB_SONAME_FULL "${LCB_SONAME_MAJOR}.0.6")
+SET(LCB_SONAME_FULL "${LCB_SONAME_MAJOR}.0.11")
 
 MESSAGE(STATUS "libcouchbase ${LCB_VERSION_MAJOR},${LCB_VERSION_MINOR},${LCB_VERSION_PATCH}")
 MESSAGE(STATUS "Building libcouchbase ${LCB_VERSION}/${LCB_VERSION_CHANGESET}")

package/deps/lcb/doc/Doxyfile

@@ -38,7 +38,7 @@ PROJECT_NAME           = "Couchbase C Client"
 # could be handy for archiving the generated documentation or if some version
 # control system is used.
 
-PROJECT_NUMBER         = 3.2.5
+PROJECT_NUMBER         = 3.3.4
 
 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a

package/deps/lcb/doc/cbc.markdown

@@ -20,6 +20,7 @@
 `cbc lock` _KEY_ [_OPTIONS_]<br>
 `cbc unlock` _KEY_ _CAS_ [_OPTIONS_]<br>
 `cbc admin` _-P PASSWORD_ _RESTAPI_ [_OPTIONS_]<br>
+`cbc bucket-list` _-P PASSWORD_ [_OPTIONS_]<br>
 `cbc bucket-create` _-P PASSWORD_ _NAME_ [_OPTIONS_]<br>
 `cbc bucket-delete` _-P PASSWORD_ _NAME_ [_OPTIONS_]<br>
 `cbc bucket-flush` _NAME_ [_OPTIONS_]<br>
@@ -362,6 +363,15 @@ In addition to the [OPTIONS](#OPTIONS) specified above, the following options ar
   Specify the HTTP method to use for the specific request. The default method is
   `GET`.
 
+### bucket-list
+
+List the buckets in the cluster
+
+In addition to the [OPTIONS](#OPTIONS) specified above, the following options are recognized:
+
+* `-r`, `--raw`:
+  Print unformatted server response in JSON form.
+
 ### bucket-create
 
 Create a bucket in the cluster.

package/deps/lcb/gyp_config/common/libcouchbase/configuration.h

@@ -33,7 +33,7 @@
  */
 
 /** @brief libcouchbase version string */
-#define LCB_VERSION_STRING "3.2.5-njs"
+#define LCB_VERSION_STRING "3.3.4-njs"
 
 /**@brief libcouchbase hex version
  *
@@ -50,12 +50,12 @@
  * 2.1.3	| 0x020103
  * 3.0.15	| 0x030015
  */
-#define LCB_VERSION 0x030205
+#define LCB_VERSION 0x030304
 
 /**@brief The SCM revision ID
  * @see LCB_CNTL_CHANGESET
  */
-#define LCB_VERSION_CHANGESET "e4de408c96550b48745b3a142d9827c898d4e96f"
+#define LCB_VERSION_CHANGESET "9bf9ef8624757474d57b06624fc55e470340d9dd"
 
 /**@brief The client ID
  */

package/deps/lcb/include/libcouchbase/error.h

@@ -72,7 +72,7 @@ X(LCB_ERR_REQUEST_CANCELED,         202, LCB_ERROR_TYPE_SHARED, 0, "A request is
 X(LCB_ERR_INVALID_ARGUMENT,         203, LCB_ERROR_TYPE_SHARED, LCB_ERROR_FLAG_INPUT, "It is unambiguously determined that the error was caused because of invalid arguments from the user") \
 X(LCB_ERR_SERVICE_NOT_AVAILABLE,    204, LCB_ERROR_TYPE_SHARED, 0, "It was determined from the config unambiguously that the service is not available") \
 X(LCB_ERR_INTERNAL_SERVER_FAILURE,  205, LCB_ERROR_TYPE_SHARED, 0, "Internal server error") \
-X(LCB_ERR_AUTHENTICATION_FAILURE,   206, LCB_ERROR_TYPE_SHARED, LCB_ERROR_FLAG_INPUT, "Authentication error") \
+X(LCB_ERR_AUTHENTICATION_FAILURE,   206, LCB_ERROR_TYPE_SHARED, LCB_ERROR_FLAG_INPUT, "Authentication error. Possible reasons: incorrect authentication configuration, bucket doesn't exist or bucket may be hibernated.") \
 X(LCB_ERR_TEMPORARY_FAILURE,        207, LCB_ERROR_TYPE_SHARED, LCB_ERROR_FLAG_TRANSIENT, "Temporary failure") \
 X(LCB_ERR_PARSING_FAILURE,          208, LCB_ERROR_TYPE_SHARED, 0, "Parsing failed") \
 X(LCB_ERR_CAS_MISMATCH,             209, LCB_ERROR_TYPE_SHARED, LCB_ERROR_FLAG_INPUT, "CAS mismatch") \

package/deps/lcb/packaging/rpm/libcouchbase.spec.in

@@ -15,7 +15,7 @@ BuildRequires: cmake >= 3.5.1
 
 BuildRequires: pkgconfig(libevent) >= 2
 BuildRequires: libev-devel >= 3
-BuildRequires: openssl-devel
+BuildRequires: openssl11-devel
 BuildRequires: systemtap-sdt-devel, systemtap-devel
 URL: https://developer.couchbase.com/server/other-products/release-notes-archives/c-sdk
 Source: https://packages.couchbase.com/clients/c/@TARREDAS@.tar.gz

package/deps/lcb/plugins/io/iocp/iocp_iops.h

@@ -155,7 +155,7 @@ int iocp_w32err_2errno(DWORD error);
 DWORD iocp_set_last_error(lcb_io_opt_t io, SOCKET sock);
 
 /** Get current timestamp in microseconds */
-lcb_U32 iocp_micros(void);
+uint64_t iocp_micros(void);
 
 /** Get current timestamp in milliseconds */
 #define iocp_millis() (iocp_micros() / 1000)

package/deps/lcb/plugins/io/iocp/iocp_loop.c

@@ -209,9 +209,9 @@ static void deque_expired_timers(iocp_t *io, lcb_U64 now)
 /** Maximum amount of time the I/O can hog the loop */
 #define IOCP_IOLOOP_MAXTIME 1000
 
-static int should_yield(lcb_U32 start)
+static int should_yield(uint64_t start)
 {
-    lcb_U32 now = iocp_micros();
+    uint64_t now = iocp_micros();
     return now - start > IOCP_IOLOOP_MAXTIME;
 }
 
@@ -238,7 +238,7 @@ static void iocp_run_loop(lcb_io_opt_t iobase, int is_tick)
 
     do {
         /** To ensure we don't starve pending timers, use an iteration */
-        lcb_U32 usStartTime;
+        uint64_t usStartTime;
 
         if (!now) {
             now = iocp_millis();

package/deps/lcb/plugins/io/iocp/iocp_util.c

@@ -44,9 +44,9 @@ DWORD iocp_set_last_error(lcb_io_opt_t io, SOCKET sock)
     return werr;
 }
 
-lcb_uint32_t iocp_micros(void)
+uint64_t iocp_micros(void)
 {
-    return (lcb_uint32_t)(gethrtime() / 1000);
+    return gethrtime() / 1000;
 }
 
 LPFN_CONNECTEX iocp_initialize_connectex(SOCKET sock)

package/deps/lcb/src/bucketconfig/bc_file.cc

@@ -45,6 +45,7 @@ struct FileProvider : Provider, Listener {
         }
     }
     void write_cache(lcbvb_CONFIG *cfg);
+    void mkcachefile(const char *name, const char *bucket);
 
     /* Overrides */
     ConfigInfo *get_cached() override;
@@ -58,6 +59,7 @@ struct FileProvider : Provider, Listener {
     int last_errno;
     bool is_readonly; /* Whether the config cache should _not_ overwrite the file */
     lcb::io::Timer<FileProvider, &FileProvider::reload_cache> timer;
+    bool do_not_cache_cluster{true};
 };
 
 FileProvider::Status FileProvider::load_cache()
@@ -70,7 +72,9 @@ FileProvider::Status FileProvider::load_cache()
 
     if (!ifs.is_open() || !ifs.good()) {
         int save_errno = last_errno = errno;
-        lcb_log(LOGARGS(this, ERROR), LOGFMT "Couldn't open for reading: %s", LOGID(this), strerror(save_errno));
+        lcb_log(LOGARGS(this, WARN),
+                LOGFMT "Couldn't open config cache for reading (%s). Proceed to next configuration provider.",
+                LOGID(this), strerror(save_errno));
         return CACHE_ERROR;
     }
 
@@ -118,17 +122,26 @@ FileProvider::Status FileProvider::load_cache()
         goto GT_DONE;
     }
 
-    if (lcbvb_get_distmode(vbc) != LCBVB_DIST_VBUCKET) {
+    if (lcbvb_get_distmode(vbc) == LCBVB_DIST_KETAMA) {
         lcb_log(LOGARGS(this, ERROR), LOGFMT "Not applying cached memcached config", LOGID(this));
         goto GT_DONE;
     }
 
-    if (settings().bucket == nullptr) {
-        lcb_log(LOGARGS(this, ERROR), LOGFMT "Bucket name is nullptr", LOGID(this));
+    if (settings().bucket == nullptr && vbc->bname != nullptr) {
+        lcb_log(
+            LOGARGS(this, DEBUG),
+            LOGFMT
+            "The cached configuration has bucket associated, but the connection does not have it. Ignore the cache.",
+            LOGID(this));
         goto GT_DONE;
-    }
-
-    if (strcmp(vbc->bname, settings().bucket) != 0) {
+    } else if (settings().bucket != nullptr && vbc->bname == nullptr) {
+        lcb_log(
+            LOGARGS(this, DEBUG),
+            LOGFMT
+            "The connection has bucket associated, but the cached configuration does not have it. Ignore the cache.",
+            LOGID(this));
+        goto GT_DONE;
+    } else if (settings().bucket != nullptr && vbc->bname != nullptr && strcmp(vbc->bname, settings().bucket) != 0) {
         lcb_log(LOGARGS(this, ERROR), LOGFMT "Bucket name in file is different from the one requested", LOGID(this));
         goto GT_DONE;
     }
@@ -152,7 +165,7 @@ GT_DONE:
 
 void FileProvider::write_cache(lcbvb_CONFIG *cfg)
 {
-    if (filename.empty() || is_readonly || cfg->bname == nullptr || cfg->bname_len == 0) {
+    if (filename.empty() || is_readonly || (do_not_cache_cluster && parent->settings->conntype == LCB_TYPE_CLUSTER)) {
         return;
     }
 
@@ -234,7 +247,7 @@ FileProvider::FileProvider(Confmon *parent_)
     parent->add_listener(this);
 }
 
-static std::string mkcachefile(const char *name, const char *bucket)
+void FileProvider::mkcachefile(const char *name, const char *bucket)
 {
     std::string buffer;
     bool is_dir = false;
@@ -252,22 +265,23 @@ static std::string mkcachefile(const char *name, const char *bucket)
         is_dir = true;
     }
     if (is_dir) {
+        // append bucket name only if we know that cachefile is directory
         if (bucket == nullptr) {
-            return "";
+            buffer += ".cluster";
+            do_not_cache_cluster = false;
+        } else {
+            buffer += bucket;
         }
-        // append bucket name only if we know that
-        // cachefile is directory
-        buffer += bucket;
     }
 
-    return buffer;
+    filename = buffer;
 }
 
 bool lcb::clconfig::file_set_filename(Provider *p, const char *f, bool ro)
 {
     auto *provider = static_cast<FileProvider *>(p);
     provider->enabled = true;
-    provider->filename = mkcachefile(f, p->parent->settings->bucket);
+    provider->mkcachefile(f, p->parent->settings->bucket);
     if (provider->filename.empty()) {
         return false;
     }

package/deps/lcb/src/capi/collection_qualifier.hh

@@ -122,9 +122,6 @@ struct collection_qualifier {
             /* nullptr/0 for collection is mapped to default collection */
             return true;
         }
-        if (element_len < 1 || element_len > 30) {
-            return false;
-        }
         for (size_t i = 0; i < element_len; ++i) {
             if (!is_valid_collection_char(element[i])) {
                 return false;

package/deps/lcb/src/instance.cc

@@ -466,6 +466,25 @@ lcb_STATUS lcb_create(lcb_INSTANCE **instance, const lcb_CREATEOPTS *options)
         goto GT_DONE;
     }
 
+    {
+        // Warn users if they attempt to use Capella without TLS being enabled.
+        bool is_capella = false;
+        static std::string suffix = "cloud.couchbase.com";
+        for (auto &node : spec.hosts()) {
+            auto pos = node.hostname.find(suffix);
+            if (pos != std::string::npos && pos + suffix.size() == node.hostname.size()) {
+                is_capella = true;
+                break;
+            }
+        }
+
+        if (is_capella && (spec.sslopts() & LCB_SSL_ENABLED) == 0) {
+            lcb_log(LOGARGS(obj, INFO),
+                    "TLS is required when connecting to Couchbase Capella. Please enable TLS by prefixing "
+                    "the connection string with \"couchbases://\" (note the final 's').");
+        }
+    }
+
     if ((obj = (lcb_INSTANCE *)calloc(1, sizeof(*obj))) == nullptr) {
         err = LCB_ERR_NO_MEMORY;
         goto GT_DONE;

package/deps/lcb/src/mcserver/mcserver.cc

@@ -990,6 +990,11 @@ void Server::handle_connected(lcbio_SOCKET *sock, lcb_STATUS err, lcbio_OSERR sy
         connreq = SessionRequest::start(sock, settings, settings->config_node_timeout, on_connected, this);
         return;
     } else {
+        if (settings->use_collections && !sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_COLLECTIONS)) {
+            settings->use_collections = 0;
+            lcb_log(LOGARGS_T(DEBUG), "<%s:%s> (SRV=%p) Disable collections support as not every node support it",
+                    curhost->host, curhost->port, (void *)this);
+        }
         jsonsupport = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_JSON);
         compsupport = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_SNAPPY);
         mutation_tokens = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_MUTATION_SEQNO);

package/deps/lcb/src/operations/ping.cc

@@ -69,7 +69,7 @@ LIBCOUCHBASE_API lcb_STATUS lcb_respping_result_id(const lcb_RESPPING *resp, siz
         return LCB_ERR_OPTIONS_CONFLICT;
     }
     *endpoint_id = resp->services[index].id;
-    *endpoint_id_len = strlen(*endpoint_id);
+    *endpoint_id_len = *endpoint_id == nullptr ? 0 : strlen(*endpoint_id);
     return LCB_SUCCESS;
 }
 
@@ -100,7 +100,7 @@ LIBCOUCHBASE_API lcb_STATUS lcb_respping_result_local(const lcb_RESPPING *resp,
         return LCB_ERR_OPTIONS_CONFLICT;
     }
     *address = resp->services[index].local;
-    *address_len = strlen(*address);
+    *address_len = *address == nullptr ? 0 : strlen(*address);
     return LCB_SUCCESS;
 }
 

package/deps/lcb/src/settings.cc

@@ -106,6 +106,7 @@ void lcb_settings_unref(lcb_settings *settings)
     }
     free(settings->bucket);
     free(settings->sasl_mech_force);
+    free(settings->truststorepath);
     free(settings->certpath);
     free(settings->keypath);
     free(settings->client_string);