corebasic 1.0.26 → 1.0.28

package/libs/auth.js

@@ -13,7 +13,7 @@ module.exports.validate = (callback, errMessage) => {
 module.exports.start = (app, successCallback) => {
     app.post("/login", async (req, res) => {
         if (validateFn && !validateFn(req)) {
-            res.status(406).json({ mode: 'login', success: false, msg: validateErrMessage ?? 'Validation Failed' })
+            res.status(401).json({ mode: 'login', success: false, info: validateErrMessage ?? 'Validation Failed', message: 'Login Server Error' })
             return
         }
         try {
@@ -28,7 +28,7 @@ module.exports.start = (app, successCallback) => {
             } else
                 res.json(login)
         } catch (err) {
-            return res.status(406).json(err)
+            return res.status(401).json(err)
         }
     })
 }
@@ -38,11 +38,15 @@ async function attemptLogin(req, res) {
     let phone = req.body.phone.trim()
     let time = new Date().getTime()
     let collection = (req.body.app ? req.body.app + '.' : '') + "auth.login"
-    if (req.body.otp) { // verify login
+    let errMessage = {success: false, message: "Login Server Error"}
+    let otpValid = Utils.isEmpty(req.body.otp) ? false : true
+    if (otpValid) { // verify login
         let res = await Elabase.query(collection, { _id: phone, otp: req.body.otp, time: { $gt: time - expiry } })
-        if (res.length) 
+        if (res.length) {
+            try {await Elabase.update(collection, { _id: phone }, { $set: { otp: '' } }) } catch (err) { throw {...errMessage, mode: 'verify', info: 'Cleanup Failed'} }
             return {...res[0], mode: 'verify', success: true, userId: res[0].userId, position: res[0].position, phone: res[0]._id}
-        throw {mode: 'verify', success: false, msg: "Invalid OTP"}
+        }
+        throw {...errMessage, mode: 'verify', info: "Invalid/Expired OTP"}
     } else {            // generate login
         let otp = phone === '0123456789' ? '1234' : otpGenerator.generate(4, { upperCaseAlphabets: false, specialChars: false, digital: true, lowerCaseAlphabets: false });
         if (phone === '0123456789' || await sendOtp(phone, otp)) {
@@ -53,7 +57,7 @@ async function attemptLogin(req, res) {
             await Elabase.update(collection, { _id: phone }, { $set: { otp, time, updatedAt: now }, $setOnInsert: { _id: phone, otp, time, userId, ...meta } }, { upsert: true })
             return {mode: 'login', success: true, userId, expiry, phone}
         }
-        throw {mode: 'login', success: false, msg: "Login Server Error"}
+        throw {...errMessage, mode: 'login', info: 'Generating Info Failed'}
     }
 }
 

package/libs/session.js

@@ -31,7 +31,7 @@ function start(expressApp, allowedUrls) {
                 return next()
             throw null;
         } catch (error) {
-            return res.status(406).json({ message: 'Unauthorized' })
+            return res.status(401).json({ message: 'Unauthorized' })
         }
     })
 
@@ -49,7 +49,7 @@ function start(expressApp, allowedUrls) {
 
         } catch (error) {
             // Access Denied
-            return res.status(406).json({ message: 'Unauthorized' })
+            return res.status(400).json({ message: 'Unauthorized' })
         }
     });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "corebasic",
-  "version": "1.0.26",
+  "version": "1.0.28",
   "description": "",
   "main": "index.js",
   "scripts": {