corebasic 1.0.232 → 1.0.234

package/libs/features.ts

@@ -58,10 +58,10 @@ export type Req = {
     params: FeatureParams
     method: string
     path: string
-    url?: string
-    headers?: Record<string, string | string[] | undefined>
-    query?: Record<string, unknown>
-    on?: (event: string, callback: () => void) => void
+    url: string
+    headers: Record<string, string | string[] | undefined>
+    query: Record<string, unknown>
+    on: (event: string, callback: () => void) => void
 }
 
 type ResJson = (response: unknown) => void
@@ -174,7 +174,7 @@ export const send = async (meta: Partial<FeatureMeta>, feature: string, data?: u
     // return  (await axios[method](`${service}${url}`, payload, {headers: {jwt: SERVICE_ACCESS_TOKEN, service: true}, timeout: 1000 })).data // Worked Earlier, but issue spotted
     if (baseFeature) { // Local call
         let response;
-        let req: ExpressRequest = { body: payload, params: params ?? {}, method, path: url, url: ''}
+        let req: ExpressRequest = { body: payload, params: params ?? {}, method, path: url, url: '', headers: {}, query: {}, on: (_event: string, _callback:()=>void) => {} }
         req = JSON.parse(JSON.stringify(req))
         const callback = (payload: unknown): void => { response = payload }
         const res: ExpressResponse = {
@@ -207,7 +207,7 @@ async function announce() {
     for (let [key, {api,subscribe}] of Object.entries(features))
         exp_features[key] = {api, service: SERVICE_ADDRESS, subscribe, topic: ""}
 
-    await Messaging.subscribe(`${process.env.REDIS_CHANNEL_PREFIX}_SLYP_FEATURES_LIST`, async (message, channel) => {
+    await Messaging.subscribe(`${process.env.REDIS_CHANNEL_PREFIX}_SLYP_FEATURES_LIST`, async (message, _channel) => {
         let {uid, ...msg} = JSON.parse(message) as Record<string, RemoteFeatureEntry> & {uid: string}
         if (uid !== appId && !appids[uid]) {
             appids[uid] = true
@@ -220,7 +220,7 @@ async function announce() {
 }
 
 
-function getFeaturelessFeature(req: ExpressRequest) {
+function getFeaturelessFeature(req: ExpressRequest): FeatureEntry | undefined {
     if (Session.ALLOWED_URLS.includes(req.path)) {
         for(let key in features) {
             const feature = features[key]!
@@ -229,6 +229,7 @@ function getFeaturelessFeature(req: ExpressRequest) {
             }
         }
     }
+    return undefined
 }
 
 const apiHandler = async (req: ExpressRequest, res: ExpressResponse) => {
@@ -381,7 +382,7 @@ export const start = async (app: ExpressApplication, url: URL, file: string) =>
     features = await Utils.fileToJson(url, file) as Record<string, FeatureEntry>
     await announce()
 
-    app.get('/features', async (req: ExpressRequest, res: ExpressResponse) => {
+    app.get('/features', async (_req: ExpressRequest, res: ExpressResponse) => {
         let exp_features: Record<string, RemoteFeatureEntry> = {}
         for (let [key, {api}] of Object.entries(features))
             exp_features[key] = {api, service: `${SERVICE_ADDRESS}`, subscribe: '', topic: ''}
@@ -535,7 +536,7 @@ async function subscribe() {
         kafka_consumer_promise
         .then(kafka_consumer => {
             subscribed_consumers[consumer] = kafka_consumer
-        }).catch(err => {
+        }).catch(() => {
             throw new Error("Error: Remote service to service kafka Feature subscription.")
         })
     }

package/libs/kafka.ts

@@ -54,7 +54,7 @@ type KafkaStartArg = {
         username?: string
         password?: string
     }
-    logLevel?: unknown
+    logLevel?: KafkaLogLevel
 }
 
 
@@ -114,11 +114,11 @@ const start_consumer = async function<T>(topic: string, groupId: string, callbac
         autoCommit: false,
         eachMessage: async ({ topic, partition, message }) => {
             // callback(topic, message.value.toString(), partition) // toString() returns array so won't parse if json.
-            let success
+
             try {
-                success = await callback(topic, JSON.parse(message.value as string), partition)
+                await callback(topic, JSON.parse(message.value as string), partition)
             } catch (ex) {
-                success = await callback(topic, message.value as T, partition) // NOTE: Beware: Ensure Kafka.receive<T> can handle raw message type that is not json parseable
+                await callback(topic, message.value as T, partition) // NOTE: Beware: Ensure Kafka.receive<T> can handle raw message type that is not json parseable
             }
 
             await consumer.commitOffsets([{ topic, partition, offset: (Number(message.offset) + 1).toString() }]);

package/libs/messaging.ts

@@ -10,20 +10,22 @@ const url = process.env.REDIS_URL || "redis://localhost:6380"
 
 // url: 'redis://alice:foobared@localhost:6380'
 
+type RedisConsumer = ReturnType<typeof createClient>;
+type RedisPublisher = ReturnType<typeof createClient>;
 
 type RedisListener = (message: string, channel: string) => void
 
-type RedisConsumer = {
-    connect: () => Promise<void>
-    subscribe: (channel: string, listener: RedisListener) => Promise<void>
-    unsubscribe: (channel: string, listener: RedisListener) => Promise<void>
-    on: (event: string, listener: (err: unknown) => void) => void
-}
-
-type RedisPublisher = {
-    connect: () => Promise<void>
-    publish: (channel: string, message: string) => Promise<unknown>
-}
+// type RedisConsumer = {
+//     connect: () => Promise<void>
+//     subscribe: (channel: string, listener: RedisListener) => Promise<void>
+//     unsubscribe: (channel: string, listener: RedisListener) => Promise<void>
+//     on: (event: string, listener: (err: unknown) => void) => void
+// }
+//
+// type RedisPublisher = {
+//     connect: () => Promise<void>
+//     publish: (channel: string, message: string) => Promise<unknown>
+// }
 
 type Request = {
     body: {
@@ -102,7 +104,7 @@ async function connect({user, req, res, uid}: {user: string, req: Request, res:
     const listener = (message: string, channel: string) => {
         if (users_pool[user]) {
             try {message = JSON.parse(message)} catch {}
-            for (let {req, res} of users_pool[user].reqres) {
+            for (let {res} of users_pool[user].reqres) {
                 res.write(JSON.stringify({message, channel}) + "\n")
                 if (res.flush) // If compression enabled
                     res.flush()
@@ -123,7 +125,7 @@ export async function start(app: ExpressApp) {
     publisher = createClient({ url });
     await publisher.connect();
 
-    consumer.on('error', err => console.log('Redis Client Error', err));
+    consumer.on('error', (err: any) => console.log('Redis Client Error', err));
 
     app.get('/messages/:user', async (req, res) => {
         let uid = req.body.client

package/libs/utils.ts

@@ -40,7 +40,7 @@ export function isEmpty(str: undefined | number | string): boolean { // returns
 export let GLOBAL_META = { company: "GLOBAL", outlet: "GLOBAL" }
 
 export function isEmptyJson(json: object): boolean {
-    for (let i in json)
+    for (let _i in json)
         return false
     return true
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "corebasic",
   "type": "module",
-  "version": "1.0.232",
+  "version": "1.0.234",
   "description": "",
   "main": "dist/index.js",
   "types": "./index.ts",

package/tsconfig.json

@@ -27,7 +27,7 @@
 
       // Stricter Typechecking Options
       "noUncheckedIndexedAccess": true,
-      "exactOptionalPropertyTypes": false,
+      // "exactOptionalPropertyTypes": false,
 
       // Style Options
       // "noImplicitReturns": true,
@@ -45,5 +45,20 @@
       "noUncheckedSideEffectImports": true,
       "moduleDetection": "force",
       "skipLibCheck": true,
+
+        "noUncheckedIndexedAccess": true,
+        "exactOptionalPropertyTypes": true,
+        "noImplicitReturns": true,
+        "noFallthroughCasesInSwitch": true,
+        "noUnusedLocals": true,
+        "noUnusedParameters": true,
+        "noImplicitOverride": true,
+        "allowUnusedLabels": false,
+        "allowUnreachableCode": false,
+        "noImplicitAny": true,
+        // "declaration": true, // generate dist/*.d.ts files
+        // "composite": true,
+        // "isolatedDeclarations": true,
+        // "noPropertyAccessFromIndexSignature": true, // Useless as all obj.foo now has to use obj["foo"]. No added benefit yet negative overall experience
     }
 }