core-services-sdk 1.3.9 → 1.3.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "core-services-sdk",
-  "version": "1.3.9",
+  "version": "1.3.10",
   "main": "src/index.js",
   "type": "module",
   "scripts": {
@@ -23,7 +23,6 @@
     "@aws-sdk/credential-provider-node": "^3.862.0",
     "@sendgrid/mail": "^8.1.5",
     "amqplib": "^0.10.8",
-    "crypto": "^1.0.1",
     "dot": "^1.1.3",
     "fastify": "^5.4.0",
     "http-status": "^2.1.0",
@@ -40,4 +39,4 @@
     "url": "^0.11.4",
     "vitest": "^3.2.4"
   }
-}
+}

package/tests/mailer/transport.factory.unit.test.js

@@ -1,9 +1,7 @@
+// @ts-nocheck
 import nodemailer from 'nodemailer'
-import { describe, it, expect, vi, beforeEach } from 'vitest'
 
-// ===================
-// SAFELY MOCK MODULES
-// ===================
+import { describe, it, expect, vi, beforeEach } from 'vitest'
 
 vi.mock('nodemailer', () => {
   const createTransport = vi.fn((options) => ({
@@ -17,23 +15,24 @@ vi.mock('nodemailer', () => {
   }
 })
 
-vi.mock('nodemailer-sendgrid-transport', () => ({
-  __esModule: true,
-  default: vi.fn((opts) => ({
-    sendgrid: true,
-    options: opts,
-  })),
-}))
+vi.mock('@sendgrid/mail', () => {
+  const setApiKey = vi.fn()
+  const send = vi.fn()
+  const sgMail = { setApiKey, send }
+  globalThis.__mockedSgMail__ = sgMail
+  return {
+    __esModule: true,
+    default: sgMail,
+  }
+})
 
 vi.mock('@aws-sdk/client-ses', () => {
-  const mockSesInstance = { mocked: true } // consistent reference
-  const sesClient = vi.fn(() => mockSesInstance)
-
-  globalThis.__mockedSesClient__ = sesClient
+  const mockSesInstance = { mocked: true }
+  const SESClient = vi.fn(() => mockSesInstance)
+  globalThis.__mockedSesClient__ = SESClient
   globalThis.__mockedSesInstance__ = mockSesInstance
-
   return {
-    SESClient: sesClient,
+    SESClient,
     SendRawEmailCommand: 'mocked-command',
   }
 })
@@ -41,15 +40,9 @@ vi.mock('@aws-sdk/client-ses', () => {
 vi.mock('@aws-sdk/credential-provider-node', () => {
   const defaultProvider = vi.fn(() => 'mocked-default-provider')
   globalThis.__mockedDefaultProvider__ = defaultProvider
-  return {
-    defaultProvider,
-  }
+  return { defaultProvider }
 })
 
-// ==========================
-// NOW IMPORT MODULE UNDER TEST
-// ==========================
-
 import { TransportFactory } from '../../src/mailer/transport.factory.js'
 
 describe('TransportFactory', () => {
@@ -66,7 +59,6 @@ describe('TransportFactory', () => {
       auth: { user: 'user', pass: 'pass' },
     }
 
-    // @ts-ignore
     const transport = TransportFactory.create(config)
 
     expect(nodemailer.createTransport).toHaveBeenCalledWith({
@@ -75,8 +67,6 @@ describe('TransportFactory', () => {
       secure: config.secure,
       auth: config.auth,
     })
-
-    // @ts-ignore
     expect(transport.type).toBe('mock-transport')
   })
 
@@ -86,46 +76,33 @@ describe('TransportFactory', () => {
       auth: { user: 'user@gmail.com', pass: 'pass' },
     }
 
-    // @ts-ignore
     const transport = TransportFactory.create(config)
 
     expect(nodemailer.createTransport).toHaveBeenCalledWith({
       service: 'gmail',
       auth: config.auth,
     })
-
-    // @ts-ignore
     expect(transport.type).toBe('mock-transport')
   })
 
   it('should create sendgrid transport', () => {
     const config = {
       type: 'sendgrid',
-      apiKey: 'SG.xxxx',
+      apiKey: 'SG.key',
     }
 
-    // @ts-ignore
     const transport = TransportFactory.create(config)
 
-    // @ts-ignore
-    const args = nodemailer.createTransport.mock.calls[0][0]
-
-    expect(args).toEqual({
-      sendgrid: true,
-      options: {
-        auth: { api_key: config.apiKey },
-      },
-    })
+    expect(globalThis.__mockedSgMail__.setApiKey).toHaveBeenCalledWith(
+      config.apiKey,
+    )
+    expect(transport).toEqual(globalThis.__mockedSgMail__)
+  })
 
-    expect(transport).toEqual({
-      type: 'mock-transport',
-      options: {
-        sendgrid: true,
-        options: {
-          auth: { api_key: config.apiKey },
-        },
-      },
-    })
+  it('should throw if sendgrid API key is missing', () => {
+    expect(() => {
+      TransportFactory.create({ type: 'sendgrid' })
+    }).toThrow('Missing SendGrid API key')
   })
 
   it('should create ses transport with credentials', () => {
@@ -136,7 +113,6 @@ describe('TransportFactory', () => {
       region: 'us-west-2',
     }
 
-    // @ts-ignore
     const transport = TransportFactory.create(config)
 
     expect(globalThis.__mockedSesClient__).toHaveBeenCalledWith({
@@ -147,19 +123,14 @@ describe('TransportFactory', () => {
       },
     })
 
-    // @ts-ignore
     const args = nodemailer.createTransport.mock.calls[0][0]
-
     expect(args).toEqual({
       SES: {
         ses: globalThis.__mockedSesInstance__,
-        aws: {
-          SendRawEmailCommand: 'mocked-command',
-        },
+        aws: { SendRawEmailCommand: 'mocked-command' },
       },
     })
 
-    // @ts-ignore
     expect(transport.type).toBe('mock-transport')
   })
 
@@ -169,35 +140,27 @@ describe('TransportFactory', () => {
       region: 'us-east-1',
     }
 
-    // @ts-ignore
     const transport = TransportFactory.create(config)
 
     expect(globalThis.__mockedDefaultProvider__).toHaveBeenCalled()
-
     expect(globalThis.__mockedSesClient__).toHaveBeenCalledWith({
       region: config.region,
       credentials: 'mocked-default-provider',
     })
 
-    // @ts-ignore
     const args = nodemailer.createTransport.mock.calls[0][0]
-
     expect(args).toEqual({
       SES: {
         ses: globalThis.__mockedSesInstance__,
-        aws: {
-          SendRawEmailCommand: 'mocked-command',
-        },
+        aws: { SendRawEmailCommand: 'mocked-command' },
       },
     })
 
-    // @ts-ignore
     expect(transport.type).toBe('mock-transport')
   })
 
   it('should throw error for unsupported type', () => {
     expect(() => {
-      // @ts-ignore
       TransportFactory.create({ type: 'invalid' })
     }).toThrow('Unsupported transport type: invalid')
   })