cordova.plugins.diagnostic 7.2.7 → 7.2.8

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
+**v7.2.8**
+(ios) bugfix: Avoid reporting false-positive Local Network Permission Denied by returning indeterminate result, instead of denied, if NSNetService publish fails with an error, as it can fail for reasons other than permission denied.
+
 **v7.2.7**
 (ios) bugfix: Handle DNS PolicyDenied like EPERM for local network permission detection
 

package/package.json

@@ -1,5 +1,5 @@
 {
-    "version": "7.2.7",
+    "version": "7.2.8",
     "name": "cordova.plugins.diagnostic",
     "cordova_name": "Diagnostic",
     "description": "Cordova/Phonegap plugin to check the state of Location/WiFi/Camera/Bluetooth device settings.",

package/plugin.xml

@@ -2,7 +2,7 @@
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova.plugins.diagnostic"
-    version="7.2.7">
+    version="7.2.8">
 
     <name>Diagnostic</name>
     <description>Cordova/Phonegap plugin to check the state of Location/WiFi/Camera/Bluetooth device settings.</description>

package/src/ios/Diagnostic_Wifi.m

@@ -434,6 +434,10 @@ static NSTimeInterval const kLocalNetworkDefaultTimeoutSeconds = 2.0;
     NSNumber *errorDomain = errorDict[NSNetServicesErrorDomain];
     NSNumber *errorCode = errorDict[NSNetServicesErrorCode];
     [diagnostic logDebug:[NSString stringWithFormat:@"netService didNotPublish (domain=%@, code=%@)", errorDomain, errorCode]];
-    [self completeLocalNetworkFlowWithState:LocalNetworkPermissionStateDenied shouldCache:YES];
+    // NSNetService can fail to publish for many reasons unrelated to permissions (network issues,
+    // name collisions, configuration problems, etc.). We cannot reliably determine permission denial
+    // from NSNetService error codes alone, so return indeterminate. The browser state handler in
+    // handleBrowserState will catch actual permission denials via isPermissionDeniedError.
+    [self completeLocalNetworkFlowWithState:LocalNetworkPermissionStateIndeterminate shouldCache:NO];
 }
 @end