cordova.plugins.diagnostic 7.2.6 → 7.2.8

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+**v7.2.8**
+(ios) bugfix: Avoid reporting false-positive Local Network Permission Denied by returning indeterminate result, instead of denied, if NSNetService publish fails with an error, as it can fail for reasons other than permission denied.
+
+**v7.2.7**
+(ios) bugfix: Handle DNS PolicyDenied like EPERM for local network permission detection
+
 **v7.2.6**
 * (ios) fix: Local Network status check now accepts a configurable timeout, detects permission denials via NWBrowser errors/NSNetService failures, and returns `UNKNOWN` instead of `DENIED_ALWAYS` when the probe times out. This works around an issue where, if the network stack is under load, local network permission may be falsely reported as denied because iOS fails to resolve the Bonjour service within the default timeout period.
 

package/package.json

@@ -1,5 +1,5 @@
 {
-    "version": "7.2.6",
+    "version": "7.2.8",
     "name": "cordova.plugins.diagnostic",
     "cordova_name": "Diagnostic",
     "description": "Cordova/Phonegap plugin to check the state of Location/WiFi/Camera/Bluetooth device settings.",

package/plugin.xml

@@ -2,7 +2,7 @@
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
     xmlns:android="http://schemas.android.com/apk/res/android"
     id="cordova.plugins.diagnostic"
-    version="7.2.6">
+    version="7.2.8">
 
     <name>Diagnostic</name>
     <description>Cordova/Phonegap plugin to check the state of Location/WiFi/Camera/Bluetooth device settings.</description>

package/src/ios/Diagnostic_Wifi.m

@@ -13,6 +13,7 @@
 #import <net/if.h> // For IFF_LOOPBACK
 #import <Network/Network.h>
 #import <Network/browser.h>
+#import <dns_sd.h>
 #import <errno.h>
 
 // UserDefaults key for caching local network permission
@@ -300,13 +301,21 @@ static NSTimeInterval const kLocalNetworkDefaultTimeoutSeconds = 2.0;
 
 - (BOOL)isPermissionDeniedError:(nw_error_t)error
 {
-    if (!error) {
-        return NO;
-    }
+	if (!error) {
+		return NO;
+	}
+
+	nw_error_domain_t errorDomain = nw_error_get_error_domain(error);
+	int errorCode = (int)nw_error_get_error_code(error);
+	if (errorDomain == nw_error_domain_posix && errorCode == EPERM) {
+		return YES;
+	}
+
+	if (errorDomain == nw_error_domain_dns && errorCode == kDNSServiceErr_PolicyDenied) {
+		return YES;
+	}
 
-    nw_error_domain_t errorDomain = nw_error_get_error_domain(error);
-    int errorCode = (int)nw_error_get_error_code(error);
-    return (errorDomain == nw_error_domain_posix && errorCode == EPERM);
+	return NO;
 }
 
 - (void)handleBrowserState:(nw_browser_state_t)newState error:(nw_error_t)error context:(NSString *)context
@@ -425,6 +434,10 @@ static NSTimeInterval const kLocalNetworkDefaultTimeoutSeconds = 2.0;
     NSNumber *errorDomain = errorDict[NSNetServicesErrorDomain];
     NSNumber *errorCode = errorDict[NSNetServicesErrorCode];
     [diagnostic logDebug:[NSString stringWithFormat:@"netService didNotPublish (domain=%@, code=%@)", errorDomain, errorCode]];
-    [self completeLocalNetworkFlowWithState:LocalNetworkPermissionStateDenied shouldCache:YES];
+    // NSNetService can fail to publish for many reasons unrelated to permissions (network issues,
+    // name collisions, configuration problems, etc.). We cannot reliably determine permission denial
+    // from NSNetService error codes alone, so return indeterminate. The browser state handler in
+    // handleBrowserState will catch actual permission denials via isPermissionDeniedError.
+    [self completeLocalNetworkFlowWithState:LocalNetworkPermissionStateIndeterminate shouldCache:NO];
 }
 @end