cordova-plugin-media3 1.1.24 → 1.1.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-media3",
-  "version": "1.1.024",
+  "version": "1.1.025",
   "description": "Media player for Cordova using Google's media3 ExoPlayer framework",
   "cordova": {
     "id": "cordova-plugin-media3",

package/src/android/Player.java

@@ -39,7 +39,6 @@ import androidx.annotation.NonNull;
 import androidx.appcompat.widget.ContentFrameLayout;
 
 // Media3 imports
-import androidx.media3.common.Player;
 import androidx.media3.common.*;
 import androidx.media3.exoplayer.*;
 import androidx.media3.exoplayer.source.*;
@@ -88,7 +87,7 @@ public class Player {
         this.audioManager = (AudioManager) activity.getSystemService(Context.AUDIO_SERVICE);
     }
 
-    private Player.Listener playerEventListener = new Player.Listener() {
+    private ExoPlayer.Listener playerEventListener = new ExoPlayer.Listener() {
         @Override
         public void onIsLoadingChanged(boolean isLoading) {
             // JSONObject payload = Payload.loadingEvent(Player.this.exoPlayer, isLoading);
@@ -109,14 +108,14 @@ public class Player {
         @Override
         public void onPlaybackStateChanged(int playbackState) {
             if (config.getShowBuffering()) {
-                LayoutProvider.setBufferingVisibility(exoView, activity, playbackState == Player.STATE_BUFFERING);
+                LayoutProvider.setBufferingVisibility(exoView, activity, playbackState == androidx.media3.common.Player.STATE_BUFFERING);
             }
             JSONObject payload = Payload.stateEvent(Player.this.exoPlayer, playbackState, Player.this.controllerVisibility == View.VISIBLE);
             new CallbackResponse(Player.this.callbackContext).send(PluginResult.Status.OK, payload, true);
         }
 
         @Override
-        public void onPositionDiscontinuity(@NonNull Player.PositionInfo oldPosition, @NonNull Player.PositionInfo newPosition, int reason) {
+        public void onPositionDiscontinuity(@NonNull androidx.media3.common.Player.PositionInfo oldPosition, @NonNull androidx.media3.common.Player.PositionInfo newPosition, int reason) {
             JSONObject payload = Payload.positionDiscontinuityEvent(Player.this.exoPlayer, reason);
             new CallbackResponse(Player.this.callbackContext).send(PluginResult.Status.OK, payload, true);
         }
@@ -232,8 +231,8 @@ public class Player {
     public void createPlayer() {
         Log.i(TAG, "Playing " + config.getUri());
 
-        // String mediaUrl = config.getUri().toString(); // Your method to get the URL
-        // if (mediaUrl != null && android.webkit.URLUtil.isValidUrl(mediaUrl)) {
+        String mediaUrl = config.getUri(); // Your method to get the URL
+        if (mediaUrl != null && URLUtil.isValidUrl(mediaUrl)) {
             // Proceed with ExoPlayer setup using mediaUrl
             if (config.useInlineView()) {
                 // Using a dialog doesn't work for us, as controls are drawn in HTML view (cordova ui)
@@ -248,11 +247,11 @@ public class Player {
             if (config.useInlineView()) {
                 setController(config.getController());
             }
-        // } else {
-        //     // Handle invalid or null URL: e.g., show an error message, log the issue, or use a placeholder.
-        //     Log.e("ExoPlayerDebug", "Invalid media URL: " + mediaUrl);
-        //     sendError("Invalid media URL: " + mediaUrl);
-        // }
+        } else {
+            // Handle invalid or null URL: e.g., show an error message, log the issue, or use a placeholder.
+            Log.e("ExoPlayerDebug", "Invalid media URL: " + mediaUrl);
+            sendError("Invalid media URL: " + uri);
+        }
     }
 
     public void createDialog() {
@@ -606,7 +605,7 @@ public class Player {
 
     public JSONObject getPlayerState() {
         return Payload.stateEvent(exoPlayer,
-                null != exoPlayer ? exoPlayer.getPlaybackState() : Player.STATE_ENDED,
+                null != exoPlayer ? exoPlayer.getPlaybackState() : androidx.media3.common.Player.STATE_ENDED,
                 Player.this.controllerVisibility == View.VISIBLE);
     }