cordova-plugin-admob-nextgen 1.0.3 → 1.0.4

package/README.md

@@ -58,7 +58,13 @@ Move beyond simple 320x50 banners. The Native Overlay feature allows you to rend
 We prioritize the safety of your AdMob account and the stability of your app.
 
 * **Smart Throttling (`retryInterval`)**: Prevents accidental spamming of ad requests using a global interval validation.
-* **Background Thread Loading**: All ad requests are dispatched on background threads (`cordova.getThreadPool()`), ensuring your app's UI never freezes.
+
+- If the loadAd or showAd function is called repeatedly accidentally by JavaScript (for example because it is tied to a scroll event or application loop), the system will continuously call loadAd or showAd.
+### This will cause two fatal problems:
+1. Banner Ad Flickering: Ads are constantly being destroyed and redrawn.
+2. Account Ban: Aggressively pulling ads (spamming impressions) is a serious violation of AdMob's Invalid Traffic (IVT) policy.
+
+* **Background Thread Loading**: All ad requests are dispatched on background threads, ensuring your app's UI never freezes.
 
 ---
 
@@ -292,8 +298,9 @@ Use the background engine to pool ads for 0ms latency.
         adUnitId: 'ca-app-pub-xxx/xxx',
         size: 'ADAPTIVE',     // 'BANNER', 'LARGE_BANNER', 'MEDIUM_RECTANGLE', 'ADAPTIVE', 'FULL_BANNER', 'LEADERBOARD'
         position: 'bottom',   // 'top' or 'bottom'
-        collapsible: false,
-        isOverlapping: false // Coba mode Push
+        collapsible: false,   // true = Enable Collapsible Format (High Revenue)
+        isOverlapping: false, 
+        retryInterval: 5000   // Anti-spam delay (ms)
     });
 
     // 2. Show Instantly (from pool)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-admob-nextgen",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Google Mobile Ads Next Gen SDK for Cordova. High performance and modular architecture. ",
   "cordova": {
     "id": "cordova-plugin-admob-nextgen",

package/plugin.xml

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='utf-8'?>
 <plugin id="cordova-plugin-admob-nextgen" 
-        version="1.0.3" 
+        version="1.0.4" 
         xmlns="http://apache.org/cordova/ns/plugins/1.0" 
         xmlns:android="http://schemas.android.com/apk/res/android">
 

package/src/android/BannerPreloadExecutor.java

@@ -21,15 +21,17 @@ import com.google.android.libraries.ads.mobile.sdk.banner.AdSize;
 import com.google.android.libraries.ads.mobile.sdk.banner.BannerAd;
 import com.google.android.libraries.ads.mobile.sdk.banner.BannerAdEventCallback;
 import com.google.android.libraries.ads.mobile.sdk.banner.BannerAdPreloader;
-import com.google.android.libraries.ads.mobile.sdk.banner.BannerAdRefreshCallback; 
+import com.google.android.libraries.ads.mobile.sdk.banner.BannerAdRefreshCallback;
 import com.google.android.libraries.ads.mobile.sdk.banner.BannerAdRequest;
 import com.google.android.libraries.ads.mobile.sdk.common.AdValue;
-import com.google.android.libraries.ads.mobile.sdk.common.FullScreenContentError; 
+import com.google.android.libraries.ads.mobile.sdk.common.FullScreenContentError;
 import com.google.android.libraries.ads.mobile.sdk.common.LoadAdError;
 import com.google.android.libraries.ads.mobile.sdk.common.PreloadCallback;
 import com.google.android.libraries.ads.mobile.sdk.common.PreloadConfiguration;
 import com.google.android.libraries.ads.mobile.sdk.common.ResponseInfo;
 
+import java.util.Date;
+
 public class BannerPreloadExecutor {
 
     private static final String TAG = "AdMobBannerPreload";
@@ -44,6 +46,14 @@ public class BannerPreloadExecutor {
 
     private String currentPosition = "bottom";
     private boolean isOverlapping = true;
+    private boolean isBannerVisible = false;
+
+    private int lastAdHeight = 0;
+    private int systemSafeTop = 0;
+    private int systemSafeBottom = 0;
+
+    private long lastShowTime = 0;
+    private long minShowInterval = 5000; 
 
     public BannerPreloadExecutor(CordovaInterface cordova, CordovaWebView webView) {
         this.cordova = cordova;
@@ -63,23 +73,27 @@ public class BannerPreloadExecutor {
             isPreloaderActive = true;
             this.currentAdUnitId = adUnitId;
 
+            if (options.has("position")) this.currentPosition = options.getString("position");
+            if (options.has("isOverlapping")) this.isOverlapping = options.getBoolean("isOverlapping");
+
+            if (options.has("retryInterval")) this.minShowInterval = options.getLong("retryInterval");
+
             String requestedSize = "ADAPTIVE";
             if (options.has("size")) requestedSize = options.getString("size");
 
             boolean isCollapsible = false;
             if (options.has("collapsible")) isCollapsible = options.getBoolean("collapsible");
 
-            String preloadPosition = "bottom";
-            if (options.has("position")) preloadPosition = options.getString("position");
-
             final String finalSizeStr = requestedSize;
             final boolean finalIsCollapsible = isCollapsible;
-            final String finalPosition = preloadPosition;
+            final String finalPosition = this.currentPosition;
 
             cordova.getActivity().runOnUiThread(() -> {
                 Context context = cordova.getActivity();
                 AdSize adSize = getAdSize(context, finalSizeStr);
 
+                this.lastAdHeight = adSize.getHeightInPixels(context);
+
                 BannerAdRequest.Builder requestBuilder = new BannerAdRequest.Builder(adUnitId, adSize);
 
                 if (finalIsCollapsible) {
@@ -87,7 +101,6 @@ public class BannerPreloadExecutor {
                     String anchor = "top".equalsIgnoreCase(finalPosition) ? "top" : "bottom";
                     extras.putString("collapsible", anchor);
                     requestBuilder.setGoogleExtrasBundle(extras);
-
                 }
 
                 BannerAdRequest adRequest = requestBuilder.build();
@@ -96,12 +109,10 @@ public class BannerPreloadExecutor {
                 PreloadCallback preloadCallback = new PreloadCallback() {
                     @Override
                     public void onAdPreloaded(@NonNull String preloadId, @NonNull ResponseInfo responseInfo) {
-
                         fireEvent("on.preload.available", null);
                     }
                     @Override
                     public void onAdFailedToPreload(@NonNull String preloadId, @NonNull LoadAdError loadAdError) {
-
                         try {
                             JSONObject err = new JSONObject();
                             err.put("message", loadAdError.getMessage());
@@ -110,13 +121,11 @@ public class BannerPreloadExecutor {
                     }
                     @Override
                     public void onAdsExhausted(@NonNull String preloadId) {
-
                         fireEvent("on.preload.exhausted", null);
                     }
                 };
 
                 BannerAdPreloader.start(adUnitId, preloadConfig, preloadCallback);
-
                 callbackContext.success("Preloader Started");
             });
 
@@ -127,51 +136,235 @@ public class BannerPreloadExecutor {
     }
 
     public void showPolledAd(JSONArray args, CallbackContext callbackContext) {
-        try {
-            JSONObject options = args.getJSONObject(0);
-            String adUnitId = options.getString("adUnitId");
+        if (currentAdUnitId == null || currentAdUnitId.isEmpty()) {
+            callbackContext.error("Preloader engine is not running.");
+            return;
+        }
 
-            if (options.has("position")) this.currentPosition = options.getString("position");
-            if (options.has("isOverlapping")) this.isOverlapping = options.getBoolean("isOverlapping");
+        String newPosition = this.currentPosition;
+        boolean newIsOverlapping = this.isOverlapping;
 
-            cordova.getActivity().runOnUiThread(() -> {
-                BannerAd ad = BannerAdPreloader.pollAd(adUnitId);
+        if (args != null && args.length() > 0) {
+            try {
+                JSONObject options = args.getJSONObject(0);
+                if (options.has("position")) newPosition = options.getString("position");
+                if (options.has("isOverlapping")) newIsOverlapping = options.getBoolean("isOverlapping");
+            } catch (JSONException ignored) {}
+        }
 
-                if (ad == null) {
+        if (currentBannerAd != null && isBannerVisible) {
+            boolean isSamePos = newPosition.equalsIgnoreCase(this.currentPosition);
+            boolean isSameOverlap = (newIsOverlapping == this.isOverlapping);
 
-                    callbackContext.error("Pool Empty");
-                    return;
-                }
+            if (isSamePos && isSameOverlap) {
 
-                destroyCurrentBanner();
-                this.currentBannerAd = ad;
+                callbackContext.success("Banner Already Visible (Flicker Prevented)");
+                return;
+            } else {
 
-                setupAdEvents(ad);
+                this.currentPosition = newPosition;
+                this.isOverlapping = newIsOverlapping;
 
-                renderBannerView(ad);
+                cordova.getActivity().runOnUiThread(() -> {
+                    updateBannerLayout();
+                    updateWebViewMargins();
+                    callbackContext.success("Banner Repositioned (No Pool Exhaustion)");
+                });
+                return;
+            }
+        }
 
-                sendLoadedEvent(ad.getAdSize(), ad.isCollapsible());
+        long currentTime = new Date().getTime();
+        if ((currentTime - lastShowTime) < minShowInterval) {
+            callbackContext.error("Spam protection active: Please wait " + minShowInterval + "ms.");
+            return;
+        }
+
+        this.currentPosition = newPosition;
+        this.isOverlapping = newIsOverlapping;
+        this.lastShowTime = currentTime;
+
+        cordova.getActivity().runOnUiThread(() -> {
+            BannerAd ad = BannerAdPreloader.pollAd(currentAdUnitId);
+
+            if (ad == null) {
+                callbackContext.error("Pool Empty");
+                return;
+            }
+
+            destroyCurrentBanner();
+            this.currentBannerAd = ad;
+
+            this.lastAdHeight = ad.getAdSize().getHeightInPixels(cordova.getActivity());
+
+            setupAdEvents(ad);
+            showBannerView();
+            sendLoadedEvent(ad.getAdSize(), ad.isCollapsible());
+
+            callbackContext.success("Ad Shown from Pool");
+        });
+    }
+
+    private void showBannerView() {
+        if (currentBannerAd == null) return;
+
+        if (adLayout == null) {
+            adLayout = new RelativeLayout(cordova.getActivity());
+
+            RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(
+                    RelativeLayout.LayoutParams.MATCH_PARENT,
+                    RelativeLayout.LayoutParams.WRAP_CONTENT);
 
-                callbackContext.success("Ad Shown from Pool");
+            if ("top".equalsIgnoreCase(currentPosition)) {
+                params.addRule(RelativeLayout.ALIGN_PARENT_TOP);
+            } else {
+                params.addRule(RelativeLayout.ALIGN_PARENT_BOTTOM);
+            }
+
+            adLayout.setClickable(false);
+            adLayout.setFocusable(false);
+            cordova.getActivity().addContentView(adLayout, params);
+        }
+
+        isBannerVisible = true;
+        updateBannerLayout();
+
+        adLayout.bringToFront();
+        adLayout.setVisibility(View.VISIBLE);
+
+        View adView = currentBannerAd.getView(cordova.getActivity());
+        if (adView != null) adView.setVisibility(View.VISIBLE);
+
+        updateWebViewMargins();
+    }
+
+    private void updateBannerLayout() {
+        if (currentBannerAd == null || adLayout == null) return;
+
+        View adView = currentBannerAd.getView(cordova.getActivity());
+        if (adView == null) return;
+
+        if (adView.getParent() != null && adView.getParent() != adLayout) {
+            ((ViewGroup) adView.getParent()).removeView(adView);
+        }
+
+        RelativeLayout.LayoutParams bannerParams = new RelativeLayout.LayoutParams(
+                RelativeLayout.LayoutParams.WRAP_CONTENT,
+                RelativeLayout.LayoutParams.WRAP_CONTENT);
+
+        bannerParams.addRule(RelativeLayout.CENTER_HORIZONTAL);
+        if ("top".equalsIgnoreCase(currentPosition)) {
+            bannerParams.addRule(RelativeLayout.ALIGN_PARENT_TOP);
+        } else {
+            bannerParams.addRule(RelativeLayout.ALIGN_PARENT_BOTTOM);
+        }
+
+        if (adView.getParent() == null) {
+            adLayout.addView(adView, bannerParams);
+        } else {
+            adView.setLayoutParams(bannerParams);
+        }
+
+        if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.KITKAT) {
+            adLayout.setOnApplyWindowInsetsListener((v, insets) -> {
+
+                if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.R) {
+                    systemSafeTop = insets.getInsets(android.view.WindowInsets.Type.systemBars()).top;
+                    systemSafeBottom = insets.getInsets(android.view.WindowInsets.Type.systemBars()).bottom;
+                } else {
+                    systemSafeTop = insets.getSystemWindowInsetTop();
+                    systemSafeBottom = insets.getSystemWindowInsetBottom();
+                }
+
+                if (adView != null && adView.getLayoutParams() instanceof RelativeLayout.LayoutParams) {
+                    RelativeLayout.LayoutParams params = (RelativeLayout.LayoutParams) adView.getLayoutParams();
+                    if ("top".equalsIgnoreCase(currentPosition)) {
+                        params.topMargin = systemSafeTop;
+                        params.bottomMargin = 0;
+                    } else {
+                        params.bottomMargin = systemSafeBottom;
+                        params.topMargin = 0;
+                    }
+                    adView.setLayoutParams(params);
+                }
+
+                updateWebViewMargins();
+
+                return insets;
             });
+            adLayout.requestApplyInsets();
+        }
+    }
 
-        } catch (JSONException e) {
-            callbackContext.error(e.getMessage());
+    private void updateWebViewMargins() {
+        if (webView == null || webView.getView() == null) return;
+
+        View webViewView = webView.getView();
+        ViewGroup.LayoutParams lp = webViewView.getLayoutParams();
+
+        if (lp instanceof ViewGroup.MarginLayoutParams) {
+            ViewGroup.MarginLayoutParams params = (ViewGroup.MarginLayoutParams) lp;
+
+            if ("top".equalsIgnoreCase(currentPosition)) {
+
+                params.setMargins(0, 0, 0, 0);
+
+                if (isBannerVisible && !isOverlapping) {
+                    float shift = (float) (lastAdHeight + systemSafeTop);
+                    webViewView.setTranslationY(shift);
+                } else {
+                    webViewView.setTranslationY(0);
+                }
+            } else {
+
+                webViewView.setTranslationY(0);
+
+                if (!isBannerVisible || isOverlapping) {
+                    params.setMargins(0, 0, 0, 0);
+                } else {
+                    int finalBottom = lastAdHeight + systemSafeBottom;
+                    params.setMargins(0, 0, 0, finalBottom);
+                }
+            }
+
+            webViewView.setLayoutParams(params);
+            webViewView.requestLayout();
         }
     }
 
-    private void setupAdEvents(BannerAd ad) {
+    private void destroyCurrentBanner() {
+        if (currentBannerAd != null) {
+            isBannerVisible = false;
+            updateWebViewMargins();
+
+            View adView = currentBannerAd.getView(cordova.getActivity());
+            if (adView != null && adView.getParent() != null) {
+                ((ViewGroup) adView.getParent()).removeView(adView);
+            }
+            currentBannerAd.destroy();
+            currentBannerAd = null;
+        }
+    }
+
+    public void stopPreloadAndClear() {
+        cordova.getActivity().runOnUiThread(() -> {
+            isPreloaderActive = false;
+            destroyCurrentBanner();
+            if (adLayout != null) {
+                adLayout.removeAllViews();
+                ((ViewGroup)adLayout.getParent()).removeView(adLayout);
+                adLayout = null;
+            }
+        });
+    }
 
+    private void setupAdEvents(BannerAd ad) {
         ad.setAdEventCallback(new BannerAdEventCallback() {
             @Override
-            public void onAdImpression() {
-                fireEvent("on.banner.impression", null);
-            }
+            public void onAdImpression() { fireEvent("on.banner.impression", null); }
 
             @Override
-            public void onAdClicked() {
-                fireEvent("on.banner.clicked", null);
-            }
+            public void onAdClicked() { fireEvent("on.banner.clicked", null); }
 
             @Override
             public void onAdPaid(@NonNull AdValue adValue) {
@@ -186,20 +379,13 @@ public class BannerPreloadExecutor {
             }
 
             @Override
-            public void onAdShowedFullScreenContent() {
-
-                fireEvent("on.banner.opened", null);
-            }
+            public void onAdShowedFullScreenContent() { fireEvent("on.banner.opened", null); }
 
             @Override
-            public void onAdDismissedFullScreenContent() {
-
-                fireEvent("on.banner.closed", null);
-            }
+            public void onAdDismissedFullScreenContent() { fireEvent("on.banner.closed", null); }
 
             @Override
             public void onAdFailedToShowFullScreenContent(@NonNull FullScreenContentError error) {
-
                 try {
                     JSONObject errData = new JSONObject();
                     errData.put("message", error.getMessage());
@@ -210,14 +396,10 @@ public class BannerPreloadExecutor {
 
         ad.setBannerAdRefreshCallback(new BannerAdRefreshCallback() {
             @Override
-            public void onAdRefreshed() {
-
-                fireEvent("on.banner.refreshed", null);
-            }
+            public void onAdRefreshed() { fireEvent("on.banner.refreshed", null); }
 
             @Override
             public void onAdFailedToRefresh(@NonNull LoadAdError loadAdError) {
-
                 try {
                     JSONObject err = new JSONObject();
                     err.put("message", loadAdError.getMessage());
@@ -231,7 +413,6 @@ public class BannerPreloadExecutor {
         try {
             Context context = cordova.getActivity();
             JSONObject data = new JSONObject();
-
             data.put("width", adSize.getWidth());
             data.put("height", adSize.getHeight());
             data.put("widthPixels", adSize.getWidthInPixels(context));
@@ -239,9 +420,7 @@ public class BannerPreloadExecutor {
             data.put("isCollapsible", isCollapsible);
 
             fireEvent("on.banner.load", data);
-        } catch (JSONException e) {
-
-        }
+        } catch (JSONException e) {}
     }
 
     private AdSize getAdSize(Context context, String sizeStr) {
@@ -258,95 +437,6 @@ public class BannerPreloadExecutor {
         return (int) (displayMetrics.widthPixels / displayMetrics.density);
     }
 
-    private void renderBannerView(BannerAd ad) {
-        if (adLayout == null) {
-            adLayout = new RelativeLayout(cordova.getActivity());
-            RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(
-                    RelativeLayout.LayoutParams.MATCH_PARENT,
-                    RelativeLayout.LayoutParams.MATCH_PARENT);
-            adLayout.setClickable(false);
-            adLayout.setFocusable(false);
-            cordova.getActivity().addContentView(adLayout, params);
-        }
-
-        adLayout.removeAllViews();
-        adLayout.setVisibility(View.VISIBLE);
-
-        View adView = ad.getView(cordova.getActivity());
-        RelativeLayout.LayoutParams bannerParams = new RelativeLayout.LayoutParams(
-                RelativeLayout.LayoutParams.WRAP_CONTENT,
-                RelativeLayout.LayoutParams.WRAP_CONTENT);
-
-        bannerParams.addRule(RelativeLayout.CENTER_HORIZONTAL);
-
-        if ("top".equalsIgnoreCase(currentPosition)) {
-            bannerParams.addRule(RelativeLayout.ALIGN_PARENT_TOP);
-        } else {
-            bannerParams.addRule(RelativeLayout.ALIGN_PARENT_BOTTOM);
-        }
-
-        adLayout.addView(adView, bannerParams);
-        adLayout.bringToFront();
-
-        updateWebViewMargins(adView);
-    }
-
-    public void stopPreloadAndClear() {
-        cordova.getActivity().runOnUiThread(() -> {
-            isPreloaderActive = false;
-            destroyCurrentBanner();
-            if (adLayout != null) {
-                adLayout.removeAllViews();
-                ((ViewGroup)adLayout.getParent()).removeView(adLayout);
-                adLayout = null;
-            }
-        });
-    }
-
-    private void destroyCurrentBanner() {
-        if (currentBannerAd != null) {
-            currentBannerAd.destroy();
-            currentBannerAd = null;
-        }
-        resetWebViewMargins();
-    }
-
-    private void updateWebViewMargins(View adView) {
-        if (isOverlapping || webView == null || webView.getView() == null) {
-            resetWebViewMargins();
-            return;
-        }
-
-        adView.measure(View.MeasureSpec.UNSPECIFIED, View.MeasureSpec.UNSPECIFIED);
-        int adHeight = adView.getMeasuredHeight();
-
-        View webViewView = webView.getView();
-        ViewGroup.LayoutParams lp = webViewView.getLayoutParams();
-
-        if (lp instanceof ViewGroup.MarginLayoutParams) {
-            ViewGroup.MarginLayoutParams params = (ViewGroup.MarginLayoutParams) lp;
-            if ("top".equalsIgnoreCase(currentPosition)) {
-                params.setMargins(0, adHeight, 0, 0);
-            } else {
-                params.setMargins(0, 0, 0, adHeight);
-            }
-            webViewView.setLayoutParams(params);
-            webViewView.requestLayout();
-        }
-    }
-
-    private void resetWebViewMargins() {
-        if (webView == null || webView.getView() == null) return;
-        View webViewView = webView.getView();
-        ViewGroup.LayoutParams lp = webViewView.getLayoutParams();
-        if (lp instanceof ViewGroup.MarginLayoutParams) {
-            ViewGroup.MarginLayoutParams params = (ViewGroup.MarginLayoutParams) lp;
-            params.setMargins(0, 0, 0, 0);
-            webViewView.setLayoutParams(params);
-            webViewView.requestLayout();
-        }
-    }
-
     private void fireEvent(String eventName, JSONObject data) {
         cordova.getActivity().runOnUiThread(() -> {
             StringBuilder js = new StringBuilder();

package/www/admob-nextgen.js

@@ -114,8 +114,8 @@ var AdMobNextGen = {
         exec(success, error, 'AdMobNextGen', 'startBannerPreload', [options]);
     },
 
-    showPreloadedBanner: function (options, success, error) {
-        exec(success, error, 'AdMobNextGen', 'showPreloadedBanner', [options]);
+    showPreloadedBanner: function (success, error) {
+        exec(success, error, 'AdMobNextGen', 'showPreloadedBanner', []);
     },
 
     stopBannerPreload: function (success, error) {