convoke-agents 3.0.4 → 3.2.0

package/scripts/update/lib/validator.js

@@ -5,7 +5,7 @@ const path = require('path');
 const yaml = require('js-yaml');
 const configMerger = require('./config-merger');
 const { countUserDataFiles } = require('./utils');
-const { AGENT_FILES, AGENT_IDS, WORKFLOW_NAMES, WAVE3_WORKFLOW_NAMES } = require('./agent-registry');
+const { AGENT_FILES, AGENT_IDS, WORKFLOW_NAMES, WAVE3_WORKFLOW_NAMES, EXTRA_BME_AGENTS, EXTRA_BME_AGENT_IDS } = require('./agent-registry');
 
 /**
  * Validator for Convoke
@@ -47,6 +47,9 @@ async function validateInstallation(preMigrationData = {}, projectRoot) {
   // 8. Enhance module validation (optional — passes if not installed)
   checks.push(await validateEnhanceModule(projectRoot));
 
+  // 9. Artifacts module validation (optional — passes if not installed)
+  checks.push(await validateArtifactsModule(projectRoot));
+
   const allPassed = checks.every(c => c.passed);
 
   return {
@@ -202,11 +205,22 @@ async function validateManifest(projectRoot) {
 
     const manifestContent = fs.readFileSync(manifestPath, 'utf8');
 
-    // Check for all Convoke agents
+    // Check for all Convoke agents (Vortex/Gyre IDs and standalone bme agents)
     const missingFromManifest = AGENT_IDS.filter(id => !manifestContent.includes(id));
+    const missingExtras = EXTRA_BME_AGENT_IDS.filter(id => !manifestContent.includes(`bmad-agent-bme-${id}`));
+
+    const allMissing = [...missingFromManifest, ...missingExtras];
+    if (allMissing.length > 0) {
+      check.error = `Agent manifest missing: ${allMissing.join(', ')}`;
+      return check;
+    }
 
-    if (missingFromManifest.length > 0) {
-      check.error = `Agent manifest missing: ${missingFromManifest.join(', ')}`;
+    // Confirm standalone bme agent files exist on disk
+    const missingExtraFiles = EXTRA_BME_AGENTS
+      .filter(a => !fs.existsSync(path.join(projectRoot, '_bmad', 'bme', a.submodule, 'agents', `${a.id}.md`)))
+      .map(a => a.id);
+    if (missingExtraFiles.length > 0) {
+      check.error = `Standalone bme agent files missing: ${missingExtraFiles.join(', ')}`;
       return check;
     }
 
@@ -468,6 +482,101 @@ async function validateEnhanceModule(projectRoot) {
   return check;
 }
 
+/**
+ * Validate Artifacts module installation (optional — passes if not installed)
+ * Performs 5-point verification: directory, config, workflows array, per-workflow entry, per-workflow skill wrapper
+ * @param {string} projectRoot - Absolute path to project root
+ * @returns {Promise<object>} Validation check result
+ */
+async function validateArtifactsModule(projectRoot) {
+  const check = {
+    name: 'Artifacts module',
+    passed: false,
+    error: null
+  };
+
+  try {
+    const artifactsDir = path.join(projectRoot, '_bmad/bme/_artifacts');
+
+    // Check 1: Directory exists — if not, Artifacts is simply not installed (optional)
+    if (!fs.existsSync(artifactsDir)) {
+      check.passed = true;
+      check.info = 'not installed';
+      return check;
+    }
+
+    const failures = [];
+
+    // Check 2: Config parse — bail early if config is unreadable, since later checks
+    // depend on a parsed workflows array.
+    const configPath = path.join(artifactsDir, 'config.yaml');
+    if (!fs.existsSync(configPath)) {
+      check.error = 'Artifacts: config.yaml not found';
+      return check;
+    }
+
+    let config = null;
+    try {
+      config = yaml.load(fs.readFileSync(configPath, 'utf8'));
+    } catch (err) {
+      check.error = `Artifacts: config.yaml parse error: ${err.message}`;
+      return check;
+    }
+
+    if (!config || typeof config !== 'object') {
+      check.error = 'Artifacts: config.yaml is empty or invalid';
+      return check;
+    }
+
+    // Check 3: Workflows array non-empty
+    if (!Array.isArray(config.workflows) || config.workflows.length === 0) {
+      check.error = 'Artifacts: config.yaml has no workflows array';
+      return check;
+    }
+
+    // Checks 4 & 5: Per-workflow entry point and skill wrapper.
+    // Aggregate failures across all workflows so a single doctor run reports every
+    // problem at once (mirrors validateEnhanceModule).
+    // Non-standalone workflows are skipped from wrapper/entry checks because
+    // refresh-installation.js section 6d does NOT install them — validating their
+    // wrapper would be a contract mismatch with the refresh logic.
+    for (const wf of config.workflows) {
+      if (!wf || !wf.name || !wf.entry) {
+        failures.push('workflow entry missing name or entry field');
+        continue;
+      }
+
+      if (wf.standalone !== true) {
+        // Refresh skips non-standalone workflows; nothing to validate.
+        continue;
+      }
+
+      // Check 4: Workflow entry point file exists
+      const entryPath = path.join(artifactsDir, wf.entry);
+      if (!fs.existsSync(entryPath)) {
+        failures.push(`workflow entry missing for ${wf.name}: ${wf.entry}`);
+      }
+
+      // Check 5: Skill wrapper exists at .claude/skills/{workflow.name}/SKILL.md
+      // (workflow.name already carries the bmad- prefix; do NOT synthesize bmad-${wf.name})
+      const skillWrapperPath = path.join(projectRoot, '.claude', 'skills', wf.name, 'SKILL.md');
+      if (!fs.existsSync(skillWrapperPath)) {
+        failures.push(`skill wrapper missing for ${wf.name}`);
+      }
+    }
+
+    if (failures.length > 0) {
+      check.error = `Artifacts: ${failures.join('; ')}`;
+    } else {
+      check.passed = true;
+    }
+  } catch (error) {
+    check.error = error.message;
+  }
+
+  return check;
+}
+
 /**
  * Validate a SKILL.md file has required frontmatter fields
  * @param {string} skillMdPath - Absolute path to SKILL.md file
@@ -633,6 +742,7 @@ module.exports = {
   validateDeprecatedWorkflows,
   validateWorkflowStepStructure,
   validateEnhanceModule,
+  validateArtifactsModule,
   validateSkillMd,
   validateStepFiles,
   validateSkillCohesion,

package/scripts/update/migrations/2.0.x-to-3.1.0.js

@@ -0,0 +1,50 @@
+const { mergeTaxonomy } = require('../lib/taxonomy-merger');
+
+/**
+ * Migration: 2.0.x → 3.1.0
+ * Introduces artifact governance taxonomy configuration.
+ * Creates or merges _bmad/_config/taxonomy.yaml with platform defaults.
+ * Idempotent — safe to re-run.
+ */
+
+module.exports = {
+  name: '2.0.x-to-3.1.0',
+  fromVersion: '2.0.x',
+  breaking: false,
+
+  async preview() {
+    return {
+      actions: [
+        'Create or merge _bmad/_config/taxonomy.yaml with platform defaults',
+        'Add 8 platform initiative IDs (vortex, gyre, bmm, forge, helm, enhance, loom, convoke)',
+        'Add 21 artifact type identifiers',
+        'Add 6 historical name aliases for migration',
+        'Promote any user initiative IDs that match new platform IDs'
+      ]
+    };
+  },
+
+  /**
+   * Apply migration: create or merge taxonomy config.
+   * @param {string} projectRoot - Absolute path to project root
+   * @returns {Promise<Array<string>>} List of changes made
+   */
+  async apply(projectRoot) {
+    const changes = [];
+    const result = await mergeTaxonomy(projectRoot);
+
+    if (result.created) {
+      changes.push('Created _bmad/_config/taxonomy.yaml with platform defaults');
+    } else if (result.merged) {
+      changes.push('Merged platform entries into existing taxonomy.yaml');
+    } else {
+      changes.push('Taxonomy already up to date — no changes needed');
+    }
+
+    if (result.promoted.length > 0) {
+      changes.push(`Promoted ${result.promoted.length} user initiative(s) to platform: ${result.promoted.join(', ')}`);
+    }
+
+    return changes;
+  }
+};

package/scripts/update/migrations/3.0.x-to-3.1.0.js

@@ -0,0 +1,41 @@
+const { mergeTaxonomy } = require('../lib/taxonomy-merger');
+
+/**
+ * Migration: 3.0.x → 3.1.0
+ * Parallel entry for 3.0.x users (same logic as 2.0.x-to-3.1.0).
+ * Introduces artifact governance taxonomy configuration.
+ */
+
+module.exports = {
+  name: '3.0.x-to-3.1.0',
+  fromVersion: '3.0.x',
+  breaking: false,
+
+  async preview() {
+    return {
+      actions: [
+        'Create or merge _bmad/_config/taxonomy.yaml with platform defaults',
+        'Add platform initiative IDs, artifact types, and aliases if missing'
+      ]
+    };
+  },
+
+  async apply(projectRoot) {
+    const changes = [];
+    const result = await mergeTaxonomy(projectRoot);
+
+    if (result.created) {
+      changes.push('Created _bmad/_config/taxonomy.yaml with platform defaults');
+    } else if (result.merged) {
+      changes.push('Merged platform entries into existing taxonomy.yaml');
+    } else {
+      changes.push('Taxonomy already up to date — no changes needed');
+    }
+
+    if (result.promoted.length > 0) {
+      changes.push(`Promoted ${result.promoted.length} user initiative(s) to platform: ${result.promoted.join(', ')}`);
+    }
+
+    return changes;
+  }
+};

package/scripts/update/migrations/registry.js

@@ -67,6 +67,20 @@ const MIGRATIONS = [
     breaking: true,
     description: 'Product rename: BMAD-Enhanced -> Convoke. CLI commands renamed from bmad-* to convoke-*. _bmad/ directory preserved.',
     module: null
+  },
+  {
+    name: '2.0.x-to-3.1.0',
+    fromVersion: '2.0.x',
+    breaking: false,
+    description: 'Artifact governance: create or merge _bmad/_config/taxonomy.yaml with platform defaults, aliases, and artifact types',
+    module: null
+  },
+  {
+    name: '3.0.x-to-3.1.0',
+    fromVersion: '3.0.x',
+    breaking: false,
+    description: 'Artifact governance: create or merge _bmad/_config/taxonomy.yaml (parallel entry for 3.0.x users)',
+    module: null
   }
   // Future migrations: append here. Only add delta logic for version-specific changes.
 ];