convex 1.44.0 → 1.45.0

package/src/cli/lib/versionApi.test.ts

@@ -1,471 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import {
-  downloadGuidelines,
-  fetchAgentSkillsCatalog,
-  fetchAgentSkillsSha,
-  getVersion,
-  validateAgentSkillCatalogResult,
-  validateVersionResult,
-} from "./versionApi.js";
-
-// Mock Sentry
-vi.mock("@sentry/node", () => ({
-  captureException: vi.fn(),
-  captureMessage: vi.fn(),
-}));
-
-// Mock fetch globally
-const mockFetch = vi.fn();
-global.fetch = mockFetch;
-
-const defaultHeaders = {
-  "Convex-Client": expect.stringMatching(/^npm-cli-/),
-  "Convex-Interactive": expect.stringMatching(/^(true|false)$/),
-  ...(process.env.CONVEX_AGENT_MODE
-    ? { "Convex-Agent-Mode": process.env.CONVEX_AGENT_MODE }
-    : {}),
-};
-
-describe("versionApi", () => {
-  afterEach(() => {
-    delete process.env.CONVEX_VERSION_API_ORIGIN;
-  });
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-  });
-
-  afterEach(() => {
-    vi.resetAllMocks();
-  });
-
-  describe("getVersion", () => {
-    it("returns version data on successful response", async () => {
-      const sha = "abc123def456abc123def456abc123def456abc1";
-      const mockResponse = {
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          message: "New version available",
-          agentSkillsSha: sha,
-        }),
-      };
-      mockFetch.mockResolvedValue(mockResponse);
-
-      const result = await getVersion();
-
-      expect(result).toEqual({
-        kind: "ok",
-        data: {
-          message: "New version available",
-          guidelinesHash: null,
-          agentSkillsSha: sha,
-          disableSkillsCli: false,
-          disableSkillsCliMessage: null,
-        },
-      });
-      expect(mockFetch).toHaveBeenCalledWith(
-        "https://version.convex.dev/v1/version",
-        { headers: defaultHeaders },
-      );
-    });
-
-    it("uses the overridden version API origin when configured", async () => {
-      process.env.CONVEX_VERSION_API_ORIGIN = "http://127.0.0.1:3210";
-      mockFetch.mockResolvedValue({
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          message: null,
-          guidelinesHash: null,
-          agentSkillsSha: null,
-          disableSkillsCli: false,
-        }),
-      });
-
-      await getVersion();
-
-      expect(mockFetch).toHaveBeenCalledWith(
-        "http://127.0.0.1:3210/v1/version",
-        {
-          headers: defaultHeaders,
-        },
-      );
-    });
-
-    it("returns error on network error", async () => {
-      mockFetch.mockRejectedValue(new Error("Network error"));
-
-      const result = await getVersion();
-
-      expect(result).toEqual({ kind: "error" });
-    });
-
-    it("returns error on non-ok response", async () => {
-      const mockResponse = {
-        ok: false,
-        status: 500,
-      };
-      mockFetch.mockResolvedValue(mockResponse);
-
-      const result = await getVersion();
-
-      expect(result).toEqual({ kind: "error" });
-    });
-
-    it("returns error on invalid JSON response", async () => {
-      const mockResponse = {
-        ok: true,
-        json: vi.fn().mockResolvedValue("invalid json"),
-      };
-      mockFetch.mockResolvedValue(mockResponse);
-
-      const result = await getVersion();
-
-      expect(result).toEqual({ kind: "error" });
-    });
-  });
-
-  describe("validateVersionResult", () => {
-    it("validates correct version result", () => {
-      const sha = "abc123def456abc123def456abc123def456abc1";
-      const validResult = {
-        message: "New version available",
-        guidelinesHash: "deadbeef",
-        agentSkillsSha: sha,
-        disableSkillsCli: true,
-        disableSkillsCliMessage: null,
-      };
-
-      const result = validateVersionResult(validResult);
-
-      expect(result).toEqual(validResult);
-    });
-
-    it("validates result with null message", () => {
-      const validResult = {
-        message: null,
-        guidelinesHash: null,
-        agentSkillsSha: null,
-        disableSkillsCli: false,
-        disableSkillsCliMessage: null,
-      };
-
-      const result = validateVersionResult(validResult);
-
-      expect(result).toEqual(validResult);
-    });
-
-    it("treats missing optional hashes as null", () => {
-      const result = validateVersionResult({
-        message: "New version available",
-        // agentSkillsSha and guidelinesHash intentionally absent
-      });
-
-      expect(result).toEqual({
-        message: "New version available",
-        guidelinesHash: null,
-        agentSkillsSha: null,
-        disableSkillsCli: false,
-        disableSkillsCliMessage: null,
-      });
-    });
-
-    it("ignores unknown fields from the server", () => {
-      const result = validateVersionResult({
-        message: null,
-        cursorRulesHash: "legacy-field",
-        guidelinesHash: "abc",
-        agentSkillsSha: null,
-      });
-
-      expect(result).toEqual({
-        message: null,
-        guidelinesHash: "abc",
-        agentSkillsSha: null,
-        disableSkillsCli: false,
-        disableSkillsCliMessage: null,
-      });
-    });
-
-    it("round-trips a string disableSkillsCliMessage", () => {
-      const result = validateVersionResult({
-        message: null,
-        guidelinesHash: null,
-        agentSkillsSha: null,
-        disableSkillsCli: true,
-        disableSkillsCliMessage: "Back at 3pm PT",
-      });
-
-      expect(result).toEqual({
-        message: null,
-        guidelinesHash: null,
-        agentSkillsSha: null,
-        disableSkillsCli: true,
-        disableSkillsCliMessage: "Back at 3pm PT",
-      });
-    });
-
-    it("treats a non-string disableSkillsCliMessage as null", () => {
-      const result = validateVersionResult({
-        message: null,
-        disableSkillsCli: true,
-        disableSkillsCliMessage: 42,
-      });
-
-      expect(result).toEqual({
-        message: null,
-        guidelinesHash: null,
-        agentSkillsSha: null,
-        disableSkillsCli: true,
-        disableSkillsCliMessage: null,
-      });
-    });
-
-    it("returns null for non-object input", () => {
-      const result = validateVersionResult("not an object");
-      expect(result).toBeNull();
-    });
-
-    it("returns null for null input", () => {
-      const result = validateVersionResult(null);
-      expect(result).toBeNull();
-    });
-
-    it("returns null for invalid message type", () => {
-      const invalidResult = {
-        message: 123, // should be string or null
-      };
-
-      const result = validateVersionResult(invalidResult);
-      expect(result).toBeNull();
-    });
-  });
-
-  describe("downloadGuidelines", () => {
-    it("returns guidelines text on successful response", async () => {
-      const mockResponse = {
-        ok: true,
-        text: vi.fn().mockResolvedValue("# Convex guidelines\n\nUse queries."),
-      };
-      mockFetch.mockResolvedValue(mockResponse);
-
-      const result = await downloadGuidelines();
-
-      expect(result).toBe("# Convex guidelines\n\nUse queries.");
-      expect(mockFetch).toHaveBeenCalledWith(
-        "https://version.convex.dev/v1/guidelines",
-        { headers: defaultHeaders },
-      );
-    });
-
-    it("returns null on network error", async () => {
-      mockFetch.mockRejectedValue(new Error("Network error"));
-
-      const result = await downloadGuidelines();
-
-      expect(result).toBeNull();
-    });
-
-    it("returns null on non-ok response", async () => {
-      mockFetch.mockResolvedValue({ ok: false, status: 500 });
-
-      const result = await downloadGuidelines();
-
-      expect(result).toBeNull();
-    });
-  });
-
-  describe("fetchAgentSkillsSha", () => {
-    it("returns the SHA from version.convex.dev", async () => {
-      const sha = "abc123def456abc123def456abc123def456abc1";
-      mockFetch.mockResolvedValue({
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          message: null,
-          guidelinesHash: null,
-          agentSkillsSha: sha,
-          disableSkillsCli: false,
-          disableSkillsCliMessage: null,
-        }),
-      });
-
-      const result = await fetchAgentSkillsSha();
-
-      expect(result).toBe(sha);
-      expect(mockFetch).toHaveBeenCalledWith(
-        "https://version.convex.dev/v1/version",
-        { headers: defaultHeaders },
-      );
-    });
-
-    it("returns null on network error", async () => {
-      mockFetch.mockRejectedValue(new Error("Network error"));
-
-      const result = await fetchAgentSkillsSha();
-
-      expect(result).toBeNull();
-    });
-
-    it("returns null on non-ok response", async () => {
-      mockFetch.mockResolvedValue({ ok: false, status: 403 });
-
-      const result = await fetchAgentSkillsSha();
-
-      expect(result).toBeNull();
-    });
-
-    it("returns null when the version response has no agent skills SHA", async () => {
-      mockFetch.mockResolvedValue({
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          message: null,
-          guidelinesHash: null,
-          agentSkillsSha: null,
-          disableSkillsCli: false,
-        }),
-      });
-
-      const result = await fetchAgentSkillsSha();
-
-      expect(result).toBeNull();
-    });
-  });
-
-  describe("validateAgentSkillCatalogResult", () => {
-    it("validates a catalog result with active and deleted skills", () => {
-      const result = validateAgentSkillCatalogResult({
-        latestRepoSha: "repo-sha-2",
-        skills: [
-          {
-            skillName: "convex-active",
-            status: { kind: "active" },
-            hash: "hash-a",
-            lastSeenRepoSha: "repo-sha-2",
-            lastSeenAt: 123,
-          },
-          {
-            skillName: "convex-deleted",
-            status: { kind: "deleted", deletedAt: 456 },
-            hash: "hash-b",
-            lastSeenRepoSha: "repo-sha-1",
-            lastSeenAt: 111,
-          },
-        ],
-      });
-
-      expect(result).toEqual({
-        latestRepoSha: "repo-sha-2",
-        skills: [
-          {
-            skillName: "convex-active",
-            status: { kind: "active" },
-            hash: "hash-a",
-            lastSeenRepoSha: "repo-sha-2",
-            lastSeenAt: 123,
-          },
-          {
-            skillName: "convex-deleted",
-            status: { kind: "deleted", deletedAt: 456 },
-            hash: "hash-b",
-            lastSeenRepoSha: "repo-sha-1",
-            lastSeenAt: 111,
-          },
-        ],
-      });
-    });
-
-    it("returns null for invalid status payloads", () => {
-      const result = validateAgentSkillCatalogResult({
-        latestRepoSha: "repo-sha-2",
-        skills: [
-          {
-            skillName: "convex-bad",
-            status: { kind: "deleted" },
-            hash: "hash-a",
-            lastSeenRepoSha: "repo-sha-2",
-            lastSeenAt: 123,
-          },
-        ],
-      });
-
-      expect(result).toBeNull();
-    });
-  });
-
-  describe("fetchAgentSkillsCatalog", () => {
-    it("returns the parsed catalog from version.convex.dev", async () => {
-      mockFetch.mockResolvedValue({
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          latestRepoSha: "repo-sha-2",
-          skills: [
-            {
-              skillName: "convex-active",
-              status: { kind: "active" },
-              hash: "hash-a",
-              lastSeenRepoSha: "repo-sha-2",
-              lastSeenAt: 123,
-            },
-            {
-              skillName: "convex-deleted",
-              status: { kind: "deleted", deletedAt: 456 },
-              hash: "hash-b",
-              lastSeenRepoSha: "repo-sha-1",
-              lastSeenAt: 111,
-            },
-          ],
-        }),
-      });
-
-      const result = await fetchAgentSkillsCatalog();
-
-      expect(result).toEqual({
-        kind: "ok",
-        data: {
-          latestRepoSha: "repo-sha-2",
-          skills: [
-            {
-              skillName: "convex-active",
-              status: { kind: "active" },
-              hash: "hash-a",
-              lastSeenRepoSha: "repo-sha-2",
-              lastSeenAt: 123,
-            },
-            {
-              skillName: "convex-deleted",
-              status: { kind: "deleted", deletedAt: 456 },
-              hash: "hash-b",
-              lastSeenRepoSha: "repo-sha-1",
-              lastSeenAt: 111,
-            },
-          ],
-        },
-      });
-      expect(mockFetch).toHaveBeenCalledWith(
-        "https://version.convex.dev/v1/agent_skills",
-        { headers: defaultHeaders },
-      );
-    });
-
-    it("returns error on network error", async () => {
-      mockFetch.mockRejectedValue(new Error("Network error"));
-
-      const result = await fetchAgentSkillsCatalog();
-
-      expect(result).toEqual({ kind: "error" });
-    });
-
-    it("returns error on invalid catalog payload", async () => {
-      mockFetch.mockResolvedValue({
-        ok: true,
-        json: vi.fn().mockResolvedValue({
-          latestRepoSha: "repo-sha-2",
-          skills: [{ skillName: "convex-active" }],
-        }),
-      });
-
-      const result = await fetchAgentSkillsCatalog();
-
-      expect(result).toEqual({ kind: "error" });
-    });
-  });
-});

package/src/cli/lib/workos/environmentApi.test.ts

@@ -1,107 +0,0 @@
-import { test, expect, describe, beforeEach, vi } from "vitest";
-import { Context } from "../../../bundler/context.js";
-import { createCORSOrigin, createRedirectURI } from "./environmentApi.js";
-
-const mockFetch = vi.fn();
-global.fetch = mockFetch;
-
-const ctx: Context = {
-  crash: vi.fn(async (args: { printedMessage: string | null }) => {
-    throw new Error(args.printedMessage ?? "crash");
-  }),
-} as unknown as Context;
-
-beforeEach(() => {
-  vi.clearAllMocks();
-});
-
-describe("createRedirectURI", () => {
-  test("returns modified: true on a successful response", async () => {
-    mockFetch.mockResolvedValue(new Response(null, { status: 201 }));
-    await expect(
-      createRedirectURI(ctx, "key", "http://localhost:5173"),
-    ).resolves.toEqual({ modified: true });
-  });
-
-  test("returns modified: false when the URI already exists", async () => {
-    mockFetch.mockResolvedValue(
-      new Response(
-        `{"message":"Redirect URI 'http://localhost:5173' already exists.","error":"Unprocessable Entity"}`,
-        { status: 422 },
-      ),
-    );
-    await expect(
-      createRedirectURI(ctx, "key", "http://localhost:5173"),
-    ).resolves.toEqual({ modified: false });
-    expect(ctx.crash).not.toHaveBeenCalled();
-  });
-
-  test("crashes with the body for a non-duplicate 422", async () => {
-    const body = `{"message":"Redirect URI 'test' is invalid.","error":"Unprocessable Entity"}`;
-    mockFetch.mockResolvedValue(new Response(body, { status: 422 }));
-    await expect(createRedirectURI(ctx, "key", "test")).rejects.toThrow(
-      `Failed to create redirect URI: 422 ${body}`,
-    );
-    expect(ctx.crash).toHaveBeenCalledWith(
-      expect.objectContaining({
-        exitCode: 1,
-        errorType: "fatal",
-        printedMessage: `Failed to create redirect URI: 422 ${body}`,
-      }),
-    );
-  });
-
-  test("crashes with the body for non-422 errors", async () => {
-    const body = `{"message":"Unauthorized"}`;
-    mockFetch.mockResolvedValue(new Response(body, { status: 401 }));
-    await expect(createRedirectURI(ctx, "key", "http://x")).rejects.toThrow(
-      `Failed to create redirect URI: 401 ${body}`,
-    );
-  });
-});
-
-describe("createCORSOrigin", () => {
-  test("returns modified: true on a successful response", async () => {
-    mockFetch.mockResolvedValue(new Response(null, { status: 201 }));
-    await expect(
-      createCORSOrigin(ctx, "key", "http://localhost:5173"),
-    ).resolves.toEqual({ modified: true });
-  });
-
-  test("returns modified: false on duplicate_cors_origin", async () => {
-    mockFetch.mockResolvedValue(
-      new Response(`{"code":"duplicate_cors_origin","message":"..."}`, {
-        status: 409,
-      }),
-    );
-    await expect(
-      createCORSOrigin(ctx, "key", "http://localhost:5173"),
-    ).resolves.toEqual({ modified: false });
-    expect(ctx.crash).not.toHaveBeenCalled();
-  });
-
-  test("returns modified: false when the origin already exists", async () => {
-    mockFetch.mockResolvedValue(
-      new Response(`{"message":"CORS origin already exists."}`, {
-        status: 409,
-      }),
-    );
-    await expect(
-      createCORSOrigin(ctx, "key", "http://localhost:5173"),
-    ).resolves.toEqual({ modified: false });
-    expect(ctx.crash).not.toHaveBeenCalled();
-  });
-
-  test("crashes with the body for a non-duplicate 409", async () => {
-    const body = `{"message":"Some other conflict."}`;
-    mockFetch.mockResolvedValue(new Response(body, { status: 409 }));
-    await expect(createCORSOrigin(ctx, "key", "http://x")).rejects.toThrow(
-      `Failed to create CORS origin: 409 ${body}`,
-    );
-    expect(ctx.crash).toHaveBeenCalledWith(
-      expect.objectContaining({
-        printedMessage: `Failed to create CORS origin: 409 ${body}`,
-      }),
-    );
-  });
-});