converse-mcp-server 2.9.6 → 2.9.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "converse-mcp-server",
-  "version": "2.9.6",
+  "version": "2.9.7",
   "description": "Converse MCP Server - Converse with other LLMs with chat and consensus tools",
   "type": "module",
   "main": "src/index.js",

package/src/async/fileCache.js

@@ -11,7 +11,6 @@ import { promises as fs } from 'fs';
 import path from 'path';
 import { debugLog, debugError } from '../utils/console.js';
 import { ConverseMCPError, ERROR_CODES } from '../utils/errorHandler.js';
-import { isSafeIdSegment } from '../utils/idValidation.js';
 
 /**
  * File cache specific error class
@@ -150,14 +149,6 @@ export class FileCache extends FileCacheInterface {
    * @private
    */
   getJobDir(jobId) {
-    if (!isSafeIdSegment(jobId)) {
-      throw new FileCacheError(
-        'Job ID contains unsafe characters',
-        ERROR_CODES.VALIDATION_ERROR,
-        { jobId },
-      );
-    }
-
     const today = new Date().toISOString().split('T')[0]; // yyyy-mm-dd
     return path.join(this.baseDir, today, jobId);
   }
@@ -210,15 +201,7 @@ export class FileCache extends FileCacheInterface {
     if (!jobId || typeof jobId !== 'string') {
       throw new FileCacheError(
         'Job ID must be a non-empty string',
-        ERROR_CODES.VALIDATION_ERROR,
-        { jobId },
-      );
-    }
-
-    if (!isSafeIdSegment(jobId)) {
-      throw new FileCacheError(
-        'Job ID contains unsafe characters',
-        ERROR_CODES.VALIDATION_ERROR,
+        ERROR_CODES.CACHE_WRITE_FAILED,
         { jobId },
       );
     }
@@ -282,15 +265,7 @@ export class FileCache extends FileCacheInterface {
     if (!jobId || typeof jobId !== 'string') {
       throw new FileCacheError(
         'Job ID must be a non-empty string',
-        ERROR_CODES.VALIDATION_ERROR,
-        { jobId },
-      );
-    }
-
-    if (!isSafeIdSegment(jobId)) {
-      throw new FileCacheError(
-        'Job ID contains unsafe characters',
-        ERROR_CODES.VALIDATION_ERROR,
+        ERROR_CODES.CACHE_WRITE_FAILED,
         { jobId },
       );
     }
@@ -349,15 +324,7 @@ export class FileCache extends FileCacheInterface {
     if (!jobId || typeof jobId !== 'string') {
       throw new FileCacheError(
         'Job ID must be a non-empty string',
-        ERROR_CODES.VALIDATION_ERROR,
-        { jobId },
-      );
-    }
-
-    if (!isSafeIdSegment(jobId)) {
-      throw new FileCacheError(
-        'Job ID contains unsafe characters',
-        ERROR_CODES.VALIDATION_ERROR,
+        ERROR_CODES.CACHE_READ_FAILED,
         { jobId },
       );
     }

package/src/providers/codex.js

@@ -284,7 +284,7 @@ export const codexProvider = {
       const rawWorkingDirectory = config.server?.client_cwd || process.cwd();
       // Normalize Windows extended-length paths (\\?\C:\...) to regular paths
       const workingDirectory = normalizeExtendedPath(rawWorkingDirectory);
-      const sandbox = config.providers?.codexsandboxmode || 'read-only';
+      const sandboxMode = config.providers?.codexsandboxmode || 'read-only';
       const skipGitRepoCheck =
         config.providers?.codexskipgitcheck !== undefined
           ? config.providers.codexskipgitcheck
@@ -294,7 +294,7 @@ export const codexProvider = {
       // Create or resume thread
       const threadOptions = {
         workingDirectory,
-        sandbox,
+        sandboxMode,
         skipGitRepoCheck,
         approvalPolicy,
       };

package/src/tools/chat.js

@@ -21,7 +21,6 @@ import { applyTokenLimit, getTokenLimit } from '../utils/tokenLimiter.js';
 import { validateAllPaths } from '../utils/fileValidator.js';
 import { SummarizationService } from '../services/summarizationService.js';
 import { exportConversation } from '../utils/conversationExporter.js';
-import { isRecoverableError, retryWithBackoff } from '../utils/errorHandler.js';
 
 const logger = createLogger('chat');
 
@@ -266,14 +265,12 @@ export async function chatTool(args, dependencies) {
 
     messages.push(userMessage);
 
-    // Select provider(s)
+    // Select provider
     let selectedProvider;
     let providerName;
 
-    const providerCandidates = [];
-
     if (model === 'auto') {
-      // Auto-select providers in priority order
+      // Auto-select first available provider in priority order
       // Prioritize subscription-based providers (codex, gemini-cli, claude) over API-key providers
       const providerOrder = [
         'codex',
@@ -291,17 +288,20 @@ export async function chatTool(args, dependencies) {
       for (const name of providerOrder) {
         const provider = providers[name];
         if (provider && provider.isAvailable && provider.isAvailable(config)) {
-          providerCandidates.push({ name, provider });
+          providerName = name;
+          selectedProvider = provider;
+          break;
         }
       }
 
-      if (providerCandidates.length === 0) {
+      if (!providerName) {
         return createToolError(
           'No providers available. Please configure at least one API key.',
         );
       }
     } else {
       // Use specified provider/model
+      // Try to map model to provider
       providerName = mapModelToProvider(model, providers);
       selectedProvider = providers[providerName];
 
@@ -314,60 +314,32 @@ export async function chatTool(args, dependencies) {
           `Provider ${providerName} is not available. Check API key configuration.`,
         );
       }
-
-      providerCandidates.push({ name: providerName, provider: selectedProvider });
     }
 
-    // Call provider with recovery (retry and, for auto, failover)
+    // Resolve model name and prepare provider options
+    const resolvedModel = resolveAutoModel(model, providerName);
+    const providerOptions = {
+      model: resolvedModel,
+      temperature,
+      reasoning_effort,
+      verbosity,
+      use_websearch,
+      config,
+      continuation_id, // Pass for thread resumption
+      continuationStore, // Pass store for state management
+    };
+
+    // Call provider
     let response;
     const startTime = Date.now();
-    let lastError;
-    let resolvedModel;
-
-    for (const candidate of providerCandidates) {
-      providerName = candidate.name;
-      selectedProvider = candidate.provider;
-
-      // Resolve model name and prepare provider options
-      resolvedModel = resolveAutoModel(model, providerName);
-      const providerOptions = {
-        model: resolvedModel,
-        temperature,
-        reasoning_effort,
-        verbosity,
-        use_websearch,
-        config,
-        continuation_id, // Pass for thread resumption
-        continuationStore, // Pass store for state management
-      };
-
-      try {
-        response = await retryWithBackoff(
-          () => selectedProvider.invoke(messages, providerOptions),
-          getProviderRetryOptions(config, providerName),
-        );
-        break;
-      } catch (error) {
-        lastError = error;
-        logger.error('Provider error', {
-          error,
-          data: { provider: providerName },
-        });
-
-        if (
-          model !== 'auto' ||
-          !shouldFailoverToNextProvider(error) ||
-          candidate === providerCandidates[providerCandidates.length - 1]
-        ) {
-          return createToolError(`Provider error: ${error.message}`);
-        }
-      }
-    }
-
-    if (!response) {
-      return createToolError(
-        `Provider error: ${(lastError && lastError.message) || 'Unknown error'}`,
-      );
+    try {
+      response = await selectedProvider.invoke(messages, providerOptions);
+    } catch (error) {
+      logger.error('Provider error', {
+        error,
+        data: { provider: providerName },
+      });
+      return createToolError(`Provider error: ${error.message}`);
     }
     const executionTime = (Date.now() - startTime) / 1000; // Convert to seconds
 
@@ -500,29 +472,6 @@ function resolveAutoModel(model, providerName) {
   return defaults[providerName] || 'gpt-5';
 }
 
-function getProviderRetryOptions(config, providerName) {
-  const nodeEnv = config?.environment?.nodeEnv || process.env.NODE_ENV;
-  const isTest = nodeEnv === 'test';
-
-  return {
-    retries: isTest ? 1 : 3,
-    delay: isTest ? 0 : 500,
-    maxDelay: isTest ? 0 : 10000,
-    operation: `provider-invoke:${providerName}`,
-  };
-}
-
-function shouldFailoverToNextProvider(error) {
-  if (isRecoverableError(error)) {
-    return true;
-  }
-
-  const message = (error && error.message) || '';
-  return /(api key|authentication|unauthorized|forbidden|invalid|not available)/i.test(
-    message,
-  );
-}
-
 export function mapModelToProvider(model, providers) {
   const modelLower = model.toLowerCase();
 

package/src/tools/checkStatus.js

@@ -17,7 +17,6 @@ import {
   formatJobListHumanReadable,
   formatConversationHistory,
 } from '../utils/formatStatus.js';
-import { isSafeIdSegment } from '../utils/idValidation.js';
 
 const logger = createLogger('check-status');
 
@@ -37,22 +36,8 @@ export async function checkStatusTool(args, dependencies) {
     const { continuation_id, full_history = false } = args;
 
     // Validate arguments
-    if (continuation_id !== undefined) {
-      if (typeof continuation_id !== 'string') {
-        return createToolError('continuation_id must be a string');
-      }
-
-      if (continuation_id.length === 0) {
-        return createToolError(
-          'Invalid continuation_id: must be a non-empty string',
-        );
-      }
-
-      if (!isSafeIdSegment(continuation_id)) {
-        return createToolError(
-          'Invalid continuation_id: contains unsafe characters',
-        );
-      }
+    if (continuation_id && typeof continuation_id !== 'string') {
+      return createToolError('continuation_id must be a string');
     }
 
     const asyncJobStore = getAsyncJobStore();

package/src/utils/idValidation.js

@@ -1,32 +0,0 @@
-/**
- * ID validation helpers
- *
- * These are intentionally conservative and are primarily used to ensure IDs that
- * are used as filesystem path segments cannot escape their intended directory.
- */
-
-/**
- * Check whether an ID is safe to use as a single filesystem path segment.
- *
- * Allowed characters: A–Z a–z 0–9 _ -
- * Disallowed: path separators, dots, whitespace, and other punctuation.
- *
- * @param {unknown} id
- * @param {object} [options]
- * @param {number} [options.maxLength]
- * @returns {boolean}
- */
-export function isSafeIdSegment(id, options = {}) {
-  const { maxLength = 128 } = options;
-
-  if (typeof id !== 'string') {
-    return false;
-  }
-
-  if (id.length === 0 || id.length > maxLength) {
-    return false;
-  }
-
-  return /^[A-Za-z0-9_-]+$/.test(id);
-}
-