converse-mcp-server 2.3.1 → 2.4.1

package/src/systemPrompts.js

@@ -1,90 +1,90 @@
-/**
- * System Prompts for Converse MCP Server Tools
- *
- * Matches the Python implementation system prompts exactly for feature parity.
- */
-
-/**
- * Chat tool system prompt - matches Python systemprompts/chat_prompt.py
- */
-export const CHAT_PROMPT = `
-You are a senior engineering thought-partner collaborating with another AI agent. Your mission is to brainstorm, validate ideas,
-and offer well-reasoned second opinions on technical decisions when they are justified and practical.
-
-CRITICAL LINE NUMBER INSTRUCTIONS
-Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be
-included in any code you generate. Always reference specific line numbers in your replies in order to locate
-exact positions if needed to point to exact locations. Include a very short code excerpt alongside for clarity.
-Include context_start_text and context_end_text as backup references. Never include "LINE│" markers in generated code
-snippets.
-
-IF MORE INFORMATION IS NEEDED
-If the agent is discussing specific code, functions, or project components that was not given as part of the context,
-and you need additional context (e.g., related files, configuration, dependencies, test files) to provide meaningful
-collaboration, you MUST respond ONLY with this JSON format (and nothing else). Do NOT ask for the same file you've been
-provided unless for some reason its content is missing or incomplete:
-{
-  "status": "files_required_to_continue",
-  "mandatory_instructions": "<your critical instructions for the agent>",
-  "files_needed": ["[file name here]", "[or some folder/]"]
-}
-
-CORE PRINCIPLES
-• Work within the existing tech stack and architecture
-• Avoid overengineering - prefer simple, practical solutions
-• Focus on current scope, not speculative future needs
-• Provide concrete, actionable recommendations with clear trade-offs
-• Surface potential issues early and challenge assumptions constructively
-`.trim();
-
-/**
- * Consensus tool system prompt - matches Python systemprompts/consensus_prompt.py
- */
-export const CONSENSUS_PROMPT = `
-You're analyzing a technical problem alongside other AI models. Each model will propose solutions independently, then potentially see others' approaches.
-
-Your goal: Find the best solution, whether it's yours or another model's. The key is often a single insight that makes everything click.
-
-CRITICAL LINE NUMBER INSTRUCTIONS
-Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be
-included in any code you generate. Always reference specific line numbers in your replies in order to locate
-exact positions if needed to point to exact locations. Include a very short code excerpt alongside for clarity.
-Never include "LINE│" markers in generated code snippets.
-
-IF MORE INFORMATION IS NEEDED
-If you need to see specific code, files, or technical context to properly analyze the problem, respond with this exact JSON:
-{
-  "status": "files_required_to_continue",
-  "mandatory_instructions": "<your critical instructions for the agent>",
-  "files_needed": ["[file name here]", "[or some folder/]"]
-}
-
-MANDATORY RESPONSE FORMAT
-You MUST respond in exactly this Markdown structure:
-
-## Approach
-Present your solution and the key insight behind it. Be direct and clear about what makes your approach work.
-If you're reviewing others' solutions, you'll do that in a later phase.
-
-## Why This Works
-Explain the technical reasoning. Be specific about why this approach solves the problem effectively.
-What's the core mechanism or principle that makes it succeed?
-
-## Implementation
-Provide concrete code or steps if relevant. Show exactly how to implement your approach.
-Focus on clarity and correctness.
-
-## Trade-offs
-What are the limitations or considerations? Be honest about where this approach might struggle
-or what alternatives might be better in certain contexts.
-
-QUALITY STANDARDS
-- Focus on finding the most elegant solution
-- Look for the key insight that simplifies the problem
-- Be direct - don't hedge unnecessarily
-- Value clarity and simplicity
-- Consider edge cases and robustness
-- Stay technical and grounded
-
-Remember: The best solution often has one breakthrough insight that makes the complexity fall away.
+/**
+ * System Prompts for Converse MCP Server Tools
+ *
+ * Matches the Python implementation system prompts exactly for feature parity.
+ */
+
+/**
+ * Chat tool system prompt - matches Python systemprompts/chat_prompt.py
+ */
+export const CHAT_PROMPT = `
+You are a senior engineering thought-partner collaborating with another AI agent. Your mission is to brainstorm, validate ideas,
+and offer well-reasoned second opinions on technical decisions when they are justified and practical.
+
+CRITICAL LINE NUMBER INSTRUCTIONS
+Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be
+included in any code you generate. Always reference specific line numbers in your replies in order to locate
+exact positions if needed to point to exact locations. Include a very short code excerpt alongside for clarity.
+Include context_start_text and context_end_text as backup references. Never include "LINE│" markers in generated code
+snippets.
+
+IF MORE INFORMATION IS NEEDED
+If the agent is discussing specific code, functions, or project components that was not given as part of the context,
+and you need additional context (e.g., related files, configuration, dependencies, test files) to provide meaningful
+collaboration, you MUST respond ONLY with this JSON format (and nothing else). Do NOT ask for the same file you've been
+provided unless for some reason its content is missing or incomplete:
+{
+  "status": "files_required_to_continue",
+  "mandatory_instructions": "<your critical instructions for the agent>",
+  "files_needed": ["[file name here]", "[or some folder/]"]
+}
+
+CORE PRINCIPLES
+• Work within the existing tech stack and architecture
+• Avoid overengineering - prefer simple, practical solutions
+• Focus on current scope, not speculative future needs
+• Provide concrete, actionable recommendations with clear trade-offs
+• Surface potential issues early and challenge assumptions constructively
+`.trim();
+
+/**
+ * Consensus tool system prompt - matches Python systemprompts/consensus_prompt.py
+ */
+export const CONSENSUS_PROMPT = `
+You're analyzing a technical problem alongside other AI models. Each model will propose solutions independently, then potentially see others' approaches.
+
+Your goal: Find the best solution, whether it's yours or another model's. The key is often a single insight that makes everything click.
+
+CRITICAL LINE NUMBER INSTRUCTIONS
+Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be
+included in any code you generate. Always reference specific line numbers in your replies in order to locate
+exact positions if needed to point to exact locations. Include a very short code excerpt alongside for clarity.
+Never include "LINE│" markers in generated code snippets.
+
+IF MORE INFORMATION IS NEEDED
+If you need to see specific code, files, or technical context to properly analyze the problem, respond with this exact JSON:
+{
+  "status": "files_required_to_continue",
+  "mandatory_instructions": "<your critical instructions for the agent>",
+  "files_needed": ["[file name here]", "[or some folder/]"]
+}
+
+MANDATORY RESPONSE FORMAT
+You MUST respond in exactly this Markdown structure:
+
+## Approach
+Present your solution and the key insight behind it. Be direct and clear about what makes your approach work.
+If you're reviewing others' solutions, you'll do that in a later phase.
+
+## Why This Works
+Explain the technical reasoning. Be specific about why this approach solves the problem effectively.
+What's the core mechanism or principle that makes it succeed?
+
+## Implementation
+Provide concrete code or steps if relevant. Show exactly how to implement your approach.
+Focus on clarity and correctness.
+
+## Trade-offs
+What are the limitations or considerations? Be honest about where this approach might struggle
+or what alternatives might be better in certain contexts.
+
+QUALITY STANDARDS
+- Focus on finding the most elegant solution
+- Look for the key insight that simplifies the problem
+- Be direct - don't hedge unnecessarily
+- Value clarity and simplicity
+- Consider edge cases and robustness
+- Stay technical and grounded
+
+Remember: The best solution often has one breakthrough insight that makes the complexity fall away.
 `.trim();

package/src/tools/cancelJob.js

@@ -45,7 +45,9 @@ export async function cancelJobTool(args, dependencies) {
 
   if (!dependencies?.asyncJobStore) {
     debugError('CancelJob: Missing AsyncJobStore dependency');
-    return createToolError('Service not available: AsyncJobStore not configured');
+    return createToolError(
+      'Service not available: AsyncJobStore not configured',
+    );
   }
 
   const { jobRunner, asyncJobStore, config, providers } = dependencies;
@@ -53,7 +55,9 @@ export async function cancelJobTool(args, dependencies) {
   try {
     // Validate continuation_id
     if (!continuation_id || typeof continuation_id !== 'string') {
-      return createToolError('Invalid continuation_id: must be a non-empty string');
+      return createToolError(
+        'Invalid continuation_id: must be a non-empty string',
+      );
     }
 
     debugLog(`CancelJob: Attempting to cancel job ${continuation_id}`);
@@ -68,14 +72,17 @@ export async function cancelJobTool(args, dependencies) {
       });
     }
 
-    debugLog(`CancelJob: Found job ${continuation_id} with status: ${jobState.status}`);
+    debugLog(
+      `CancelJob: Found job ${continuation_id} with status: ${jobState.status}`,
+    );
 
     // Check if job is in a cancellable state
     const cancellableStatuses = ['queued', 'running'];
     if (!cancellableStatuses.includes(jobState.status)) {
-      const message = jobState.status === 'cancelled'
-        ? `Job ${continuation_id} is already cancelled`
-        : `Job ${continuation_id} cannot be cancelled (status: ${jobState.status})`;
+      const message =
+        jobState.status === 'cancelled'
+          ? `Job ${continuation_id} is already cancelled`
+          : `Job ${continuation_id} cannot be cancelled (status: ${jobState.status})`;
 
       return createToolResponse({
         status: 'not_cancellable',
@@ -95,7 +102,9 @@ export async function cancelJobTool(args, dependencies) {
       const updatedJobState = await asyncJobStore.get(continuation_id);
 
       // Calculate actual elapsed time from job creation
-      const elapsedMs = Date.now() - (updatedJobState?.createdAt || jobState.createdAt || Date.now());
+      const elapsedMs =
+        Date.now() -
+        (updatedJobState?.createdAt || jobState.createdAt || Date.now());
       const elapsedSeconds = elapsedMs / 1000;
 
       // Format elapsed time
@@ -113,7 +122,9 @@ export async function cancelJobTool(args, dependencies) {
 
       // Status line with proper timing
       const statusEmoji = '⛔';
-      const startTime = updatedJobState?.createdAt ? new Date(updatedJobState.createdAt).toLocaleString() : 'unknown';
+      const startTime = updatedJobState?.createdAt
+        ? new Date(updatedJobState.createdAt).toLocaleString()
+        : 'unknown';
 
       let statusLine = `${statusEmoji} CANCELLED | ${updatedJobState?.tool?.toUpperCase() || jobState.tool?.toUpperCase() || 'UNKNOWN'} | ${continuation_id} | Started: ${startTime} | ${timeStr} elapsed`;
 
@@ -130,9 +141,10 @@ export async function cancelJobTool(args, dependencies) {
 
       // Add partial results info if available
       if (updatedJobState?.accumulated_content) {
-        const preview = updatedJobState.accumulated_content.length > 200
-          ? updatedJobState.accumulated_content.substring(0, 200) + '...'
-          : updatedJobState.accumulated_content;
+        const preview =
+          updatedJobState.accumulated_content.length > 200
+            ? updatedJobState.accumulated_content.substring(0, 200) + '...'
+            : updatedJobState.accumulated_content;
         parts.push(`Partial results available: "${preview}"`);
       } else if (updatedJobState?.result) {
         parts.push('Partial results available in job state');
@@ -149,11 +161,15 @@ export async function cancelJobTool(args, dependencies) {
           cancelled_at: new Date().toISOString(),
           previous_status: jobState.status,
           elapsed_seconds: elapsedSeconds,
-          has_partial_results: !!(updatedJobState?.result || updatedJobState?.accumulated_content)
-        }
+          has_partial_results: !!(
+            updatedJobState?.result || updatedJobState?.accumulated_content
+          ),
+        },
       });
     } else {
-      debugLog(`CancelJob: Failed to cancel job ${continuation_id} - may have completed`);
+      debugLog(
+        `CancelJob: Failed to cancel job ${continuation_id} - may have completed`,
+      );
 
       // Job may have completed between our checks
       const currentJobState = await asyncJobStore.get(continuation_id);
@@ -165,14 +181,10 @@ export async function cancelJobTool(args, dependencies) {
         current_status: currentJobState?.status || 'unknown',
       });
     }
-
   } catch (error) {
     debugError(`CancelJob: Error cancelling job ${continuation_id}:`, error);
 
-    return createToolError(
-      `Failed to cancel job ${continuation_id}`,
-      error
-    );
+    return createToolError(`Failed to cancel job ${continuation_id}`, error);
   }
 }