contract-driven-delivery 1.0.1 → 1.6.0

package/assets/skill/scripts/validate_ci_gates.py

@@ -3,12 +3,40 @@
 from pathlib import Path
 import argparse, sys
 REQUIRED_TERMS=['required gates','tier','trigger','workflow','promotion policy','rollback policy']
-def main():
-    ap=argparse.ArgumentParser(); ap.add_argument('path')
-    args=ap.parse_args(); p=Path(args.path)
-    if not p.exists(): print(f'{p} not found'); sys.exit(1)
+def check_file(p):
+    """Check one ci-gates.md file. Returns list of error strings."""
+    errors=[]
     text=p.read_text(encoding='utf-8', errors='ignore').lower()
     missing=[t for t in REQUIRED_TERMS if t not in text]
-    if missing: print('ci-gates missing terms: '+', '.join(missing)); sys.exit(1)
-    print('CI gates basic validation passed.')
+    if missing:
+        errors.append(f'{p}: ci-gates missing terms: '+', '.join(missing))
+    else:
+        print(f'CI gates basic validation passed: {p}')
+    return errors
+def main():
+    ap=argparse.ArgumentParser(); ap.add_argument('path', nargs='?', default=None)
+    args=ap.parse_args()
+    if args.path is not None:
+        p=Path(args.path)
+        if not p.exists():
+            print(f'Warning: {p} not found -- skipping CI gates validation (file not yet created).')
+            sys.exit(0)
+        errors=check_file(p)
+        if errors: [print(e) for e in errors]; sys.exit(1)
+        sys.exit(0)
+    # No argument: scan specs/changes/*/ci-gates.md
+    changes_root=Path('specs/changes')
+    if not changes_root.exists():
+        print('Warning: specs/changes/ not found -- skipping CI gates validation.')
+        sys.exit(0)
+    gates_files=sorted(changes_root.glob('*/ci-gates.md'))
+    if not gates_files:
+        print('Warning: no ci-gates.md found in specs/changes/ -- skipping CI gates validation.')
+        sys.exit(0)
+    all_errors=[]
+    for p in gates_files:
+        all_errors.extend(check_file(p))
+    if all_errors:
+        [print(e) for e in all_errors]; sys.exit(1)
+    sys.exit(0)
 if __name__=='__main__': main()

package/assets/skill/scripts/validate_contract_versions.py

@@ -0,0 +1,385 @@
+#!/usr/bin/env python3
+"""
+validate_contract_versions.py — Contract Version Control Validator (v1.2.0)
+
+For every contract file, validates:
+  - frontmatter presence and schema correctness (always)
+  - content-change ↔ version-bump coherence (1.0+ only)
+  - no version skips or downgrades (1.0+ only)
+  - CHANGELOG.md entry exists for every bump (1.0+ only)
+  - major bump CHANGELOG entry includes ### Removed or ### Changed (breaking)
+"""
+
+import argparse
+import hashlib
+import re
+import subprocess
+import sys
+from pathlib import Path
+
+# ── Constants ─────────────────────────────────────────────────────────────────
+
+CONTRACT_FILES = [
+    'contracts/api/api-contract.md',
+    'contracts/css/css-contract.md',
+    'contracts/env/env-contract.md',
+    'contracts/data/data-shape-contract.md',
+    'contracts/business/business-rules.md',
+    'contracts/ci/ci-gate-contract.md',
+]
+
+VALID_CONTRACT_TYPES = {'api', 'css', 'env', 'data', 'business', 'ci'}
+VALID_BREAKING_POLICIES = {'deprecate-2-minors', 'fail-on-major', 'no-breaking'}
+SEMVER_RE = re.compile(r'^\d+\.\d+\.\d+$')
+DATE_RE = re.compile(r'^\d{4}-\d{2}-\d{2}$')
+
+CHANGELOG_PATH = 'contracts/CHANGELOG.md'
+
+# ── Frontmatter Parser (zero-dependency) ──────────────────────────────────────
+
+def parse_frontmatter(text: str):
+    """
+    Parse YAML-style frontmatter from a markdown file.
+    Returns (fields_dict, body_text) or (None, text) if no frontmatter.
+    Handles the pattern: ^---\n...\n---\n
+    """
+    if not text.startswith('---\n'):
+        return None, text
+
+    end = text.find('\n---\n', 4)
+    if end == -1:
+        return None, text
+
+    fm_block = text[4:end]
+    body = text[end + 5:]  # skip '\n---\n'
+
+    fields = {}
+    for line in fm_block.splitlines():
+        if ':' in line:
+            key, _, value = line.partition(':')
+            fields[key.strip()] = value.strip()
+
+    return fields, body
+
+
+def strip_frontmatter(text: str) -> str:
+    """Return the body text with frontmatter removed."""
+    _, body = parse_frontmatter(text)
+    return body
+
+
+def sha256_of(text: str) -> str:
+    return hashlib.sha256(text.encode('utf-8')).hexdigest()
+
+
+# ── Semver helpers ────────────────────────────────────────────────────────────
+
+def parse_semver(s: str):
+    """Return (major, minor, patch) tuple or None."""
+    m = SEMVER_RE.match(s)
+    if not m:
+        return None
+    parts = s.split('.')
+    return int(parts[0]), int(parts[1]), int(parts[2])
+
+
+def is_pre_1_0(ver_tuple) -> bool:
+    return ver_tuple[0] == 0
+
+
+# ── CHANGELOG parser ──────────────────────────────────────────────────────────
+
+def parse_changelog(root: Path):
+    """
+    Parse contracts/CHANGELOG.md and return a dict:
+      { (contract_type, version_str): set_of_section_types }
+    section types are the ### headings: 'Added', 'Changed (non-breaking)', etc.
+    """
+    cl_path = root / CHANGELOG_PATH
+    if not cl_path.exists():
+        return {}
+
+    text = cl_path.read_text(encoding='utf-8', errors='ignore')
+    entries = {}
+
+    # Match headings like: ## [api 1.0.0] — 2026-01-10
+    heading_re = re.compile(
+        r'^## \[([a-z]+) (\d+\.\d+\.\d+)\]',
+        re.MULTILINE
+    )
+    section_re = re.compile(r'^### (.+)$', re.MULTILINE)
+
+    matches = list(heading_re.finditer(text))
+    for i, m in enumerate(matches):
+        contract_type = m.group(1)
+        version = m.group(2)
+        start = m.end()
+        end = matches[i + 1].start() if i + 1 < len(matches) else len(text)
+        block = text[start:end]
+
+        sections = set(s.strip() for s in section_re.findall(block))
+        entries[(contract_type, version)] = sections
+
+    return entries
+
+
+# ── Git helpers ───────────────────────────────────────────────────────────────
+
+def git_available(root: Path) -> bool:
+    """Return True if git is available and root is inside a git repo."""
+    try:
+        r = subprocess.run(
+            ['git', 'rev-parse', '--git-dir'],
+            capture_output=True,
+            text=True,
+            cwd=str(root),
+        )
+        return r.returncode == 0
+    except FileNotFoundError:
+        return False
+
+
+def git_show_head(root: Path, rel_path: str) -> str | None:
+    """
+    Return file content at HEAD, or None if:
+    - git unavailable
+    - file not tracked / no HEAD yet
+    """
+    try:
+        r = subprocess.run(
+            ['git', 'show', f'HEAD:{rel_path}'],
+            capture_output=True,
+            text=True,
+            cwd=str(root),
+        )
+        if r.returncode == 0:
+            return r.stdout
+        return None
+    except FileNotFoundError:
+        return None
+
+
+# ── Per-file validation ───────────────────────────────────────────────────────
+
+def validate_format(rel_path: str, fields, errors: list) -> bool:
+    """
+    Validate frontmatter fields. Returns True if all required fields pass.
+    Appends error messages to `errors`.
+    """
+    ok = True
+
+    if fields is None:
+        errors.append(f'{rel_path}: missing frontmatter (expected ---...--- block)')
+        return False
+
+    # contract type
+    contract = fields.get('contract', '')
+    if not contract:
+        errors.append(f'{rel_path}: frontmatter missing field "contract"')
+        ok = False
+    elif contract not in VALID_CONTRACT_TYPES:
+        errors.append(
+            f'{rel_path}: invalid contract type "{contract}" '
+            f'(allowed: {", ".join(sorted(VALID_CONTRACT_TYPES))})'
+        )
+        ok = False
+
+    # schema-version
+    schema_version = fields.get('schema-version', '')
+    if not schema_version:
+        errors.append(f'{rel_path}: frontmatter missing field "schema-version"')
+        ok = False
+    elif not SEMVER_RE.match(schema_version):
+        errors.append(
+            f'{rel_path}: invalid schema-version "{schema_version}" '
+            f'(must match X.Y.Z)'
+        )
+        ok = False
+
+    # last-changed
+    last_changed = fields.get('last-changed', '')
+    if not last_changed:
+        errors.append(f'{rel_path}: frontmatter missing field "last-changed"')
+        ok = False
+    elif not DATE_RE.match(last_changed):
+        errors.append(
+            f'{rel_path}: invalid last-changed "{last_changed}" '
+            f'(must be YYYY-MM-DD)'
+        )
+        ok = False
+
+    # breaking-change-policy
+    policy = fields.get('breaking-change-policy', '')
+    if not policy:
+        errors.append(f'{rel_path}: frontmatter missing field "breaking-change-policy"')
+        ok = False
+    elif policy not in VALID_BREAKING_POLICIES:
+        errors.append(
+            f'{rel_path}: invalid breaking-change-policy "{policy}" '
+            f'(allowed: {", ".join(sorted(VALID_BREAKING_POLICIES))})'
+        )
+        ok = False
+
+    return ok
+
+
+def validate_file(root: Path, rel_path: str, changelog_entries: dict, errors: list):
+    abs_path = root / rel_path
+
+    if not abs_path.exists():
+        errors.append(f'{rel_path}: file not found')
+        return
+
+    current_text = abs_path.read_text(encoding='utf-8', errors='ignore')
+    current_fields, current_body = parse_frontmatter(current_text)
+
+    # ── Always validate format ────────────────────────────────────────────────
+    format_ok = validate_format(rel_path, current_fields, errors)
+    if not format_ok:
+        return  # cannot proceed without valid frontmatter
+
+    schema_version_str = current_fields.get('schema-version', '')
+    current_ver = parse_semver(schema_version_str)
+    if current_ver is None:
+        return  # already caught above
+
+    contract_type = current_fields.get('contract', '')
+
+    # ── Try to get HEAD version ───────────────────────────────────────────────
+    head_text = git_show_head(root, rel_path)
+
+    if head_text is None:
+        # New/untracked file or no HEAD — baseline, format already validated
+        return
+
+    head_fields, head_body = parse_frontmatter(head_text)
+
+    if head_fields is None:
+        # HEAD had no frontmatter — treat as baseline (format already validated)
+        return
+
+    head_version_str = head_fields.get('schema-version', '')
+    head_ver = parse_semver(head_version_str)
+    if head_ver is None:
+        # HEAD had invalid version — can't compare sensibly, skip extra rules
+        return
+
+    # ── Pre-1.0: only format validation ──────────────────────────────────────
+    if is_pre_1_0(current_ver):
+        return
+
+    # ── Post-1.0 rules ────────────────────────────────────────────────────────
+
+    current_body_hash = sha256_of(current_body)
+    head_body_hash = sha256_of(head_body)
+    content_changed = current_body_hash != head_body_hash
+    version_changed = current_ver != head_ver
+
+    # a) Content ↔ version coherence
+    if content_changed and not version_changed:
+        errors.append(
+            f'{rel_path}: content changed but schema-version not bumped '
+            f'(still {schema_version_str})'
+        )
+        return
+
+    if version_changed and not content_changed:
+        errors.append(
+            f'{rel_path}: version changed without content change '
+            f'({head_version_str} → {schema_version_str})'
+        )
+        return
+
+    if not version_changed:
+        # No change at all — fine
+        return
+
+    # b) Version bump rules (version_changed == True here)
+    new_maj, new_min, new_pat = current_ver
+    old_maj, old_min, old_pat = head_ver
+
+    # No downgrade
+    if current_ver < head_ver:
+        errors.append(
+            f'{rel_path}: schema-version downgrade not allowed '
+            f'({head_version_str} → {schema_version_str})'
+        )
+        return
+
+    # Major bump: must be exactly +1, minor and patch reset to 0
+    if new_maj > old_maj:
+        if new_maj != old_maj + 1:
+            errors.append(
+                f'{rel_path}: major version skip not allowed '
+                f'({head_version_str} → {schema_version_str}); '
+                f'must increment by 1'
+            )
+            return
+        # major bump is valid version increment; fall through to CHANGELOG check
+
+    # Minor bump (same major): must be exactly +1, patch reset to 0
+    elif new_min > old_min:
+        if new_min != old_min + 1:
+            errors.append(
+                f'{rel_path}: minor version skip not allowed '
+                f'({head_version_str} → {schema_version_str}); '
+                f'must increment by 1'
+            )
+            return
+
+    # Patch bump (same major.minor): any positive increment is ok
+
+    # c) CHANGELOG entry required
+    key = (contract_type, schema_version_str)
+    if key not in changelog_entries:
+        errors.append(
+            f'{rel_path}: schema-version bumped to {schema_version_str} '
+            f'but no CHANGELOG entry "## [{contract_type} {schema_version_str}]" found'
+        )
+        return
+
+    # d) Major bump requires ### Removed or ### Changed (breaking)
+    if new_maj > old_maj:
+        sections = changelog_entries[key]
+        if 'Removed' not in sections and 'Changed (breaking)' not in sections:
+            errors.append(
+                f'{rel_path}: major version bump to {schema_version_str} '
+                f'requires "### Removed" or "### Changed (breaking)" '
+                f'in CHANGELOG entry (found sections: {sections or "none"})'
+            )
+
+
+# ── Main ──────────────────────────────────────────────────────────────────────
+
+def main():
+    ap = argparse.ArgumentParser(
+        description='Validate contract file versions against frontmatter and CHANGELOG.'
+    )
+    ap.add_argument('root', nargs='?', default='.', help='Project root directory')
+    args = ap.parse_args()
+    root = Path(args.root).resolve()
+
+    if not git_available(root):
+        print(
+            'Warning: git not available or not a git repo — '
+            'skipping version comparison checks, validating format only.'
+        )
+
+    changelog_entries = parse_changelog(root)
+    errors: list[str] = []
+
+    for rel_path in CONTRACT_FILES:
+        validate_file(root, rel_path, changelog_entries, errors)
+
+    if errors:
+        print('Contract version validation FAILED:')
+        for e in errors:
+            print(f'  FAIL: {e}')
+        sys.exit(1)
+    else:
+        print('Contract version validation passed.')
+        sys.exit(0)
+
+
+if __name__ == '__main__':
+    main()

package/assets/skill/scripts/validate_contracts.py

@@ -1,13 +1,37 @@
 #!/usr/bin/env python3
 """Check for required contract surfaces."""
 from pathlib import Path
-import argparse, sys
+import argparse, sys, re
 REQUIRED=['contracts/api/api-contract.md','contracts/css/css-contract.md','contracts/env/env-contract.md','contracts/data/data-shape-contract.md','contracts/business/business-rules.md','contracts/ci/ci-gate-contract.md']
+PLACEHOLDER_THRESHOLD=470
+
+def meaningful_chars(text):
+    """Return text stripped of markdown headings, blank lines, table borders, and comments."""
+    lines=text.splitlines()
+    filtered=[]
+    for line in lines:
+        s=line.strip()
+        if not s: continue
+        if s.startswith('#'): continue
+        if re.match(r'^[|\s\-:]+$', s): continue
+        if s.startswith('<!--'): continue
+        filtered.append(s)
+    return ''.join(filtered)
+
 def main():
     ap=argparse.ArgumentParser(); ap.add_argument('root', nargs='?', default='.')
     args=ap.parse_args(); root=Path(args.root)
     missing=[p for p in REQUIRED if not (root/p).exists()]
     if missing:
         print('Missing contract files:'); [print(f'- {p}') for p in missing]; sys.exit(1)
+    placeholders=[]
+    for p in REQUIRED:
+        text=(root/p).read_text(encoding='utf-8', errors='ignore')
+        if len(meaningful_chars(text))<PLACEHOLDER_THRESHOLD:
+            placeholders.append(p)
+    if placeholders:
+        print('Error: contracts present but appear empty: '+', '.join(placeholders))
+        print('Fill them in before relying on the gate.')
+        sys.exit(1)
     print('All required contract files are present.')
 if __name__=='__main__': main()

package/assets/skill/scripts/validate_env_contract.py

@@ -6,7 +6,9 @@ REQUIRED_COLUMNS=['name','scope','required','secret','default','example','valida
 def main():
     ap=argparse.ArgumentParser(); ap.add_argument('path', nargs='?', default='contracts/env/env-contract.md')
     args=ap.parse_args(); p=Path(args.path)
-    if not p.exists(): print(f'{p} not found'); sys.exit(1)
+    if not p.exists():
+        print(f'Warning: {p} not found -- skipping env contract validation (file not yet created).')
+        sys.exit(0)
     text=p.read_text(encoding='utf-8', errors='ignore').lower()
     missing=[c for c in REQUIRED_COLUMNS if c not in text]
     if missing: print('Env contract missing columns/terms: '+', '.join(missing)); sys.exit(1)

package/assets/skill/scripts/validate_env_semantic.py

@@ -0,0 +1,182 @@
+#!/usr/bin/env python3
+"""Semantic validation of the env contract variable table.
+
+Reads contracts/env/env-contract.md (relative to cwd), skips YAML frontmatter,
+finds the variable table (first markdown table whose header starts with '| name |'),
+and validates each data row for:
+  - secret=true AND non-empty default → fail (secrets must not have defaults)
+  - required=true AND secret=false AND empty default → warn only (valid scenario)
+
+Column order expected:
+  name | scope | environments | required | secret | default | example | owner |
+  validation | restart required | failure behavior
+"""
+import sys
+import re
+from pathlib import Path
+
+CONTRACT_PATH = Path('contracts/env/env-contract.md')
+
+# Column indices (0-based)
+COL_NAME     = 0
+COL_REQUIRED = 3
+COL_SECRET   = 4
+COL_DEFAULT  = 5
+
+
+def strip_frontmatter(text: str) -> str:
+    """Remove YAML frontmatter delimited by --- ... ---."""
+    if text.startswith('---'):
+        end = text.find('\n---', 3)
+        if end != -1:
+            return text[end + 4:].lstrip('\n')
+    return text
+
+
+def parse_table_row(line: str) -> list[str]:
+    """Split a markdown table row into stripped cell values."""
+    row = line.strip().strip('|')
+    return [cell.strip() for cell in row.split('|')]
+
+
+def is_separator_row(cells: list[str]) -> bool:
+    """Return True if this is a markdown table separator (---|---|...)."""
+    return all(re.match(r'^:?-+:?$', c) for c in cells if c)
+
+
+def is_truthy(val: str) -> bool:
+    """Return True if the value represents a truthy boolean in the table."""
+    return val.lower() in {'true', 'yes', '1'}
+
+
+def is_empty_default(val: str) -> bool:
+    """Return True if the default column represents an absent/empty value."""
+    return val in {'', '-', 'n/a', 'none', '—'}
+
+
+def find_variable_table(lines: list[str]) -> list[tuple[int, str]]:
+    """
+    Find all rows belonging to any table with a '| name |' header in the document.
+    This is robust to blank lines within the table and to the table header appearing
+    multiple times (e.g., when content is appended to a file that already has a header).
+    Returns list of (line_number, raw_line) for all data rows across all matching tables.
+    """
+    # Collect all (line_index, line) pairs that start with '|'
+    # Track which lines are headers, separators, or data rows.
+    in_name_table = False
+    sep_seen = False
+    data_rows: list[tuple[int, str]] = []
+
+    for i, line in enumerate(lines):
+        stripped = line.strip()
+
+        # Blank lines inside a table: keep scanning (don't break out of table mode)
+        if not stripped:
+            continue
+
+        if not stripped.startswith('|'):
+            # Non-pipe line: if we were collecting data, pause (but don't stop searching)
+            # A new section heading might precede another occurrence of the table header.
+            # We keep `in_name_table` True so we capture data rows even after headings.
+            continue
+
+        cells = parse_table_row(stripped)
+        if not cells:
+            continue
+
+        # A header row for a '| name |' table
+        if cells[0].lower() == 'name':
+            in_name_table = True
+            sep_seen = False
+            continue  # skip header row itself
+
+        if not in_name_table:
+            continue
+
+        # Separator row
+        if not sep_seen and is_separator_row(cells):
+            sep_seen = True
+            continue
+
+        # Data row
+        data_rows.append((i + 1, line))
+
+    return data_rows
+
+
+def main() -> None:
+    cwd = Path('.')
+    contract = cwd / CONTRACT_PATH
+
+    if not contract.exists():
+        print(f'Env contract not found: {CONTRACT_PATH}')
+        sys.exit(1)
+
+    try:
+        raw = contract.read_text(encoding='utf-8', errors='ignore')
+    except OSError as e:
+        print(f'Cannot read {CONTRACT_PATH}: {e}')
+        sys.exit(1)
+
+    if not raw.strip():
+        print('Env contract: file is empty.')
+        sys.exit(1)
+
+    body = strip_frontmatter(raw)
+    lines = body.splitlines()
+
+    data_rows = find_variable_table(lines)
+
+    if not data_rows:
+        print('Env contract: no variable table found')
+        sys.exit(1)
+
+    errors: list[str] = []
+    warnings: list[str] = []
+
+    for lineno, raw_line in data_rows:
+        cells = parse_table_row(raw_line)
+
+        # Skip entirely empty rows
+        if not any(cells):
+            continue
+
+        # Need at least name, required (col 3), secret (col 4), default (col 5)
+        if len(cells) <= COL_DEFAULT:
+            # Not enough columns to validate — skip silently
+            continue
+
+        name      = cells[COL_NAME]
+        required  = is_truthy(cells[COL_REQUIRED])
+        secret    = is_truthy(cells[COL_SECRET])
+        default_  = cells[COL_DEFAULT]
+
+        # Rule: secret=true AND non-empty default → fail
+        if secret and not is_empty_default(default_):
+            errors.append(
+                f'Line {lineno}: variable "{name}" is secret=true but has '
+                f'a non-empty default value "{default_}" '
+                f'(secrets must not have defaults in the contract)'
+            )
+
+        # Rule: required=true AND secret=false AND empty default → warn only
+        if required and not secret and is_empty_default(default_):
+            warnings.append(
+                f'Line {lineno}: variable "{name}" is required=true, '
+                f'secret=false, and has no default — ensure it is always set.'
+            )
+
+    for w in warnings:
+        print(f'Warning: {w}')
+
+    if errors:
+        print('Env semantic validation failed:')
+        for err in errors:
+            print(f'  {err}')
+        sys.exit(1)
+
+    print(f'Env semantic validation passed ({len(data_rows)} variable(s) checked).')
+
+
+if __name__ == '__main__':
+    main()