continuous-improvement 3.8.0 → 3.9.2

package/hooks/three-section-close.mjs

@@ -1,181 +1,181 @@
-#!/usr/bin/env node
-// three-section-close.mjs — Stop hook that requires every substantive
-// assistant reply to close with three named sections:
-//   "What has been done", "What is next", "Recommendation".
-//
-// Implements Law 4 + Law 5 in-band: verify before reporting, reflect at
-// the end. See SKILL.md for the discipline rationale.
-//
-// Behavior:
-//   - exit 0 to allow the response to stand
-//   - emit {"decision":"block","reason":"..."} on stdout to re-prompt
-//   - never block on internal failure (parse error, missing transcript,
-//     unexpected message shape) — fail open
-//
-// Heuristic: skip messages shorter than 600 chars. Pure clarifying replies
-// don't need the close; only substantive technical responses (work
-// summaries, plan responses, post-execution reports) get gated.
-//
-// Telemetry: best-effort JSONL line per gated invocation written to
-// ~/.claude/hook-telemetry/<project-hash>.jsonl. Never throws, never
-// blocks the response. No network. No transcript content recorded.
-
-import { appendFileSync, existsSync, mkdirSync, readFileSync } from "node:fs";
-import { createHash } from "node:crypto";
-import { platform } from "node:os";
-import { dirname, join } from "node:path";
-import { performance } from "node:perf_hooks";
-
-import { resolveHomeDir } from "../lib/resolve-home-dir.mjs";
-
-const MIN_LENGTH_TO_GATE = 600;
-
-const REQUIRED_SECTIONS = [
-  {
-    heading: "What has been done",
-    hint: "concrete summary of changes/findings from this turn",
-    pattern: /^#+ +What has been done(?:\s|$)/m,
-  },
-  {
-    heading: "What is next",
-    hint: "minimum 5 specific, actionable bullets",
-    pattern: /^#+ +What is next(?:\s|$)/m,
-  },
-  {
-    heading: "Recommendation",
-    hint: "ranked descending by impact, or write \"no\" if there is no recommendation",
-    pattern: /^#+ +Recommendation(?:\s|$)/m,
-  },
-];
-
-function readStdinSync() {
-  try {
-    return readFileSync(0, "utf8");
-  } catch {
-    return "";
-  }
-}
-
-function safeJsonParse(text) {
-  try {
-    return JSON.parse(text);
-  } catch {
-    return null;
-  }
-}
-
-function extractLastAssistantText(transcriptPath) {
-  const raw = readFileSync(transcriptPath, "utf8");
-  const lines = raw.split(/\r?\n/);
-  for (let i = lines.length - 1; i >= 0; i--) {
-    const line = lines[i].trim();
-    if (!line) continue;
-    const obj = safeJsonParse(line);
-    if (!obj || obj.type !== "assistant") continue;
-    const blocks = obj.message?.content;
-    if (!Array.isArray(blocks)) continue;
-    const texts = blocks
-      .filter((b) => b && b.type === "text" && typeof b.text === "string")
-      .map((b) => b.text);
-    if (texts.length === 0) continue;
-    return texts.join("\n");
-  }
-  return null;
-}
-
-function emitBlock(missing) {
-  const bullets = missing
-    .map(
-      (s) =>
-        `- "## ${s.heading}" — ${s.hint}`,
-    )
-    .join("\n");
-  const reason =
-    `Your reply is missing the required 3-section close. Add these sections at the end of the reply with these exact headings:\n${bullets}`;
-  process.stdout.write(JSON.stringify({ decision: "block", reason }) + "\n");
-}
-
-function projectHashFor(transcriptPath) {
-  const dir = dirname(transcriptPath);
-  let normalized = dir.split("\\").join("/");
-  if (platform() === "win32") normalized = normalized.toLowerCase();
-  return createHash("sha256").update(normalized).digest("hex").slice(0, 12);
-}
-
-function recordTelemetry(entry, transcriptPath) {
-  try {
-    const home = resolveHomeDir();
-    if (!home) return;
-    const telemetryDir = join(home, ".claude", "hook-telemetry");
-    try {
-      mkdirSync(telemetryDir, { recursive: true });
-    } catch {
-      return;
-    }
-    const file = join(telemetryDir, `${projectHashFor(transcriptPath)}.jsonl`);
-    try {
-      appendFileSync(file, JSON.stringify(entry) + "\n", "utf8");
-    } catch {
-      return;
-    }
-  } catch {
-    // belt-and-suspenders: telemetry must never throw
-  }
-}
-
-function main() {
-  // Per-operator opt-out. When CLAUDE_THREE_SECTION_CLOSE_DISABLED=1, the hook
-  // short-circuits entirely: no enforcement, no telemetry. Public default is
-  // unchanged (rule still fires for everyone else). See feedback memory
-  // 2026-05-04 for rationale: an audit found 22,876 observations produced
-  // only 2 graduated instincts, so visible end-of-turn reflection earns its
-  // keep poorly enough that operators may want to run it as internal thinking.
-  if (process.env.CLAUDE_THREE_SECTION_CLOSE_DISABLED === "1") return;
-  const startedAt = performance.now();
-  const stdin = readStdinSync();
-  if (!stdin) return;
-
-  const payload = safeJsonParse(stdin);
-  if (!payload || typeof payload.transcript_path !== "string") return;
-  if (!existsSync(payload.transcript_path)) return;
-
-  let lastText;
-  try {
-    lastText = extractLastAssistantText(payload.transcript_path);
-  } catch {
-    return; // fail open on read error
-  }
-  if (!lastText) return;
-
-  const textLength = lastText.length;
-  let action;
-  let missing = [];
-
-  if (textLength < MIN_LENGTH_TO_GATE) {
-    action = "skip-short";
-  } else {
-    missing = REQUIRED_SECTIONS.filter((s) => !s.pattern.test(lastText));
-    if (missing.length === 0) {
-      action = "pass";
-    } else {
-      action = "block";
-      emitBlock(missing);
-    }
-  }
-
-  const entry = {
-    ts: new Date().toISOString(),
-    hook: "three-section-close",
-    action,
-    textLength,
-    missing: missing.map((s) => s.heading),
-    durationMs: Math.round((performance.now() - startedAt) * 1000) / 1000,
-  };
-  recordTelemetry(entry, payload.transcript_path);
-}
-
-try {
-  main();
-} catch {
-  // fail open — never block the session due to a hook bug
-}
+#!/usr/bin/env node
+// three-section-close.mjs — Stop hook that requires every substantive
+// assistant reply to close with three named sections:
+//   "What has been done", "What is next", "Recommendation".
+//
+// Implements Law 4 + Law 5 in-band: verify before reporting, reflect at
+// the end. See SKILL.md for the discipline rationale.
+//
+// Behavior:
+//   - exit 0 to allow the response to stand
+//   - emit {"decision":"block","reason":"..."} on stdout to re-prompt
+//   - never block on internal failure (parse error, missing transcript,
+//     unexpected message shape) — fail open
+//
+// Heuristic: skip messages shorter than 600 chars. Pure clarifying replies
+// don't need the close; only substantive technical responses (work
+// summaries, plan responses, post-execution reports) get gated.
+//
+// Telemetry: best-effort JSONL line per gated invocation written to
+// ~/.claude/hook-telemetry/<project-hash>.jsonl. Never throws, never
+// blocks the response. No network. No transcript content recorded.
+
+import { appendFileSync, existsSync, mkdirSync, readFileSync } from "node:fs";
+import { createHash } from "node:crypto";
+import { platform } from "node:os";
+import { dirname, join } from "node:path";
+import { performance } from "node:perf_hooks";
+
+import { resolveHomeDir } from "../lib/resolve-home-dir.mjs";
+
+const MIN_LENGTH_TO_GATE = 600;
+
+const REQUIRED_SECTIONS = [
+  {
+    heading: "What has been done",
+    hint: "concrete summary of changes/findings from this turn",
+    pattern: /^#+ +What has been done(?:\s|$)/m,
+  },
+  {
+    heading: "What is next",
+    hint: "minimum 5 specific, actionable bullets",
+    pattern: /^#+ +What is next(?:\s|$)/m,
+  },
+  {
+    heading: "Recommendation",
+    hint: "ranked descending by impact, or write \"no\" if there is no recommendation",
+    pattern: /^#+ +Recommendation(?:\s|$)/m,
+  },
+];
+
+function readStdinSync() {
+  try {
+    return readFileSync(0, "utf8");
+  } catch {
+    return "";
+  }
+}
+
+function safeJsonParse(text) {
+  try {
+    return JSON.parse(text);
+  } catch {
+    return null;
+  }
+}
+
+function extractLastAssistantText(transcriptPath) {
+  const raw = readFileSync(transcriptPath, "utf8");
+  const lines = raw.split(/\r?\n/);
+  for (let i = lines.length - 1; i >= 0; i--) {
+    const line = lines[i].trim();
+    if (!line) continue;
+    const obj = safeJsonParse(line);
+    if (!obj || obj.type !== "assistant") continue;
+    const blocks = obj.message?.content;
+    if (!Array.isArray(blocks)) continue;
+    const texts = blocks
+      .filter((b) => b && b.type === "text" && typeof b.text === "string")
+      .map((b) => b.text);
+    if (texts.length === 0) continue;
+    return texts.join("\n");
+  }
+  return null;
+}
+
+function emitBlock(missing) {
+  const bullets = missing
+    .map(
+      (s) =>
+        `- "## ${s.heading}" — ${s.hint}`,
+    )
+    .join("\n");
+  const reason =
+    `Your reply is missing the required 3-section close. Add these sections at the end of the reply with these exact headings:\n${bullets}`;
+  process.stdout.write(JSON.stringify({ decision: "block", reason }) + "\n");
+}
+
+function projectHashFor(transcriptPath) {
+  const dir = dirname(transcriptPath);
+  let normalized = dir.split("\\").join("/");
+  if (platform() === "win32") normalized = normalized.toLowerCase();
+  return createHash("sha256").update(normalized).digest("hex").slice(0, 12);
+}
+
+function recordTelemetry(entry, transcriptPath) {
+  try {
+    const home = resolveHomeDir();
+    if (!home) return;
+    const telemetryDir = join(home, ".claude", "hook-telemetry");
+    try {
+      mkdirSync(telemetryDir, { recursive: true });
+    } catch {
+      return;
+    }
+    const file = join(telemetryDir, `${projectHashFor(transcriptPath)}.jsonl`);
+    try {
+      appendFileSync(file, JSON.stringify(entry) + "\n", "utf8");
+    } catch {
+      return;
+    }
+  } catch {
+    // belt-and-suspenders: telemetry must never throw
+  }
+}
+
+function main() {
+  // Per-operator opt-out. When CLAUDE_THREE_SECTION_CLOSE_DISABLED=1, the hook
+  // short-circuits entirely: no enforcement, no telemetry. Public default is
+  // unchanged (rule still fires for everyone else). See feedback memory
+  // 2026-05-04 for rationale: an audit found 22,876 observations produced
+  // only 2 graduated instincts, so visible end-of-turn reflection earns its
+  // keep poorly enough that operators may want to run it as internal thinking.
+  if (process.env.CLAUDE_THREE_SECTION_CLOSE_DISABLED === "1") return;
+  const startedAt = performance.now();
+  const stdin = readStdinSync();
+  if (!stdin) return;
+
+  const payload = safeJsonParse(stdin);
+  if (!payload || typeof payload.transcript_path !== "string") return;
+  if (!existsSync(payload.transcript_path)) return;
+
+  let lastText;
+  try {
+    lastText = extractLastAssistantText(payload.transcript_path);
+  } catch {
+    return; // fail open on read error
+  }
+  if (!lastText) return;
+
+  const textLength = lastText.length;
+  let action;
+  let missing = [];
+
+  if (textLength < MIN_LENGTH_TO_GATE) {
+    action = "skip-short";
+  } else {
+    missing = REQUIRED_SECTIONS.filter((s) => !s.pattern.test(lastText));
+    if (missing.length === 0) {
+      action = "pass";
+    } else {
+      action = "block";
+      emitBlock(missing);
+    }
+  }
+
+  const entry = {
+    ts: new Date().toISOString(),
+    hook: "three-section-close",
+    action,
+    textLength,
+    missing: missing.map((s) => s.heading),
+    durationMs: Math.round((performance.now() - startedAt) * 1000) / 1000,
+  };
+  recordTelemetry(entry, payload.transcript_path);
+}
+
+try {
+  main();
+} catch {
+  // fail open — never block the session due to a hook bug
+}

package/instinct-packs/go.json

@@ -1,58 +1,58 @@
-[
-  {
-    "id": "go-error-handling",
-    "trigger": "when calling functions that return errors",
-    "body": "Always check returned errors immediately. Never use _ to discard errors unless you've explicitly decided it's safe and documented why.",
-    "confidence": 0.7,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-defer-cleanup",
-    "trigger": "when opening files, connections, or acquiring locks",
-    "body": "Use defer immediately after acquiring a resource for cleanup. Place defer right after the error check for the acquisition.",
-    "confidence": 0.7,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-interface-consumer",
-    "trigger": "when defining Go interfaces",
-    "body": "Define interfaces at the consumer side, not the producer side. Keep interfaces small (1-3 methods). Accept interfaces, return structs.",
-    "confidence": 0.65,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-table-driven-tests",
-    "trigger": "when writing Go tests",
-    "body": "Use table-driven tests with subtests (t.Run) for functions with multiple input/output cases. Name test cases descriptively.",
-    "confidence": 0.7,
-    "domain": "testing"
-  },
-  {
-    "id": "go-context-propagation",
-    "trigger": "when writing HTTP handlers or long-running operations",
-    "body": "Accept context.Context as the first parameter. Propagate it to all downstream calls. Use it for cancellation and timeouts.",
-    "confidence": 0.65,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-goroutine-lifecycle",
-    "trigger": "when spawning goroutines",
-    "body": "Always ensure goroutines have a way to exit (context cancellation, done channel, or WaitGroup). Never fire-and-forget goroutines without cleanup.",
-    "confidence": 0.7,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-struct-zero-values",
-    "trigger": "when designing Go structs",
-    "body": "Design structs so their zero value is useful. Use pointer fields only when nil is a meaningful distinct state from zero value.",
-    "confidence": 0.6,
-    "domain": "patterns"
-  },
-  {
-    "id": "go-mod-tidy",
-    "trigger": "when adding or removing dependencies",
-    "body": "Run 'go mod tidy' after adding or removing imports to keep go.mod and go.sum clean.",
-    "confidence": 0.65,
-    "domain": "workflow"
-  }
-]
+[
+  {
+    "id": "go-error-handling",
+    "trigger": "when calling functions that return errors",
+    "body": "Always check returned errors immediately. Never use _ to discard errors unless you've explicitly decided it's safe and documented why.",
+    "confidence": 0.7,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-defer-cleanup",
+    "trigger": "when opening files, connections, or acquiring locks",
+    "body": "Use defer immediately after acquiring a resource for cleanup. Place defer right after the error check for the acquisition.",
+    "confidence": 0.7,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-interface-consumer",
+    "trigger": "when defining Go interfaces",
+    "body": "Define interfaces at the consumer side, not the producer side. Keep interfaces small (1-3 methods). Accept interfaces, return structs.",
+    "confidence": 0.65,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-table-driven-tests",
+    "trigger": "when writing Go tests",
+    "body": "Use table-driven tests with subtests (t.Run) for functions with multiple input/output cases. Name test cases descriptively.",
+    "confidence": 0.7,
+    "domain": "testing"
+  },
+  {
+    "id": "go-context-propagation",
+    "trigger": "when writing HTTP handlers or long-running operations",
+    "body": "Accept context.Context as the first parameter. Propagate it to all downstream calls. Use it for cancellation and timeouts.",
+    "confidence": 0.65,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-goroutine-lifecycle",
+    "trigger": "when spawning goroutines",
+    "body": "Always ensure goroutines have a way to exit (context cancellation, done channel, or WaitGroup). Never fire-and-forget goroutines without cleanup.",
+    "confidence": 0.7,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-struct-zero-values",
+    "trigger": "when designing Go structs",
+    "body": "Design structs so their zero value is useful. Use pointer fields only when nil is a meaningful distinct state from zero value.",
+    "confidence": 0.6,
+    "domain": "patterns"
+  },
+  {
+    "id": "go-mod-tidy",
+    "trigger": "when adding or removing dependencies",
+    "body": "Run 'go mod tidy' after adding or removing imports to keep go.mod and go.sum clean.",
+    "confidence": 0.65,
+    "domain": "workflow"
+  }
+]

package/instinct-packs/meta.json

@@ -1,16 +1,16 @@
-[
-  {
-    "id": "skip-thin-observation-schema",
-    "trigger": "when running /continuous-improvement and observations.jsonl entries contain only tool_start events with no inputs/outputs/errors",
-    "body": "Skip instinct fabrication and report the schema gap instead. With only ts/event/session/tool/project_id/project_name fields, the stream cannot distinguish a `git status` Bash call from a `rm -rf` Bash call. Tool-name bigrams (Bash→Bash, Edit→Edit, Read→Edit) reflect parallel-call artifacts and harness-enforced read-before-edit, not learned preferences. Recommend enhancing PostToolUse/PreToolUse hooks to log tool inputs (Bash command head, Skill name) and tool_end with success flag before retrying analysis.",
-    "confidence": 0.6,
-    "domain": "meta"
-  },
-  {
-    "id": "parallelize-independent-tool-calls",
-    "trigger": "when issuing 2+ tool calls with no data dependency between them in the same turn",
-    "body": "Batch independent tool calls into a single message instead of issuing them sequentially. Independent reads, independent greps, independent git inspections, independent file edits in unrelated files belong in one message with multiple tool blocks. Dependent calls (output of A determines input of B) stay sequential. Exception: when a single check would short-circuit the whole task (e.g., `git status` returning empty), one call first is fine. Sequential issuing of independent calls wastes wall-clock time and burns context per round-trip.",
-    "confidence": 0.6,
-    "domain": "workflow"
-  }
-]
+[
+  {
+    "id": "skip-thin-observation-schema",
+    "trigger": "when running /continuous-improvement and observations.jsonl entries contain only tool_start events with no inputs/outputs/errors",
+    "body": "Skip instinct fabrication and report the schema gap instead. With only ts/event/session/tool/project_id/project_name fields, the stream cannot distinguish a `git status` Bash call from a `rm -rf` Bash call. Tool-name bigrams (Bash→Bash, Edit→Edit, Read→Edit) reflect parallel-call artifacts and harness-enforced read-before-edit, not learned preferences. Recommend enhancing PostToolUse/PreToolUse hooks to log tool inputs (Bash command head, Skill name) and tool_end with success flag before retrying analysis.",
+    "confidence": 0.6,
+    "domain": "meta"
+  },
+  {
+    "id": "parallelize-independent-tool-calls",
+    "trigger": "when issuing 2+ tool calls with no data dependency between them in the same turn",
+    "body": "Batch independent tool calls into a single message instead of issuing them sequentially. Independent reads, independent greps, independent git inspections, independent file edits in unrelated files belong in one message with multiple tool blocks. Dependent calls (output of A determines input of B) stay sequential. Exception: when a single check would short-circuit the whole task (e.g., `git status` returning empty), one call first is fine. Sequential issuing of independent calls wastes wall-clock time and burns context per round-trip.",
+    "confidence": 0.6,
+    "domain": "workflow"
+  }
+]

package/instinct-packs/python.json

@@ -1,58 +1,58 @@
-[
-  {
-    "id": "python-virtual-env",
-    "trigger": "when starting work on a Python project",
-    "body": "Check for virtual environment (venv, .venv, conda) before installing packages. Never install to system Python.",
-    "confidence": 0.7,
-    "domain": "workflow"
-  },
-  {
-    "id": "python-type-hints",
-    "trigger": "when writing Python functions",
-    "body": "Add type hints to function parameters and return values. Use Optional[], list[], dict[] (Python 3.10+) or typing module for older versions.",
-    "confidence": 0.6,
-    "domain": "code-style"
-  },
-  {
-    "id": "python-pathlib",
-    "trigger": "when working with file paths in Python",
-    "body": "Use pathlib.Path instead of os.path for file operations. It's more readable and cross-platform.",
-    "confidence": 0.65,
-    "domain": "patterns"
-  },
-  {
-    "id": "python-context-managers",
-    "trigger": "when opening files or database connections",
-    "body": "Always use context managers (with statement) for files, database connections, and locks. Never rely on manual .close() calls.",
-    "confidence": 0.7,
-    "domain": "patterns"
-  },
-  {
-    "id": "python-list-comprehension",
-    "trigger": "when writing simple for loops that build lists",
-    "body": "Prefer list comprehensions for simple transformations. Use regular for loops when the logic is complex or has side effects.",
-    "confidence": 0.6,
-    "domain": "code-style"
-  },
-  {
-    "id": "python-requirements-check",
-    "trigger": "when adding a new import",
-    "body": "Check if the package is already in requirements.txt, pyproject.toml, or Pipfile before adding. Search for existing usage in the codebase.",
-    "confidence": 0.65,
-    "domain": "workflow"
-  },
-  {
-    "id": "python-pytest-fixtures",
-    "trigger": "when writing Python tests",
-    "body": "Use pytest fixtures for test setup/teardown instead of unittest setUp/tearDown. Use conftest.py for shared fixtures.",
-    "confidence": 0.6,
-    "domain": "testing"
-  },
-  {
-    "id": "python-dataclass",
-    "trigger": "when creating classes that primarily hold data",
-    "body": "Use @dataclass or Pydantic BaseModel instead of plain classes for data containers. They provide __init__, __repr__, and comparison for free.",
-    "confidence": 0.65,
-    "domain": "patterns"
-  }
-]
+[
+  {
+    "id": "python-virtual-env",
+    "trigger": "when starting work on a Python project",
+    "body": "Check for virtual environment (venv, .venv, conda) before installing packages. Never install to system Python.",
+    "confidence": 0.7,
+    "domain": "workflow"
+  },
+  {
+    "id": "python-type-hints",
+    "trigger": "when writing Python functions",
+    "body": "Add type hints to function parameters and return values. Use Optional[], list[], dict[] (Python 3.10+) or typing module for older versions.",
+    "confidence": 0.6,
+    "domain": "code-style"
+  },
+  {
+    "id": "python-pathlib",
+    "trigger": "when working with file paths in Python",
+    "body": "Use pathlib.Path instead of os.path for file operations. It's more readable and cross-platform.",
+    "confidence": 0.65,
+    "domain": "patterns"
+  },
+  {
+    "id": "python-context-managers",
+    "trigger": "when opening files or database connections",
+    "body": "Always use context managers (with statement) for files, database connections, and locks. Never rely on manual .close() calls.",
+    "confidence": 0.7,
+    "domain": "patterns"
+  },
+  {
+    "id": "python-list-comprehension",
+    "trigger": "when writing simple for loops that build lists",
+    "body": "Prefer list comprehensions for simple transformations. Use regular for loops when the logic is complex or has side effects.",
+    "confidence": 0.6,
+    "domain": "code-style"
+  },
+  {
+    "id": "python-requirements-check",
+    "trigger": "when adding a new import",
+    "body": "Check if the package is already in requirements.txt, pyproject.toml, or Pipfile before adding. Search for existing usage in the codebase.",
+    "confidence": 0.65,
+    "domain": "workflow"
+  },
+  {
+    "id": "python-pytest-fixtures",
+    "trigger": "when writing Python tests",
+    "body": "Use pytest fixtures for test setup/teardown instead of unittest setUp/tearDown. Use conftest.py for shared fixtures.",
+    "confidence": 0.6,
+    "domain": "testing"
+  },
+  {
+    "id": "python-dataclass",
+    "trigger": "when creating classes that primarily hold data",
+    "body": "Use @dataclass or Pydantic BaseModel instead of plain classes for data containers. They provide __init__, __repr__, and comparison for free.",
+    "confidence": 0.65,
+    "domain": "patterns"
+  }
+]