containerify 3.1.0 → 3.1.2

package/README.md

@@ -45,7 +45,7 @@ This will take the `nginx:alpine` image, and copy the files from `./dist/` into
 
 1. Create the repository in GitLab
 2. Login using your username and password, [CI-credentials](https://docs.gitlab.com/ee/ci/jobs/ci_job_token.html), or [obtain a token from GitLab](https://docs.gitlab.com/ee/api/container_registry.html#obtain-token-from-gitlab)
-3. Example using CI-credentials `containerify --toToken "Basic $(echo -n '${CI_REGISTRY_USER}:${CI_REGISTRY_PASSWORD}' | base64)" --to registry.gitlab.com/<Gitlab organisation>/<repository>:<tag>`
+3. Example using CI-credentials `containerify --toToken "Basic $(echo -n "${CI_REGISTRY_USER}:${CI_REGISTRY_PASSWORD}" | base64)" --to registry.gitlab.com/<Gitlab organisation>/<repository>:<tag>`
 
 ### Command line options
 

package/lib/cli.js

@@ -226,8 +226,8 @@ Object.keys(options.extraContent).forEach((k) => {
     exitWithErrorIf(!fs.existsSync(options.folder + k), "Could not find `" + k + "` in the folder " + options.folder);
 });
 function run(options) {
-    var _a;
     return __awaiter(this, void 0, void 0, function* () {
+        var _a;
         if (!(yield fse.pathExists(options.folder)))
             throw new Error("No such folder: " + options.folder);
         const tmpdir = fs.mkdtempSync(path.join(os.tmpdir(), "containerify-"));

package/lib/fileutil.js

@@ -9,7 +9,8 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ensureEmptyDir = exports.sizeOf = void 0;
+exports.sizeOf = sizeOf;
+exports.ensureEmptyDir = ensureEmptyDir;
 const fs_1 = require("fs");
 const fse = require("fs-extra");
 const fss = require("fs");
@@ -18,7 +19,6 @@ function sizeOf(file) {
         return (yield fs_1.promises.lstat(file)).size;
     });
 }
-exports.sizeOf = sizeOf;
 function ensureEmptyDir(path) {
     return __awaiter(this, void 0, void 0, function* () {
         if (fss.existsSync(path))
@@ -27,7 +27,6 @@ function ensureEmptyDir(path) {
         return path;
     });
 }
-exports.ensureEmptyDir = ensureEmptyDir;
 exports.default = {
     sizeOf,
     ensureEmptyDir,

package/lib/httpRequest.d.ts

@@ -1,6 +1,3 @@
-/// <reference types="node" />
-/// <reference types="node" />
-/// <reference types="node" />
 import * as https from "https";
 import * as http from "http";
 import { InsecureRegistrySupport } from "./types";

package/lib/httpRequest.js

@@ -9,7 +9,15 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.followRedirects = exports.dlJson = exports.waitForResponseEnd = exports.toError = exports.request = exports.buildHeaders = exports.createHttpOptions = exports.isOk = exports.redirectCodes = void 0;
+exports.redirectCodes = void 0;
+exports.isOk = isOk;
+exports.createHttpOptions = createHttpOptions;
+exports.buildHeaders = buildHeaders;
+exports.request = request;
+exports.toError = toError;
+exports.waitForResponseEnd = waitForResponseEnd;
+exports.dlJson = dlJson;
+exports.followRedirects = followRedirects;
 const https = require("https");
 const http = require("http");
 const URL = require("url");
@@ -19,21 +27,22 @@ exports.redirectCodes = [308, 307, 303, 302, 301];
 function isOk(httpStatus) {
     return httpStatus >= 200 && httpStatus < 300;
 }
-exports.isOk = isOk;
 function createHttpOptions(method, url, headers) {
     const options = Object.assign({}, URL.parse(url));
     options.headers = headers;
     options.method = method;
+    if (url.includes("X-Amz-Algorithm") && method == "GET") {
+        //We are using a pre-signed URL, so we don't need to send the Authorization header
+        options.headers["Authorization"] = "";
+    }
     return options;
 }
-exports.createHttpOptions = createHttpOptions;
 function buildHeaders(accept, auth) {
     const headers = { accept: accept };
     if (auth)
         headers.authorization = auth;
     return headers;
 }
-exports.buildHeaders = buildHeaders;
 function request(options, allowInsecure, callback) {
     if (allowInsecure == types_1.InsecureRegistrySupport.YES)
         options.rejectUnauthorized = false;
@@ -46,17 +55,14 @@ function request(options, allowInsecure, callback) {
     });
     return req;
 }
-exports.request = request;
 function toError(res) {
     return `Unexpected HTTP status ${res.statusCode} : ${res.statusMessage}`;
 }
-exports.toError = toError;
 function waitForResponseEnd(res, cb) {
     const data = [];
     res.on("data", (d) => data.push(d));
     res.on("end", () => cb(Buffer.concat(data)));
 }
-exports.waitForResponseEnd = waitForResponseEnd;
 function dl(uri, headers, allowInsecure) {
     logger_1.default.debug("dl", uri);
     return new Promise((resolve, reject) => {
@@ -66,9 +72,17 @@ function dl(uri, headers, allowInsecure) {
                 return reject(result.error);
             const { res } = result;
             logger_1.default.debug(res.statusCode, res.statusMessage, res.headers["content-type"], res.headers["content-length"]);
-            if (!isOk((_a = res.statusCode) !== null && _a !== void 0 ? _a : 0))
-                return reject(toError(res));
-            waitForResponseEnd(res, (data) => resolve(data.toString()));
+            if (!isOk((_a = res.statusCode) !== null && _a !== void 0 ? _a : 0)) {
+                const d = [];
+                res.on("data", (dt) => d.push(dt));
+                res.on("end", () => {
+                    logger_1.default.error("ERROR", Buffer.concat(d).toString());
+                    reject(toError(res));
+                });
+            }
+            else {
+                waitForResponseEnd(res, (data) => resolve(data.toString()));
+            }
         });
     });
 }
@@ -78,7 +92,6 @@ function dlJson(uri, headers, allowInsecure) {
         return JSON.parse(Buffer.from(data).toString("utf-8"));
     });
 }
-exports.dlJson = dlJson;
 function followRedirects(uri, headers, allowInsecure, cb, count = 0) {
     logger_1.default.debug("rc", uri);
     const options = createHttpOptions("GET", uri, headers);
@@ -88,6 +101,7 @@ function followRedirects(uri, headers, allowInsecure, cb, count = 0) {
             if (count > 10)
                 return cb({ error: "Too many redirects for " + uri });
             const location = res.headers.location;
+            console.log(res.headers);
             if (!location)
                 return cb({ error: "Redirect, but missing location header" });
             return followRedirects(location, headers, allowInsecure, cb, count + 1);
@@ -95,4 +109,3 @@ function followRedirects(uri, headers, allowInsecure, cb, count = 0) {
         cb({ res });
     }).end();
 }
-exports.followRedirects = followRedirects;

package/lib/registry.js

@@ -9,7 +9,9 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.parseFullImageUrl = exports.DEFAULT_DOCKER_REGISTRY = exports.createRegistry = void 0;
+exports.DEFAULT_DOCKER_REGISTRY = void 0;
+exports.createRegistry = createRegistry;
+exports.parseFullImageUrl = parseFullImageUrl;
 const URL = require("url");
 const fss = require("fs");
 const fs_1 = require("fs");
@@ -130,19 +132,12 @@ function processToken(registryBaseUrl, allowInsecure, imagePath, token) {
     return __awaiter(this, void 0, void 0, function* () {
         const { hostname } = URL.parse(registryBaseUrl);
         const image = (0, utils_1.parseImage)(imagePath);
-        if ((hostname === null || hostname === void 0 ? void 0 : hostname.endsWith(".docker.io")) && !token) {
-            const resp = yield (0, httpRequest_1.dlJson)(`https://auth.docker.io/token?service=registry.docker.io&scope=repository:${image.path}:pull`, {}, allowInsecure);
-            return `Bearer ${resp.token}`;
-        }
-        if ((hostname === null || hostname === void 0 ? void 0 : hostname.endsWith(".gitlab.com")) && (token === null || token === void 0 ? void 0 : token.startsWith("Basic"))) {
-            if (token === null || token === void 0 ? void 0 : token.includes(":")) {
-                token = "Basic " + Buffer.from(token === null || token === void 0 ? void 0 : token.replace("Basic ", "")).toString("base64");
-            }
-            const resp = yield (0, httpRequest_1.dlJson)(`https://gitlab.com/jwt/auth?service=container_registry&scope=repository:${image.path}:pull,push`, { Authorization: token }, allowInsecure);
-            return `Bearer ${resp.token}`;
-        }
+        if ((hostname === null || hostname === void 0 ? void 0 : hostname.endsWith(".docker.io")) && !token)
+            return getDockerToken(image.path, allowInsecure);
         if (!token)
             return ""; //We allow to pull from tokenless registries
+        if ((hostname === null || hostname === void 0 ? void 0 : hostname.endsWith(".gitlab.com")) && token.startsWith("Basic "))
+            return getGitLabToken(token, image.path, allowInsecure);
         if (token.startsWith("Basic "))
             return token;
         if (token.startsWith("ghp_"))
@@ -150,8 +145,23 @@ function processToken(registryBaseUrl, allowInsecure, imagePath, token) {
         return "Bearer " + token;
     });
 }
-function createRegistry(registryBaseUrl, imagePath, allowInsecure, auth, optimisticToRegistryCheck = false) {
+function getDockerToken(imagePath, allowInsecure) {
+    return __awaiter(this, void 0, void 0, function* () {
+        const resp = yield (0, httpRequest_1.dlJson)(`https://auth.docker.io/token?service=registry.docker.io&scope=repository:${imagePath}:pull`, {}, allowInsecure);
+        return `Bearer ${resp.token}`;
+    });
+}
+function getGitLabToken(token, imagePath, allowInsecure) {
     return __awaiter(this, void 0, void 0, function* () {
+        if (token.includes(":")) {
+            token = "Basic " + Buffer.from(token.replace("Basic ", "")).toString("base64");
+        }
+        const resp = yield (0, httpRequest_1.dlJson)(`https://gitlab.com/jwt/auth?service=container_registry&scope=repository:${imagePath}:pull,push`, { Authorization: token }, allowInsecure);
+        return `Bearer ${resp.token}`;
+    });
+}
+function createRegistry(registryBaseUrl_1, imagePath_1, allowInsecure_1, auth_1) {
+    return __awaiter(this, arguments, void 0, function* (registryBaseUrl, imagePath, allowInsecure, auth, optimisticToRegistryCheck = false) {
         const token = yield processToken(registryBaseUrl, allowInsecure, imagePath, auth);
         function exists(image, layer) {
             return __awaiter(this, void 0, void 0, function* () {
@@ -166,15 +176,15 @@ function createRegistry(registryBaseUrl, imagePath, allowInsecure, auth, optimis
                 yield uploadContent(uploadUrl, file, layer, allowInsecure, token);
             });
         }
-        function getUploadUrl(image, mountParameters = undefined) {
-            return __awaiter(this, void 0, void 0, function* () {
+        function getUploadUrl(image_1) {
+            return __awaiter(this, arguments, void 0, function* (image, mountParameters = undefined) {
                 return new Promise((resolve, reject) => {
                     const parameters = new URLSearchParams(mountParameters);
                     const url = `${registryBaseUrl}${image.path}/blobs/uploads/${parameters.size > 0 ? "?" + parameters : ""}`;
                     const options = URL.parse(url);
                     options.method = "POST";
-                    if (auth)
-                        options.headers = { authorization: auth };
+                    if (token)
+                        options.headers = { authorization: token };
                     (0, httpRequest_1.request)(options, allowInsecure, (res) => {
                         logger_1.default.debug("POST", `${url}`, res.statusCode);
                         if (res.statusCode == 202) {
@@ -329,7 +339,6 @@ function createRegistry(registryBaseUrl, imagePath, allowInsecure, auth, optimis
         };
     });
 }
-exports.createRegistry = createRegistry;
 exports.DEFAULT_DOCKER_REGISTRY = "https://registry-1.docker.io/v2/";
 function parseFullImageUrl(imageStr) {
     const [registry, ...rest] = imageStr.split("/");
@@ -344,4 +353,3 @@ function parseFullImageUrl(imageStr) {
         image: rest.join("/"),
     };
 }
-exports.parseFullImageUrl = parseFullImageUrl;

package/lib/utils.js

@@ -1,15 +1,19 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.parseImage = exports.getHash = exports.getLayerTypeFileEnding = exports.getManifestLayerType = exports.getPreferredPlatform = exports.omit = exports.unique = void 0;
+exports.unique = unique;
+exports.omit = omit;
+exports.getPreferredPlatform = getPreferredPlatform;
+exports.getManifestLayerType = getManifestLayerType;
+exports.getLayerTypeFileEnding = getLayerTypeFileEnding;
+exports.getHash = getHash;
+exports.parseImage = parseImage;
 const MIMETypes_1 = require("./MIMETypes");
 function unique(vals) {
     return [...new Set(vals)];
 }
-exports.unique = unique;
 function omit(obj, keys) {
     return Object.fromEntries(Object.entries(obj).filter(([k]) => !keys.includes(k)));
 }
-exports.omit = omit;
 function getPreferredPlatform(platform) {
     var _a, _b;
     // We assume the input is similar to docker which accepts `<os>/<arch>` and `<arch>`
@@ -68,7 +72,6 @@ function getPreferredPlatform(platform) {
         architecture: targetArch,
     };
 }
-exports.getPreferredPlatform = getPreferredPlatform;
 function getManifestLayerType(manifest) {
     if (manifest.mediaType === MIMETypes_1.OCI.manifest) {
         return MIMETypes_1.OCI.layer.gzip;
@@ -78,7 +81,6 @@ function getManifestLayerType(manifest) {
     }
     throw new Error(`${manifest.mediaType} not recognized.`);
 }
-exports.getManifestLayerType = getManifestLayerType;
 function getLayerTypeFileEnding(layer) {
     switch (layer.mediaType) {
         case MIMETypes_1.OCI.layer.gzip:
@@ -91,15 +93,12 @@ function getLayerTypeFileEnding(layer) {
             throw new Error(`Layer mediaType ${layer.mediaType} not known.`);
     }
 }
-exports.getLayerTypeFileEnding = getLayerTypeFileEnding;
 function getHash(digest) {
     return digest.split(":")[1];
 }
-exports.getHash = getHash;
 function parseImage(imageStr) {
     const ar = imageStr.split(":");
     const tag = ar[1] || "latest";
     const ipath = ar[0];
     return { path: ipath, tag: tag };
 }
-exports.parseImage = parseImage;

package/lib/version.d.ts

@@ -1 +1 @@
-export declare const VERSION = "3.1.0";
+export declare const VERSION = "3.1.2";

package/lib/version.js

@@ -1,4 +1,4 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.VERSION = void 0;
-exports.VERSION = "3.1.0";
+exports.VERSION = "3.1.2";

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "containerify",
-	"version": "3.1.0",
+	"version": "3.1.2",
 	"description": "Build node.js docker images without docker",
 	"main": "./lib/cli.js",
 	"scripts": {