comq 0.20.0 → 0.20.1

package/features/silence.feature

@@ -57,6 +57,7 @@ Feature: Silent Connection Tolerance
   Scenario: Reporting that there is nowhere left to publish
     Given an active sharded connection
     And a producer replying `echo` queue
-    When the network goes silent
+    When the network goes silent and refuses new connections
     Then publishing is paused within 10 seconds
-    And publishing is resumed within 10 seconds
+    When the network admits new connections
+    Then publishing is resumed within 10 seconds

package/features/steps/network.js

@@ -26,6 +26,24 @@ When('the network goes silent',
     silence.call(this)
   })
 
+When('the network goes silent and refuses new connections',
+  /**
+   * @this {comq.features.Context}
+   */
+  function () {
+    for (const network of this.networks) network.refuse()
+
+    silence.call(this)
+  })
+
+When('the network admits new connections',
+  /**
+   * @this {comq.features.Context}
+   */
+  function () {
+    for (const network of this.networks) network.admit()
+  })
+
 When('the silent connection is let go',
   /**
    * @this {comq.features.Context}

package/features/steps/networks.js

@@ -23,6 +23,8 @@ class Network {
   /** @type {number} */
   #port
 
+  #refusing = false
+
   /**
    * @param {number} [n] broker index
    */
@@ -51,6 +53,18 @@ class Network {
     for (const tunnel of this.#tunnels) tunnel.silent = true
   }
 
+  /**
+   * A connection established from now on is closed as soon as it is accepted, so
+   * a connection that is lost stays lost until the network admits it.
+   */
+  refuse () {
+    this.#refusing = true
+  }
+
+  admit () {
+    this.#refusing = false
+  }
+
   /**
    * Closes the tunnels that went silent, at both ends, so the broker learns that the
    * connection it was still holding is gone — the moment its heartbeat would otherwise tell it.
@@ -69,6 +83,8 @@ class Network {
    * @param {net.Socket} client
    */
   #tunnel = (client) => {
+    if (this.#refusing) return client.destroy()
+
     const upstream = net.connect(this.#port, this.#host)
 
     /** @type {comq.features.Tunnel} */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "comq",
-  "version": "0.20.0",
+  "version": "0.20.1",
   "description": "ComQ",
   "author": {
     "name": "Artem Gurtovoi",

package/source/connection.js

@@ -371,6 +371,8 @@ const SHUTDOWN_MS = 5_000
 
 const SOCKET_OPTIONS = {
   timeout: CONNECT_MS,
+  // a message is written once and is small, which is what Nagle's algorithm holds back
+  noDelay: true,
   // a peer that went away without a word is noticed by the kernel as well
   keepAlive: true,
   keepAliveDelay: KEEPALIVE_MS

package/test/connection.test.js

@@ -684,6 +684,13 @@ describe('heartbeat', () => {
     expect(amqplib.connect)
       .toHaveBeenCalledWith(expect.any(String), expect.objectContaining({ keepAlive: true }))
   })
+
+  it('should send without delay', async () => {
+    await connection.open()
+
+    expect(amqplib.connect)
+      .toHaveBeenCalledWith(expect.any(String), expect.objectContaining({ noDelay: true }))
+  })
 })
 
 describe('close', () => {