comq 0.15.6 → 0.15.8

package/test/shards/channel.test.js

@@ -2,7 +2,8 @@
 
 const { randomBytes } = require('node:crypto')
 const { generate } = require('randomstring')
-const { promex, sample, immediate, random, each } = require('@toa.io/generic')
+const { Promex } = require('promex')
+const { sample, immediate, random } = require('../helpers')
 
 const mock = require('../connection.mock')
 
@@ -96,6 +97,65 @@ it('should not publish to a lost shard', async () => {
   expect(channels[1].send).not.toHaveBeenCalled()
 })
 
+it('should wait for a shard to recover when all are lost', async () => {
+  channel = await create(connections, type)
+
+  const channels = await getCreatedChannels()
+  const buffer = randomBytes(8)
+  const label = generate()
+  let sent = false
+
+  for (const connection of connections) {
+    const calls = connection.diagnose.mock.calls.filter((call) => call[0] === 'close')
+
+    for (const call of calls) call[1](new Error('gone'))
+  }
+
+  const sending = channel.send(label, buffer).then(() => { sent = true })
+
+  await immediate()
+
+  expect(sent).toStrictEqual(false)
+
+  for (const chan of channels) expect(chan.send).not.toHaveBeenCalled()
+
+  const open = connections[0].diagnose.mock.calls.filter((call) => call[0] === 'open')
+  const recover = channels[0].diagnose.mock.calls.filter((call) => call[0] === 'recover')
+
+  for (const call of open) call[1]()
+  for (const call of recover) call[1]()
+
+  await sending
+
+  expect(channels[0].send).toHaveBeenCalled()
+  expect(channels[1].send).not.toHaveBeenCalled()
+})
+
+it('should pause when no shard is left to publish to', async () => {
+  channel = await create(connections, type)
+
+  const pause = /** @type {jest.MockedFunction} */ jest.fn()
+  const resume = /** @type {jest.MockedFunction} */ jest.fn()
+
+  channel.diagnose('pause', pause)
+  channel.diagnose('resume', resume)
+
+  lose(connections[0])
+
+  // the other shard is still reachable
+  expect(pause).not.toHaveBeenCalled()
+
+  lose(connections[1])
+
+  expect(pause).toHaveBeenCalledTimes(1)
+  expect(resume).not.toHaveBeenCalled()
+
+  restore(connections[1])
+
+  expect(resume).toHaveBeenCalledTimes(1)
+  expect(pause).toHaveBeenCalledTimes(1)
+})
+
 // a lost shard is not benched, so it is used again as soon as it reconnects
 it('should publish to a recovered shard', async () => {
   channel = await create(connections, type)
@@ -116,11 +176,11 @@ it('should publish to a recovered shard', async () => {
 })
 
 it('should resolve when one of the connections has created a channel', async () => {
-  /** @type {toa.generic.Promex[]} */
+  /** @type {Promex[]} */
   const promises = []
 
   for (const conn of connections) {
-    const promise = promex()
+    const promise = new Promex()
 
     conn.createChannel.mockImplementationOnce(() => promise)
 
@@ -149,7 +209,7 @@ it('should resolve when one of the connections has created a channel', async ()
 it('should create failfast channels of given type', async () => {
   await create(connections, type)
 
-  each(connections, (conn, index) => {
+  connections.forEach((conn, index) => {
     expect(conn.createChannel).toHaveBeenCalledWith(type, index)
   })
 })
@@ -174,7 +234,7 @@ describe.each(['consume', 'subscribe'])('%s', (method) => {
   })
 
   it(`should not resolve ${method} until pending channels are created`, async () => {
-    const promise = promex()
+    const promise = new Promex()
 
     connections[0].createChannel.mockImplementationOnce(() => promise)
 
@@ -204,7 +264,7 @@ describe.each(['consume', 'subscribe'])('%s', (method) => {
   })
 
   it(`should resolve ${method} without a disconnected shard`, async () => {
-    const promise = promex()
+    const promise = new Promex()
 
     connections[0].createChannel.mockImplementationOnce(() => promise)
     connections[0].connected = false
@@ -226,7 +286,7 @@ describe.each(['consume', 'subscribe'])('%s', (method) => {
   })
 
   it(`should resolve ${method} when a shard disconnects`, async () => {
-    const promise = promex()
+    const promise = new Promex()
 
     connections[0].createChannel.mockImplementationOnce(() => promise)
 
@@ -379,7 +439,7 @@ describe('seal', () => {
 
     const channels = await getCreatedChannels()
     const chan = sample(channels)
-    const promise = promex()
+    const promise = new Promex()
     let sealed = false
 
     chan.seal.mockImplementationOnce(() => promise)
@@ -399,7 +459,7 @@ describe('seal', () => {
 
   it('should seal pending channel', async () => {
     const connection = sample(connections)
-    const promise = promex()
+    const promise = new Promex()
 
     connection.createChannel.mockImplementationOnce(() => promise)
 
@@ -622,6 +682,34 @@ function emitReturn (channel, message) {
   for (const call of calls) call[1](message)
 }
 
+/**
+ * @param {jest.MockedObject<comq.Connection>} connection
+ * @param {Error} [error]
+ */
+function lose (connection, error) {
+  emit(connection, 'close', error)
+}
+
+/**
+ * @param {jest.MockedObject<comq.Connection>} connection
+ */
+function restore (connection) {
+  emit(connection, 'open')
+}
+
+/**
+ * @param {jest.MockedObject<comq.Connection>} connection
+ * @param {comq.diagnostics.Event} event
+ * @param {any[]} args
+ */
+function emit (connection, event, ...args) {
+  const calls = connection.diagnose.mock.calls.filter((call) => call[0] === event)
+
+  expect(calls.length).toBeGreaterThan(0)
+
+  for (const call of calls) call[1](...args)
+}
+
 /**
  * @return {Promise<jest.MockedObject<comq.Channel>[]>}
  */

package/test/shards/connection.test.js

@@ -1,7 +1,8 @@
 'use strict'
 
 const { generate } = require('randomstring')
-const { random, promex, immediate } = require('@toa.io/generic')
+const { Promex } = require('promex')
+const { random, immediate } = require('../helpers')
 
 const { Connection } = require('../../source/shards')
 
@@ -32,11 +33,11 @@ describe('open', () => {
   it('should resolve when all of the connections are established', async () => {
     expect.assertions(2)
 
-    /** @type {toa.generic.Promex[]} */
+    /** @type {Promex[]} */
     const promises = []
 
     for (const conn of connections) {
-      const promise = promex()
+      const promise = new Promex()
 
       conn.open.mockImplementation(() => promise)
       promises.push(promise)

package/types/diagnostic.d.ts

@@ -1,7 +1,7 @@
 declare namespace comq.diagnostics {
 
-  type Event = 'open' | 'close' | 'error' | 'flow' | 'drain' | 'remove' | 'recover' | 'discard' |
-    'pause' | 'resume' | 'return'
+  type Event = 'open' | 'close' | 'error' | 'reconnect' | 'flow' | 'drain' | 'remove' | 'lost' |
+    'recover' | 'discard' | 'pause' | 'resume' | 'return'
 
   interface Diagnosable {
     diagnose(event: Event, listener: Function): void

package/types/encoding.d.ts

@@ -1,8 +1,7 @@
 declare namespace comq {
 
   type Encoding =
-    'application/msgpack'
-    | 'application/json'
+    'application/json'
     | 'application/octet-stream'
     | 'text/plain'
 

package/types/io.d.ts

@@ -63,6 +63,8 @@ declare namespace comq {
 
     diagnose(event: 'error', listener: (error: Error, index?: number) => void): void
 
+    diagnose(event: 'reconnect', listener: (index?: number) => void): void
+
     diagnose(event: 'flow', listener: (channel: _topology.type, index?: number) => void): void
 
     diagnose(event: 'drain', listener: (channel: _topology.type, index?: number) => void): void

package/AGENTS.md

@@ -1,35 +0,0 @@
-# AGENTS.md
-
-## Cursor Cloud specific instructions
-
-### Project Overview
-
-ComQ is a Node.js communication library over AMQP (RabbitMQ). It provides RPC, pub/sub, task queues, pipelines, and sharded connections.
-
-### Services
-
-Feature tests start two RabbitMQ instances automatically via Testcontainers (`features/steps/brokers.js`). Credentials: `developer` / `secret`. AMQP ports are assigned dynamically on the host.
-
-### Docker
-
-Feature tests require a running Docker daemon. In nested container environments, start Docker with:
-
-```bash
-sudo dockerd --exec-opt native.cgroupdriver=cgroupfs &
-sudo chmod 666 /var/run/docker.sock
-```
-
-Do not use `docker compose up` for feature tests — Testcontainers manages broker lifecycle. `docker compose` may fail here because `deploy.resources.limits.memory` requires cgroupv2 memory limits that are unavailable in nested setups.
-
-### Commands
-
-- `npm test` — runs `standard` (lint) + `jest` (300 unit tests, no RabbitMQ required)
-- `npm run features` — runs all Cucumber feature tests (starts RabbitMQ via Testcontainers)
-- `npm run lint` — runs `standard --fix --verbose | snazzy`
-
-### Testing Notes
-
-- Unit tests (`jest`) use mocks and do NOT require running RabbitMQ.
-- Feature tests (`cucumber-js`) start brokers in `BeforeAll` and stop them in `AfterAll`.
-- Recovery/connection tests (in `features/connection.feature`, `features/recovery.feature`, `features/shards.feature`) stop/kill broker containers and take 5-15 minutes to complete.
-- To run only fast feature tests (no broker stop/start): `npx cucumber-js --fail-fast -t 'not @manual' features/events.feature features/rpc.feature features/tasks.feature features/singleton.feature features/properties.feature features/tasks.shards.feature`

package/CHANGELOG.md

@@ -1,76 +0,0 @@
-## [0.15.6](https://github.com/toa-io/comq/compare/v0.15.5...v0.15.6) (2026-08-26)
-
-
-### Bug Fixes
-
-* do not report shards as lost on shutdown ([abbe0e8](https://github.com/toa-io/comq/commit/abbe0e8e1048509ff2c981b7aa33659c0829e821))
-* do not report shards as lost on shutdown ([#248](https://github.com/toa-io/comq/issues/248)) ([b269a5c](https://github.com/toa-io/comq/commit/b269a5cc78d8ca74036290abec234a1e87056e9c))
-
-## [0.15.5](https://github.com/toa-io/comq/compare/v0.15.4...v0.15.5) (2026-08-25)
-
-
-### Bug Fixes
-
-* recover from a lost connection reliably ([59b1fab](https://github.com/toa-io/comq/commit/59b1fab61d4f27ab6eb608693da6493b5b1f4ae5))
-* recover from a lost connection reliably ([#247](https://github.com/toa-io/comq/issues/247)) ([e4701cf](https://github.com/toa-io/comq/commit/e4701cfa384d5451c15d0a6bf53c82ce1da91ac5))
-
-## [0.15.4](https://github.com/toa-io/comq/compare/v0.15.3...v0.15.4) (2026-08-16)
-
-
-### Bug Fixes
-
-* remove request() timeout ([#246](https://github.com/toa-io/comq/issues/246)) ([d432388](https://github.com/toa-io/comq/commit/d4323889bcad867a870d0ed351b92098f6aad551))
-
-## [0.15.3](https://github.com/toa-io/comq/compare/v0.15.2...v0.15.3) (2026-08-04)
-
-
-### Bug Fixes
-
-* re-send requests left unanswered by a lost shard ([c534a01](https://github.com/toa-io/comq/commit/c534a0136e5f0189cdb6976cd9cffb9a2ca5a148))
-* re-send requests left unanswered by a lost shard ([#242](https://github.com/toa-io/comq/issues/242)) ([c821da8](https://github.com/toa-io/comq/commit/c821da895049bd78a907c6705477ebe74c160e1b))
-
-## [0.15.2](https://github.com/toa-io/comq/compare/v0.15.1...v0.15.2) (2026-08-04)
-
-
-### Bug Fixes
-
-* report and recover undeliverable replies ([b2d2d0f](https://github.com/toa-io/comq/commit/b2d2d0f11d7714c2d32d3d85894fa78e2203f8c6))
-* report and recover undeliverable replies ([#241](https://github.com/toa-io/comq/issues/241)) ([73e5592](https://github.com/toa-io/comq/commit/73e5592762634fbead29d825be68a3da3136729b))
-
-## [0.15.1](https://github.com/toa-io/comq/compare/v0.15.0...v0.15.1) (2026-08-02)
-
-
-### Bug Fixes
-
-* skip end control when reply stream buffer overflows ([654e046](https://github.com/toa-io/comq/commit/654e046bdcbfbbbbbb789e5bb032bc16564221d1)), closes [#control](https://github.com/toa-io/comq/issues/control) [#reply](https://github.com/toa-io/comq/issues/reply)
-* skip end control when reply stream buffer overflows ([#237](https://github.com/toa-io/comq/issues/237)) ([c34d87f](https://github.com/toa-io/comq/commit/c34d87f6d219ce6c8509d989117eadd55a33ca86))
-
-# [0.15.0](https://github.com/toa-io/comq/compare/v0.14.0...v0.15.0) (2026-08-01)
-
-
-### Bug Fixes
-
-* avoid channel recover deadlock after broker restart ([8eeaf2e](https://github.com/toa-io/comq/commit/8eeaf2e12321be71b57913adb6a8fb04bd24d439)), closes [#recovery](https://github.com/toa-io/comq/issues/recovery)
-* destroy half-open connections via socket idle watchdog ([9f7ed5f](https://github.com/toa-io/comq/commit/9f7ed5fe50e9ab1857547a6e908185b6b472162f))
-* ignore close events from replaced AMQP connections ([c1070ab](https://github.com/toa-io/comq/commit/c1070abeca9eb30a1c0ed07925bc06e530c1d9ce))
-* reconnect hang after broker restart ([#235](https://github.com/toa-io/comq/issues/235)) ([be07079](https://github.com/toa-io/comq/commit/be07079863194301d0279e2bdd551260196ce20a))
-* retry transient network errors on initial connect ([c436a20](https://github.com/toa-io/comq/commit/c436a2017a2b52d102afa05bc694c9f22faf2065)), closes [#transient](https://github.com/toa-io/comq/issues/transient)
-* tolerate empty YAML documents after js-yaml 5 bump ([0a05ecb](https://github.com/toa-io/comq/commit/0a05ecbf744822b3aa884382642ce51a93922dfc))
-
-
-### Features
-
-* allow request() to time out pending replies ([ac9e2bd](https://github.com/toa-io/comq/commit/ac9e2bd7eb0834d19d404c84f24548bd5475017f))
-* tag container-manipulation features [@heavy](https://github.com/heavy) and add features:fast script ([c0f52ec](https://github.com/toa-io/comq/commit/c0f52ecf72c010e387e853b3daed6884c1cef474))
-
-# [0.14.0](https://github.com/toa-io/comq/compare/v0.13.0...v0.14.0) (2026-05-24)
-
-
-### Features
-
-* **features:** manage RabbitMQ brokers with Testcontainers ([1d9ca59](https://github.com/toa-io/comq/commit/1d9ca591ff458c75caf87ab63224b15942ba7d07))
-* **features:** use Testcontainers for RabbitMQ in Gherkin tests ([#219](https://github.com/toa-io/comq/issues/219)) ([a33e66b](https://github.com/toa-io/comq/commit/a33e66bfc357f0f089c728bc60c08f6f24b2c8d1))
-
-# Changelog
-
-All notable changes to this project are documented in this file by [semantic-release](https://github.com/semantic-release/semantic-release).

package/source/encoders/msgpack.js

@@ -1,6 +0,0 @@
-'use strict'
-
-const { pack, unpack } = require('msgpackr')
-
-exports.encode = pack
-exports.decode = unpack