comq 0.15.5 → 0.15.6

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [0.15.6](https://github.com/toa-io/comq/compare/v0.15.5...v0.15.6) (2026-08-26)
+
+
+### Bug Fixes
+
+* do not report shards as lost on shutdown ([abbe0e8](https://github.com/toa-io/comq/commit/abbe0e8e1048509ff2c981b7aa33659c0829e821))
+* do not report shards as lost on shutdown ([#248](https://github.com/toa-io/comq/issues/248)) ([b269a5c](https://github.com/toa-io/comq/commit/b269a5cc78d8ca74036290abec234a1e87056e9c))
+
 ## [0.15.5](https://github.com/toa-io/comq/compare/v0.15.4...v0.15.5) (2026-08-25)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "comq",
-  "version": "0.15.5",
+  "version": "0.15.6",
   "description": "ComQ",
   "author": {
     "name": "Artem Gurtovoi",

package/source/connection.js

@@ -60,6 +60,10 @@ class Connection {
     return this.#connection !== undefined
   }
 
+  get closed () {
+    return this.#closed
+  }
+
   async open () {
     this.#closed = false
 

package/source/shards/channel.js

@@ -111,6 +111,7 @@ class Channel {
    * when it actually fails to publish, otherwise a lost connection would
    * interrupt the streams it is carrying. Losing a shard is reported instead,
    * since a request awaiting its reply on it will never be answered.
+   * A connection closed on purpose is not a loss.
    *
    * @param {comq.Connection} connection
    * @param {number} index
@@ -121,10 +122,13 @@ class Channel {
 
     if (connection.connected === false) this.#down[index].resolve()
 
-    connection.diagnose('close', () => {
+    connection.diagnose('close', (error) => {
       this.#alive[index] = false
       this.#down[index].resolve()
-      this.#diagnostics.emit(LOST, index)
+
+      if (error !== undefined && connection.closed !== true) {
+        this.#diagnostics.emit(LOST, index)
+      }
     })
 
     connection.diagnose('open', () => {

package/test/connection.mock.js

@@ -20,6 +20,7 @@ const channel = /** @type {jest.MockedFunction<(sharded?: boolean, index?: numbe
  */
 const connection = (sharded = false) => (/** @type {jest.MockedObject<comq.Connection>} */ {
   connected: true,
+  closed: false,
   createChannel: jest.fn(async (type, index) => channel(sharded, index)),
   open: jest.fn(async () => undefined),
   close: jest.fn(async () => undefined),

package/test/connection.test.js

@@ -402,6 +402,7 @@ describe('close', () => {
     const amqp = await amqplib.connect.mock.results[0].value
 
     expect(amqp.close).toHaveBeenCalled()
+    expect(connection.closed).toStrictEqual(true)
   })
 
   it('should close after connection is (re)established', async () => {

package/test/shards/channel.test.js

@@ -40,11 +40,45 @@ it('should report a lost shard', async () => {
 
   expect(calls.length).toBeGreaterThan(0)
 
-  for (const call of calls) call[1]()
+  for (const call of calls) call[1](new Error('gone'))
 
   expect(lost).toHaveBeenCalledWith(1)
 })
 
+it('should not report a lost shard when the connection is closed', async () => {
+  channel = await create(connections, type)
+
+  const lost = /** @type {jest.MockedFunction} */ jest.fn()
+
+  channel.diagnose('lost', lost)
+
+  connections[1].closed = true
+
+  const calls = connections[1].diagnose.mock.calls.filter((call) => call[0] === 'close')
+
+  expect(calls.length).toBeGreaterThan(0)
+
+  for (const call of calls) call[1](new Error('gone'))
+
+  expect(lost).not.toHaveBeenCalled()
+})
+
+it('should not report a lost shard when the connection is closed cleanly', async () => {
+  channel = await create(connections, type)
+
+  const lost = /** @type {jest.MockedFunction} */ jest.fn()
+
+  channel.diagnose('lost', lost)
+
+  const calls = connections[1].diagnose.mock.calls.filter((call) => call[0] === 'close')
+
+  expect(calls.length).toBeGreaterThan(0)
+
+  for (const call of calls) call[1]()
+
+  expect(lost).not.toHaveBeenCalled()
+})
+
 it('should not publish to a lost shard', async () => {
   channel = await create(connections, type)
 

package/types/connection.d.ts

@@ -7,6 +7,7 @@ declare namespace comq {
 
   interface Connection {
     readonly connected?: boolean
+    readonly closed?: boolean
 
     open(): Promise<void>