compound-workflow 1.4.2 → 1.4.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -75,6 +75,17 @@ You are an independent technical reviewer for plan documents. Your purpose is to
|
|
|
75
75
|
- Impact
|
|
76
76
|
- Suggested improvement
|
|
77
77
|
|
|
78
|
+
### Findings Queue (for stepwise dialogue)
|
|
79
|
+
1. [Finding title]
|
|
80
|
+
- Summary: [one-line]
|
|
81
|
+
- Intent: [why it matters]
|
|
82
|
+
- Options:
|
|
83
|
+
- A: [path]
|
|
84
|
+
- B: [path]
|
|
85
|
+
- C: [path, optional]
|
|
86
|
+
- Recommendation: [preferred option]
|
|
87
|
+
- Initial status: pending
|
|
88
|
+
|
|
78
89
|
### Direction Drift Check
|
|
79
90
|
- In-scope: yes|no
|
|
80
91
|
- Drift signals found: [none | list]
|
|
@@ -86,6 +97,8 @@ You are an independent technical reviewer for plan documents. Your purpose is to
|
|
|
86
97
|
- Preferred option + why
|
|
87
98
|
```
|
|
88
99
|
|
|
100
|
+
The `Findings Queue` is mandatory when at least one finding exists. It is consumed by `technical-review` for one-finding-at-a-time review (`next` progression).
|
|
101
|
+
|
|
89
102
|
## Guardrails
|
|
90
103
|
|
|
91
104
|
- Do not edit the plan in this agent.
|
|
@@ -5,7 +5,7 @@ description: Use when a feature approach or plan doc has passed document review
|
|
|
5
5
|
|
|
6
6
|
# Technical Review
|
|
7
7
|
|
|
8
|
-
Review a feature approach or plan document for technical alignment with architecture, code standards, and quality.
|
|
8
|
+
Review a feature approach or plan document for technical alignment with architecture, code standards, and quality. Keep a running summary of findings, then review findings one at a time through user-driven dialogue (`next`). For each finding, output intent, options, and a recommendation. Do not approve for build until the plan is updated via a second document review.
|
|
9
9
|
|
|
10
10
|
Primary execution model: run an independent planning-phase pass first using `planning-technical-reviewer` (when available), then synthesize final technical review verdict.
|
|
11
11
|
|
|
@@ -27,6 +27,15 @@ Primary execution model: run an independent planning-phase pass first using `pla
|
|
|
27
27
|
- Treat its blocking findings as pre-build blockers.
|
|
28
28
|
- If the agent is not available, explicitly state: "planning-technical-reviewer unavailable; running direct technical review (degraded bias resistance)".
|
|
29
29
|
|
|
30
|
+
## Step 1.6: Build Findings Queue (Required)
|
|
31
|
+
|
|
32
|
+
- Consolidate all blocking and non-blocking findings into an ordered queue.
|
|
33
|
+
- Keep a persistent `Findings Summary` visible throughout the review with status per finding:
|
|
34
|
+
- `pending`
|
|
35
|
+
- `aligned`
|
|
36
|
+
- `deferred`
|
|
37
|
+
- Do not process findings in bulk. Process one finding at a time.
|
|
38
|
+
|
|
30
39
|
## Step 2: Assess Against Technical Criteria
|
|
31
40
|
|
|
32
41
|
Evaluate the plan against:
|
|
@@ -52,7 +61,29 @@ Assign one **overall** risk level for the plan:
|
|
|
52
61
|
|
|
53
62
|
State the risk level and one-line rationale.
|
|
54
63
|
|
|
55
|
-
## Step 4:
|
|
64
|
+
## Step 4: One-Finding Dialogue Loop (Required)
|
|
65
|
+
|
|
66
|
+
For each queued finding, present:
|
|
67
|
+
|
|
68
|
+
- `Finding:` concise summary
|
|
69
|
+
- `Intent:` why this matters technically
|
|
70
|
+
- `Options:` 2-3 viable paths with tradeoffs
|
|
71
|
+
- `Recommendation:` preferred option with rationale
|
|
72
|
+
- `Outcome:` leave as `pending` until user aligns
|
|
73
|
+
|
|
74
|
+
After each finding, stop and prompt exactly:
|
|
75
|
+
|
|
76
|
+
- `Say "next" to continue to the next finding.`
|
|
77
|
+
|
|
78
|
+
Supported user controls in this loop:
|
|
79
|
+
|
|
80
|
+
- `next` -> advance to the next pending finding
|
|
81
|
+
- `accept` -> mark current finding as `aligned`, record chosen outcome
|
|
82
|
+
- `revise: <note>` -> update current finding framing/options/recommendation before moving on
|
|
83
|
+
|
|
84
|
+
Do not skip ahead automatically while findings remain pending.
|
|
85
|
+
|
|
86
|
+
## Step 5: Three Options with Justifications (Overall Verdict)
|
|
56
87
|
|
|
57
88
|
For each option, provide 2–3 sentences justification:
|
|
58
89
|
|
|
@@ -60,25 +91,27 @@ For each option, provide 2–3 sentences justification:
|
|
|
60
91
|
- **Option B — Proceed with changes** — When risk is medium. List specific doc or code changes; justify why this is sufficient.
|
|
61
92
|
- **Option C — Rework or spike** — When risk is high or uncertain. Say what to rework or spike; justify why build should wait.
|
|
62
93
|
|
|
63
|
-
## Step
|
|
94
|
+
## Step 6: Recommendation (Overall Verdict)
|
|
64
95
|
|
|
65
96
|
State the **preferred option** and clear rationale (e.g. "Recommend Option B because …"). Tie to the risk level and findings.
|
|
66
97
|
|
|
67
|
-
## Step
|
|
98
|
+
## Step 7: Output and Handoff
|
|
68
99
|
|
|
69
|
-
- **If pass (Option A or B with changes agreed):** Say "Approved for build" and optional notes. **Handoff:** Run **document review again** to update the plan with technical review findings (recommendation, agreed changes). Then build.
|
|
100
|
+
- **If pass (Option A or B with changes agreed):** Say "Approved for build" and optional notes. **Handoff:** Run **document review again** to update the plan with all aligned technical review findings (recommendation, agreed changes, per-finding outcomes). Then build.
|
|
70
101
|
- **If issues (Option C or B with open changes):** List issues to fix in the doc; do not approve for build until addressed. Handoff: update the plan (or re-run document review to incorporate fixes), then optionally re-run technical review.
|
|
71
102
|
|
|
72
103
|
## Required Output
|
|
73
104
|
|
|
74
105
|
End every technical review with:
|
|
75
106
|
|
|
107
|
+
- `Findings summary:` full list with status `pending|aligned|deferred`
|
|
108
|
+
- `Per-finding outcomes:` one line each for every aligned finding
|
|
76
109
|
- `Risk level:` low | medium | high (plus one-line rationale)
|
|
77
110
|
- `Fresh-context pass:` ran | unavailable (degraded)
|
|
78
111
|
- `Options A/B/C:` 2–3 sentences each
|
|
79
112
|
- `Recommendation:` preferred option and rationale
|
|
80
113
|
- `Approved for build:` yes | no
|
|
81
|
-
- `Handoff:` re-run document review to update plan with findings before build (when approved), or list issues to fix (when not approved)
|
|
114
|
+
- `Handoff:` re-run document review to update the plan with related findings and outcomes before build (when approved), or list issues to fix (when not approved)
|
|
82
115
|
|
|
83
116
|
## What NOT to Do
|
|
84
117
|
|
|
@@ -86,6 +119,7 @@ End every technical review with:
|
|
|
86
119
|
- Do not add scope or new requirements.
|
|
87
120
|
- Do not approve for build when risk is high and no rework is agreed.
|
|
88
121
|
- Do not skip the second document review—the plan must be updated with technical review findings before build.
|
|
122
|
+
- Do not collapse multiple findings into one response when interactive finding review is active.
|
|
89
123
|
|
|
90
124
|
## Integration
|
|
91
125
|
|