componentsjs 5.0.0-beta.5 → 5.0.0-beta.6

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+<a name="v5.0.0-beta.6"></a>
+## [v5.0.0-beta.6](https://github.com/LinkedSoftwareDependencies/Components.js/compare/v5.0.0-beta.5...v5.0.0-beta.6) - 2022-02-09
+
+### Fixed
+* [Fix generic errors still throwing during ignored type checking](https://github.com/LinkedSoftwareDependencies/Components.js/commit/c14adcf4757e5194db22c0f0285407bd03bf5635)
+
 <a name="v5.0.0-beta.5"></a>
 ## [v5.0.0-beta.5](https://github.com/LinkedSoftwareDependencies/Components.js/compare/v5.0.0-beta.4...v5.0.0-beta.5) - 2022-02-08
 

package/lib/preprocess/ConfigPreprocessorComponent.js

@@ -97,8 +97,11 @@ class ConfigPreprocessorComponent {
         // ParameterPropertyHandlerRange#hasParamValueValidType)
         if (config.property.genericTypeInstancesComponentScope &&
             handleResponse.component.value === config.property.genericTypeInstancesComponentScope.value) {
-            genericsContext.bindComponentGenericTypes(handleResponse.component, config.properties.genericTypeInstances, { config }, (subType, superType) => this.parameterHandler.parameterPropertyHandlerRange
+            const conflict = genericsContext.bindComponentGenericTypes(handleResponse.component, config.properties.genericTypeInstances, { config }, (subType, superType) => this.parameterHandler.parameterPropertyHandlerRange
                 .hasType(subType, superType, genericsContext, config.property.genericTypeInstancesComponentScope, config.properties.genericTypeInstances, { config }));
+            if (conflict) {
+                throw new ErrorResourcesContext_1.ErrorResourcesContext(conflict.description, conflict.context);
+            }
         }
         return genericsContext;
     }

package/lib/preprocess/GenericsContext.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.GenericsContext = void 0;
-const ErrorResourcesContext_1 = require("../util/ErrorResourcesContext");
 const ParameterPropertyHandlerRange_1 = require("./parameterproperty/ParameterPropertyHandlerRange");
 /**
  * Context for binding generic types to a concrete range value.
@@ -270,7 +269,10 @@ class GenericsContext {
         }
         // Throw if an unexpected number of generic type instances are passed.
         if (genericTypeParameters.length !== genericTypeInstances.length) {
-            throw new ErrorResourcesContext_1.ErrorResourcesContext(`Invalid generic type instantiation: a different amount of generic types are passed (${genericTypeInstances.length}) than are defined on the component (${genericTypeParameters.length}).`, Object.assign({ passedGenerics: genericTypeInstances, definedGenerics: genericTypeParameters, component }, errorContext));
+            return {
+                description: `Invalid generic type instantiation: a different amount of generic types are passed (${genericTypeInstances.length}) than are defined on the component (${genericTypeParameters.length}).`,
+                context: Object.assign({ passedGenerics: genericTypeInstances, definedGenerics: genericTypeParameters, component }, errorContext),
+            };
         }
         // Populate with manually defined generic type bindings
         for (const [i, genericTypeInstance] of genericTypeInstances.entries()) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "componentsjs",
-  "version": "5.0.0-beta.5",
+  "version": "5.0.0-beta.6",
   "description": "A semantic dependency injection framework",
   "lsd:contexts": {
     "https://linkedsoftwaredependencies.org/bundles/npm/componentsjs/^3.0.0/components/context.jsonld": "components/context.jsonld"