commit-sheriff 1.7.1 → 1.7.2

package/README.md

@@ -251,19 +251,19 @@ The default config added by `init` (only if you don't already have one):
 ```json
 {
   "lint-staged": {
-    "*.{js,jsx,ts,tsx}": ["eslint --fix --max-warnings=0", "prettier --write"],
+    "*.{js,jsx,ts,tsx}": ["eslint --fix", "prettier --write"],
     "*.{json,md,css,scss,html}": ["prettier --write"]
   }
 }
 ```
 
-`--max-warnings=0` is there on purpose: ESLint only fails (non-zero exit) on errors by default, so
-a rule set to `"warn"` (e.g. many "recommended" configs' default severity for unused imports) would
-otherwise print in the terminal but still let the commit through looking clean.
+Warnings are printed but never block the commit — only actual errors (ESLint's non-zero exit) do.
+That's the default ESLint behavior (`--fix` alone exits 0 on warning-only results), so a rule set to
+`"warn"` (e.g. an unused import under some "recommended" configs) shows up in the terminal as a
+heads-up but doesn't stop you from committing.
 
-Adjust freely — `commit-sheriff` doesn't overwrite it once present. That also means this default
-only lands on **new** setups; if your project already has a `lint-staged` block from before this
-change, add `--max-warnings=0` to it by hand to get the same behavior.
+Adjust freely — `commit-sheriff` doesn't overwrite it once present. If you want warnings to block
+the commit too, add `--max-warnings=0` to the `eslint --fix` command by hand.
 
 ## Advanced: ESLint module-boundary template (TypeScript/React)
 

package/bin/commit-sheriff.js

@@ -38,10 +38,9 @@ const DEFAULT_COMMIT_GUARD = {
 };
 
 const DEFAULT_LINT_STAGED = {
-  // --max-warnings=0: without this, ESLint only fails (non-zero exit) on errors — a warning
-  // (e.g. many "recommended" configs' default severity for unused imports) prints in the
-  // terminal but still lets `eslint --fix` exit 0, so the commit goes through looking clean.
-  "*.{js,jsx,ts,tsx}": ["eslint --fix --max-warnings=0", "prettier --write"],
+  // No --max-warnings=0 here on purpose: warnings should be visible (ESLint prints them to the
+  // terminal either way) but must NOT block the commit — only actual errors (non-zero exit) do.
+  "*.{js,jsx,ts,tsx}": ["eslint --fix", "prettier --write"],
   "*.{json,md,css,scss,html}": ["prettier --write"],
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "commit-sheriff",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "description": "Shared husky commit-msg / pre-commit hooks enforcing ticket-based commit messages and branch naming",
   "main": "index.js",
   "bin": {

package/templates/pre-commit

@@ -77,7 +77,11 @@ HAS_LINT_CONFIG=$(node -e "
 " 2>/dev/null)
 if [ "$HAS_LINT_CONFIG" = "1" ]; then
     if node -e "require.resolve('lint-staged')" 2>/dev/null; then
-        npx lint-staged || exit 1
+        # --verbose: lint-staged only prints a task's output when it *fails* by default, so a
+        # warning-only ESLint result (exit 0, commit still allowed through) would otherwise show
+        # nothing at all. --verbose keeps it printing on success too, so warnings stay visible as
+        # a heads-up without blocking the commit.
+        npx lint-staged --verbose || exit 1
     else
         echo ""
         echo "  package.json-da 'lint-staged' konfiqurasiyası var, amma paketin özü"