commandmate 0.44.1 → 0.44.3

package/dist/server/src/lib/detection/tools/claude/live-region.js

@@ -0,0 +1,26 @@
+"use strict";
+/**
+ * Claude's live region (Issue #3183; design doc §7 "claude").
+ *
+ * - **composer** — the input box: closing rule within 4 rows of the bottom, an
+ *   opening rule within 40 rows above it, and a `>`/`❯` row right under the
+ *   opening rule (`findClaudeInputBox`, the finder #2847 / the idle rule / the
+ *   dialog rule already share). Measured: `tui-frame-footer-2776/
+ *   claude-2.1.278-idle-quoted-footers.txt` L997-L1000.
+ * - **dialog top** — the rule above the first option of the dialog that closes
+ *   with Claude's footer (`claude-2.1.278-bash-approval.txt` L12 / L20 / L25,
+ *   `claude-2.1.278-askuserquestion-picker.txt` L17 / L22 / L30, whose inner
+ *   rule L27 is why the search starts at the option).
+ *
+ * @module lib/detection/tools/claude/live-region
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CLAUDE_LIVE_REGION = void 0;
+const composer_text_1 = require("../../composer-text");
+const tui_detection_frame_1 = require("../../tui-detection-frame");
+const live_region_1 = require("../live-region");
+exports.CLAUDE_LIVE_REGION = {
+    composer: (0, live_region_1.fencedComposer)(lines => (0, composer_text_1.findClaudeInputBox)(lines)?.openingSeparator ?? -1),
+    dialogTop: (0, live_region_1.ruleAboveOptionRun)({ footer: tui_detection_frame_1.isClaudeFooter, rule: /^─{10,}$/, maxRows: 120 }),
+    composerHidesDialogs: true,
+};

package/dist/server/src/lib/detection/tools/claude/patterns.js

@@ -2,9 +2,10 @@
 /**
  * Claude Code's own detection patterns (Issue #1927).
  *
- * The regexes shared with other tools stay in `cli-patterns.ts`; what lives here
- * is what Issue #1927 had to measure to give Claude a §4 D1 idle rule, plus the
- * provenance of that measurement.
+ * What comes first is what Issue #1927 had to measure to give Claude a §4 D1
+ * idle rule, plus the provenance of that measurement. Below `VERIFIED_AGAINST`
+ * are the Claude patterns Issue #3217 moved here from `cli-patterns.ts`, which
+ * keeps the per-tool table and re-exports their public names.
  *
  * ## Why Claude needed a new rule at all
  *
@@ -45,7 +46,11 @@
  * argument #1893 used to make opencode's `▣ … · 2.3s` duration mandatory.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.VERIFIED_AGAINST = exports.CLAUDE_EFFORT_CHIP_PATTERN = exports.CLAUDE_TRANSCRIPT_USER_TURN_PATTERN = exports.CLAUDE_BANNER_PATTERN = exports.CLAUDE_TURN_COMPLETE_PATTERN = void 0;
+exports.CLAUDE_SESSION_ERROR_REGEX_PATTERNS = exports.CLAUDE_SESSION_ERROR_PATTERNS = exports.CLAUDE_SELECTION_LIST_FOOTER = exports.CLAUDE_MODEL_OVERLAY_FOOTER_PATTERN = exports.CLAUDE_TRUST_DIALOG_PATTERN = exports.CLAUDE_SEPARATOR_PATTERN = exports.CLAUDE_PROMPT_PATTERN = exports.CLAUDE_INTERRUPT_HINT_PATTERN = exports.CLAUDE_THINKING_PATTERN = exports.CLAUDE_SPINNER_CHARS = exports.VERIFIED_AGAINST = exports.CLAUDE_EFFORT_CHIP_PATTERN = exports.CLAUDE_TRANSCRIPT_USER_TURN_PATTERN = exports.CLAUDE_BANNER_PATTERN = exports.CLAUDE_TURN_COMPLETE_PATTERN = void 0;
+exports.findClaudeChromeStart = findClaudeChromeStart;
+exports.resolveClaudeTrustDialogKeys = resolveClaudeTrustDialogKeys;
+exports.isClaudeTrustDialogOpen = isClaudeTrustDialogOpen;
+const composer_text_1 = require("../../composer-text");
 /**
  * Claude's turn-completion marker: a spinner glyph, a verb, and a duration.
  *
@@ -96,3 +101,258 @@ exports.CLAUDE_EFFORT_CHIP_PATTERN = /·\s*\/effort\s*$/;
  */
 var verified_against_1 = require("../verified-against");
 Object.defineProperty(exports, "VERIFIED_AGAINST", { enumerable: true, get: function () { return verified_against_1.CLAUDE_VERIFIED_AGAINST; } });
+/**
+ * The Claude blocks moved out of `../../cli-patterns.ts` (Issue #3217 I-7).
+ * `cli-patterns.ts` re-exports every public name.
+ */
+/**
+ * Claude CLI spinner characters (expanded set)
+ * These are shown when Claude is thinking/processing
+ */
+exports.CLAUDE_SPINNER_CHARS = [
+    '✻', '✽', '⏺', '·', '∴', '✢', '✳', '✶',
+    '⦿', '◉', '●', '○', '◌', '◎', '⊙', '⊚',
+    '⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏', // Braille spinner
+];
+/**
+ * Claude thinking pattern
+ * Matches spinner character followed by activity text ending with …
+ * The text can contain spaces (e.g., "Verifying implementation (dead code detection)…")
+ *
+ * Alternative 2: "esc to interrupt" status bar text (Issue #188)
+ * Claude Code shows "esc to interrupt" in the terminal status bar during active processing.
+ * Previous pattern required closing paren `to interrupt\)` matching `(esc to interrupt)`,
+ * but Claude Code v2.x status bar format uses `· esc to interrupt ·` without parens.
+ * Updated to match `esc to interrupt` which covers both formats.
+ */
+exports.CLAUDE_THINKING_PATTERN = new RegExp(`[${exports.CLAUDE_SPINNER_CHARS.join('')}]\\s+.+…|esc to interrupt`, 'm');
+/**
+ * Claude status-bar "esc to interrupt" hint (Issue #805)
+ *
+ * Claude Code shows "esc to interrupt" in the bottom status bar ONLY while it is
+ * actively processing. When idle/ready, the status bar shows shortcut hints
+ * (e.g., "? for shortcuts") instead -- so this token is a reliable "running" signal.
+ *
+ * Why this exists separately from CLAUDE_THINKING_PATTERN's "esc to interrupt"
+ * alternative: status detection evaluates the spinner+ellipsis branch of
+ * CLAUDE_THINKING_PATTERN within a narrow 5-line window (THINKING_TAIL_LINE_COUNT)
+ * to avoid mistaking a completed thinking summary in scrollback for active work
+ * (Issue #188). During /pm-auto-dev + subagent runs, the bottom task panel
+ * ("⏺ main" / "◯ general-purpose ..." rows) pushes both the "✶ Running…" spinner
+ * AND the "esc to interrupt" status bar out of that 5-line window, so the session
+ * was misdetected as Ready (Issue #805). Unlike the spinner+ellipsis summary, the
+ * status-bar text is repainted live and never lingers in scrollback, so it can be
+ * matched in a wider footer window without regressing Issue #188.
+ */
+exports.CLAUDE_INTERRUPT_HINT_PATTERN = /esc to interrupt/;
+/**
+ * Claude prompt pattern (waiting for input)
+ * Supports both legacy '>' and new '❯' (U+276F) prompt characters
+ * Issue #132: Also matches prompts with recommended commands (e.g., "❯ /work-plan")
+ *
+ * Matches:
+ * - Empty prompt: "❯ " or "> "
+ * - Prompt with command: "❯ /work-plan" or "> npm install"
+ */
+exports.CLAUDE_PROMPT_PATTERN = /^[>❯](\s*$|\s+\S)/m;
+/**
+ * Claude separator pattern
+ */
+exports.CLAUDE_SEPARATOR_PATTERN = /^─{10,}$/m;
+/**
+ * Locate the start of Claude Code's bottom-pinned footer within a captured pane.
+ *
+ * Claude Code v2 draws in the alternate screen and reserves the last rows of the
+ * pane for a footer that is never transcript content:
+ *
+ *     <hint row>            ← "◉ xhigh · /effort", "tmux detected · …", or blank
+ *     ────────────────────  ← separator
+ *     ❯ <input box>         ← one or more rows
+ *     ────────────────────  ← separator
+ *     ⏸ manual mode on · ? for shortcuts · ← for agents        focus
+ *
+ * The hint row rotates every few seconds while the conversation sits idle, so
+ * keeping the footer in an extracted response makes its content hash change on
+ * every poll tick. That defeated the content-based dedup added in #1268 and
+ * re-saved the same reply once per tick (#1289).
+ *
+ * The boundary is found structurally rather than by matching hint text: the hint
+ * strings are Claude Code's to change, and pattern-matching them is what let this
+ * regression through (`? for shortcuts` was already listed as a skip pattern, but
+ * the real status bar embeds it mid-line so the anchors never matched). The row
+ * above the opening separator is reserved by Claude Code's layout and stays blank
+ * even when a reply fills the whole pane, so it is always safe to drop.
+ *
+ * @param lines - Captured pane lines; trailing blank rows are tolerated
+ * @returns Index of the first footer row, or -1 when no footer is present
+ */
+function findClaudeChromeStart(lines) {
+    // Issue #1879: the structural search (closing separator → opening separator →
+    // prompt glyph, including the "is this really the input box and not a reply
+    // fenced by two horizontal rules?" check) moved to `findClaudeInputBox` so the
+    // composer reader locates the same box this trimmer does. Behaviour here is
+    // unchanged; only the caller of the search moved.
+    const box = (0, composer_text_1.findClaudeInputBox)(lines);
+    if (box === null)
+        return -1;
+    // Include the reserved hint row directly above the opening separator.
+    return Math.max(0, box.openingSeparator - 1);
+}
+/**
+ * Claude trust dialog pattern (Issue #201)
+ *
+ * Matches the "Quick safety check" dialog displayed by Claude CLI v2.x
+ * when accessing a workspace for the first time.
+ *
+ * Intentionally uses partial matching (no line-start anchor ^):
+ * Other pattern constants (CLAUDE_PROMPT_PATTERN, CLAUDE_SEPARATOR_PATTERN, etc.)
+ * use line-start anchors (^), but this pattern needs to match at any position
+ * within the tmux output buffer because the dialog text may appear after
+ * tmux padding or other output. (SF-001)
+ */
+exports.CLAUDE_TRUST_DIALOG_PATTERN = /Yes, I trust this folder/m;
+/** The option row of the trust dialog's cursor: `❯` (or legacy `>`) after the dialog's left padding. */
+const CLAUDE_TRUST_CURSOR_ROW_PATTERN = /^\s*[>❯]\s+\S/;
+/** How far the cursor row may sit from the `Yes, I trust this folder` row (the dialog has two options). */
+const CLAUDE_TRUST_MAX_CURSOR_DISTANCE = 3;
+/**
+ * Keys that answer Claude Code's folder-trust dialog with "Yes", or null when
+ * no answerable dialog is on screen (Issue #3078).
+ *
+ * The dialog comes in two layouts, and Enter alone is only right for one:
+ *
+ *   - default Yes (Issue #201 era, `tests/unit/lib/claude-session.test.ts`):
+ *     ` ❯ 1. Yes, I trust this folder` / `   2. No, exit` — Enter confirms Yes.
+ *   - default No (2.1.259 `tests/fixtures/chat-dialog-card-2254/claude-trust-2-1-259.txt`,
+ *     2.1.287 with a permission allow-list
+ *     `tests/fixtures/claude-trust-dialog-3078/allowlist-default-no-2-1-287.txt`):
+ *     ` ❯ No, exit` / `   Yes, I trust this folder` — Enter EXITS Claude Code.
+ *
+ * So the answer is read off the screen: the distance from the cursor row to the
+ * Yes row becomes that many `Up`/`Down` presses, then `Enter`. Only the last
+ * dialog in the capture counts, and a dialog followed by Claude's input-box
+ * separator is history in the scrollback, not an open dialog.
+ *
+ * @param output - ANSI-stripped pane output
+ * @returns tmux key names ending in `Enter` (just `['Enter']` when the cursor is
+ *   already on Yes), or null when no open dialog / no readable cursor row
+ */
+function resolveClaudeTrustDialogKeys(output) {
+    const lines = output.split('\n');
+    const yesIndex = findOpenClaudeTrustYesRow(lines);
+    if (yesIndex === -1)
+        return null;
+    for (let distance = 0; distance <= CLAUDE_TRUST_MAX_CURSOR_DISTANCE; distance++) {
+        for (const direction of distance === 0 ? [0] : [-1, 1]) {
+            const index = yesIndex + direction * distance;
+            if (index < 0 || index >= lines.length)
+                continue;
+            if (!CLAUDE_TRUST_CURSOR_ROW_PATTERN.test(lines[index]))
+                continue;
+            // Cursor above Yes → move Down; below → move Up.
+            const key = direction < 0 ? 'Down' : 'Up';
+            return [...Array(distance).fill(key), 'Enter'];
+        }
+    }
+    return null;
+}
+/**
+ * Whether Claude Code's folder-trust dialog is the open screen (Issue #3078).
+ *
+ * The dialog's cursor row (` ❯ No, exit`) has the prompt glyph, so the start
+ * wait asks this before CLAUDE_PROMPT_PATTERN rather than reading the dialog as
+ * a ready prompt.
+ *
+ * @param output - ANSI-stripped pane output
+ */
+function isClaudeTrustDialogOpen(output) {
+    return findOpenClaudeTrustYesRow(output.split('\n')) !== -1;
+}
+/** Row of the last `Yes, I trust this folder`, or -1 when absent or already answered. */
+function findOpenClaudeTrustYesRow(lines) {
+    for (let i = lines.length - 1; i >= 0; i--) {
+        if (!exports.CLAUDE_TRUST_DIALOG_PATTERN.test(lines[i]))
+            continue;
+        // Claude's input box (separator rows) drawn below it: the dialog is scrollback.
+        return lines.slice(i + 1).some((line) => exports.CLAUDE_SEPARATOR_PATTERN.test(line)) ? -1 : i;
+    }
+    return -1;
+}
+/**
+ * [Issue #1495] Footer signature of Claude Code's `/model` local-settings overlay.
+ * Verified against a real Claude Code v2.1.218 capture, the footer reads:
+ *   "Enter to set as default · s to use this session only · Esc to cancel"
+ *
+ * The overlay renders a ❯-marked numbered model list ("1. Default … 5. Haiku")
+ * under a "Select model" header that detectMultipleChoicePrompt() otherwise
+ * matches as a genuine multiple_choice prompt — which let Auto-Yes Enter-confirm
+ * a selection and silently change the user's default model. This "set as default"
+ * phrasing is unique to the model picker: genuine confirmation prompts never
+ * contain it (the trust dialog uses "Enter to confirm · Esc to cancel", Bash-tool
+ * approvals use "Esc to cancel · Tab to amend", AskUserQuestion uses
+ * "Enter to select · … to navigate"), so it is a safe exclusion signal.
+ *
+ * Linear pattern, no nested quantifiers — ReDoS safe (S4-001).
+ */
+exports.CLAUDE_MODEL_OVERLAY_FOOTER_PATTERN = /Enter\s+to\s+set\s+as\s+default\b/i;
+/**
+ * Claude CLI selection list footer pattern
+ * Detects Claude CLI's interactive selection prompts that require
+ * arrow key navigation and Enter to select/toggle.
+ *
+ * Matches footer instruction lines (known variants):
+ *   "Enter to select · Tab/Arrow keys to navigate · Esc to cancel"
+ *   "Enter to select · ↑/↓ to navigate · n to add notes · Esc to cancel"
+ *   "Enter to confirm · Esc to exit"  (legacy /model command footer)
+ *   "Enter to set as default · s to use this session only · Esc to cancel"
+ *     (/model command footer as of Claude Code v2.1.218 — Issue #1495)
+ *
+ *   "←/→ to adjust · Enter to confirm · s for this session only · Esc to cancel"
+ *     (/effort slider footer as of Claude Code v2.1.257 — Issue #3052; before
+ *      2.1.257 it was "Enter to confirm · Esc to cancel")
+ *
+ * The /effort branch keys on "Enter to confirm · s for this session only" rather
+ * than "←/→ to adjust": the `s` hint is unique to the pickers (the trust dialog's
+ * "Enter to confirm · Esc to cancel" and approval dialogs never carry it), and
+ * keeping the match under the `Enter to` prefix leaves the pattern a single
+ * linear alternation. Linear, no nested quantifiers — ReDoS safe.
+ *
+ * The "set as default" branch lets status-detector classify the `/model` overlay
+ * as a Claude selection list (NavigationButtons + ESC hatch, hasActivePrompt=false)
+ * once detectPrompt() no longer reports it as a prompt (see
+ * CLAUDE_MODEL_OVERLAY_FOOTER_PATTERN).
+ */
+exports.CLAUDE_SELECTION_LIST_FOOTER = /Enter\s+to\s+(?:select\s+.*to\s+navigate|confirm\s+·\s+(?:Esc|s\s+for\s+this\s+session\s+only)|set\s+as\s+default)/;
+/**
+ * Error patterns that indicate a Claude session failed to start properly
+ * Used by isSessionHealthy() to detect broken sessions (MF-001: SRP)
+ * Style: readonly + as const for type safety (SF-S2-001: follows response-poller.ts precedent)
+ *
+ * SEC-SF-004: Pattern maintenance process:
+ * - When Claude CLI is updated, verify that error messages still match these patterns.
+ * - Test procedure: Intentionally trigger each error condition (e.g., nested session launch)
+ *   and confirm the error message is captured by the patterns.
+ * - If Claude CLI introduces localized error messages, add locale-aware patterns or
+ *   consider switching to exit code-based detection as a more robust alternative.
+ * - Pattern additions should be accompanied by corresponding test cases in
+ *   claude-session.test.ts.
+ *
+ * C-S3-001: Codex/Gemini monitoring note:
+ * These patterns are currently Claude-specific. If Codex or Gemini exhibit similar
+ * "nested session" or startup failure behaviors, analogous error patterns should be
+ * added to their respective tool configurations (codex.ts, gemini.ts) rather than
+ * extending these arrays, to maintain SRP per CLI tool type.
+ */
+exports.CLAUDE_SESSION_ERROR_PATTERNS = [
+    'Claude Code cannot be launched inside another Claude Code session',
+];
+/**
+ * Regex patterns for Claude session errors requiring context matching
+ * Used by isSessionHealthy() for multi-condition error detection (MF-001: SRP)
+ * Style: readonly + as const for type safety (SF-S2-001: follows response-poller.ts precedent)
+ *
+ * SEC-SF-004: See CLAUDE_SESSION_ERROR_PATTERNS JSDoc for pattern maintenance process.
+ */
+exports.CLAUDE_SESSION_ERROR_REGEX_PATTERNS = [
+    /^Error:.*Claude Code/,
+];

package/dist/server/src/lib/detection/tools/claude/prompt.js

@@ -63,6 +63,7 @@ exports.detectClaudeDialog = detectClaudeDialog;
 const cli_patterns_1 = require("../../cli-patterns");
 const prompt_detect_multiple_choice_1 = require("../../prompt-detect-multiple-choice");
 const dialog_block_1 = require("../dialog-block");
+const context_above_1 = require("../context-above");
 const picker_chrome_1 = require("./picker-chrome");
 /**
  * Claude's dialog footers, in every spelling measured.
@@ -78,8 +79,6 @@ const picker_chrome_1 = require("./picker-chrome");
 const CLAUDE_DIALOG_FOOTER_PATTERN = /esc\s+to\s+cancel|enter\s+to\s+(?:select|confirm|set\s+as\s+default)/i;
 /** The selection cursor Claude puts on the highlighted option. */
 const CLAUDE_SELECTION_GLYPHS = new Set(['❯', '>']);
-/** How many non-blank rows above the options may hold the question. */
-const QUESTION_SCAN_ROWS = 4;
 /** The permission dialog's question, in the spellings 2.1.x draws. */
 const CLAUDE_PERMISSION_QUESTION_PATTERN = /do you want to\b|allow\b.*\?$/i;
 /** The AskUserQuestion review screen's closing question. */
@@ -94,14 +93,7 @@ const CLAUDE_PICKER_FOOTER_PATTERN = /set\s+as\s+default/i;
  */
 function readContextAbove(lines, firstRow) {
     const tabRow = (0, picker_chrome_1.findAskUserQuestionTabRow)(lines, firstRow, prompt_detect_multiple_choice_1.APPROVAL_TARGET_MAX_LOOKBACK);
-    const rows = [];
-    for (let i = firstRow - 1; i > tabRow && rows.length < QUESTION_SCAN_ROWS; i--) {
-        const row = lines[i].trim();
-        if (row === '')
-            continue;
-        rows.push(row);
-    }
-    return rows.join('\n');
+    return (0, context_above_1.readContextAbove)(lines, firstRow, tabRow);
 }
 /**
  * The non-blank rows in [from, end) — the block's footer — without Claude's

package/dist/server/src/lib/detection/tools/codex/cli-patterns.js

@@ -316,7 +316,7 @@ function readCodexGlyphRowKind(rawRow) {
  * Find and classify the bottom-most `›` row of a raw capture.
  *
  * "Bottom-most" is the whole point, and it is the same rule `isCodexPromptReady`
- * and `codexActiveRegionLines` already apply for their own questions: codex
+ * and `findCodexComposerRow` already apply for their own questions: codex
  * draws on the normal screen, so a dialog the operator answered minutes ago is
  * still in the frame with its options intact (Issue #1160). Only the LAST `›`
  * row says what the pane is doing now — and when a turn is generating, that row