commandmate 0.29.1 → 0.29.2

package/dist/server/src/lib/updates/codex-version.js

@@ -0,0 +1,215 @@
+"use strict";
+/**
+ * `~/.codex/version.json` — what codex itself already knows about its updates
+ * (Issue #2069).
+ *
+ * ## Why a file rather than a request
+ *
+ * codex runs its own release check and writes the answer next to its config:
+ *
+ * ```json
+ * {"latest_version":"0.151.0","last_checked_at":"2026-08-30T15:12:18.082219Z","dismissed_version":null}
+ * ```
+ *
+ * So "is there a newer codex?" is answerable with a `readFileSync` and no
+ * network at all. That is the whole reason this module exists rather than a
+ * registry query: `GET /api/agents/versions` is rendered on a settings screen
+ * and inside the agent pane, and #1913's rule — do not put a network round trip
+ * on a surface that renders a list — applies to a fetch exactly as it applies to
+ * a child process. The trade is that the answer is only as fresh as the last
+ * time codex itself looked, which is the correct freshness: it is codex's own
+ * notion of "you are behind", the same one its TUI banner uses.
+ *
+ * ## Fail-open, in every direction
+ *
+ * The file is written by another program, on its own schedule, in a format it
+ * owns. It is legitimately **absent** (a fresh install, a codex that has never
+ * run), legitimately **null-valued** (`dismissed_version` is null until the user
+ * dismisses a banner), and it can be a half-written temp file caught mid-rename.
+ * None of those is an error here: every failure resolves to
+ * {@link EMPTY_CODEX_VERSION_FILE} and the caller reports "no update known",
+ * which is exactly what the surfaces render when codex is not installed either.
+ * The acceptance criterion for this Issue names that behaviour directly —
+ * 「`version.json` が無い / 壊れている環境で落ちない」— and
+ * `tests/unit/updates/codex-version-2069.test.ts` pins it case by case.
+ *
+ * ## `$CODEX_HOME`: why it is resolved here, and where the two rules diverge
+ *
+ * `lib/hooks/sources/codex/hooks-config.getCodexHome()` answers the same
+ * question, and this module cannot call it: that function reaches `@/lib/logger`
+ * through `config/safe-directory`, and `tsconfig.cli.json` resets `"paths"` to
+ * `{}` — so one alias import anywhere in this module's transitive closure breaks
+ * `npm run build:cli` with TS2307 (the #1933 defect PR #1991 fixed), and
+ * `commandmate agents update` puts this file in the CLI's closure. The variable
+ * NAME therefore exists in two files, and
+ * `tests/unit/updates/codex-home-parity-2069.test.ts` is the join: it imports
+ * both and fails if the spellings or the shared rules ever drift.
+ *
+ * The rules are deliberately identical except for one case, and that case is a
+ * correctness fix rather than a divergence for its own sake:
+ *
+ * | `$CODEX_HOME`            | hooks-config                        | here                |
+ * |--------------------------|-------------------------------------|---------------------|
+ * | unset                    | `~/.codex`                          | `~/.codex`          |
+ * | absolute                 | that path                           | that path           |
+ * | inside `/proc`/`/sys`/`/dev` | `~/.codex` (#1774)              | `~/.codex`          |
+ * | **relative**             | passed through **verbatim**         | **null = unknown**  |
+ *
+ * `resolveSafeDirectory` returns a relative candidate unchanged, and
+ * `hooks-config` puts that value on codex's own launch line — so codex resolves
+ * it against **the agent's worktree cwd**, and `CODEX_HOME=.codex-shared` means
+ * codex writes `<worktree>/.codex-shared/version.json`. This process is not in
+ * that worktree and, with several worktrees open, cannot say which one was
+ * meant. Falling back to `~/.codex` there is the one genuinely bad answer: it
+ * is not "no data", it is an unrelated install's version, reported with the
+ * same confidence as a real reading. So a relative value resolves to null and
+ * every surface renders "no update information", which is what they already
+ * render when codex has never run.
+ *
+ * @module lib/updates/codex-version
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EMPTY_CODEX_VERSION_FILE = exports.CODEX_VERSION_FILE_MAX_BYTES = exports.CODEX_VERSION_FILENAME = void 0;
+exports.getCodexHomeForVersionRead = getCodexHomeForVersionRead;
+exports.getCodexVersionFilePath = getCodexVersionFilePath;
+exports.readCodexVersionFile = readCodexVersionFile;
+exports.evaluateCodexUpdate = evaluateCodexUpdate;
+const fs_1 = require("fs");
+const os_1 = require("os");
+const path_1 = require("path");
+const system_directories_1 = require("../../config/system-directories");
+const version_probes_1 = require("../detection/version-probes");
+/**
+ * codex's own config-directory override.
+ *
+ * NOT exported: `lib/hooks/sources/codex/hooks-config` already exports this name
+ * and that one is the repository's single public spelling. A second exported
+ * `CODEX_HOME_ENV_VAR` is how two modules end up disagreeing about it, and the
+ * `@/`-import rule above is the only reason the literal exists twice at all.
+ * `tests/unit/updates/codex-home-parity-2069.test.ts` pins the two together.
+ */
+const CODEX_HOME_ENV_VAR = 'CODEX_HOME';
+/** The file codex writes its release check into, inside `$CODEX_HOME`. */
+exports.CODEX_VERSION_FILENAME = 'version.json';
+/**
+ * Largest `version.json` this module will parse.
+ *
+ * Three short fields; anything past this is not the file we mean. A cap rather
+ * than trust because the read happens on a request path and the file is written
+ * by another process — an oversized file is discarded, not truncated and parsed.
+ */
+exports.CODEX_VERSION_FILE_MAX_BYTES = 64 * 1024;
+/** The answer for every failure: "codex has told us nothing". */
+exports.EMPTY_CODEX_VERSION_FILE = {
+    latestVersion: null,
+    dismissedVersion: null,
+    lastCheckedAt: null,
+    readable: false,
+};
+/**
+ * The directory codex keeps its state in, as seen from THIS process.
+ *
+ * See the table in the module header for the four cases. The one that returns
+ * null is a relative `$CODEX_HOME`: `hooks-config` forwards such a value to
+ * codex verbatim, codex resolves it against the agent's worktree cwd, and this
+ * process has no worktree — so the honest answer is "cannot tell", not
+ * `~/.codex`.
+ *
+ * @param env - Environment to read. Injectable so tests need no `process.env`
+ *   mutation.
+ * @returns An absolute directory path, or null when it cannot be determined.
+ */
+function getCodexHomeForVersionRead(env = process.env) {
+    const fallback = (0, path_1.join)((0, os_1.homedir)(), '.codex');
+    const configured = env[CODEX_HOME_ENV_VAR];
+    if (!configured)
+        return fallback;
+    // Matches `resolveSafeDirectory`: a /proc, /sys or /dev path is refused and
+    // the built-in default is used, on both sides of the join.
+    if ((0, system_directories_1.isVirtualFilesystemPath)(configured))
+        return fallback;
+    if (!(0, path_1.isAbsolute)(configured))
+        return null;
+    return configured;
+}
+/**
+ * Absolute path of the file codex writes its release check into, or null when
+ * {@link getCodexHomeForVersionRead} cannot determine the directory.
+ */
+function getCodexVersionFilePath(env = process.env) {
+    const home = getCodexHomeForVersionRead(env);
+    return home === null ? null : (0, path_1.join)(home, exports.CODEX_VERSION_FILENAME);
+}
+/** Read one field as a normalized version, tolerating null / wrong types. */
+function readVersionField(raw, key) {
+    const value = raw[key];
+    if (typeof value !== 'string')
+        return null;
+    return (0, version_probes_1.parseCliVersion)(value);
+}
+/**
+ * Read `$CODEX_HOME/version.json`.
+ *
+ * Never throws and never rejects: see the module header. A file that parses but
+ * carries junk in a field yields null for **that field only**, so a codex build
+ * that adds or renames a key still gives up whatever the rest of it says.
+ *
+ * @param options.path - Read this file instead of the resolved default (tests,
+ *   and an isolated-HOME verification run).
+ * @param options.env - Environment used to resolve the default path.
+ */
+function readCodexVersionFile(options = {}) {
+    const path = options.path ?? getCodexVersionFilePath(options.env);
+    const empty = { ...exports.EMPTY_CODEX_VERSION_FILE, path };
+    // Unknown directory (a relative `$CODEX_HOME`): read nothing rather than read
+    // the wrong install's file. See the table in the module header.
+    if (path === null)
+        return empty;
+    try {
+        const stat = (0, fs_1.statSync)(path);
+        if (!stat.isFile())
+            return empty;
+        if (stat.size > exports.CODEX_VERSION_FILE_MAX_BYTES)
+            return empty;
+        const parsed = JSON.parse((0, fs_1.readFileSync)(path, 'utf-8'));
+        if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed))
+            return empty;
+        const raw = parsed;
+        return {
+            latestVersion: readVersionField(raw, 'latest_version'),
+            dismissedVersion: readVersionField(raw, 'dismissed_version'),
+            lastCheckedAt: typeof raw.last_checked_at === 'string' ? raw.last_checked_at : null,
+            path,
+            readable: true,
+        };
+    }
+    catch {
+        return empty;
+    }
+}
+/**
+ * Combine the installed version with codex's own release check.
+ *
+ * Both halves are "no answer"-tolerant, and every kind of no-answer resolves to
+ * `updateAvailable: false` — not installed, never checked, unparseable. That is
+ * the same posture `DetectorFreshnessRow.stale` takes, and for the same reason:
+ * an update prompt the user cannot act on is worse than no prompt.
+ *
+ * @param installed - Output of the `codex --version` probe, or null.
+ * @param file - What {@link readCodexVersionFile} recovered.
+ */
+function evaluateCodexUpdate(installed, file) {
+    const updateAvailable = installed !== null &&
+        file.latestVersion !== null &&
+        (0, version_probes_1.compareCliVersions)(file.latestVersion, installed) > 0;
+    return {
+        installed,
+        latestVersion: file.latestVersion,
+        dismissedVersion: file.dismissedVersion,
+        updateAvailable,
+        dismissedInCodex: updateAvailable &&
+            file.dismissedVersion !== null &&
+            file.dismissedVersion === file.latestVersion,
+        source: file.readable ? 'version.json' : null,
+    };
+}

package/dist/server/src/lib/updates/index.js

@@ -0,0 +1,42 @@
+"use strict";
+/**
+ * Agent CLI update flow (Issue #2069).
+ *
+ * `codex.ts` is deliberately untouched by this feature: reading
+ * `~/.codex/version.json` and running `codex update` are neither session
+ * lifecycle nor screen scraping, and putting them in the tool class would put a
+ * child-process spawner inside the module every pane's `startSession` goes
+ * through.
+ *
+ * @module lib/updates
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.clearAgentVersionsCache = exports.getAgentVersions = exports.AGENT_VERSIONS_CACHE_TTL_MS = exports.isAgentUpdateInProgress = exports.releaseAgentUpdateLock = exports.acquireAgentUpdateLock = exports.runAgentUpdate = exports.resolveAgentUpdatePlan = exports.isUpdatableAgentTool = exports.AGENT_UPDATE_MAX_BUFFER_BYTES = exports.AGENT_UPDATE_TIMEOUT_MS = exports.CODEX_NATIVE_UPDATE_MIN_VERSION = exports.CODEX_NPM_PACKAGE = exports.UPDATABLE_AGENT_TOOLS = exports.evaluateCodexUpdate = exports.readCodexVersionFile = exports.getCodexVersionFilePath = exports.getCodexHomeForVersionRead = exports.EMPTY_CODEX_VERSION_FILE = exports.CODEX_VERSION_FILE_MAX_BYTES = exports.CODEX_VERSION_FILENAME = void 0;
+var codex_version_1 = require("./codex-version");
+// `CODEX_HOME_ENV_VAR` is deliberately NOT re-exported here: the repository's
+// single public spelling of that name lives in
+// `lib/hooks/sources/codex/hooks-config`, and `codex-version` keeps a private
+// copy only because importing that module would break `build:cli`.
+Object.defineProperty(exports, "CODEX_VERSION_FILENAME", { enumerable: true, get: function () { return codex_version_1.CODEX_VERSION_FILENAME; } });
+Object.defineProperty(exports, "CODEX_VERSION_FILE_MAX_BYTES", { enumerable: true, get: function () { return codex_version_1.CODEX_VERSION_FILE_MAX_BYTES; } });
+Object.defineProperty(exports, "EMPTY_CODEX_VERSION_FILE", { enumerable: true, get: function () { return codex_version_1.EMPTY_CODEX_VERSION_FILE; } });
+Object.defineProperty(exports, "getCodexHomeForVersionRead", { enumerable: true, get: function () { return codex_version_1.getCodexHomeForVersionRead; } });
+Object.defineProperty(exports, "getCodexVersionFilePath", { enumerable: true, get: function () { return codex_version_1.getCodexVersionFilePath; } });
+Object.defineProperty(exports, "readCodexVersionFile", { enumerable: true, get: function () { return codex_version_1.readCodexVersionFile; } });
+Object.defineProperty(exports, "evaluateCodexUpdate", { enumerable: true, get: function () { return codex_version_1.evaluateCodexUpdate; } });
+var agent_updater_1 = require("./agent-updater");
+Object.defineProperty(exports, "UPDATABLE_AGENT_TOOLS", { enumerable: true, get: function () { return agent_updater_1.UPDATABLE_AGENT_TOOLS; } });
+Object.defineProperty(exports, "CODEX_NPM_PACKAGE", { enumerable: true, get: function () { return agent_updater_1.CODEX_NPM_PACKAGE; } });
+Object.defineProperty(exports, "CODEX_NATIVE_UPDATE_MIN_VERSION", { enumerable: true, get: function () { return agent_updater_1.CODEX_NATIVE_UPDATE_MIN_VERSION; } });
+Object.defineProperty(exports, "AGENT_UPDATE_TIMEOUT_MS", { enumerable: true, get: function () { return agent_updater_1.AGENT_UPDATE_TIMEOUT_MS; } });
+Object.defineProperty(exports, "AGENT_UPDATE_MAX_BUFFER_BYTES", { enumerable: true, get: function () { return agent_updater_1.AGENT_UPDATE_MAX_BUFFER_BYTES; } });
+Object.defineProperty(exports, "isUpdatableAgentTool", { enumerable: true, get: function () { return agent_updater_1.isUpdatableAgentTool; } });
+Object.defineProperty(exports, "resolveAgentUpdatePlan", { enumerable: true, get: function () { return agent_updater_1.resolveAgentUpdatePlan; } });
+Object.defineProperty(exports, "runAgentUpdate", { enumerable: true, get: function () { return agent_updater_1.runAgentUpdate; } });
+Object.defineProperty(exports, "acquireAgentUpdateLock", { enumerable: true, get: function () { return agent_updater_1.acquireAgentUpdateLock; } });
+Object.defineProperty(exports, "releaseAgentUpdateLock", { enumerable: true, get: function () { return agent_updater_1.releaseAgentUpdateLock; } });
+Object.defineProperty(exports, "isAgentUpdateInProgress", { enumerable: true, get: function () { return agent_updater_1.isAgentUpdateInProgress; } });
+var agent_versions_1 = require("./agent-versions");
+Object.defineProperty(exports, "AGENT_VERSIONS_CACHE_TTL_MS", { enumerable: true, get: function () { return agent_versions_1.AGENT_VERSIONS_CACHE_TTL_MS; } });
+Object.defineProperty(exports, "getAgentVersions", { enumerable: true, get: function () { return agent_versions_1.getAgentVersions; } });
+Object.defineProperty(exports, "clearAgentVersionsCache", { enumerable: true, get: function () { return agent_versions_1.clearAgentVersionsCache; } });