commandmate 0.11.4 → 0.12.1

package/dist/server/src/lib/db/migrations/index.js

@@ -27,6 +27,10 @@ const v40_timer_error_1 = require("./v40-timer-error");
 const v41_push_subscriptions_1 = require("./v41-push-subscriptions");
 const v42_push_subscription_locale_1 = require("./v42-push-subscription-locale");
 const v43_remove_cm_root_dir_ghost_repository_1 = require("./v43-remove-cm-root-dir-ghost-repository");
+const v44_skill_operations_1 = require("./v44-skill-operations");
+const v45_skill_installations_1 = require("./v45-skill-installations");
+const v46_skill_installations_cascade_1 = require("./v46-skill-installations-cascade");
+const v47_skill_installations_roots_1 = require("./v47-skill-installations-roots");
 /**
  * Complete ordered list of all migrations.
  * Used internally by the barrel file (db-migrations.ts); NOT exported from the barrel (DR2-004).
@@ -57,4 +61,8 @@ exports.migrations = [
     ...v41_push_subscriptions_1.v41_migrations,
     ...v42_push_subscription_locale_1.v42_migrations,
     ...v43_remove_cm_root_dir_ghost_repository_1.v43_migrations,
+    ...v44_skill_operations_1.v44_migrations,
+    ...v45_skill_installations_1.v45_migrations,
+    ...v46_skill_installations_cascade_1.v46_migrations,
+    ...v47_skill_installations_roots_1.v47_migrations,
 ];

package/dist/server/src/lib/db/migrations/runner.js

@@ -17,7 +17,7 @@ const path_1 = __importDefault(require("path"));
  * Current schema version
  * Increment this when adding new migrations
  */
-exports.CURRENT_SCHEMA_VERSION = 43;
+exports.CURRENT_SCHEMA_VERSION = 47;
 /**
  * Get current schema version from database
  */

package/dist/server/src/lib/db/migrations/v44-skill-operations.js

@@ -0,0 +1,81 @@
+"use strict";
+/**
+ * Migration v44: append-only skill_operations audit log (Issue #1234).
+ *
+ * One row per audit event, not per operation: a single operationId appends a row
+ * when it fails and another when reconciliation converges it, so the sequence of
+ * events survives instead of being overwritten. Append-only is enforced in the
+ * database by BEFORE UPDATE/DELETE triggers rather than by convention, so a bug
+ * or a direct sqlite3 session cannot silently rewrite history.
+ *
+ * Source coordinates (repository/ref/resolved commit/artifact digest) are stored
+ * as separate columns so an install can be traced back to an immutable source
+ * without parsing a blob. No column holds a URL, token or machine-absolute path.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.v44_migrations = void 0;
+exports.v44_migrations = [
+    {
+        version: 44,
+        name: 'add-skill-operations',
+        up: (db) => {
+            db.exec(`
+        CREATE TABLE IF NOT EXISTS skill_operations (
+          id TEXT PRIMARY KEY,
+          operation_id TEXT NOT NULL,
+          idempotency_key TEXT NOT NULL,
+          binding_hash TEXT NOT NULL,
+          operation TEXT NOT NULL,
+          state TEXT NOT NULL,
+          result TEXT NOT NULL,
+          actor_type TEXT NOT NULL,
+          actor_id TEXT,
+          worktree_id TEXT NOT NULL,
+          skill_id TEXT NOT NULL,
+          skill_version TEXT,
+          source_origin TEXT,
+          source_repository TEXT,
+          source_ref TEXT,
+          source_commit TEXT,
+          artifact_sha256 TEXT,
+          error_code TEXT,
+          error_message TEXT,
+          recorded_at INTEGER NOT NULL
+        );
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_operations_operation_id
+          ON skill_operations(operation_id);
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_operations_idempotency_key
+          ON skill_operations(idempotency_key);
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_operations_target
+          ON skill_operations(worktree_id, skill_id, recorded_at);
+      `);
+            db.exec(`
+        CREATE TRIGGER IF NOT EXISTS skill_operations_no_update
+        BEFORE UPDATE ON skill_operations
+        BEGIN
+          SELECT RAISE(ABORT, 'skill_operations is append-only');
+        END;
+      `);
+            db.exec(`
+        CREATE TRIGGER IF NOT EXISTS skill_operations_no_delete
+        BEFORE DELETE ON skill_operations
+        BEGIN
+          SELECT RAISE(ABORT, 'skill_operations is append-only');
+        END;
+      `);
+        },
+        down: (db) => {
+            // Triggers first: the delete guard would otherwise be the only thing
+            // standing between a rollback and an ABORT on any later cleanup.
+            db.exec('DROP TRIGGER IF EXISTS skill_operations_no_delete;');
+            db.exec('DROP TRIGGER IF EXISTS skill_operations_no_update;');
+            db.exec('DROP TABLE IF EXISTS skill_operations;');
+        },
+    },
+];

package/dist/server/src/lib/db/migrations/v45-skill-installations.js

@@ -0,0 +1,59 @@
+"use strict";
+/**
+ * Migration v45: `skill_installations` index (Issue #1235).
+ *
+ * One row per (worktree, skill): the index answers "what is installed here"
+ * without walking every worktree on disk. It is an *index*, not the truth — the
+ * receipt inside `.agents/skills/<id>/` is. That ordering is what lets a crash
+ * between the atomic rename and this row be reconciled forward (#1234) instead
+ * of being reported as a rollback that the filesystem contradicts.
+ *
+ * `receipt_sha256` is the join back to the payload: reconciliation compares it
+ * against the receipt actually on disk, so a row that describes a different
+ * install than the one present is detectable rather than merely stale.
+ *
+ * No column holds a URL, a token or a machine-absolute path; `install_root` is
+ * repository-relative by construction.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.v45_migrations = void 0;
+exports.v45_migrations = [
+    {
+        version: 45,
+        name: 'add-skill-installations',
+        up: (db) => {
+            db.exec(`
+        CREATE TABLE IF NOT EXISTS skill_installations (
+          id TEXT PRIMARY KEY,
+          worktree_id TEXT NOT NULL,
+          skill_id TEXT NOT NULL,
+          version TEXT NOT NULL,
+          install_root TEXT NOT NULL,
+          receipt_sha256 TEXT NOT NULL,
+          source_repository TEXT NOT NULL,
+          source_ref TEXT NOT NULL,
+          source_commit TEXT NOT NULL,
+          artifact_sha256 TEXT NOT NULL,
+          effective_risk TEXT NOT NULL,
+          operation_id TEXT NOT NULL,
+          installed_at INTEGER NOT NULL,
+          updated_at INTEGER NOT NULL,
+          UNIQUE (worktree_id, skill_id)
+        );
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_installations_worktree
+          ON skill_installations(worktree_id);
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_installations_skill
+          ON skill_installations(skill_id, version);
+      `);
+        },
+        down: (db) => {
+            db.exec('DROP INDEX IF EXISTS idx_skill_installations_skill;');
+            db.exec('DROP INDEX IF EXISTS idx_skill_installations_worktree;');
+            db.exec('DROP TABLE IF EXISTS skill_installations;');
+        },
+    },
+];

package/dist/server/src/lib/db/migrations/v46-skill-installations-cascade.js

@@ -0,0 +1,107 @@
+"use strict";
+/**
+ * Migration v46: `skill_installations` follows the worktree it belongs to (Issue #1430).
+ *
+ * v45 created the table with `worktree_id TEXT NOT NULL` and no foreign key, so
+ * deleting a worktree left its install rows behind forever (`UNIQUE(worktree_id,
+ * skill_id)` keeps them). Recreating a worktree at the same path mints a new
+ * UUID, so the UI reports "not installed" while the payload and receipt are
+ * still on disk: re-install fails with SKILL_INSTALL_DESTINATION_EXISTS and
+ * uninstall has no record to act on.
+ *
+ * The fix follows the convention every other worktree-scoped table already uses
+ * — `ON DELETE CASCADE` — rather than an explicit DELETE at one call site. Two
+ * reasons beyond consistency: `deleteWorktreesByIds` is not the only path that
+ * removes a worktree row, and `migrateWorktreeIdPreservingChildren` (#1151)
+ * discovers child tables through `PRAGMA foreign_key_list`, so the constraint is
+ * also what makes a same-directory branch switch *carry* installs forward
+ * instead of orphaning them.
+ *
+ * SQLite cannot add a constraint in place, so the table is rebuilt (same pattern
+ * as v33). Rows whose worktree is already gone are dropped by the copy filter,
+ * which is what clears the dangling rows existing databases have accumulated —
+ * `PRAGMA foreign_keys` cannot be toggled inside the migration transaction, so
+ * the filter must be in the SELECT rather than deferred to the constraint.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.v46_migrations = void 0;
+const COLUMNS = `
+  id, worktree_id, skill_id, version, install_root, receipt_sha256,
+  source_repository, source_ref, source_commit, artifact_sha256,
+  effective_risk, operation_id, installed_at, updated_at
+`;
+const COLUMN_DEFINITIONS = `
+  id TEXT PRIMARY KEY,
+  worktree_id TEXT NOT NULL,
+  skill_id TEXT NOT NULL,
+  version TEXT NOT NULL,
+  install_root TEXT NOT NULL,
+  receipt_sha256 TEXT NOT NULL,
+  source_repository TEXT NOT NULL,
+  source_ref TEXT NOT NULL,
+  source_commit TEXT NOT NULL,
+  artifact_sha256 TEXT NOT NULL,
+  effective_risk TEXT NOT NULL,
+  operation_id TEXT NOT NULL,
+  installed_at INTEGER NOT NULL,
+  updated_at INTEGER NOT NULL,
+  UNIQUE (worktree_id, skill_id)
+`;
+function createIndexes(db) {
+    db.exec(`
+    CREATE INDEX IF NOT EXISTS idx_skill_installations_worktree
+      ON skill_installations(worktree_id);
+  `);
+    db.exec(`
+    CREATE INDEX IF NOT EXISTS idx_skill_installations_skill
+      ON skill_installations(skill_id, version);
+  `);
+}
+exports.v46_migrations = [
+    {
+        version: 46,
+        name: 'skill-installations-worktree-cascade',
+        up: (db) => {
+            db.exec(`
+        CREATE TABLE skill_installations_new (
+          ${COLUMN_DEFINITIONS},
+          FOREIGN KEY (worktree_id) REFERENCES worktrees(id) ON DELETE CASCADE
+        );
+      `);
+            // The WHERE clause is the dangling-row sweep: rows pointing at a worktree
+            // that no longer exists are not carried over.
+            db.exec(`
+        INSERT INTO skill_installations_new (${COLUMNS})
+        SELECT ${COLUMNS} FROM skill_installations
+        WHERE worktree_id IN (SELECT id FROM worktrees);
+      `);
+            const dangling = db
+                .prepare(`SELECT COUNT(*) AS n FROM skill_installations
+           WHERE worktree_id NOT IN (SELECT id FROM worktrees)`)
+                .get();
+            // Dropping the table drops its indexes too; recreate them on the new one.
+            db.exec('DROP TABLE skill_installations;');
+            db.exec('ALTER TABLE skill_installations_new RENAME TO skill_installations;');
+            createIndexes(db);
+            if (dangling.n > 0) {
+                console.log(`Removed ${dangling.n} skill_installations row(s) with no worktree`);
+            }
+            console.log('skill_installations now cascades with its worktree');
+        },
+        down: (db) => {
+            db.exec(`
+        CREATE TABLE skill_installations_old (
+          ${COLUMN_DEFINITIONS}
+        );
+      `);
+            db.exec(`
+        INSERT INTO skill_installations_old (${COLUMNS})
+        SELECT ${COLUMNS} FROM skill_installations;
+      `);
+            db.exec('DROP TABLE skill_installations;');
+            db.exec('ALTER TABLE skill_installations_old RENAME TO skill_installations;');
+            createIndexes(db);
+            console.log('Rolled back skill_installations cascade (v46)');
+        },
+    },
+];

package/dist/server/src/lib/db/migrations/v47-skill-installations-roots.js

@@ -0,0 +1,70 @@
+"use strict";
+/**
+ * Migration v47: `skill_installations.install_roots` (Issue #1460).
+ *
+ * A package is now placed into more than one discovery root — `.agents/skills`
+ * (Codex) and `.claude/skills` (Claude) — so the index needs to record the full
+ * set, not just the primary `install_root`. The column is a JSON array of
+ * repository-relative roots, primary first.
+ *
+ * Nullable and added by `ALTER TABLE`, so it is backward compatible: rows written
+ * before this migration keep `install_root` and read back as the single root they
+ * name. The on-disk receipt remains the source of truth; this column, like the
+ * rest of the row, is a rebuildable index over it (#1235).
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.v47_migrations = void 0;
+exports.v47_migrations = [
+    {
+        version: 47,
+        name: 'add-skill-installations-roots',
+        up: (db) => {
+            db.exec('ALTER TABLE skill_installations ADD COLUMN install_roots TEXT;');
+        },
+        down: (db) => {
+            // SQLite < 3.35 cannot DROP COLUMN; rebuild the table without it. The
+            // column is nullable and index-only, so no data of record is lost.
+            db.exec(`
+        CREATE TABLE skill_installations__v46 (
+          id TEXT PRIMARY KEY,
+          worktree_id TEXT NOT NULL,
+          skill_id TEXT NOT NULL,
+          version TEXT NOT NULL,
+          install_root TEXT NOT NULL,
+          receipt_sha256 TEXT NOT NULL,
+          source_repository TEXT NOT NULL,
+          source_ref TEXT NOT NULL,
+          source_commit TEXT NOT NULL,
+          artifact_sha256 TEXT NOT NULL,
+          effective_risk TEXT NOT NULL,
+          operation_id TEXT NOT NULL,
+          installed_at INTEGER NOT NULL,
+          updated_at INTEGER NOT NULL,
+          UNIQUE (worktree_id, skill_id)
+        );
+      `);
+            db.exec(`
+        INSERT INTO skill_installations__v46 (
+          id, worktree_id, skill_id, version, install_root, receipt_sha256,
+          source_repository, source_ref, source_commit, artifact_sha256,
+          effective_risk, operation_id, installed_at, updated_at
+        )
+        SELECT
+          id, worktree_id, skill_id, version, install_root, receipt_sha256,
+          source_repository, source_ref, source_commit, artifact_sha256,
+          effective_risk, operation_id, installed_at, updated_at
+        FROM skill_installations;
+      `);
+            db.exec('DROP TABLE skill_installations;');
+            db.exec('ALTER TABLE skill_installations__v46 RENAME TO skill_installations;');
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_installations_worktree
+          ON skill_installations(worktree_id);
+      `);
+            db.exec(`
+        CREATE INDEX IF NOT EXISTS idx_skill_installations_skill
+          ON skill_installations(skill_id, version);
+      `);
+        },
+    },
+];

package/dist/server/src/lib/db/worktree-db.js

@@ -523,8 +523,11 @@ function getWorktreesByRepository(db, repositoryPath) {
 }
 /**
  * Delete all worktrees for a given repository path
- * Related data (chat_messages, session_states, worktree_memos, worktree_todos)
- * will be automatically deleted via CASCADE foreign key constraints.
+ * Related data is automatically deleted via ON DELETE CASCADE in every table
+ * holding a foreign key to worktrees(id) — chat_messages, session_states,
+ * worktree_memos, worktree_todos, agent_instances, scheduled_executions,
+ * execution_logs, timer_messages and skill_installations (#1430). The live list
+ * is whatever `PRAGMA foreign_key_list` reports; see getWorktreeChildTables.
  *
  * @param db - Database instance
  * @param repositoryPath - Path of the repository to delete
@@ -539,8 +542,10 @@ function deleteRepositoryWorktrees(db, repositoryPath) {
 }
 /**
  * Delete worktrees by their IDs
- * Related data (chat_messages, session_states, worktree_memos, worktree_todos)
- * will be automatically deleted via CASCADE foreign key constraints.
+ * Related data is automatically deleted via ON DELETE CASCADE in every table
+ * holding a foreign key to worktrees(id) — including skill_installations, whose
+ * rows used to survive the worktree and make a re-created worktree at the same
+ * path un-installable (#1430). See getWorktreeChildTables for the live list.
  *
  * @param db - Database instance
  * @param worktreeIds - Array of worktree IDs to delete