commandmate 0.1.10 → 0.1.11

package/dist/cli/utils/port-allocator.js

@@ -0,0 +1,166 @@
+"use strict";
+/**
+ * Port Allocator
+ * Issue #136: Phase 1 - Foundation
+ *
+ * Provides automatic port allocation for worktree servers.
+ * SF-SEC-002: Implements MAX_WORKTREES limit to prevent port exhaustion attacks.
+ *
+ * @module port-allocator
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PortAllocator = exports.MAX_WORKTREES = exports.DEFAULT_PORT_RANGE = void 0;
+exports.createPortAllocator = createPortAllocator;
+const net_1 = require("net");
+const errors_1 = require("../../lib/errors");
+/**
+ * Default port range for worktree servers
+ * Main server uses 3000, worktrees use 3001-3100
+ */
+exports.DEFAULT_PORT_RANGE = {
+    min: 3001,
+    max: 3100,
+};
+/**
+ * Maximum number of concurrent worktree servers
+ * SF-SEC-002: Prevents port exhaustion attacks
+ */
+exports.MAX_WORKTREES = 10;
+/**
+ * Port allocator for managing worktree server ports
+ *
+ * @example
+ * ```typescript
+ * const allocator = new PortAllocator();
+ * const port = await allocator.findAvailablePort();
+ * allocator.markAllocated(port);
+ * // ... start server on port ...
+ * allocator.release(port);
+ * ```
+ */
+class PortAllocator {
+    static instance = null;
+    range;
+    allocatedPorts;
+    issuePortMap;
+    constructor(range = exports.DEFAULT_PORT_RANGE) {
+        this.range = range;
+        this.allocatedPorts = new Set();
+        this.issuePortMap = new Map();
+    }
+    /**
+     * Get singleton instance
+     * Issue #136: Singleton pattern for CLI commands
+     */
+    static getInstance() {
+        if (!PortAllocator.instance) {
+            PortAllocator.instance = new PortAllocator();
+        }
+        return PortAllocator.instance;
+    }
+    /**
+     * Allocate a port for a specific issue (synchronous, deterministic)
+     * Issue #136: Simple port allocation based on issue number
+     *
+     * @param issueNo - Issue number
+     * @returns Allocated port number
+     */
+    allocate(issueNo) {
+        // Check if already allocated for this issue
+        const existing = this.issuePortMap.get(issueNo);
+        if (existing !== undefined) {
+            return existing;
+        }
+        // Deterministic port based on issue number (3001 + issueNo % 100)
+        const basePort = this.range.min + (issueNo % (this.range.max - this.range.min));
+        this.issuePortMap.set(issueNo, basePort);
+        this.allocatedPorts.add(basePort);
+        return basePort;
+    }
+    /**
+     * Find an available port in the configured range
+     *
+     * @returns Available port number
+     * @throws AppError with code PORT_EXHAUSTED if no ports available
+     * @throws AppError with code MAX_WORKTREES_EXCEEDED if limit reached
+     */
+    async findAvailablePort() {
+        // Check MAX_WORKTREES limit
+        if (this.allocatedPorts.size >= exports.MAX_WORKTREES) {
+            throw new errors_1.AppError('MAX_WORKTREES_EXCEEDED', `Maximum number of worktrees (${exports.MAX_WORKTREES}) exceeded`, { currentCount: this.allocatedPorts.size, limit: exports.MAX_WORKTREES });
+        }
+        for (let port = this.range.min; port <= this.range.max; port++) {
+            // Skip already allocated ports
+            if (this.allocatedPorts.has(port)) {
+                continue;
+            }
+            if (await this.isPortAvailable(port)) {
+                return port;
+            }
+        }
+        throw new errors_1.AppError(errors_1.ErrorCode.PORT_EXHAUSTED, `No available ports in range ${this.range.min}-${this.range.max}`, { range: this.range, allocatedPorts: Array.from(this.allocatedPorts) });
+    }
+    /**
+     * Check if a specific port is available
+     *
+     * @param port - Port number to check
+     * @returns true if port is available
+     */
+    async isPortAvailable(port) {
+        return new Promise((resolve) => {
+            const server = (0, net_1.createServer)();
+            server.on('error', () => {
+                resolve(false);
+            });
+            server.listen(port, () => {
+                server.close(() => {
+                    resolve(true);
+                });
+            });
+        });
+    }
+    /**
+     * Mark a port as allocated
+     *
+     * @param port - Port number to mark as allocated
+     */
+    markAllocated(port) {
+        this.allocatedPorts.add(port);
+    }
+    /**
+     * Release an allocated port
+     *
+     * @param port - Port number to release
+     */
+    release(port) {
+        this.allocatedPorts.delete(port);
+    }
+    /**
+     * Get the count of allocated ports
+     */
+    getAllocatedCount() {
+        return this.allocatedPorts.size;
+    }
+    /**
+     * Check if a port is currently allocated (in-memory tracking)
+     *
+     * @param port - Port number to check
+     * @returns true if port is allocated
+     */
+    isAllocated(port) {
+        return this.allocatedPorts.has(port);
+    }
+    /**
+     * Get all allocated ports
+     */
+    getAllocatedPorts() {
+        return Array.from(this.allocatedPorts);
+    }
+}
+exports.PortAllocator = PortAllocator;
+/**
+ * Create a port allocator with default settings
+ */
+function createPortAllocator(range) {
+    return new PortAllocator(range);
+}

package/dist/cli/utils/resource-resolvers.d.ts

@@ -0,0 +1,92 @@
+/**
+ * Resource Path Resolvers
+ * Issue #136: Phase 1 - Task 1.2
+ *
+ * Provides Strategy pattern implementation for resolving resource paths:
+ * - Database paths (cm.db, cm-{issueNo}.db)
+ * - PID file paths (.commandmate.pid, pids/{issueNo}.pid)
+ * - Log file paths (commandmate.log, commandmate-{issueNo}.log)
+ *
+ * SF-SEC-001: TOCTOU protection via try-catch pattern in validate()
+ *
+ * @module resource-resolvers
+ */
+/**
+ * Interface for resource path resolvers
+ * Strategy pattern for unified resource path handling
+ */
+export interface ResourcePathResolver {
+    /**
+     * Resolve the path for a resource
+     * @param issueNo - Optional issue number for worktree-specific resources
+     * @returns Absolute path to the resource
+     */
+    resolve(issueNo?: number): string;
+    /**
+     * Validate that a path is within the allowed directory
+     * SF-SEC-001: Uses try-catch pattern for TOCTOU protection
+     *
+     * @param targetPath - Path to validate
+     * @returns true if path is valid and within allowed boundaries
+     */
+    validate(targetPath: string): boolean;
+}
+/**
+ * Database path resolver
+ *
+ * @example
+ * ```typescript
+ * const resolver = new DbPathResolver();
+ * resolver.resolve(); // ~/.commandmate/data/cm.db
+ * resolver.resolve(135); // ~/.commandmate/data/cm-135.db
+ * ```
+ */
+export declare class DbPathResolver implements ResourcePathResolver {
+    resolve(issueNo?: number): string;
+    validate(targetPath: string): boolean;
+}
+/**
+ * PID file path resolver
+ *
+ * Maintains backward compatibility:
+ * - No issueNo: ~/.commandmate/.commandmate.pid (main server)
+ * - With issueNo: ~/.commandmate/pids/{issueNo}.pid (worktree server)
+ *
+ * @example
+ * ```typescript
+ * const resolver = new PidPathResolver();
+ * resolver.resolve(); // ~/.commandmate/.commandmate.pid
+ * resolver.resolve(135); // ~/.commandmate/pids/135.pid
+ * ```
+ */
+export declare class PidPathResolver implements ResourcePathResolver {
+    resolve(issueNo?: number): string;
+    validate(targetPath: string): boolean;
+}
+/**
+ * Log file path resolver
+ *
+ * @example
+ * ```typescript
+ * const resolver = new LogPathResolver();
+ * resolver.resolve(); // ~/.commandmate/logs/commandmate.log
+ * resolver.resolve(135); // ~/.commandmate/logs/commandmate-135.log
+ * ```
+ */
+export declare class LogPathResolver implements ResourcePathResolver {
+    resolve(issueNo?: number): string;
+    validate(targetPath: string): boolean;
+}
+/**
+ * Factory function for DbPathResolver
+ */
+export declare function createDbPathResolver(): DbPathResolver;
+/**
+ * Factory function for PidPathResolver
+ */
+export declare function createPidPathResolver(): PidPathResolver;
+/**
+ * Factory function for LogPathResolver
+ */
+export declare function createLogPathResolver(): LogPathResolver;
+//# sourceMappingURL=resource-resolvers.d.ts.map

package/dist/cli/utils/resource-resolvers.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"resource-resolvers.d.ts","sourceRoot":"","sources":["../../../src/cli/utils/resource-resolvers.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAMH;;;GAGG;AACH,MAAM,WAAW,oBAAoB;IACnC;;;;OAIG;IACH,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,MAAM,CAAC;IAElC;;;;;;OAMG;IACH,QAAQ,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO,CAAC;CACvC;AAED;;;;;;;;;GASG;AACH,qBAAa,cAAe,YAAW,oBAAoB;IACzD,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,MAAM;IAQjC,QAAQ,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO;CAqBtC;AAED;;;;;;;;;;;;;GAaG;AACH,qBAAa,eAAgB,YAAW,oBAAoB;IAC1D,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,MAAM;IASjC,QAAQ,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO;CAqBtC;AAED;;;;;;;;;GASG;AACH,qBAAa,eAAgB,YAAW,oBAAoB;IAC1D,OAAO,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,MAAM;IASjC,QAAQ,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO;CAqBtC;AAED;;GAEG;AACH,wBAAgB,oBAAoB,IAAI,cAAc,CAErD;AAED;;GAEG;AACH,wBAAgB,qBAAqB,IAAI,eAAe,CAEvD;AAED;;GAEG;AACH,wBAAgB,qBAAqB,IAAI,eAAe,CAEvD"}

package/dist/cli/utils/resource-resolvers.js

@@ -0,0 +1,175 @@
+"use strict";
+/**
+ * Resource Path Resolvers
+ * Issue #136: Phase 1 - Task 1.2
+ *
+ * Provides Strategy pattern implementation for resolving resource paths:
+ * - Database paths (cm.db, cm-{issueNo}.db)
+ * - PID file paths (.commandmate.pid, pids/{issueNo}.pid)
+ * - Log file paths (commandmate.log, commandmate-{issueNo}.log)
+ *
+ * SF-SEC-001: TOCTOU protection via try-catch pattern in validate()
+ *
+ * @module resource-resolvers
+ */
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.LogPathResolver = exports.PidPathResolver = exports.DbPathResolver = void 0;
+exports.createDbPathResolver = createDbPathResolver;
+exports.createPidPathResolver = createPidPathResolver;
+exports.createLogPathResolver = createLogPathResolver;
+const fs_1 = require("fs");
+const path_1 = __importDefault(require("path"));
+const install_context_1 = require("./install-context");
+/**
+ * Database path resolver
+ *
+ * @example
+ * ```typescript
+ * const resolver = new DbPathResolver();
+ * resolver.resolve(); // ~/.commandmate/data/cm.db
+ * resolver.resolve(135); // ~/.commandmate/data/cm-135.db
+ * ```
+ */
+class DbPathResolver {
+    resolve(issueNo) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        if (issueNo !== undefined) {
+            return path_1.default.join(configDir, 'data', `cm-${issueNo}.db`);
+        }
+        return path_1.default.join(configDir, 'data', 'cm.db');
+    }
+    validate(targetPath) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        // SF-SEC-001: try-catch for TOCTOU protection
+        try {
+            const resolved = (0, fs_1.realpathSync)(targetPath);
+            return resolved.startsWith(configDir);
+        }
+        catch (error) {
+            if (error.code === 'ENOENT') {
+                // New file - validate parent directory
+                const parentDir = path_1.default.dirname(targetPath);
+                try {
+                    const resolvedParent = (0, fs_1.realpathSync)(parentDir);
+                    return resolvedParent.startsWith(configDir);
+                }
+                catch {
+                    return false;
+                }
+            }
+            return false;
+        }
+    }
+}
+exports.DbPathResolver = DbPathResolver;
+/**
+ * PID file path resolver
+ *
+ * Maintains backward compatibility:
+ * - No issueNo: ~/.commandmate/.commandmate.pid (main server)
+ * - With issueNo: ~/.commandmate/pids/{issueNo}.pid (worktree server)
+ *
+ * @example
+ * ```typescript
+ * const resolver = new PidPathResolver();
+ * resolver.resolve(); // ~/.commandmate/.commandmate.pid
+ * resolver.resolve(135); // ~/.commandmate/pids/135.pid
+ * ```
+ */
+class PidPathResolver {
+    resolve(issueNo) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        if (issueNo !== undefined) {
+            return path_1.default.join(configDir, 'pids', `${issueNo}.pid`);
+        }
+        // Backward compatibility: main PID file in config root
+        return path_1.default.join(configDir, '.commandmate.pid');
+    }
+    validate(targetPath) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        // SF-SEC-001: try-catch for TOCTOU protection
+        try {
+            const resolved = (0, fs_1.realpathSync)(targetPath);
+            return resolved.startsWith(configDir);
+        }
+        catch (error) {
+            if (error.code === 'ENOENT') {
+                // New file - validate parent directory
+                const parentDir = path_1.default.dirname(targetPath);
+                try {
+                    const resolvedParent = (0, fs_1.realpathSync)(parentDir);
+                    return resolvedParent.startsWith(configDir);
+                }
+                catch {
+                    return false;
+                }
+            }
+            return false;
+        }
+    }
+}
+exports.PidPathResolver = PidPathResolver;
+/**
+ * Log file path resolver
+ *
+ * @example
+ * ```typescript
+ * const resolver = new LogPathResolver();
+ * resolver.resolve(); // ~/.commandmate/logs/commandmate.log
+ * resolver.resolve(135); // ~/.commandmate/logs/commandmate-135.log
+ * ```
+ */
+class LogPathResolver {
+    resolve(issueNo) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        const logsDir = path_1.default.join(configDir, 'logs');
+        if (issueNo !== undefined) {
+            return path_1.default.join(logsDir, `commandmate-${issueNo}.log`);
+        }
+        return path_1.default.join(logsDir, 'commandmate.log');
+    }
+    validate(targetPath) {
+        const configDir = (0, install_context_1.getConfigDir)();
+        const logsDir = path_1.default.join(configDir, 'logs');
+        // SF-SEC-001: try-catch for TOCTOU protection
+        try {
+            const resolved = (0, fs_1.realpathSync)(targetPath);
+            return resolved.startsWith(logsDir);
+        }
+        catch (error) {
+            if (error.code === 'ENOENT') {
+                // New file - validate logs directory exists within config
+                try {
+                    const resolvedLogsDir = (0, fs_1.realpathSync)(logsDir);
+                    return resolvedLogsDir.startsWith(configDir);
+                }
+                catch {
+                    return false;
+                }
+            }
+            return false;
+        }
+    }
+}
+exports.LogPathResolver = LogPathResolver;
+/**
+ * Factory function for DbPathResolver
+ */
+function createDbPathResolver() {
+    return new DbPathResolver();
+}
+/**
+ * Factory function for PidPathResolver
+ */
+function createPidPathResolver() {
+    return new PidPathResolver();
+}
+/**
+ * Factory function for LogPathResolver
+ */
+function createLogPathResolver() {
+    return new LogPathResolver();
+}

package/dist/cli/utils/worktree-detector.d.ts

@@ -0,0 +1,82 @@
+/**
+ * Worktree Detector
+ * Issue #136: Phase 1 - Task 1.3
+ *
+ * Provides utilities for detecting git worktrees and extracting issue numbers.
+ * Used to automatically identify which worktree environment the CLI is running in.
+ *
+ * Security: Uses execFile instead of exec to prevent command injection.
+ *
+ * @module worktree-detector
+ */
+/**
+ * Information about a detected worktree
+ */
+export interface WorktreeInfo {
+    /** Issue number associated with the worktree */
+    issueNo: number;
+    /** Absolute path to the worktree root */
+    path: string;
+    /** Current git branch */
+    branch: string;
+}
+/**
+ * Extract issue number from a worktree directory path
+ *
+ * @param dirPath - Directory path to check
+ * @returns Issue number or null if not a worktree path
+ *
+ * @example
+ * ```typescript
+ * extractIssueNoFromPath('/home/user/repos/commandmate-issue-135'); // 135
+ * extractIssueNoFromPath('/home/user/repos/commandmate'); // null
+ * ```
+ */
+export declare function extractIssueNoFromPath(dirPath: string): number | null;
+/**
+ * Extract issue number from a git branch name
+ *
+ * @param branchName - Git branch name
+ * @returns Issue number or null if not found
+ *
+ * @example
+ * ```typescript
+ * extractIssueNoFromBranch('feature/135-add-worktree'); // 135
+ * extractIssueNoFromBranch('main'); // null
+ * ```
+ */
+export declare function extractIssueNoFromBranch(branchName: string): number | null;
+/**
+ * Check if a directory is inside a git worktree
+ *
+ * @param dirPath - Directory path to check
+ * @returns true if directory is inside a git repository
+ */
+export declare function isWorktreeDirectory(dirPath: string): Promise<boolean>;
+/**
+ * Detect if the current directory is within a CommandMate worktree
+ *
+ * Attempts to extract issue number from:
+ * 1. Directory path (e.g., commandmate-issue-135)
+ * 2. Git branch name (e.g., feature/135-description)
+ *
+ * @param dirPath - Directory path to check (defaults to cwd)
+ * @returns WorktreeInfo if detected, null otherwise
+ *
+ * @example
+ * ```typescript
+ * const info = await detectCurrentWorktree();
+ * if (info) {
+ *   console.log(`Running in worktree for Issue #${info.issueNo}`);
+ * }
+ * ```
+ */
+export declare function detectCurrentWorktree(dirPath?: string): Promise<WorktreeInfo | null>;
+/**
+ * Detect worktree from environment or current directory
+ * Convenience function that checks CM_ISSUE_NO env var first
+ *
+ * @returns WorktreeInfo if detected, null otherwise
+ */
+export declare function detectWorktreeContext(): Promise<WorktreeInfo | null>;
+//# sourceMappingURL=worktree-detector.d.ts.map

package/dist/cli/utils/worktree-detector.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"worktree-detector.d.ts","sourceRoot":"","sources":["../../../src/cli/utils/worktree-detector.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAQH;;GAEG;AACH,MAAM,WAAW,YAAY;IAC3B,gDAAgD;IAChD,OAAO,EAAE,MAAM,CAAC;IAChB,yCAAyC;IACzC,IAAI,EAAE,MAAM,CAAC;IACb,yBAAyB;IACzB,MAAM,EAAE,MAAM,CAAC;CAChB;AAkBD;;;;;;;;;;;GAWG;AACH,wBAAgB,sBAAsB,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAiBrE;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,wBAAwB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAc1E;AAED;;;;;GAKG;AACH,wBAAsB,mBAAmB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAY3E;AA6CD;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAsB,qBAAqB,CAAC,OAAO,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,YAAY,GAAG,IAAI,CAAC,CAkC1F;AAED;;;;;GAKG;AACH,wBAAsB,qBAAqB,IAAI,OAAO,CAAC,YAAY,GAAG,IAAI,CAAC,CAmB1E"}