commander 14.0.0 → 14.0.1

package/Readme.md

@@ -943,7 +943,7 @@ You can configure the help by modifying data properties and methods using `.conf
 
 Simple properties include `sortSubcommands`, `sortOptions`, and `showGlobalOptions`. You can add color using the style methods like `styleTitle()`.
 
-For more detail and examples of changing the displayed text, color, and layout see (./docs/help-in-depth.md).
+For more detail and examples of changing the displayed text, color, and layout see [help in depth](./docs/help-in-depth.md).
 
 ## Custom event listeners
 
@@ -1063,7 +1063,7 @@ customise the new subcommand (example file [custom-command-class.js](./examples/
 You can enable `--harmony` option in two ways:
 
 - Use `#! /usr/bin/env node --harmony` in the subcommands scripts. (Note Windows does not support this pattern.)
-- Use the `--harmony` option when call the command, like `node --harmony examples/pm publish`. The `--harmony` option will be preserved when spawning subcommand process.
+- Use the `--harmony` option when calling the command, like `node --harmony examples/pm publish`. The `--harmony` option will be preserved when spawning subcommand processes.
 
 ### Debugging stand-alone executable subcommands
 

package/lib/argument.js

@@ -33,7 +33,7 @@ class Argument {
         break;
     }
 
-    if (this._name.length > 3 && this._name.slice(-3) === '...') {
+    if (this._name.endsWith('...')) {
       this.variadic = true;
       this._name = this._name.slice(0, -3);
     }
@@ -53,12 +53,13 @@ class Argument {
    * @package
    */
 
-  _concatValue(value, previous) {
+  _collectValue(value, previous) {
     if (previous === this.defaultValue || !Array.isArray(previous)) {
       return [value];
     }
 
-    return previous.concat(value);
+    previous.push(value);
+    return previous;
   }
 
   /**
@@ -103,7 +104,7 @@ class Argument {
         );
       }
       if (this.variadic) {
-        return this._concatValue(arg, previous);
+        return this._collectValue(arg, previous);
       }
       return arg;
     };

package/lib/command.js

@@ -245,11 +245,10 @@ class Command extends EventEmitter {
   configureOutput(configuration) {
     if (configuration === undefined) return this._outputConfiguration;
 
-    this._outputConfiguration = Object.assign(
-      {},
-      this._outputConfiguration,
-      configuration,
-    );
+    this._outputConfiguration = {
+      ...this._outputConfiguration,
+      ...configuration,
+    };
     return this;
   }
 
@@ -375,7 +374,7 @@ class Command extends EventEmitter {
    */
   addArgument(argument) {
     const previousArgument = this.registeredArguments.slice(-1)[0];
-    if (previousArgument && previousArgument.variadic) {
+    if (previousArgument?.variadic) {
       throw new Error(
         `only the last argument can be variadic '${previousArgument.name()}'`,
       );
@@ -702,7 +701,7 @@ Expecting one of '${allowedValues.join("', '")}'`);
       if (val !== null && option.parseArg) {
         val = this._callParseArg(option, val, oldValue, invalidValueMessage);
       } else if (val !== null && option.variadic) {
-        val = option._concatValue(val, oldValue);
+        val = option._collectValue(val, oldValue);
       }
 
       // Fill-in appropriate missing values. Long winded but easy to follow.
@@ -1481,7 +1480,7 @@ Expecting one of '${allowedValues.join("', '")}'`);
 
   _chainOrCall(promise, fn) {
     // thenable
-    if (promise && promise.then && typeof promise.then === 'function') {
+    if (promise?.then && typeof promise.then === 'function') {
       // already have a promise, chain callback
       return promise.then(() => fn());
     }
@@ -1612,7 +1611,7 @@ Expecting one of '${allowedValues.join("', '")}'`);
       promiseChain = this._chainOrCallHooks(promiseChain, 'postAction');
       return promiseChain;
     }
-    if (this.parent && this.parent.listenerCount(commandEvent)) {
+    if (this.parent?.listenerCount(commandEvent)) {
       checkForUnknownOptions();
       this._processArguments();
       this.parent.emit(commandEvent, operands, unknown); // legacy
@@ -1742,15 +1741,14 @@ Expecting one of '${allowedValues.join("', '")}'`);
    *     sub --unknown uuu op => [sub], [--unknown uuu op]
    *     sub -- --unknown uuu op => [sub --unknown uuu op], []
    *
-   * @param {string[]} argv
+   * @param {string[]} args
    * @return {{operands: string[], unknown: string[]}}
    */
 
-  parseOptions(argv) {
+  parseOptions(args) {
     const operands = []; // operands, not options or values
     const unknown = []; // first unknown option and remaining unknown args
     let dest = operands;
-    const args = argv.slice();
 
     function maybeOption(arg) {
       return arg.length > 1 && arg[0] === '-';
@@ -1769,13 +1767,16 @@ Expecting one of '${allowedValues.join("', '")}'`);
 
     // parse options
     let activeVariadicOption = null;
-    while (args.length) {
-      const arg = args.shift();
+    let activeGroup = null; // working through group of short options, like -abc
+    let i = 0;
+    while (i < args.length || activeGroup) {
+      const arg = activeGroup ?? args[i++];
+      activeGroup = null;
 
       // literal
       if (arg === '--') {
         if (dest === unknown) dest.push(arg);
-        dest.push(...args);
+        dest.push(...args.slice(i));
         break;
       }
 
@@ -1793,17 +1794,17 @@ Expecting one of '${allowedValues.join("', '")}'`);
         // recognised option, call listener to assign value with possible custom processing
         if (option) {
           if (option.required) {
-            const value = args.shift();
+            const value = args[i++];
             if (value === undefined) this.optionMissingArgument(option);
             this.emit(`option:${option.name()}`, value);
           } else if (option.optional) {
             let value = null;
             // historical behaviour is optional value is following arg unless an option
             if (
-              args.length > 0 &&
-              (!maybeOption(args[0]) || negativeNumberArg(args[0]))
+              i < args.length &&
+              (!maybeOption(args[i]) || negativeNumberArg(args[i]))
             ) {
-              value = args.shift();
+              value = args[i++];
             }
             this.emit(`option:${option.name()}`, value);
           } else {
@@ -1826,9 +1827,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
             // option with value following in same argument
             this.emit(`option:${option.name()}`, arg.slice(2));
           } else {
-            // boolean option, emit and put back remainder of arg for further processing
+            // boolean option
             this.emit(`option:${option.name()}`);
-            args.unshift(`-${arg.slice(2)}`);
+            // remove the processed option and keep processing group
+            activeGroup = `-${arg.slice(2)}`;
           }
           continue;
         }
@@ -1865,26 +1867,23 @@ Expecting one of '${allowedValues.join("', '")}'`);
       ) {
         if (this._findCommand(arg)) {
           operands.push(arg);
-          if (args.length > 0) unknown.push(...args);
+          unknown.push(...args.slice(i));
           break;
         } else if (
           this._getHelpCommand() &&
           arg === this._getHelpCommand().name()
         ) {
-          operands.push(arg);
-          if (args.length > 0) operands.push(...args);
+          operands.push(arg, ...args.slice(i));
           break;
         } else if (this._defaultCommandName) {
-          unknown.push(arg);
-          if (args.length > 0) unknown.push(...args);
+          unknown.push(arg, ...args.slice(i));
           break;
         }
       }
 
       // If using passThroughOptions, stop processing options at first command-argument.
       if (this._passThroughOptions) {
-        dest.push(arg);
-        if (args.length > 0) dest.push(...args);
+        dest.push(arg, ...args.slice(i));
         break;
       }
 

package/lib/option.js

@@ -162,12 +162,13 @@ class Option {
    * @package
    */
 
-  _concatValue(value, previous) {
+  _collectValue(value, previous) {
     if (previous === this.defaultValue || !Array.isArray(previous)) {
       return [value];
     }
 
-    return previous.concat(value);
+    previous.push(value);
+    return previous;
   }
 
   /**
@@ -186,7 +187,7 @@ class Option {
         );
       }
       if (this.variadic) {
-        return this._concatValue(arg, previous);
+        return this._collectValue(arg, previous);
       }
       return arg;
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "commander",
-  "version": "14.0.0",
+  "version": "14.0.1",
   "description": "the complete solution for node.js command-line programs",
   "keywords": [
     "commander",
@@ -61,16 +61,16 @@
   },
   "devDependencies": {
     "@eslint/js": "^9.4.0",
-    "@types/jest": "^29.2.4",
+    "@types/jest": "^30.0.0",
     "@types/node": "^22.7.4",
     "eslint": "^9.17.0",
     "eslint-config-prettier": "^10.0.1",
-    "eslint-plugin-jest": "^28.3.0",
+    "eslint-plugin-jest": "^29.0.1",
     "globals": "^16.0.0",
-    "jest": "^29.3.1",
+    "jest": "^30.0.3",
     "prettier": "^3.2.5",
     "ts-jest": "^29.0.3",
-    "tsd": "^0.31.0",
+    "tsd": "^0.33.0",
     "typescript": "^5.0.4",
     "typescript-eslint": "^8.12.2"
   },