comfyui-mcp 0.52.6 → 0.52.7

package/dist/orchestrator/panel-tools.js

@@ -74,7 +74,7 @@ function journalTabFor(ctx) {
 function journalConversationFor(ctx) {
     return conversationOfScopeAddress(ctx.tabId);
 }
-import { BRIDGE_DEFAULT_TIMEOUT_MS, BRIDGE_READ_DEFAULT_TIMEOUT_MS, dispatchOutcomeOf, isCapabilityRefusal, isPanelCmdUnsupportedError, isReplyTimeoutTagged, isRoutingAmbiguity, } from "../services/ui-bridge.js";
+import { BRIDGE_DEFAULT_TIMEOUT_MS, BRIDGE_READ_DEFAULT_TIMEOUT_MS, dispatchOutcomeOf, isCapabilityRefusal, isPanelCmdUnsupportedError, isReplyTimeoutTagged, isRoutingAmbiguity, requiresWorkflowStampEnforcement, } from "../services/ui-bridge.js";
 import { withWorkflowTarget, } from "../services/workflow-target-store.js";
 import { addUserMcpServer, readUserMcpServers, removeUserMcpServer, setUserMcpServerSecret, } from "../services/user-mcp-config.js";
 import { setComfyuiSecret, setAgentSecret, isAllowedAgentSecretKey, receiptDisclosures, shadowedNote, storeDamageNote, } from "../services/panel-secrets.js";
@@ -791,6 +791,26 @@ function isFencedGraphRead(cmd) {
     const name = typeof cmd.cmd === "string" ? cmd.cmd : "";
     return name.startsWith("graph_") && !MUTATING_GRAPH_EDIT_CMDS.has(name);
 }
+/**
+ * #1778 — a fenced command that is neither a graph edit nor a graph read.
+ *
+ * `workflow_save` / `workflow_save_as` / `workflow_rename` / `workflow_close`
+ * require a workflow stamp (`requiresWorkflowStampEnforcement`) and the
+ * dispatch gate refuses them the same way it refuses a graph_* command. They
+ * are not in MUTATING_GRAPH_EDIT_CMDS and they do not start with `graph_`, so
+ * neither existing probe branch fires. The save handler then returns at
+ * `if (res.isError) return res` with the generic "tab may be disconnected"
+ * wrapper and an empty corroboration, so a save-only retry never self-heals.
+ *
+ * Derived from the stamp-enforcement classifier minus the `graph_` prefix, so
+ * a newly added active-workflow mutator cannot drift out. The prefix is still
+ * load-bearing for the same reason as `isFencedGraphRead`: the diagnosis runs
+ * `workflow_list`, which must not re-enter this branch.
+ */
+function isFencedActiveWorkflowMutator(cmd) {
+    const name = typeof cmd.cmd === "string" ? cmd.cmd : "";
+    return !name.startsWith("graph_") && requiresWorkflowStampEnforcement(cmd);
+}
 /** True when an error is a TRANSIENT transport/reconnect drop (the tab went away
  *  or was replaced), NOT a genuine command error or a live-but-frozen reply
  *  timeout. Deliberately EXCLUDES "did not reply within N ms" (a backgrounded/
@@ -7016,7 +7036,47 @@ export function makePanelToolCtx(bridge, tabId, workflowTargets) {
             //
             // Safe to recommend a retry because a fence refusal is checked BEFORE the handler
             // runs — "Nothing was applied" is structural here, not an echoed claim.
-            if (isWorkflowInstanceMismatch(err) && isMutatingGraphCmd(cmd)) {
+            //
+            // #1778 — the same refusal on workflow_save / save_as / rename / close. Those
+            // carry a workflow target but are not graph_*, so neither isMutatingGraphCmd
+            // nor isFencedGraphRead was true and the call fell through to the generic
+            // dispatched:false wrapper: no probe, no corroborateTabStamp, and a
+            // "tab may be disconnected" line that is false here (the tab is connected;
+            // what is stale is the stamp). Widening this branch is the self-heal.
+            //
+            // THE PHRASE IS NOT THE STATE, AND TWO OTHER REFUSALS QUOTE IT.
+            //
+            // `isWorkflowInstanceMismatch` is an unanchored `/workflow instance mismatch/i`,
+            // and the fence is not the only thing that says those words. The bridge's
+            // `"<cmd>" cannot be safely targeted to the active workflow` reject quotes them
+            // inside its `readsNote` — to describe what a DIFFERENT command would get — and
+            // carries the second look-alike, `no trusted identity`, in its `why` clause.
+            // Both are minted pre-dispatch and flagged `dispatched:false`, so both satisfy
+            // the phrase match on their way through here.
+            //
+            // For a mutating graph edit that never surfaced, by ORDERING rather than by
+            // design: the #1401 branch catches `no trusted identity` for `isMutatingGraphCmd`
+            // above. The four active-workflow mutators have no branch above them, so the
+            // widening alone handed each of these two states the OTHER's remedy — measured,
+            // not reasoned. A capability refusal ending "Update the panel and hard-refresh
+            // the browser tab" came back with "Retry once — … panel_open_workflow is the way
+            // to settle which one you mean" appended to it: the futile retry #709 exists to
+            // suppress, contradicting the sentence directly above it, plus a wasted
+            // workflow_list round trip. And a fence-less session got #1330's "the fence
+            // already names the live canvas" for the state whose own docstring says "a
+            // mismatch may clear by itself, this never does".
+            //
+            // So the arm carries the discriminators the graph arm gets from ordering. Both
+            // are TYPED-or-explicit, never a second reading of the same prose:
+            // `isCapabilityRefusal` is the bridge's own symbol marker, and
+            // `isNoTrustedIdentityRefusal` matches a distinct phrase a mismatch refusal never
+            // contains. Scoped to THIS arm on purpose — `isMutatingGraphCmd` keeps its exact
+            // prior behaviour, so nothing about the graph path moves here.
+            if (isWorkflowInstanceMismatch(err) &&
+                (isMutatingGraphCmd(cmd) ||
+                    (isFencedActiveWorkflowMutator(cmd) &&
+                        !isCapabilityRefusal(err) &&
+                        !isNoTrustedIdentityRefusal(err)))) {
                 const name = typeof cmd.cmd === "string" ? cmd.cmd : "panel command";
                 const raw = err instanceof Error ? err.message : String(err);
                 // The uuid the command CARRIED, read from the panel's own refusal rather than