comfyui-mcp 0.52.39 → 0.52.41

package/dist/orchestrator/panel-tools.js

@@ -1048,6 +1048,28 @@ function sessionRouteIsLive(ctx) {
         return false;
     }
 }
+/**
+ * Snapshot of whether this tab can fence a graph WRITE right now.
+ *
+ * `known:false` (resolver threw, ctx threw) is `undefined`, not `false`: the
+ * boolean probe fails closed, and rendering that as "your panel lacks the write
+ * fence" is a claim built from our own failure to look.
+ */
+function readTabMutationCapability(ctx) {
+    try {
+        if (ctx.tabGraphMutationCapability) {
+            const cap = ctx.tabGraphMutationCapability();
+            return {
+                canMutateNow: cap.known ? cap.canMutate : undefined,
+                refusalCause: cap.known && !cap.canMutate ? cap.because : undefined,
+            };
+        }
+        return { canMutateNow: ctx.tabCanMutateGraph?.(), refusalCause: undefined };
+    }
+    catch {
+        return { canMutateNow: undefined, refusalCause: undefined };
+    }
+}
 /**
  * #1331 — the bridge refused a mutation because the active workflow has no identity to
  * fence against (ui-bridge's `no trusted identity` branch).
@@ -3070,6 +3092,137 @@ function isLoraManagerAutocompleteRefusal(res) {
     return (/had no widget after .+ waiting for node extensions to register/i.test(text) &&
         /AUTOCOMPLETE_TEXT_/i.test(text));
 }
+/**
+ * #1944 — the panel's add-node socket proof read "which datatypes does some
+ * installed node output?" off a single-class `/object_info/<class_type>`
+ * payload (or a whole-schema widen that did not land). Custom link types a
+ * SIBLING node produces — SeedVR2LoadDiTModel → SEEDVR2_DIT — then look
+ * unproven, and the refusal claims "no installed node outputs X" while that
+ * very node sits on the canvas. Retrying the add re-runs the same proof;
+ * panel_refresh_nodes re-registers the class, which is what arms the
+ * single-class path. The live graph is the authority the guard did not consult.
+ */
+function isMissingInstalledOutputsRefusal(res) {
+    if (!res.isError)
+        return false;
+    const text = textOfToolResult(res);
+    return (/had no widget after .+ waiting for node extensions to register/i.test(text) &&
+        /no installed node outputs/i.test(text));
+}
+/** Types the panel named as unproven in a #1944-shaped refusal. */
+function parseUnprovenSocketTypes(text) {
+    const types = [];
+    const add = (raw) => {
+        const v = raw.trim();
+        if (v && !types.includes(v))
+            types.push(v);
+    };
+    for (const re of [
+        /no installed node outputs "([^"]+)"/gi,
+        /declared type "([^"]+)": no installed node outputs/gi,
+    ]) {
+        re.lastIndex = 0;
+        let m;
+        while ((m = re.exec(text)))
+            add(m[1]);
+    }
+    return types;
+}
+function nodeOutputDeclaresType(node, socketType) {
+    const outputs = node.outputs;
+    if (Array.isArray(outputs)) {
+        for (const out of outputs) {
+            if (!out || typeof out !== "object" || Array.isArray(out))
+                continue;
+            const t = out.type;
+            if (typeof t !== "string" || !t)
+                continue;
+            if (t === socketType)
+                return true;
+            if (t.split(",").map((part) => part.trim()).includes(socketType))
+                return true;
+        }
+    }
+    const matchedOn = node.matched_on;
+    if (!Array.isArray(matchedOn))
+        return false;
+    const needle = `(${socketType.toLowerCase()})`;
+    return matchedOn.some((entry) => typeof entry === "string" && entry.toLowerCase().includes(needle));
+}
+/**
+ * Ask the live canvas whether each unproven type is actually produced there.
+ * Returns null when a probe fails — an unreadable graph is not evidence the
+ * producers are present, so the original refusal stays the last word.
+ */
+async function findLiveSocketProducers(ctx, types) {
+    const found = new Map();
+    for (const socketType of types) {
+        const probe = await ctx.call({ cmd: "graph_find_nodes", output: socketType, limit: 5 }, 8000);
+        if (probe.isError)
+            return null;
+        const payload = parseToolResultJson(probe);
+        const matches = Array.isArray(payload?.matches) ? payload.matches : [];
+        const producers = [];
+        for (const row of matches) {
+            if (!row || typeof row !== "object" || Array.isArray(row))
+                continue;
+            const rec = row;
+            if (!nodeOutputDeclaresType(rec, socketType))
+                continue;
+            const id = rec.id;
+            const type = rec.type ?? rec.class_type;
+            producers.push({
+                id: id == null ? "?" : String(id),
+                type: typeof type === "string" && type ? type : "unknown",
+            });
+        }
+        found.set(socketType, producers);
+    }
+    return found;
+}
+function liveSocketProducerNote(classType, found) {
+    const target = typeof classType === "string" && classType ? classType : "this node";
+    const lines = [...found.entries()].map(([socket, nodes]) => {
+        const who = nodes
+            .slice(0, 3)
+            .map((n) => `${n.type} #${n.id}`)
+            .join(", ");
+        return `  - ${socket}: ${who}`;
+    });
+    return (`\n\nThis is NOT a missing pack and NOT a widget that is still loading. ` +
+        `The live canvas ALREADY has nodes that output every type the add-node guard ` +
+        `claimed was missing:\n` +
+        `${lines.join("\n")}\n` +
+        `The guard consulted a single-class /object_info payload (or a whole-schema ` +
+        `widen that did not land), not the live frontend graph, so it cannot see ` +
+        `sibling producers added earlier in this session. ` +
+        `Retrying panel_add_node will keep failing; panel_refresh_nodes will not ` +
+        `clear it (it re-registers the class, which is what arms the single-class path). ` +
+        `Workaround: copy an existing "${target}" from another open workflow and ` +
+        `paste it here (panel_copy_nodes / panel_paste_nodes), or reload the ComfyUI ` +
+        `browser tab so the page rebuilds its node registry. Do not retry this class_type ` +
+        `until then.`);
+}
+async function withLiveSocketProducerNote(res, classType, ctx) {
+    if (!isMissingInstalledOutputsRefusal(res))
+        return res;
+    // #1708 is a Vue-widget miss, not a sibling-producer miss. Querying the
+    // canvas for AUTOCOMPLETE_TEXT_* would only delay the named remedy.
+    if (isLoraManagerAutocompleteRefusal(res))
+        return res;
+    const missing = parseUnprovenSocketTypes(textOfToolResult(res));
+    if (!missing.length)
+        return res;
+    const found = await findLiveSocketProducers(ctx, missing);
+    if (!found)
+        return res;
+    if (!missing.every((t) => (found.get(t)?.length ?? 0) > 0))
+        return res;
+    return appendToolResultText(res, liveSocketProducerNote(classType, found));
+}
+async function annotateAddNodeRefusal(res, classType, ctx) {
+    return withFrontendOnlyPanelSkewNote(withLoraManagerAutocompleteNote(await withLiveSocketProducerNote(res, classType, ctx)), classType, ctx);
+}
 const LORA_MANAGER_AUTOCOMPLETE_NOTE = `\n\nThis is NOT a missing pack and NOT a widget that is still loading. ` +
     `ComfyUI-LoRA-Manager registers AUTOCOMPLETE_TEXT_* via getCustomWidgets() into ` +
     `the frontend widget store; the add-node guard only looks at app.widgets (core types), ` +
@@ -10234,7 +10387,7 @@ export function buildPanelToolDefs() {
                 },
             },
         ])),
-        def("panel_add_node", "Add a node to the user's OPEN ComfyUI graph by class_type (e.g. 'KSampler', 'CheckpointLoaderSimple'). The user sees it appear live; Ctrl+Z undoes it. Returns the created node's id, slots, and default widget values. Frontend-only virtual types are addable too: 'Note' and 'MarkdownNote' — the supported way to ANNOTATE a workflow with on-canvas instructions (add the node, then put the text in its 'text' widget via panel_set_widget) — plus 'Reroute' and 'PrimitiveNode'. These are LiteGraph-native and never appear in the backend node registry, so they legitimately bypass the backend class_type check. ComfyUI-LoRA-Manager's 'Lora Loader (LoraManager)' (and other AUTOCOMPLETE_TEXT_* nodes) cannot be added: the pack is healthy, but the add-node guard cannot see its Vue autocomplete widget. Use 'LoRA Text Loader (LoraManager)' — same outputs, lora_syntax is a STRING — or core LoraLoader; reload/retry will not clear it. ADD NODES ONE AT A TIME, not as a parallel batch: each add carries a fresh /object_info payload and those register SERIALLY, so N concurrent adds become N sequential refresh cycles. On a large install that outruns the 30s per-command deadline and the later adds time out WHILE STILL QUEUED — they then apply when their turn arrives, leaving nodes you were told had failed (panel#767). Sequential adds each get the refresh to themselves and stay well inside the deadline.", {
+        def("panel_add_node", "Add a node to the user's OPEN ComfyUI graph by class_type (e.g. 'KSampler', 'CheckpointLoaderSimple'). The user sees it appear live; Ctrl+Z undoes it. Returns the created node's id, slots, and default widget values. Frontend-only virtual types are addable too: 'Note' and 'MarkdownNote' — the supported way to ANNOTATE a workflow with on-canvas instructions (add the node, then put the text in its 'text' widget via panel_set_widget) — plus 'Reroute' and 'PrimitiveNode'. These are LiteGraph-native and never appear in the backend node registry, so they legitimately bypass the backend class_type check. ComfyUI-LoRA-Manager's 'Lora Loader (LoraManager)' (and other AUTOCOMPLETE_TEXT_* nodes) cannot be added: the pack is healthy, but the add-node guard cannot see its Vue autocomplete widget. Use 'LoRA Text Loader (LoraManager)' — same outputs, lora_syntax is a STRING — or core LoraLoader; reload/retry will not clear it. A 'no installed node outputs' refusal for a custom link type (SEEDVR2_DIT, SEEDVR2_VAE, …) after sibling producer nodes were just added is the guard looking at a single-class /object_info, not the live graph; retry/refresh will not clear it — copy the node from another workflow (panel_copy_nodes / panel_paste_nodes) or reload the tab. ADD NODES ONE AT A TIME, not as a parallel batch: each add carries a fresh /object_info payload and those register SERIALLY, so N concurrent adds become N sequential refresh cycles. On a large install that outruns the 30s per-command deadline and the later adds time out WHILE STILL QUEUED — they then apply when their turn arrives, leaving nodes you were told had failed (panel#767). Sequential adds each get the refresh to themselves and stay well inside the deadline.", {
             class_type: z.string().describe("Exact ComfyUI node class_type to create."),
             pos: xy()
                 .optional()
@@ -10248,7 +10401,7 @@ export function buildPanelToolDefs() {
             const add = () => ctx.call({ cmd: "graph_add_node", class_type: args.class_type, pos: args.pos, title: args.title }, OBJECT_INFO_REFRESH_ACK_TIMEOUT_MS);
             const first = await add();
             if (!isStaleNodeSchemaRefusal(first)) {
-                return withFrontendOnlyPanelSkewNote(withLoraManagerAutocompleteNote(first), args.class_type, ctx);
+                return annotateAddNodeRefusal(first, args.class_type, ctx);
             }
             // #1329 — DO THE REFRESH THE REFUSAL ASKS FOR, instead of billing the caller.
             //
@@ -10283,9 +10436,9 @@ export function buildPanelToolDefs() {
                 // the refresh failure alongside so the caller knows the automatic attempt
                 // happened and why it did not help. No retry here, because the schema really is
                 // unchanged and a second add really would refuse again.
-                return withFrontendOnlyPanelSkewNote(withLoraManagerAutocompleteNote(appendToolResultText(first, `\n\n(Tried to clear this automatically: panel_refresh_nodes was dispatched and FAILED, ` +
+                return annotateAddNodeRefusal(appendToolResultText(first, `\n\n(Tried to clear this automatically: panel_refresh_nodes was dispatched and FAILED, ` +
                     `so the schema is unchanged and retrying the add will refuse again. ` +
-                    `${textOfToolResult(refreshed)})`)), args.class_type, ctx);
+                    `${textOfToolResult(refreshed)})`), args.class_type, ctx);
             }
             // panel#1518 — TAKE THE RETRY, instead of telling the caller to take it.
             //
@@ -10310,7 +10463,7 @@ export function buildPanelToolDefs() {
             // refresh left behind.
             const second = await add();
             if (!isStaleNodeSchemaRefusal(second)) {
-                return withFrontendOnlyPanelSkewNote(withLoraManagerAutocompleteNote(
+                return annotateAddNodeRefusal(
                 // An error from the RETRY, on the path where the caller never asked for a
                 // retry, must say which attempt it came from — otherwise a bare
                 // `graph_add_node` timeout reads as the first add's outcome and leaves the
@@ -10321,12 +10474,12 @@ export function buildPanelToolDefs() {
                         `node schema and created NOTHING, then panel_refresh_nodes was dispatched and did ` +
                         `NOT answer within its window. The error above is from the second attempt, so at ` +
                         `most ONE add is unaccounted for here.)`)
-                    : second), args.class_type, ctx);
+                    : second, args.class_type, ctx);
             }
             // Still stale after the refresh: report THAT, because it means the remedy the
             // refusal prescribes does not fix this instance and a caller following it by hand
             // would loop.
-            return withFrontendOnlyPanelSkewNote(withLoraManagerAutocompleteNote(appendToolResultText(second, refreshOutranItsAck
+            return annotateAddNodeRefusal(appendToolResultText(second, refreshOutranItsAck
                 ? // The refresh was never observed to finish, so "repeating it will not clear
                     // it" and "reload the tab" would both overclaim. What IS known: it was not
                     // cancelled, it is still registering the definitions this add needs, and the
@@ -10342,7 +10495,7 @@ export function buildPanelToolDefs() {
                         `the tab being frozen. ${textOfToolResult(refreshed)})`
                 : `\n\n(This was already retried ONCE automatically: panel_refresh_nodes reported success ` +
                     `and the add still refuses, so repeating panel_refresh_nodes will not clear it. ` +
-                    `Reload the ComfyUI browser tab, which rebuilds the page's node registry from scratch.)`)), args.class_type, ctx);
+                    `Reload the ComfyUI browser tab, which rebuilds the page's node registry from scratch.)`), args.class_type, ctx);
         }),
         def("panel_remove_node", "Remove a node (and its connections) from the user's open graph by id. Undoable with Ctrl+Z.", { node_id: nodeId().describe("Node id from panel_graph_outline / panel_query_graph.") }, async (args, ctx) => ctx.call({ cmd: "graph_remove_node", node_id: args.node_id })),
         def("panel_clear", "Remove EVERY node from the user's open graph — only for an explicit 'clear/reset the canvas'. Just CALL THIS DIRECTLY when they ask to clear: the tool itself pops a confirm card and only wipes on a yes (don't ask separately first). The wipe is a single Ctrl+Z undo. NEVER use this for a 'new workflow' — that's panel_new_workflow (a new tab, leaves this graph intact).", {}, async (_args, ctx) => {
@@ -12732,26 +12885,12 @@ export function buildPanelToolDefs() {
             // unreadable capability would be RENDERED as "your panel lacks the write
             // fence" — a claim about the panel built from our own failure to look
             // (codex gate). Only an OBSERVED negative may say that.
-            let canMutateNow;
-            let refusalCause;
-            try {
-                if (ctx.tabGraphMutationCapability) {
-                    const cap = ctx.tabGraphMutationCapability();
-                    canMutateNow = cap.known ? cap.canMutate : undefined;
-                    if (cap.known && !cap.canMutate)
-                        refusalCause = cap.because;
-                }
-                else {
-                    // The legacy boolean probe cannot say WHY, and guessing would put us
-                    // back where the tri-state started. Leave the cause undefined so the
-                    // narration falls back to the generic wording rather than inventing one.
-                    canMutateNow = ctx.tabCanMutateGraph?.();
-                }
-            }
-            catch {
-                canMutateNow = undefined; // a guard that can throw is not a guard
-                refusalCause = undefined;
-            }
+            //
+            // This snapshot is taken BEFORE the settling read. After a restart the
+            // tab can still be reconnecting, so the honest answer here is often
+            // unknown (`undefined`) even though a moment later `graph_query` will
+            // round-trip. #1696 re-reads after that probe, on the tab that answered.
+            let { canMutateNow, refusalCause } = readTabMutationCapability(ctx);
             // #1043 (codex review) — NO version note on THIS path, deliberately.
             //
             // The note claims that on 0.11.45+ "the command that re-pointed the canvas
@@ -12867,6 +13006,13 @@ export function buildPanelToolDefs() {
                 }
                 if (probeOk) {
                     probePassed = true;
+                    // #1696 — the snapshot above is taken BEFORE this read, while the tab
+                    // may still be reconnecting. `canMutateNow` is then undefined (the
+                    // probe could not inspect the tab) even though this command just
+                    // proved the socket and fence are live. Re-read on the tab that
+                    // answered; a still-unknown or still-refused write capability keeps
+                    // the failure below. Treating unknown as true is not this fix.
+                    ({ canMutateNow, refusalCause } = readTabMutationCapability(ctx));
                     settledNote =
                         // ONE OBSERVATION, STATED AS ONE (codex r2). A passing graph_query proves that
                         // read passed this fence just now — not that every command will, and not that