comfyui-mcp 0.52.122 → 0.52.123

package/docker/runpod/README.md

@@ -175,16 +175,22 @@ So SSH + Jupyter + nginx come from the base; **our hook adds everything else**.
   volume.
 * **`--input-directory` / `--output-directory`** — inputs and generated images on
   the volume.
+* **`--models-directory /workspace/models`** — makes ComfyUI's
+  `folder_paths.models_dir` the persistent volume root. This is required for
+  ComfyUI-Manager's explicit relative `save_path` values; `is_default` only
+  changes the ordering of category search paths.
 * **`--extra-model-paths-config`** — points every model category at
   `/workspace/models` (see below). MODELS persist on the volume.
 * **We deliberately do NOT use `--base-directory`.** It would relocate
   `custom_nodes` (and temp) onto the volume too — but we want `custom_nodes` to
-  stay **in the image**. The per-dir flags + `extra_model_paths.yaml` give us
-  exactly the split we want (data on the volume, software in the image).
+  stay **in the image**. The per-dir flags, explicit `--models-directory`, and
+  `extra_model_paths.yaml` give us exactly the split we want (data on the
+  volume, software in the image).
 
 > **Flag verification.** These flag names were verified against ComfyUI `master`
-> (`comfy/cli_args.py`): `--user-directory`, `--input-directory`,
-> `--output-directory`, `--base-directory`, and `--extra-model-paths-config` all
+> (`comfy/cli_args.py`): `--user-directory`, `--models-directory`,
+> `--input-directory`, `--output-directory`, `--base-directory`, and
+> `--extra-model-paths-config` all
 > exist with these exact spellings, and `--base-directory`'s own help text states
 > it sets the base for "models, custom_nodes, input, output, temp, and user
 > directories" — confirming why we avoid it. **Assumption to confirm at build:**
@@ -198,10 +204,10 @@ So SSH + Jupyter + nginx come from the base; **our hook adds everything else**.
 ## Model paths (`extra_model_paths.yaml`)
 
 `extra_model_paths.yaml` is baked at `/opt/ComfyUI/extra_model_paths.yaml` and
-loaded via `--extra-model-paths-config`. It maps **every** model category to a
-subfolder under `/workspace/models`, with `is_default: true` so the volume is the
-**primary** (download) location — i.e. Manager's install-model writes there and
-the files persist.
+loaded via `--extra-model-paths-config`. It maps every model category **this
+image knows about** to a subfolder under `/workspace/models`, with
+`is_default: true` so the volume is the **primary** (download) location — i.e.
+Manager's install-model writes there and the files persist.
 
 ```yaml
 comfyui_mcp_volume:
@@ -239,15 +245,22 @@ comfyui_mcp_volume:
     geometry_estimation: models/geometry_estimation/
     optical_flow: models/optical_flow/
     detection: models/detection/
+
+    # registered by the node packs themselves, not by ComfyUI core:
+    ultralytics: models/ultralytics/          # Impact Subpack
+    ultralytics_bbox: models/ultralytics/bbox/
+    ultralytics_segm: models/ultralytics/segm/
+    sams: models/sams/                       # Impact Pack (SAMLoader)
 ```
 
 Notes:
 
-* **`is_default: true`** is the load-bearing line. ComfyUI's
+* **`is_default: true`** keeps the volume category paths first for lookup. ComfyUI's
   `add_model_folder_path(..., is_default=True)` **inserts** the path at the front
-  of each category's list, so `/workspace/models/<cat>` becomes the default
-  download target. Without it, the image's `/opt/ComfyUI/models/<cat>` (ephemeral)
-  would stay first and Manager downloads would **not** persist.
+  of each category's list, so `/workspace/models/<cat>` is preferred for lookup.
+  The launch's explicit `--models-directory /workspace/models` is the separate
+  guarantee that Manager's explicit relative `save_path` writes also land on the
+  volume; `is_default` alone cannot change `folder_paths.models_dir`.
 * **No `custom_nodes:` key** — on purpose. Mapping `custom_nodes` to the volume
   would break the fast-restart contract.
 * `base_path: /workspace` with `models/...` relative subpaths mirrors ComfyUI's
@@ -255,8 +268,28 @@ Notes:
 * The category **keys** match ComfyUI's `folder_names_and_paths` keys (verified
   against `master`'s `folder_paths.py`). The category list mirrors the example's
   full set; harmless if a future ComfyUI renames one.
+* **Custom node packs register their own categories, and those are NOT in ComfyUI's
+  example.** A category absent from this file has no `/workspace` entry at all, so
+  `/opt/ComfyUI/models/<cat>` stays its only path and downloads land on the ephemeral
+  image layer - no error, just gone after the next rebuild (#2302). Adding the key is
+  sufficient and order-independent: packs register via a helper that calls
+  `add_model_folder_path` **without** `is_default`, i.e. it appends behind whatever this
+  file already put at the front. Impact Pack also registers `onnx` (read from its
+  source, deliberately left out of #2302's fix as it is a deprecated provider);
+  `insightface`, `facerestore_models` and `rembg` are the same shape but have NOT
+  been audited — do that before adding them.
 * `/post_start.sh` pre-creates the matching subfolders under `/workspace/models`
   so they exist on a cold volume.
+* **This file does not reach a node pack's OWN installer.** It adds *search* paths;
+  it does not move `folder_paths.models_dir`, which is what Impact Pack's and Impact
+  Subpack's `install.py` derive their download directory from (Subpack has no
+  `folder_paths` fallback at all). So `post_start.sh` also exports
+  `COMFYUI_MODEL_PATH=/workspace/models` before launching ComfyUI - pack installers
+  read that first, and Manager runs them as children of the ComfyUI process, so they
+  inherit it. Without it, installing Impact Subpack drops `face_yolov8m.pt` into
+  `/opt/ComfyUI/models/ultralytics/bbox` and Impact Pack drops `sam_vit_b_01ec64.pth`
+  into `/opt/ComfyUI/models/sams`, both on the ephemeral layer. ComfyUI core never
+  reads `COMFYUI_MODEL_PATH`, so this redirects only the packs' installers.
 
 ### Warm model volume (skip the cold HF pull)
 

package/docker/runpod/extra_model_paths.yaml

@@ -59,3 +59,19 @@ comfyui_mcp_volume:
     geometry_estimation: models/geometry_estimation/
     optical_flow: models/optical_flow/
     detection: models/detection/
+
+    # Impact Pack / Impact Subpack register these categories THEMSELVES at import
+    # time (Subpack: ultralytics, ultralytics_bbox, ultralytics_segm — Pack: sams),
+    # so without the entries below the categories exist only as the in-image
+    # /opt/ComfyUI/models/<cat> and a FaceDetailer user's YOLO/SAM weights land on
+    # the ephemeral layer and vanish on the next rebuild (#2302).
+    #
+    # Order is safe either way round: both packs register via a helper that calls
+    # folder_paths.add_model_folder_path WITHOUT is_default, i.e. it APPENDS. So if
+    # this file loads first the volume path is already index 0 and the pack appends
+    # behind it; if the pack loads first, `is_default: true` above inserts the
+    # volume path at the FRONT. Either way /workspace stays the download target.
+    ultralytics: models/ultralytics/
+    ultralytics_bbox: models/ultralytics/bbox/
+    ultralytics_segm: models/ultralytics/segm/
+    sams: models/sams/

package/docker/runpod/post_start.sh

@@ -141,7 +141,8 @@ for sub in checkpoints configs loras vae text_encoders clip diffusion_models \
            controlnet t2i_adapter gligen upscale_models latent_upscale_models \
            hypernetworks photomaker classifiers model_patches audio_encoders \
            background_removal frame_interpolation geometry_estimation \
-           optical_flow detection; do
+           optical_flow detection \
+           sams ultralytics ultralytics/bbox ultralytics/segm; do
   mkdir -p "${MODELS_DIR}/${sub}"
 done
 
@@ -442,6 +443,17 @@ CN_VOL="${WORKSPACE}/custom_nodes"
 CN_LINK="${COMFY_HOME}/custom_nodes"
 CN_SEED="${COMFY_HOME}/custom_nodes_seed"
 export PIP_CACHE_DIR="${WORKSPACE}/.cache/pip"
+# Pack install scripts resolve their OWN download dir from $COMFYUI_MODEL_PATH and
+# fall back to the IMAGE's models dir when it is unset. extra_model_paths.yaml cannot
+# reach them: it adds SEARCH paths, it does not move folder_paths.models_dir. So
+# Impact Subpack's installer drops face_yolov8m.pt into
+# /opt/ComfyUI/models/ultralytics/bbox (it has no folder_paths fallback at all) and
+# Impact Pack's drops sam_vit_b_01ec64.pth into /opt/ComfyUI/models/sams - both on the
+# ephemeral layer, both gone on the next rebuild (#2302). ComfyUI core never reads this
+# variable (models_dir comes from --models-directory or base_path), so setting it
+# redirects ONLY the node packs' own installers, and onto the same dirs
+# extra_model_paths.yaml already maps.
+export COMFYUI_MODEL_PATH="${MODELS_DIR}"
 mkdir -p "${CN_VOL}" "${PIP_CACHE_DIR}"
 
 # (a) Point the image's custom_nodes at the volume. Replace whatever is there — a
@@ -569,10 +581,12 @@ fi
 # -----------------------------------------------------------------------------
 # 5. Launch ComfyUI from the BAKED venv (image), pointed at the volume dirs.
 #    Invoke the venv python by ABSOLUTE PATH (no `activate` needed).
-#    Per-directory flags keep user/input/output on /workspace; models come from
-#    extra_model_paths.yaml (is_default → volume is primary). custom_nodes are
-#    symlinked onto the volume in §4.5 above (so runtime installs persist); we do
-#    NOT use --base-directory (it would relocate the whole tree, incl. the venv).
+#    Per-directory flags keep user/input/output on /workspace. --models-directory
+#    makes ComfyUI's folder_paths.models_dir the persistent volume root, which is
+#    required for Manager's explicit relative save_path values; the extra path map
+#    still puts every category's volume subfolder first. custom_nodes are symlinked
+#    onto the volume in §4.5 above (so runtime installs persist); we do NOT use
+#    --base-directory (it would relocate the whole tree, incl. the venv).
 # -----------------------------------------------------------------------------
 VPY="${COMFY_HOME}/venv/bin/python"
 if [ ! -x "${VPY}" ]; then
@@ -612,6 +626,7 @@ ARGS=(--listen 0.0.0.0 --port "${COMFY_PORT}"
       --enable-manager --enable-cors-header
       "${ATTN_ARGS[@]}"
       --user-directory  "${USER_DIR}"
+      --models-directory "${MODELS_DIR}"
       --input-directory "${INPUT_DIR}"
       --output-directory "${OUTPUT_DIR}")
 # Load the volume model map only if the file exists (it's baked, but be defensive).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "comfyui-mcp",
-  "version": "0.52.122",
+  "version": "0.52.123",
   "mcpName": "io.github.artokun/comfyui-mcp",
   "description": "Local-first, agent-native control plane for ComfyUI — MCP server + autonomous sidebar agent that drives your live graph in natural language on ANY LLM: Claude/ChatGPT/Gemini on your subscription (no API key), free local models via Ollama (fully offline), or any hosted model via an OpenAI-compatible endpoint (DeepSeek, GLM, MiMo, OpenRouter). Generate images, video & audio, author and run workflows, manage models and custom nodes; a compact tool-router mode keeps even 4B models effective, and a built-in LLM Arena benchmarks them on real ComfyUI tasks. Also a Claude Code plugin with skills, slash commands, and installer packs. Local, LAN, VPS, or Comfy Cloud.",
   "homepage": "https://comfyui-mcp.artokun.io/docs",