comfyui-mcp 0.51.46 → 0.51.48

package/dist/orchestrator/panel-tools.js

@@ -34,6 +34,7 @@ import { fileURLToPath } from "node:url";
 import { comfyuiFetch } from "../comfyui/fetch.js";
 import { assertPanelNotTargetedUnverifiable } from "../services/panel-pin-guard.js";
 import { nodesInstallCommandArgs } from "../services/node-management.js";
+import { isPreExecutorRefusal } from "../services/panel-refusal.js";
 import { createSdkMcpServer, tool } from "@anthropic-ai/claude-agent-sdk";
 import { parse as parseYaml } from "yaml";
 import { conversationOfScopeAddress, isScopeAddress, shortTabId } from "../services/session-scope.js";
@@ -3494,6 +3495,37 @@ async function unreadableOrHealed(ctx, before, detail) {
 function panelTooOldNote(ctx) {
     try {
         const v = ctx.bridge?.panelTooOldForReplyUuid?.(ctx.tabId);
+        // #1560 — A PANEL TOO OLD TO HELP IS ALSO TOO OLD TO SAY SO.
+        //
+        // The note below needs an advertised version, and `panel_version` has only
+        // ridden the hello since panel v0.11.83. So the panels most likely to be
+        // causing this deadlock — anything below 0.11.45 — cannot report it, and the
+        // reporter of #1560 (on 0.11.37, after two Manager self-updates of the pack
+        // crashed) got a bare "the panel did not answer" with nothing to act on.
+        //
+        // Deliberately WEAKER than the version case, and weaker still after review: an
+        // absent version proves only "below 0.11.83", NOT "below the minimum". Panels
+        // in 0.11.45–0.11.82 publish the reply uuid and simply predate version
+        // advertisement, so this must read as SOMETHING TO CHECK and never as a finding
+        // — naming a cause that is not theirs is the failure this whole cluster exists
+        // to avoid.
+        if (v?.neverAdvertised) {
+            return (`
+
+WORTH CHECKING — THE PANEL'S VERSION IS UNKNOWN HERE: this session's panel has never ` +
+                `reported its version, and panels have advertised one on connect since 0.11.83, so ` +
+                `this one is older than that. That does NOT by itself mean it is too old: a panel ` +
+                `reports the new workflow's identity ON THE REPLY from ${v.needed} onwards, and ` +
+                `0.11.45–0.11.82 do that while still not advertising a version. But if it IS below ` +
+                `${v.needed}, that is the whole cause of this failure rather than anything about this ` +
+                `workflow — on ${v.needed}+ the command that re-pointed the canvas repairs the fence ` +
+                `from its own reply and never makes the read that just failed. ` +
+                `Find out with install_comfyui (action:"panel", panel_action:"status"). If it is ` +
+                `older, update with install_comfyui (action:"panel", panel_action:"sync"), restart ` +
+                `ComfyUI, and HARD-REFRESH the browser tab (Ctrl+Shift+R) — a pack update that ` +
+                `ComfyUI-Manager reported as FAILED leaves the old panel JS running in the open tab, ` +
+                `so a restart alone does not pick it up.`);
+        }
         if (!v?.tooOld)
             return "";
         return (`
@@ -5694,7 +5726,22 @@ export function makePanelToolCtx(bridge, tabId, workflowTargets) {
             // for a retry in a moment; the section lasts a fraction of a second, which
             // is what retrySettleMs already waits. Still gated on RETRY-SAFE commands,
             // so a mutation is never re-issued on our own initiative.
-            if (isRetrySafeCmd(cmd) && (isTransientReconnectError(err) || isWorkflowSwitchGuardRefusal(err))) {
+            // #1529 — a PRE-EXECUTOR refusal is retryable even for a MUTATION.
+            //
+            // Every other branch here is gated on RETRY_SAFE_CMDS precisely because a
+            // mutation might have landed before the failure, and re-issuing it would
+            // double-apply. That reasoning does not hold for this one: the panel's
+            // reconnect gate runs BEFORE its executor, and says so in a structured field
+            // (`applied:false, stage:"pre-executor"`) rather than in prose. Nothing ran,
+            // so there is nothing to double-apply — which is the entire point of the
+            // channel, and why it is keyed on the FIELD and never on the message text.
+            //
+            // The refusal is the panel's own claim about its own execution, validated on
+            // arrival; an older panel sends no field, `preExecutorRefusal` is null, and
+            // this branch simply never fires.
+            const preExecutorRefusal = isPreExecutorRefusal(err);
+            if (preExecutorRefusal ||
+                (isRetrySafeCmd(cmd) && (isTransientReconnectError(err) || isWorkflowSwitchGuardRefusal(err)))) {
                 // panel#1097 — declared out here so the refusal branch below can see it,
                 // and REASSIGNED after ensureReachable so it names the tab the command is
                 // actually dispatched on. Reading it before the rebind attributed a refusal