comfyui-mcp 0.50.53 → 0.50.55

package/dist/orchestrator/panel-tools.js

@@ -2329,6 +2329,36 @@ async function unreadableOrHealed(ctx, before, detail) {
     }
     return { status: "unreadable", before, detail };
 }
+/**
+ * The version-gap sentence for a fence rebind that failed on an OLD panel (#1043).
+ *
+ * Empty string when the panel is new enough, or when its version is unknown —
+ * an unproven version must never be narrated as "yours is too old", which would
+ * send someone to update a panel that is already current. That is the same
+ * three-state discipline the rest of this file runs on.
+ *
+ * Never throws: this decorates an error path, and a decoration that fails must
+ * not replace the diagnosis it was meant to improve.
+ */
+function panelTooOldNote(ctx) {
+    try {
+        const v = ctx.bridge?.panelTooOldForReplyUuid?.(ctx.tabId);
+        if (!v?.tooOld)
+            return "";
+        return (`
+
+WHY THIS READ WAS NEEDED AT ALL: this session's panel is ${v.version}, and a ` +
+            `panel only reports the new workflow's identity ON THE REPLY from ${v.needed} ` +
+            `onwards. On ${v.needed}+ the command that re-pointed the canvas repairs the ` +
+            `fence from its own reply and never makes this read — so UPDATING THE PANEL ` +
+            `to ${v.needed} or later removes this failure rather than working around it. ` +
+            `Update it with install_comfyui (action:"panel", panel_action:"sync"), then ` +
+            `restart ComfyUI.`);
+    }
+    catch {
+        return "";
+    }
+}
 async function rebindWorkflowFence(ctx) {
     const tabAtStart = ctx.tabId;
     let before = currentWorkflowFence(ctx);
@@ -2468,7 +2498,14 @@ function describeFenceRebind(r, canMutate,
  * both yield `canMutate:false` but need opposite advice, and narrating the
  * first as the second is a bucket standing in for a cause (codex gate P1).
  */
-refusalCause) {
+refusalCause, 
+/**
+ * #1043 — the version-gap sentence, when the connected panel is PROVABLY too
+ * old to publish the reply uuid this rebind exists to avoid needing. Passed in
+ * rather than looked up: this renderer is pure, and keeping it that way is what
+ * makes its wording testable without a bridge.
+ */
+panelGapNote = "") {
     // A panel that cannot fence a WRITE gives reads only, however good the stamp is.
     const mutationsRefused = canMutate === false;
     const mutationsUnknown = canMutate === undefined;
@@ -2619,6 +2656,19 @@ refusalCause) {
                 binding: "not_recovered",
                 note: ` Could NOT read the live canvas identity — the panel did not answer, so NOTHING ` +
                     `about this session's graph binding was observed.` +
+                    // #1043 — NAME THE VERSION GAP when that is what this is.
+                    //
+                    // The repair that would have avoided this read entirely
+                    // (refreshFenceFromOwnReply, #1161) trusts a workflow_uuid the panel
+                    // only publishes from 0.11.45. Three reports — #1043, #1077, #1174 —
+                    // deadlocked here on OLDER panels: the fix is present and inert, and
+                    // the message said only "could not be read", which reads as a mystery
+                    // rather than as "update the panel".
+                    //
+                    // Only a PARSEABLE version below the minimum says this; an unknown
+                    // version stays quiet rather than telling someone to update a panel
+                    // that may already be current.
+                    panelGapNote +
                     // THREE states, not two (codex gate). "We could not read the existing
                     // fence either" must not render as "it has no fence" — that absence was
                     // never observed, and it is the same fold one level down.
@@ -7158,7 +7208,7 @@ export function buildPanelToolDefs() {
                 canMutateNow = undefined;
                 refusalCause = undefined;
             }
-            const fence = describeFenceRebind(fenceRebind, canMutateNow, refusalCause);
+            const fence = describeFenceRebind(fenceRebind, canMutateNow, refusalCause, panelTooOldNote(ctx));
             if (!fence || fence.binding === "bound")
                 return res;
             return appendNote(res, `The workflow WAS saved.${fence.note}`);
@@ -7397,6 +7447,19 @@ export function buildPanelToolDefs() {
                 canMutateNow = undefined; // a guard that can throw is not a guard
                 refusalCause = undefined;
             }
+            // #1043 (codex review) — NO version note on THIS path, deliberately.
+            //
+            // The note claims that on 0.11.45+ "the command that re-pointed the canvas
+            // repairs the fence from its own reply and never makes this read". That is
+            // true of panel_save_workflow and panel_new_workflow, which DO carry a
+            // workflow_uuid on their reply. panel_set_workflow_target does not — it has
+            // no own-reply uuid to gain, so updating the panel would NOT remove this
+            // failure, and saying it would is a confident wrong remedy.
+            //
+            // A user may well have arrived here recovering from a save/new that hit the
+            // gap — but arriving here does not establish that, and guessing which of
+            // the two it was is exactly the kind of unearned claim this file exists to
+            // avoid. The save/new paths say it at the moment it is provable.
             const fence = fenceRebind
                 ? describeFenceRebind(fenceRebind, canMutateNow, refusalCause)
                 : undefined;
@@ -7460,7 +7523,7 @@ export function buildPanelToolDefs() {
                 canMutateNow = undefined; // a guard that can throw is not a guard
                 refusalCause = undefined;
             }
-            const fence = describeFenceRebind(fenceRebind, canMutateNow, refusalCause);
+            const fence = describeFenceRebind(fenceRebind, canMutateNow, refusalCause, panelTooOldNote(ctx));
             if (!fence || fence.binding === "bound")
                 return res;
             return appendNote(res, `The blank workflow WAS created.${fence.note}`);