comfyui-mcp 0.50.2 → 0.50.3

package/dist/orchestrator/panel-tools.js

@@ -25,7 +25,7 @@
 import { z } from "zod";
 import { randomUUID } from "node:crypto";
 import { existsSync, readdirSync, readFileSync, realpathSync, statSync } from "node:fs";
-import { forwardedByReferenceNote, oversizedInlineRefusal, resolveServableViewRef, } from "../services/comfy-view-ref.js";
+import { forwardedByReferenceNote, oversizedInlineRefusal, resolveServableViewRef, unverifiedViewRefNote, } from "../services/comfy-view-ref.js";
 import { extname, isAbsolute, join, resolve, sep } from "node:path";
 import { fileURLToPath } from "node:url";
 import { comfyuiFetch } from "../comfyui/fetch.js";
@@ -33,7 +33,7 @@ import { assertPanelNotTargetedUnverifiable } from "../services/panel-pin-guard.
 import { nodesInstallCommandArgs } from "../services/node-management.js";
 import { createSdkMcpServer, tool } from "@anthropic-ai/claude-agent-sdk";
 import { parse as parseYaml } from "yaml";
-import { conversationOfScopeAddress, isScopeAddress } from "../services/session-scope.js";
+import { conversationOfScopeAddress, isScopeAddress, shortTabId } from "../services/session-scope.js";
 /** #884 — journal TICKETS (run completions #468, ask answers #486) must be
  *  keyed by the REAL tab a run/card was routed to: the panel reports back under
  *  that tab id, and a ticket keyed by the shared scope address a tool ctx is
@@ -6606,7 +6606,12 @@ export function buildPanelToolDefs() {
                 // Detect the rebind regardless of whether awaitReachable or rebindToActiveTab
                 // performed it (either mutates ctx.tabId), so the note is never swallowed.
                 if (!deferredBind && ctx.tabId !== before) {
-                    rebindNote = ` Rebound this session from tab ${before.slice(0, 8)} onto the active tab ${ctx.tabId.slice(0, 8)}.`;
+                    // #934 — `.slice(0, 8)` renders EVERY `wf:workflows/…` tab as the
+                    // literal "wf:workf", so this note read "Rebound this session from
+                    // tab wf:workf onto the active tab wf:workf" for a rebind between two
+                    // DIFFERENT workflows. In the middle of a wedge whose entire question
+                    // was whether the retarget did anything, it read as a no-op.
+                    rebindNote = ` Rebound this session from tab ${shortTabId(before)} onto the active tab ${shortTabId(ctx.tabId)}.`;
                 }
             }
             // PIN: bind to the EXACT open-workflow identity from the authoritative
@@ -7795,6 +7800,10 @@ export function buildPanelToolDefs() {
             const resolved = [];
             /** Oversized items that took the /view reference route instead (#648). */
             const forwarded = [];
+            // #941 — /view references handed to a BROWSER panel, whose rendering this
+            // process never observes. Collected so the reply can say what "painted"
+            // does and does not establish.
+            const unverifiedRefs = [];
             for (const item of items) {
                 const src = item.source;
                 if ("path" in src) {
@@ -7942,6 +7951,15 @@ export function buildPanelToolDefs() {
                             filename: src.filename,
                             caption: item.caption,
                         });
+                        // #941 — the panel will report this as painted, meaning it made a
+                        // card. Whether the IMAGE loads is decided later, by the browser's
+                        // own /view fetch, and a proxied ComfyUI answering HTML breaks it
+                        // with no error anywhere. Remember the ref so the reply can say so.
+                        unverifiedRefs.push({
+                            filename: src.filename,
+                            subfolder: src.subfolder,
+                            type: src.type,
+                        });
                     }
                 }
             }
@@ -7956,6 +7974,43 @@ export function buildPanelToolDefs() {
                     text: forwardedByReferenceNote(forwarded, MAX_BYTES),
                 });
             }
+            // #941 — a forwarded /view reference is DISPATCHED, not displayed. Probe a
+            // bounded sample from here so the note can carry evidence instead of only
+            // a caveat; the probe is best-effort and never affects the result.
+            if (unverifiedRefs.length > 0 && !res.isError) {
+                const probe = { checked: 0, nonMedia: [] };
+                const base = (process.env.COMFYUI_URL ?? "http://127.0.0.1:8188").replace(/\/+$/, "");
+                for (const ref of unverifiedRefs.slice(0, 3)) {
+                    try {
+                        const qs = new URLSearchParams({ filename: ref.filename, type: ref.type ?? "output" });
+                        if (ref.subfolder)
+                            qs.set("subfolder", ref.subfolder);
+                        const resp = await comfyuiFetch(`${base}/view?${qs.toString()}`, {
+                            method: "HEAD",
+                            signal: AbortSignal.timeout(4000),
+                        });
+                        probe.checked++;
+                        const mime = resp.headers.get("content-type") ?? "";
+                        if (!resp.ok) {
+                            probe.nonMedia.push({ filename: ref.filename, detail: `HTTP ${resp.status}` });
+                        }
+                        else if (!mime.startsWith("image/") && !mime.startsWith("video/")) {
+                            probe.nonMedia.push({
+                                filename: ref.filename,
+                                detail: `content-type "${mime || "unset"}"`,
+                            });
+                        }
+                    }
+                    catch {
+                        // An unreachable /view from HERE says nothing reliable about the
+                        // browser's origin, so it is simply not counted as checked.
+                    }
+                }
+                res.content.push({
+                    type: "text",
+                    text: unverifiedViewRefNote(unverifiedRefs, probe),
+                });
+            }
             return res;
         }),
         def("panel_ui_render", "Render an INTERACTIVE UI CARD in the panel chat from an A2UI-subset JSON spec — choice buttons, forms (TextField/Select/Checkbox + a submit Button), node-wiring diagrams (comfy:graph), and bar/line charts (comfy:chart). Use a card whenever the user must pick between options, confirm a plan, fill in parameters, or would understand a wiring explanation better as a diagram. The card is non-blocking: this returns { card_id } immediately; when the user clicks a button (or submits a form) their choice arrives as a NORMAL chat message (the button's `reply` text; submit buttons append 'name: value' lines) — so after rendering a card that asks a question, END YOUR TURN and wait. Set surface:'wide' for diagram-heavy cards (the panel widens and restores automatically). Spec shape: { surface?, title?, root: '<id>', components: [ {id, type, ...} ] } with children referenced by id. Types: Text{text}, Heading{text,level?}, Button{label,reply?,submit?,style?:'primary'|'secondary'}, Row/Column/Card{children:[ids]}, Divider, Image{src:/view-URL,caption?}, TextField{label,name,value?,placeholder?}, Select{label,name,options:[{label,value?}],value?}, Checkbox{label,name,checked?}, 'comfy:graph'{nodes:[{id,label,color?}],edges:[{from,to,label?}],direction?:'lr'|'tb'}, 'comfy:chart'{kind:'bar'|'line',series:[{label,values:[num]}],x?:[labels]}. Caps: ≤64 components, ≤30 graph nodes, ≤8×256 chart points. On a validation error, FIX the spec and retry.", {