com.wallstop-studios.unity-helpers 2.0.0-rc81.9 → 2.0.0

package/Tests/Runtime/Utils/CoroutineHandlerTests.cs

@@ -20,7 +20,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Utils
             Track(instance.gameObject);
 
             Assert.IsTrue(CoroutineHandler.HasInstance);
-            Assert.IsNotNull(instance);
+            Assert.IsTrue(instance != null);
             yield return null;
         }
 

package/Tests/Runtime/Utils/LZMAComprehensiveTests.cs

@@ -11,7 +11,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Utils
         public void RoundtripVariousSizes()
         {
             Random random = new(12345);
-            int[] sizes = new[] { 0, 1, 3, 5, 32, 64, 257, 1024, 4096 };
+            int[] sizes = { 0, 1, 3, 5, 32, 64, 257, 1024, 4096 };
             foreach (int length in sizes)
             {
                 byte[] data = new byte[length];

package/Tests/Runtime/Utils/LZMATests.cs

@@ -24,7 +24,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Utils
         [Test]
         public void DecompressingGarbageThrows()
         {
-            byte[] garbage = new byte[] { 1, 2, 3, 4, 5 };
+            byte[] garbage = { 1, 2, 3, 4, 5 };
             Assert.Throws<Exception>(() => LZMA.Decompress(garbage));
         }
     }

package/Tests/Runtime/Utils/MatchColliderToSpriteTests.cs

@@ -24,7 +24,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Utils
             );
 
             // Define a physics shape for the sprite (a simple rectangle)
-            Vector2[] physicsShape = new[]
+            Vector2[] physicsShape =
             {
                 new Vector2(-0.5f, -0.5f),
                 new Vector2(-0.5f, 0.5f),

package/Tests/Runtime/Visuals/EnhancedImageTests.cs

@@ -1,6 +1,5 @@
 namespace WallstopStudios.UnityHelpers.Tests.Visuals
 {
-    using System.Reflection;
     using NUnit.Framework;
     using UnityEngine;
     using WallstopStudios.UnityHelpers.Core.Helper;
@@ -17,10 +16,10 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
             EnhancedImage image = CreateEnhancedImage(out Material baseMaterial);
             image.color = new Color(0.2f, 0.4f, 0.6f, 0.8f);
 
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
             Material cached = image.material;
-            Assert.That(cached, Is.Not.Null);
+            Assert.IsTrue(cached != null);
             Assert.AreNotSame(baseMaterial, cached);
             Assert.IsTrue(cached.GetColor("_Color").Approximately(image.color));
         }
@@ -29,13 +28,13 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
         public void HdrColorAboveSdrOverridesMaterialColor()
         {
             EnhancedImage image = CreateEnhancedImage(out _);
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
             Color hdr = new(2f, 0.5f, 0.25f, 1f);
             image.HdrColor = hdr;
 
             Material cached = image.material;
-            Assert.That(cached, Is.Not.Null);
+            Assert.IsTrue(cached != null);
             Assert.IsTrue(cached.GetColor("_Color").Approximately(hdr));
         }
 
@@ -45,11 +44,9 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
             EnhancedImage image = CreateEnhancedImage(out _);
             Texture2D mask = Track(new Texture2D(4, 4, TextureFormat.RGBA32, false, false));
 
-            typeof(EnhancedImage)
-                .GetField("_shapeMask", BindingFlags.Instance | BindingFlags.NonPublic)
-                ?.SetValue(image, mask);
+            image._shapeMask = mask;
 
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
             Texture maskInMaterial = image.material.GetTexture("_ShapeMask");
             Assert.That(maskInMaterial, Is.SameAs(mask));
@@ -59,21 +56,15 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
         public void OnDestroyReleasesCachedMaterialInstance()
         {
             EnhancedImage image = CreateEnhancedImage(out _);
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
-            FieldInfo cachedField = typeof(EnhancedImage).GetField(
-                "_cachedMaterialInstance",
-                BindingFlags.Instance | BindingFlags.NonPublic
-            );
-            Assert.That(cachedField, Is.Not.Null);
-
-            Material cachedBefore = (Material)cachedField.GetValue(image);
-            Assert.That(cachedBefore, Is.Not.Null);
+            Material cachedBefore = image.CachedMaterialInstanceForTests;
+            Assert.IsTrue(cachedBefore != null);
 
-            InvokeLifecycle(image, "OnDestroy");
+            image.InvokeOnDestroyForTests();
 
-            Material cachedAfter = (Material)cachedField.GetValue(image);
-            Assert.That(cachedAfter, Is.Null);
+            Material cachedAfter = image.CachedMaterialInstanceForTests;
+            Assert.IsTrue(cachedAfter == null);
             Assert.That(cachedBefore == null, Is.True);
         }
 
@@ -83,17 +74,11 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
             EnhancedImage image = CreateEnhancedImage(out _);
             image.material = null;
 
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
-            FieldInfo field = typeof(EnhancedImage).GetField(
-                "_cachedMaterialInstance",
-                BindingFlags.Instance | BindingFlags.NonPublic
-            );
-            Assert.That(field, Is.Not.Null);
-            Material cached = (Material)field.GetValue(image);
-            Assert.That(
-                cached,
-                Is.Null,
+            Material cached = image.CachedMaterialInstanceForTests;
+            Assert.IsTrue(
+                cached == null,
                 "Expected no instance to be created when material is null."
             );
         }
@@ -105,10 +90,10 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
             image.color = new Color(0.1f, 0.2f, 0.3f, 0.9f);
             image.HdrColor = new Color(0.4f, 0.4f, 0.4f, 0.4f);
 
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
 
             Material cached = image.material;
-            Assert.That(cached, Is.Not.Null);
+            Assert.IsTrue(cached != null);
             Assert.AreNotSame(baseMaterial, cached);
             Assert.IsTrue(
                 cached.GetColor("_Color").Approximately(image.color),
@@ -120,9 +105,9 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
         public void MaterialInstanceIsReusedAcrossUpdates()
         {
             EnhancedImage image = CreateEnhancedImage(out _);
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
             Material first = image.material;
-            Assert.That(first, Is.Not.Null);
+            Assert.IsTrue(first != null);
 
             image.HdrColor = new Color(1.1f, 0.2f, 0.3f, 1f);
             Material second = image.material;
@@ -137,11 +122,11 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
         public void StartDoesNotDuplicateExistingInstance()
         {
             EnhancedImage image = CreateEnhancedImage(out _);
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
             Material first = image.material;
-            Assert.That(first, Is.Not.Null);
+            Assert.IsTrue(first != null);
 
-            InvokeLifecycle(image, "Start");
+            image.InvokeStartForTests();
             Material second = image.material;
             Assert.That(
                 second,
@@ -153,11 +138,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
         private EnhancedImage CreateEnhancedImage(out Material baseMaterial)
         {
             Shader shader = Shader.Find("UI/Default");
-            Assert.That(
-                shader,
-                Is.Not.Null,
-                "Expected UI/Default shader to be available for tests."
-            );
+            Assert.IsTrue(shader != null, "Expected UI/Default shader to be available for tests.");
 
             baseMaterial = Track(new Material(shader));
 
@@ -167,18 +148,6 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
             return image;
         }
 
-        private static void InvokeLifecycle(EnhancedImage image, string methodName)
-        {
-            MethodInfo method = typeof(EnhancedImage).GetMethod(
-                methodName,
-                BindingFlags.Instance | BindingFlags.NonPublic
-            );
-            Assert.That(
-                method,
-                Is.Not.Null,
-                $"Expected method {methodName} to exist on EnhancedImage."
-            );
-            method.Invoke(image, null);
-        }
+        // No reflection lifecycle helpers needed; use internal wrappers on EnhancedImage
     }
 }

package/Tests/Runtime/Visuals/VisualsTestHelpers.cs

@@ -67,14 +67,7 @@ namespace WallstopStudios.UnityHelpers.Tests.Visuals
 
         public static Texture2D[] GetComputedTextures(LayeredImage image, List<Object> tracked)
         {
-            Texture2D[] computed = (Texture2D[])
-                typeof(LayeredImage)
-                    .GetField(
-                        "_computed",
-                        System.Reflection.BindingFlags.NonPublic
-                            | System.Reflection.BindingFlags.Instance
-                    )
-                    .GetValue(image);
+            Texture2D[] computed = image?.ComputedTexturesForTests;
 
             foreach (Texture2D texture in computed)
             {

package/package-lock.json.meta

@@ -0,0 +1,7 @@
+fileFormatVersion: 2
+guid: eb975aaa9a7b55842a63ac0105034aa4
+TextScriptImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.wallstop-studios.unity-helpers",
-  "version": "2.0.0-rc81.9",
+  "version": "2.0.0",
   "displayName": "Unity Helpers",
   "description": "Various Unity Helper Library",
   "dependencies": {},
@@ -84,12 +84,16 @@
     "format:md:check": "prettier --check \"**/*.{md,markdown}\"",
     "format:json": "prettier --write \"**/*.{json,asmdef,asmref}\"",
     "format:json:check": "prettier --check \"**/*.{json,asmdef,asmref}\"",
+    "format:yaml": "prettier --write \"**/*.{yml,yaml}\"",
+    "format:yaml:check": "prettier --check \"**/*.{yml,yaml}\"",
     "lint:markdown": "markdownlint \"**/*.md\" \"**/*.markdown\" --config .markdownlint.json --ignore-path .markdownlintignore",
-    "validate:content": "npm run lint:docs && npm run lint:markdown && npm run format:md:check && npm run format:json:check",
+    "validate:content": "npm run lint:docs && npm run lint:markdown && npm run format:md:check && npm run format:json:check && npm run format:yaml:check",
+    "validate:prepush": "npm run validate:content && npm run eol:check && npm run lint:tests",
+    "lint:tests": "pwsh -NoProfile -File scripts/lint-tests.ps1 -VerboseOutput",
     "prepublishOnly": "npm run validate:content"
   },
   "devDependencies": {
-    "markdownlint-cli": "^0.40.0",
-    "prettier": "^3.3.3"
+    "markdownlint-cli": "^0.45.0",
+    "prettier": "3.6.2"
   }
 }

package/scripts/check-eol.ps1

@@ -24,10 +24,10 @@ $bomIssues = New-Object System.Collections.Generic.List[string]
 
 foreach ($path in Get-TrackedFiles) {
     try { $bytes = [System.IO.File]::ReadAllBytes($path) } catch { continue }
-    # BOM
+    # BOM (flag any file that contains a UTF-8 BOM — we require NO BOM)
     $hasBom = $false
     if ($bytes.Length -ge 3) { $hasBom = ($bytes[0] -eq 0xEF -and $bytes[1] -eq 0xBB -and $bytes[2] -eq 0xBF) }
-    if (-not $hasBom) { $bomIssues.Add($path) | Out-Null }
+    if ($hasBom) { $bomIssues.Add($path) | Out-Null }
     # CRLF check
     $hasLfOnly = $false
     for ($i = 0; $i -lt $bytes.Length; $i++) {
@@ -41,12 +41,11 @@ if ($VerboseOutput) {
         Write-Host "LF-only or mixed EOL files:"; $lfIssues | Sort-Object -Unique | ForEach-Object { " - $_" }
     }
     if ($bomIssues.Count -gt 0) {
-        Write-Host "Missing UTF-8 BOM:"; $bomIssues | Sort-Object -Unique | ForEach-Object { " - $_" }
+        Write-Host "Contains UTF-8 BOM (disallowed):"; $bomIssues | Sort-Object -Unique | ForEach-Object { " - $_" }
     }
 }
 
 Write-Host "LF issues: $($lfIssues | Sort-Object -Unique | Measure-Object | % Count)"
-Write-Host "Missing BOM: $($bomIssues | Sort-Object -Unique | Measure-Object | % Count)"
+Write-Host "Files with BOM: $($bomIssues | Sort-Object -Unique | Measure-Object | % Count)"
 
 if ($lfIssues.Count -gt 0 -or $bomIssues.Count -gt 0) { exit 3 }
-

package/scripts/lint-tests.ps1

@@ -0,0 +1,156 @@
+Param(
+  [switch]$VerboseOutput
+)
+
+Set-StrictMode -Version Latest
+$ErrorActionPreference = 'Stop'
+
+function Write-Info($msg) {
+  if ($VerboseOutput) { Write-Host "[lint-tests] $msg" -ForegroundColor Cyan }
+}
+
+# Heuristics and allowlists
+$testRoots = @('Tests')
+$allowedHelperFiles = @(
+  'Tests/Runtime/Visuals/VisualsTestHelpers.cs'
+)
+
+$destroyPattern = [regex]'(?<!UNH-SUPPRESS).*\b(?:UnityEngine\.)?Object\.(?:DestroyImmediate|Destroy)\s*\((?<arg>[^)]*)\)'
+$createAssignObjectPattern = [regex]'(?<var>\b\w+)\s*=\s*new\s+(?<type>GameObject|Texture2D|Material|Mesh|Camera)\s*\('
+$createInlineTrackPattern = [regex]'\bTrack\s*\(\s*new\s+(?:GameObject|Texture2D|Material|Mesh|Camera)\s*\('
+$createSoAssignPattern = [regex]'(?<var>\b\w+)\s*=\s*ScriptableObject\.CreateInstance\s*<'
+
+# Returns true if line contains an allowlisted helper file path
+function Is-AllowlistedFile([string]$relPath) {
+  foreach ($a in $allowedHelperFiles) {
+    if ($relPath -replace '\\','/' -ieq $a) { return $true }
+  }
+  return $false
+}
+
+function Get-RelativePath([string]$path) {
+  $root = (Get-Location).Path
+  return ($path.Substring($root.Length).TrimStart([System.IO.Path]::DirectorySeparatorChar))
+}
+
+$violations = @()
+
+foreach ($root in $testRoots) {
+  if (-not (Test-Path $root)) { continue }
+  Get-ChildItem -Recurse -Include *.cs -Path $root | ForEach-Object {
+    $file = $_.FullName
+    $rel = Get-RelativePath $file
+    $content = Get-Content $file
+    $text = $content -join "`n"
+
+    if (Is-AllowlistedFile $rel) {
+      return
+    }
+
+    # Skip meta or non-source
+    if ($file -like '*.meta') { return }
+
+    # Check destroy calls; allow if argument var was tracked earlier in file
+    $lineIndex = 0
+    foreach ($line in $content) {
+      $lineIndex++
+      if ($destroyPattern.IsMatch($line)) {
+        $m = $destroyPattern.Match($line)
+        $arg = ($m.Groups['arg'].Value).Trim()
+        # Extract variable token before any commas or closing paren
+        $varName = $arg -replace ',.*','' -replace '\)',''
+        $allowed = $false
+        if (-not [string]::IsNullOrWhiteSpace($varName)) {
+          # Search up to 100 lines above for Track(varName)
+          $searchStart = [Math]::Max(0, $lineIndex - 100)
+          for ($i = $searchStart; $i -lt $lineIndex; $i++) {
+            if ($content[$i] -match "Track\s*\(\s*$varName\b") { $allowed = $true; break }
+          }
+        }
+        if (-not $allowed) {
+          $violations += (@{
+            Path=$rel; Line=$lineIndex; Message="UNH001: Avoid direct destroy in tests; track object and let teardown clean up (or add // UNH-SUPPRESS)"
+          })
+        }
+      }
+    }
+
+    # Check untracked new allocations via assignment (var = new Type(...))
+    $assignMatches = $createAssignObjectPattern.Matches($text)
+    foreach ($am in $assignMatches) {
+      $var = $am.Groups['var'].Value
+      if ([string]::IsNullOrWhiteSpace($var)) { continue }
+      # Find the index of this match in terms of line
+      $prefix = $text.Substring(0, $am.Index)
+      $lineNo = ($prefix -split "`n").Length
+      # Look ahead 10 lines for Track(var)
+      $endLine = [Math]::Min($content.Count, $lineNo + 10)
+      $found = $false
+      for ($j = $lineNo; $j -le $endLine; $j++) {
+        if ($content[$j-1] -match "Track\s*\(\s*$var\b") { $found = $true; break }
+      }
+      if (-not $found) {
+        $violations += (@{
+          Path=$rel; Line=$lineNo; Message="UNH002: Unity object allocation should be tracked: add Track($var)"
+        })
+      }
+    }
+
+    # Check inline Track(new ...) OK; but find bare inline new ... in args without Track
+    if ($text -match '\bnew\s+(GameObject|Texture2D|Material|Mesh|Camera)\s*\(') {
+      # If Track(new ...) not present at all, flag a generic warning at file level
+      if (-not $createInlineTrackPattern.IsMatch($text)) {
+        # locate first occurrence for line number
+        $m = [regex]::Match($text, '\bnew\s+(GameObject|Texture2D|Material|Mesh|Camera)\s*\(')
+        $lineNo = (($text.Substring(0, $m.Index)) -split "`n").Length
+        $violations += (@{
+          Path=$rel; Line=$lineNo; Message="UNH002: Inline Unity object creation should be passed to Track(new …)"
+        })
+      }
+    }
+
+    # Check ScriptableObject.CreateInstance<T>() assigned, ensure tracked
+    $soMatches = $createSoAssignPattern.Matches($text)
+    foreach ($sm in $soMatches) {
+      $var = $sm.Groups['var'].Value
+      if ([string]::IsNullOrWhiteSpace($var)) { continue }
+      $prefix = $text.Substring(0, $sm.Index)
+      $lineNo = ($prefix -split "`n").Length
+      $found = $false
+      $endLine = [Math]::Min($content.Count, $lineNo + 10)
+      for ($j = $lineNo; $j -le $endLine; $j++) {
+        if ($content[$j-1] -match "Track\s*\(\s*$var\b") { $found = $true; break }
+      }
+      if (-not $found) {
+        $violations += (@{
+          Path=$rel; Line=$lineNo; Message="UNH002: ScriptableObject instance should be tracked: add Track($var)"
+        })
+      }
+    }
+
+    # Enforce CommonTestBase inheritance only if file creates Unity objects and is under Runtime/ or Editor/
+    $createsUnity = ($assignMatches.Count -gt 0) -or ($text -match '\bnew\s+(GameObject|Texture2D|Material|Mesh|Camera)\s*\(') -or ($soMatches.Count -gt 0)
+    if ($createsUnity) {
+      $usesBase = ($text -match ':\s*CommonTestBase')
+      if (-not $usesBase) {
+        # Only enforce for test classes; skip helper-only files
+        if ($text -match '\bnamespace\s+WallstopStudios') {
+          $violations += (@{
+            Path=$rel; Line=1; Message="UNH003: Test classes creating Unity objects should inherit CommonTestBase (Editor or Runtime variant)"
+          })
+        }
+      }
+    }
+  }
+}
+
+if ($violations.Count -gt 0) {
+  Write-Host "Test lifecycle lint failed:" -ForegroundColor Red
+  foreach ($v in $violations) {
+    Write-Host ("{0}:{1}: {2}" -f $v.Path, $v.Line, $v.Message) -ForegroundColor Yellow
+  }
+  exit 1
+} else {
+  Write-Info "No issues found in test code."
+}
+

package/scripts/lint-tests.ps1.meta

@@ -0,0 +1,7 @@
+fileFormatVersion: 2
+guid: 7e3d3f61549d89e47b9d98c36a04b816
+DefaultImporter:
+  externalObjects: {}
+  userData: 
+  assetBundleName: 
+  assetBundleVariant: 

package/scripts/normalize-eol.ps1

@@ -28,7 +28,7 @@ function To-CrLf([string]$text) {
 
 $changed = 0
 $eolFixed = 0
-$bomAdded = 0
+$bomRemoved = 0
 $modified = New-Object System.Collections.Generic.List[string]
 
 $tracked = Get-TrackedFiles
@@ -50,15 +50,13 @@ foreach ($path in $tracked) {
 
     $fileChanged = $false
     if ($normalized -ne $text) { $fileChanged = $true; $eolFixed++ }
-    if (-not $hasBom) { $fileChanged = $true; $bomAdded++ }
+    # Remove BOM if present (we enforce UTF-8 without BOM)
+    if ($hasBom) { $fileChanged = $true; $bomRemoved++ }
 
     if ($fileChanged) {
         if (-not $DryRun) {
-            $out = New-Object System.Collections.Generic.List[byte]
-            # UTF-8 BOM
-            $out.AddRange([byte[]](0xEF,0xBB,0xBF))
-            $out.AddRange([System.Text.Encoding]::UTF8.GetBytes($normalized))
-            [System.IO.File]::WriteAllBytes($path, $out.ToArray())
+            # Write UTF-8 without BOM
+            [System.IO.File]::WriteAllBytes($path, [System.Text.Encoding]::UTF8.GetBytes($normalized))
         }
         $changed++
         $modified.Add($path) | Out-Null
@@ -66,6 +64,5 @@ foreach ($path in $tracked) {
     }
 }
 
-Write-Host "Files fixed: $changed (EOL:$eolFixed, BOM:$bomAdded)"
+Write-Host "Files fixed: $changed (EOL:$eolFixed, BOMRemoved:$bomRemoved)"
 if ($DryRun -and $changed -gt 0) { exit 2 }
-

package/.github/workflows/csharpier.yml

@@ -1,135 +0,0 @@
-name: CSharpier
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-
-permissions:
-  contents: read
-  pull-requests: write
-
-jobs:
-  format-check:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Setup .NET SDK
-        uses: actions/setup-dotnet@v4
-        with:
-          dotnet-version: '8.0.x'
-
-      - name: Restore dotnet tools
-        run: dotnet tool restore
-
-      - name: CSharpier check
-        id: csharpier_check
-        run: |
-          dotnet tool run csharpier check .
-        continue-on-error: true
-
-      - name: Generate CSharpier diff
-        if: ${{ steps.csharpier_check.outcome == 'failure' }}
-        run: |
-          echo "Formatting issues detected. Generating diff..."
-          dotnet tool run csharpier format .
-          git config user.email "actions@github.com"
-          git config user.name "github-actions[bot]"
-          git diff > csharpier.patch || true
-          # Provide a concise summary, too
-          git status --porcelain > csharpier_changed_files.txt
-
-      - name: Skip PR comment on fork
-        if: ${{ github.event_name == 'pull_request' && steps.csharpier_check.outcome == 'failure' && github.event.pull_request.head.repo.fork }}
-        run: |
-          echo "Forked PR detected; skipping sticky PR comment due to restricted permissions. Full diff uploaded as artifact."
-          {
-            echo "## CSharpier Formatting Issues Detected"
-            echo ""
-            echo "- PR is from a fork; comment skipped due to token restrictions."
-            echo "- Full diff uploaded as artifact 'csharpier-diff'."
-          } >> $GITHUB_STEP_SUMMARY
-
-      - name: Read diff for comment
-        if: ${{ github.event_name == 'pull_request' && steps.csharpier_check.outcome == 'failure' && !github.event.pull_request.head.repo.fork }}
-        id: read_diff
-        shell: bash
-        run: |
-          # Limit diff size in comment to ~60KB to avoid API limits
-          max=60000
-          content=$(cat csharpier.patch)
-          if [ ${#content} -gt $max ]; then
-            echo "diff<<EOF" >> $GITHUB_OUTPUT
-            echo "(Diff too large for inline comment. See attached artifact 'csharpier-diff'.)" >> $GITHUB_OUTPUT
-            echo EOF >> $GITHUB_OUTPUT
-          else
-            echo "diff<<EOF" >> $GITHUB_OUTPUT
-            printf '%s\n' "$content" >> $GITHUB_OUTPUT
-            echo EOF >> $GITHUB_OUTPUT
-          fi
-
-      - name: Post CSharpier suggestion comment
-        if: ${{ github.event_name == 'pull_request' && steps.csharpier_check.outcome == 'failure' && !github.event.pull_request.head.repo.fork }}
-        uses: marocchino/sticky-pull-request-comment@v2
-        with:
-          header: csharpier-formatting
-          message: |
-            CSharpier found formatting changes. This job is failing until formatting is applied.
-
-            To apply locally:
-            1) dotnet tool restore
-            2) dotnet tool run csharpier format .
-
-            Diff of proposed changes:
-
-            ```diff
-            ${{ steps.read_diff.outputs.diff }}
-            ```
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Attach full patch as artifact
-        if: ${{ steps.csharpier_check.outcome == 'failure' }}
-        uses: actions/upload-artifact@v4
-        with:
-          name: csharpier-diff
-          path: |
-            csharpier.patch
-            csharpier_changed_files.txt
-
-      - name: Job summary (formatting required)
-        if: ${{ steps.csharpier_check.outcome == 'failure' }}
-        run: |
-          {
-            echo "## CSharpier Formatting Required"
-            echo ""
-            echo "- The formatter detected changes that need to be applied."
-            echo "- Apply locally: dotnet tool restore && dotnet tool run csharpier format ."
-            echo "- Changed files and full patch are uploaded as 'csharpier-diff' artifact."
-          } >> $GITHUB_STEP_SUMMARY
-          if [ "${{ github.event_name }}" = "pull_request" ] && [ "${{ github.event.pull_request.head.repo.fork }}" = "true" ]; then
-            echo "- PR comment was skipped because this is a fork." >> $GITHUB_STEP_SUMMARY
-          fi
-
-      - name: Fail if formatting required
-        if: ${{ steps.csharpier_check.outcome == 'failure' }}
-        run: |
-          echo "CSharpier formatting required. Failing the job." 1>&2
-          exit 1
-
-      - name: Success summary
-        if: ${{ steps.csharpier_check.outcome == 'success' }}
-        run: |
-          echo "CSharpier check passed."
-          {
-            echo "## CSharpier Check Passed"
-            echo ""
-            echo "- No formatting changes required."
-          } >> $GITHUB_STEP_SUMMARY
-
-