com.wallstop-studios.unity-helpers 2.0.0-rc72 → 2.0.0-rc73

package/Runtime/Tags/AttributeEffect.cs

@@ -5,10 +5,12 @@
     using System.ComponentModel;
     using System.Linq;
     using System.Text;
+    using System.Text.Json.Serialization;
     using Core.Extension;
     using Core.Helper;
-    using Newtonsoft.Json;
+#if ODIN_INSPECTOR
     using Sirenix.OdinInspector;
+#endif
 
     [Serializable]
     public sealed class AttributeEffect :
@@ -219,7 +221,9 @@
 
                 for (int i = 0; i < effectTags.Count; ++i)
                 {
-                    if (effectTags[i] != other.effectTags[i])
+                    if (
+                        !string.Equals(effectTags[i], other.effectTags[i], StringComparison.Ordinal)
+                    )
                     {
                         return false;
                     }

package/Runtime/Tags/AttributeModification.cs

@@ -25,10 +25,7 @@
 
         public static bool operator ==(AttributeModification lhs, AttributeModification rhs)
         {
-            // ReSharper disable once CompareOfFloatsByEqualityOperator
-            return string.Equals(lhs.attribute, rhs.attribute)
-                && lhs.action == rhs.action
-                && lhs.value == rhs.value;
+            return lhs.Equals(rhs);
         }
 
         public override bool Equals(object obj)
@@ -36,16 +33,16 @@
             return obj is AttributeModification other && Equals(other);
         }
 
-        public override int GetHashCode()
-        {
-            return Objects.HashCode(attribute, action, value);
-        }
-
         public bool Equals(AttributeModification other)
         {
             return string.Equals(attribute, other.attribute, StringComparison.Ordinal)
                 && action == other.action
                 && value.Equals(other.value);
         }
+
+        public override int GetHashCode()
+        {
+            return Objects.HashCode(attribute, action, value);
+        }
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.wallstop-studios.unity-helpers",
-  "version": "2.0.0-rc72",
+  "version": "2.0.0-rc73",
   "displayName": "Unity Helpers",
   "description": "Various Unity Helper Library",
   "dependencies": {},