com.wallstop-studios.unity-helpers 1.0.1-rc10 → 1.0.1-rc12

package/Runtime/Core/Threading/SingleThreadedThreadPool.cs

@@ -6,18 +6,22 @@
 
     public sealed class SingleThreadedThreadPool : IDisposable
     {
+        public ConcurrentQueue<Exception> Exceptions => _exceptions;
+
         private int _active;
         private int _working;
         private Thread _worker;
         private readonly ConcurrentQueue<Action> _work;
         private AutoResetEvent _waitHandle;
         private bool _disposed;
+        private readonly ConcurrentQueue<Exception> _exceptions;
 
         public SingleThreadedThreadPool()
         {
             _active = 1;
             _working = 1;
             _work = new ConcurrentQueue<Action>();
+            _exceptions = new ConcurrentQueue<Exception>();
             _waitHandle = new AutoResetEvent(false);
             _worker = new Thread(DoWork);
             _worker.Start();
@@ -40,15 +44,16 @@
                     {
                         workItem();
                     }
-                    catch
+                    catch (Exception e)
                     {
-                        // Ignore (TODO: Log to some output function? The downside here is that this is in another thread, which means standard Unity logging is a no-go)
+                        _exceptions.Enqueue(e);
                     }
                 }
                 else
                 {
                     _ = _waitHandle.WaitOne(TimeSpan.FromSeconds(1));
                 }
+
                 _ = Interlocked.Exchange(ref _working, 0);
             }
         }
@@ -92,6 +97,7 @@
                 {
                     // Swallow
                 }
+
                 _waitHandle = null;
                 _worker = null;
             }
@@ -99,4 +105,4 @@
             _disposed = true;
         }
     }
-}
+}

package/Runtime/Utils/RuntimeSingleton.cs

@@ -1,11 +1,12 @@
 namespace UnityHelpers.Utils
 {
+    using System;
     using UnityEngine;
 
     [DisallowMultipleComponent]
     public abstract class RuntimeSingleton<T> : MonoBehaviour where T : RuntimeSingleton<T>
     {
-        private static T _instance;
+        protected static T _instance;
 
         protected virtual bool Preserve => true;
 
@@ -18,7 +19,8 @@
                     return _instance;
                 }
 
-                GameObject instance = new(typeof(T).Name + "Singleton", typeof(T));
+                Type type = typeof(T);
+                GameObject instance = new($"{type.Name}-Singleton", type);
                 if (instance.TryGetComponent(out _instance) && _instance.Preserve)
                 {
                     DontDestroyOnLoad(instance);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.wallstop-studios.unity-helpers",
-  "version": "1.0.1-rc10",
+  "version": "1.0.1-rc12",
   "displayName": "Unity Helpers",
   "description": "Various Unity Helper Library",
   "dependencies": {