com.wallstop-studios.dxmessaging 2.1.1 → 2.1.2

package/.github/workflows/dotnet-tests.yml

@@ -0,0 +1,72 @@
+name: dotnet-tests
+
+on:
+  push:
+    branches:
+      - master
+      - main
+      - develop
+  pull_request:
+    branches:
+      - "*"
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v3
+        with:
+          dotnet-version: "9.0.x"
+
+      - name: Install reportgenerator tool
+        run: |
+          dotnet tool install --global dotnet-reportgenerator-globaltool
+          echo "$HOME/.dotnet/tools" >> "$GITHUB_PATH"
+
+      - name: Restore
+        run: dotnet restore SourceGenerators/WallstopStudios.DxMessaging.SourceGenerators.Tests/WallstopStudios.DxMessaging.SourceGenerators.Tests.csproj
+
+      - name: Run generator diagnostics tests
+        run: >
+          dotnet test SourceGenerators/WallstopStudios.DxMessaging.SourceGenerators.Tests/WallstopStudios.DxMessaging.SourceGenerators.Tests.csproj
+          --configuration Release
+          --collect:"XPlat Code Coverage"
+
+      - name: Generate coverage summary
+        run: |
+          mkdir -p artifacts/coverage
+          reportgenerator \
+            -reports:".artifacts/SourceGenerators.Tests/TestResults/**/coverage.cobertura.xml" \
+            -targetdir:"artifacts/coverage" \
+            -reporttypes:"TextSummary;HtmlSummary;Cobertura"
+          cat artifacts/coverage/Summary.txt
+
+      - name: Upload coverage report
+        uses: actions/upload-artifact@v4
+        with:
+          name: generator-coverage
+          path: artifacts/coverage
+
+      - name: Check for TODO/FIXME markers
+        shell: bash
+        run: |
+          set -uo pipefail
+          if rg --files-with-matches "(TODO|FIXME)" \
+                --hidden \
+                --no-ignore \
+                -g '!.git/**' \
+                -g '!.artifacts/**' \
+                -g '!node_modules/**' \
+                -g '!Tests/**/TestResults/**' \
+                -g '!PLAN.md' \
+                -g '!.vs/**'; then
+            echo "::error::Found TODO/FIXME markers in the repository. Please resolve or suppress them."
+            exit 1
+          else
+            echo "No TODO/FIXME markers detected."
+          fi

package/.lychee.toml

@@ -17,10 +17,12 @@ accept = ["200..=299", 429]
 # Only check web links
 scheme = ["https", "http"]
 
-# Ignore common local/test URLs
+# Ignore endpoints that block automated clients (local hosts, CF challenges)
 exclude = [
   "^https?://localhost",
   "^http://127\\.0\\.0\\.1",
   "^https?://0\\.0\\.0\\.0",
-  "^file://"
+  "^file://",
+  # NPM package page serves a Cloudflare JS challenge to non-browser clients; registry endpoint remains covered.
+  "^https://www\\.npmjs\\.com/package/com\\.wallstop-studios\\.dxmessaging$"
 ]

package/AGENTS.md

@@ -24,6 +24,7 @@
 - Do not use underscores in function names, especially test function names.
 - Do not use regions, anywhere, ever.
 - Avoid `var` wherever possible, use expressive types.
+- Do not use nullable reference types.
 
 ## Testing Guidelines
 

package/Docs/Comparisons.md

@@ -34,10 +34,10 @@ These sections are auto-updated by the PlayMode comparison benchmarks in `Tests/
 
 | Message Tech                       | Operations / Second | Allocations? |
 | ---------------------------------- | ------------------- | ------------ |
-| DxMessaging (Untargeted) - No-Copy | 14,740,000          | No           |
-| UniRx MessageBroker                | 17,858,000          | No           |
-| MessagePipe (Global)               | 96,052,000          | No           |
-| Zenject SignalBus                  | 2,632,000           | Yes          |
+| DxMessaging (Untargeted) - No-Copy | 14,734,000          | No           |
+| UniRx MessageBroker                | 18,044,000          | No           |
+| MessagePipe (Global)               | 97,774,000          | No           |
+| Zenject SignalBus                  | 2,600,000           | Yes          |
 
 ### Comparisons (macOS)
 

package/Docs/Install.md

@@ -9,7 +9,8 @@ This page helps you install DxMessaging into a Unity 2021.3+ project using the U
 - Unity Package Manager > Add package from git URL...
 - Paste:
 
-```text
+```bash
+# Unity UPM: Add package from git URL...
 https://github.com/wallstop/DxMessaging.git
 ```
 

package/Docs/Performance.md

@@ -12,17 +12,19 @@ See also: `Docs/DesignAndArchitecture.md#performance-optimizations` for design d
 
 ## Windows
 
-| Message Tech                       | Operations / Second | Allocations? |
-| ---------------------------------- | ------------------- | ------------ |
-| Unity                              | 2,628,000           | Yes          |
-| DxMessaging (GameObject) - Normal  | 8,208,000           | No           |
-| DxMessaging (Component) - Normal   | 8,210,000           | No           |
-| DxMessaging (GameObject) - No-Copy | 9,412,000           | No           |
-| DxMessaging (Component) - No-Copy  | 9,354,000           | No           |
-| DxMessaging (Untargeted) - No-Copy | 14,812,000          | No           |
-| Reflexive (One Argument)           | 2,856,000           | No           |
-| Reflexive (Two Arguments)          | 2,372,000           | No           |
-| Reflexive (Three Arguments)        | 2,382,000           | No           |
+| Message Tech                               | Operations / Second | Allocations? |
+| ------------------------------------------ | ------------------- | ------------ |
+| Unity                                      | 2,564,000           | Yes          |
+| DxMessaging (GameObject) - Normal          | 8,476,000           | No           |
+| DxMessaging (Component) - Normal           | 8,474,000           | No           |
+| DxMessaging (GameObject) - No-Copy         | 9,418,000           | No           |
+| DxMessaging (Component) - No-Copy          | 9,536,000           | No           |
+| DxMessaging (Untargeted) - No-Copy         | 14,736,000          | No           |
+| DxMessaging (Untargeted) - Interceptors    | 6,618,000           | No           |
+| DxMessaging (Untargeted) - Post-Processors | 5,244,000           | No           |
+| Reflexive (One Argument)                   | 2,828,000           | No           |
+| Reflexive (Two Arguments)                  | 2,360,000           | No           |
+| Reflexive (Three Arguments)                | 2,358,000           | No           |
 
 ## macOS
 

package/Editor/Analyzers/Microsoft.CodeAnalysis.CSharp.dll.meta

@@ -11,15 +11,26 @@ PluginImporter:
   isExplicitlyReferenced: 0
   validateReferences: 1
   platformData:
+  - first:
+      : Any
+    second:
+      enabled: 0
+      settings:
+        Exclude Editor: 0
+        Exclude Linux64: 1
+        Exclude OSXUniversal: 1
+        Exclude WebGL: 1
+        Exclude Win: 1
+        Exclude Win64: 1
   - first:
       Any: 
     second:
-      enabled: 1
+      enabled: 0
       settings: {}
   - first:
       Editor: Editor
     second:
-      enabled: 0
+      enabled: 1
       settings:
         DefaultValueInitialized: true
   - first:

package/Editor/Analyzers/Microsoft.CodeAnalysis.dll.meta

@@ -11,6 +11,17 @@ PluginImporter:
   isExplicitlyReferenced: 0
   validateReferences: 1
   platformData:
+  - first:
+      : Any
+    second:
+      enabled: 0
+      settings:
+        Exclude Editor: 0
+        Exclude Linux64: 1
+        Exclude OSXUniversal: 1
+        Exclude WebGL: 1
+        Exclude Win: 1
+        Exclude Win64: 1
   - first:
       Any: 
     second:

package/Editor/Analyzers/System.Collections.Immutable.dll.meta

@@ -11,6 +11,17 @@ PluginImporter:
   isExplicitlyReferenced: 0
   validateReferences: 1
   platformData:
+  - first:
+      : Any
+    second:
+      enabled: 0
+      settings:
+        Exclude Editor: 0
+        Exclude Linux64: 1
+        Exclude OSXUniversal: 1
+        Exclude WebGL: 1
+        Exclude Win: 1
+        Exclude Win64: 1
   - first:
       Any: 
     second:

package/Editor/Analyzers/System.Reflection.Metadata.dll.meta

@@ -11,15 +11,26 @@ PluginImporter:
   isExplicitlyReferenced: 0
   validateReferences: 1
   platformData:
+  - first:
+      : Any
+    second:
+      enabled: 0
+      settings:
+        Exclude Editor: 0
+        Exclude Linux64: 1
+        Exclude OSXUniversal: 1
+        Exclude WebGL: 1
+        Exclude Win: 1
+        Exclude Win64: 1
   - first:
       Any: 
     second:
-      enabled: 1
+      enabled: 0
       settings: {}
   - first:
       Editor: Editor
     second:
-      enabled: 0
+      enabled: 1
       settings:
         DefaultValueInitialized: true
   - first:

package/Editor/Analyzers/System.Runtime.CompilerServices.Unsafe.dll.meta

@@ -11,6 +11,17 @@ PluginImporter:
   isExplicitlyReferenced: 0
   validateReferences: 1
   platformData:
+  - first:
+      : Any
+    second:
+      enabled: 0
+      settings:
+        Exclude Editor: 0
+        Exclude Linux64: 1
+        Exclude OSXUniversal: 1
+        Exclude WebGL: 1
+        Exclude Win: 1
+        Exclude Win64: 1
   - first:
       Any: 
     second:

package/Editor/Analyzers/WallstopStudios.DxMessaging.SourceGenerators.dll.meta

@@ -18,9 +18,10 @@ PluginImporter:
     second:
       enabled: 0
       settings:
-        Exclude Editor: 1
+        Exclude Editor: 0
         Exclude Linux64: 1
         Exclude OSXUniversal: 1
+        Exclude WebGL: 1
         Exclude Win: 1
         Exclude Win64: 1
   - first:
@@ -31,7 +32,7 @@ PluginImporter:
   - first:
       Editor: Editor
     second:
-      enabled: 0
+      enabled: 1
       settings:
         CPU: AnyCPU
         DefaultValueInitialized: true

package/Editor/AssemblyInfo.cs

@@ -0,0 +1,3 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("WallstopStudios.DxMessaging.Tests.Editor")]

package/Editor/AssemblyInfo.cs.meta

@@ -0,0 +1,3 @@
+fileFormatVersion: 2
+guid: 55bb3ae7ef064633b5fe4b17ce29f8cc
+timeCreated: 1761880591

package/Editor/CustomEditors/MessagingComponentEditor.cs

@@ -7,6 +7,7 @@ namespace DxMessaging.Editor.CustomEditors
     using Core.Diagnostics;
     using Core.MessageBus;
     using Core.Messages;
+    using DxMessaging.Editor.Testing;
     using Unity;
     using UnityEditor;
     using UnityEngine;
@@ -66,6 +67,26 @@ namespace DxMessaging.Editor.CustomEditors
                 return;
             }
 
+            MessagingComponentInspectorState inspectorState =
+                MessagingComponentEditorHarness.Capture(component);
+            ProviderDiagnosticsView providerDiagnostics = inspectorState.ProviderDiagnostics;
+
+            if (providerDiagnostics.SerializedProviderMissingWarning)
+            {
+                EditorGUILayout.HelpBox(
+                    "Auto-configure serialized provider is enabled, but no provider asset is assigned.",
+                    MessageType.Warning
+                );
+            }
+
+            if (providerDiagnostics.SerializedProviderNullBusWarning)
+            {
+                EditorGUILayout.HelpBox(
+                    "The serialized provider resolved without returning a message bus. Verify the provider implementation.",
+                    MessageType.Warning
+                );
+            }
+
             if (component._registeredListeners.Count == 0)
             {
                 EditorGUILayout.LabelField("No listeners registered.");

package/Editor/SetupCscRsp.cs

@@ -6,6 +6,7 @@ namespace DxMessaging.Editor
     using System.Collections.Generic;
     using System.IO;
     using System.Linq;
+    using System.Security.Cryptography;
     using UnityEditor;
     using UnityEngine;
     using Object = UnityEngine.Object;
@@ -20,11 +21,11 @@ namespace DxMessaging.Editor
             )
             .Replace("\\", "/");
 
-        private static readonly string AnalyzerPathRelative =
-            "Packages/com.wallstop-studios.dxmessaging/Editor/Analyzers/";
-
-        private static readonly string LibraryPathRelative =
-            "Library/PackageCache/com.wallstop-studios.dxmessaging/Editor/Analyzers/";
+        private static readonly string[] AnalyzerDirectories =
+        {
+            "Packages/com.wallstop-studios.dxmessaging/Editor/Analyzers/",
+            "Library/PackageCache/com.wallstop-studios.dxmessaging/Editor/Analyzers/",
+        };
 
         private static readonly string SourceGeneratorDllName =
             "WallstopStudios.DxMessaging.SourceGenerators.dll";
@@ -34,13 +35,18 @@ namespace DxMessaging.Editor
             SourceGeneratorDllName,
             "Microsoft.CodeAnalysis.dll",
             "Microsoft.CodeAnalysis.CSharp.dll",
+            "System.Text.Encodings.Web.dll",
             "System.Reflection.Metadata.dll",
             "System.Runtime.CompilerServices.Unsafe.dll",
             "System.Collections.Immutable.dll",
+            "System.Memory.dll",
+            "System.Buffers.dll",
+            "System.Threading.Tasks.Extensions.dll",
+            "System.Numerics.Vectors.dll",
+            "System.Text.Encoding.CodePages.dll",
+            "Microsoft.Bcl.AsyncInterfaces.dll",
         };
 
-        private static readonly string LibraryArgument = $"-a:\"{LibraryPathRelative}\"";
-
         private static readonly HashSet<string> DllNames = new(StringComparer.OrdinalIgnoreCase);
 
         static SetupCscRsp()
@@ -69,17 +75,14 @@ namespace DxMessaging.Editor
                 }
             }
 
-            string[] dllRelativeDirectories = { LibraryPathRelative, AnalyzerPathRelative };
-
-            bool anyFound = false;
-            foreach (
-                string requiredDllName in RequiredDllNames.Where(dllName =>
-                    !DllNames.Contains(dllName)
-                )
-            )
+            foreach (string requiredDllName in RequiredDllNames)
             {
-                bool found = false;
-                foreach (string relativeDirectory in dllRelativeDirectories)
+                if (DllNames.Contains(requiredDllName))
+                {
+                    continue;
+                }
+
+                foreach (string relativeDirectory in AnalyzerDirectories)
                 {
                     try
                     {
@@ -92,52 +95,62 @@ namespace DxMessaging.Editor
                         const string pluginsDirectory =
                             "Assets/Plugins/Editor/WallstopStudios.DxMessaging/";
                         string outputAsset = $"{pluginsDirectory}{requiredDllName}";
-                        string sourceAsset = $"{relativeDirectory}{requiredDllName}";
                         if (!Directory.Exists(pluginsDirectory))
                         {
                             Directory.CreateDirectory(pluginsDirectory);
                             AssetDatabase.Refresh();
                         }
-                        if (!File.Exists(outputAsset))
+                        bool needsCopy = FilesDiffer(sourceFile, outputAsset);
+                        if (needsCopy)
                         {
-                            File.Copy(sourceAsset, outputAsset);
+                            File.Copy(sourceFile, outputAsset, true);
                             AssetDatabase.ImportAsset(outputAsset);
-                            found = true;
                         }
-                        else
+
+                        if (requiredDllName == SourceGeneratorDllName)
+                        {
+                            Object loadedDll = AssetDatabase.LoadMainAssetAtPath(outputAsset);
+                            if (loadedDll != null)
+                            {
+                                string[] existingLabels = AssetDatabase.GetLabels(loadedDll);
+                                if (!existingLabels.Contains("RoslynAnalyzer"))
+                                {
+                                    List<string> newLabels = existingLabels.ToList();
+                                    newLabels.Add("RoslynAnalyzer");
+                                    AssetDatabase.SetLabels(loadedDll, newLabels.ToArray());
+                                }
+                            }
+                        }
+
+                        if (AssetImporter.GetAtPath(outputAsset) is PluginImporter importer)
                         {
-                            FileInfo sourceInfo = new(sourceAsset);
-                            FileInfo destInfo = new(outputAsset);
+                            bool importerDirty = false;
 
-                            if (destInfo.LastWriteTime < sourceInfo.LastWriteTime)
+                            if (importer.GetCompatibleWithAnyPlatform())
                             {
-                                // Source file is newer, so copy the file (overwrite destination)
-                                File.Copy(sourceAsset, outputAsset, true);
-                                AssetDatabase.ImportAsset(outputAsset);
-                                found = true;
+                                importer.SetCompatibleWithAnyPlatform(false);
+                                importerDirty = true;
                             }
-                            else
+
+                            if (importer.GetExcludeFromAnyPlatform("Editor"))
                             {
-                                continue;
+                                importer.SetExcludeFromAnyPlatform("Editor", false);
+                                importerDirty = true;
                             }
-                        }
 
-                        if (requiredDllName == SourceGeneratorDllName)
-                        {
-                            Object loadedDll = AssetDatabase.LoadMainAssetAtPath(outputAsset);
-                            AssetDatabase.SetLabels(loadedDll, new[] { "RoslynAnalyzer" });
-                        }
+                            if (!importer.GetExcludeFromAnyPlatform("Standalone"))
+                            {
+                                importer.SetExcludeFromAnyPlatform("Standalone", true);
+                                importerDirty = true;
+                            }
 
-                        PluginImporter importer =
-                            AssetImporter.GetAtPath(outputAsset) as PluginImporter;
-                        if (importer != null)
-                        {
-                            importer.SetCompatibleWithAnyPlatform(false);
-                            importer.SetExcludeFromAnyPlatform("Editor", false);
-                            importer.SetExcludeFromAnyPlatform("Standalone", false);
-                            importer.SaveAndReimport();
+                            if (importerDirty || needsCopy)
+                            {
+                                importer.SaveAndReimport();
+                            }
                         }
 
+                        DllNames.Add(requiredDllName);
                         break;
                     }
                     catch (Exception e)
@@ -147,16 +160,36 @@ namespace DxMessaging.Editor
                         );
                     }
                 }
-
-                anyFound |= found;
             }
 
-            if (anyFound)
+            if (DllNames.Count > 0)
             {
                 AssetDatabase.Refresh();
             }
         }
 
+        private static bool FilesDiffer(string sourcePath, string destinationPath)
+        {
+            if (!File.Exists(destinationPath))
+            {
+                return true;
+            }
+
+            FileInfo sourceInfo = new(sourcePath);
+            FileInfo destinationInfo = new(destinationPath);
+            if (sourceInfo.Length != destinationInfo.Length)
+            {
+                return true;
+            }
+
+            using FileStream sourceStream = File.OpenRead(sourcePath);
+            using FileStream destinationStream = File.OpenRead(destinationPath);
+            using SHA256 sha256 = SHA256.Create();
+            byte[] sourceHash = sha256.ComputeHash(sourceStream);
+            byte[] destinationHash = sha256.ComputeHash(destinationStream);
+            return !sourceHash.AsSpan().SequenceEqual(destinationHash);
+        }
+
         private static void EnsureCscRsp()
         {
             try
@@ -168,20 +201,67 @@ namespace DxMessaging.Editor
                 }
 
                 string rspContent = File.ReadAllText(RspFilePath);
-                if (rspContent.Contains(LibraryArgument, StringComparison.OrdinalIgnoreCase))
+                bool modified = false;
+                foreach (string analyzerArgument in GetAnalyzerArguments())
                 {
-                    return;
+                    if (rspContent.Contains(analyzerArgument, StringComparison.OrdinalIgnoreCase))
+                    {
+                        continue;
+                    }
+
+                    File.AppendAllText(RspFilePath, analyzerArgument + Environment.NewLine);
+                    modified = true;
                 }
 
-                File.AppendAllText(RspFilePath, $"{LibraryArgument}{Environment.NewLine}");
-                AssetDatabase.ImportAsset("csc.rsp");
-                Debug.Log("Updated csc.rsp.");
+                if (modified)
+                {
+                    AssetDatabase.ImportAsset("csc.rsp");
+                    Debug.Log("Updated csc.rsp.");
+                }
             }
             catch (IOException ex)
             {
                 Debug.LogError($"Failed to modify csc.rsp: {ex}");
             }
         }
+
+        private static IEnumerable<string> GetAnalyzerArguments()
+        {
+            HashSet<string> yielded = new(StringComparer.OrdinalIgnoreCase);
+            string projectRoot = Path.GetFullPath(Path.Combine(Application.dataPath, ".."));
+
+            foreach (string directory in AnalyzerDirectories)
+            {
+                foreach (string dllName in RequiredDllNames)
+                {
+                    string absoluteDirectory = Path.IsPathRooted(directory)
+                        ? directory
+                        : Path.GetFullPath(Path.Combine(projectRoot, directory));
+
+                    string absoluteAnalyzerPath = Path.Combine(absoluteDirectory, dllName);
+                    if (!File.Exists(absoluteAnalyzerPath))
+                    {
+                        continue;
+                    }
+
+                    string projectRelativePath = FileUtil.GetProjectRelativePath(
+                        absoluteAnalyzerPath
+                    );
+                    if (string.IsNullOrEmpty(projectRelativePath))
+                    {
+                        continue;
+                    }
+
+                    string normalizedRelativePath = projectRelativePath.Replace("\\", "/");
+                    if (!yielded.Add(normalizedRelativePath))
+                    {
+                        continue;
+                    }
+
+                    yield return $"-a:\"{normalizedRelativePath}\"";
+                }
+            }
+        }
     }
 }
 #endif